From b127da40f77c8e0338bc812a96707c6569f16a51 Mon Sep 17 00:00:00 2001 From: Vitaliy Filippov Date: Sun, 11 Feb 2024 02:33:30 +0300 Subject: [PATCH] Add a FIXME about incomplete PGs --- src/osd_peering.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/osd_peering.cpp b/src/osd_peering.cpp index 40657369..d8aff7dc 100644 --- a/src/osd_peering.cpp +++ b/src/osd_peering.cpp @@ -222,6 +222,9 @@ void osd_t::start_pg_peering(pg_t & pg) } if (pg.pg_cursize < pg.pg_minsize) { + // FIXME: Incomplete EC PGs may currently easily lead to write hangs ("slow ops" in OSD logs) + // because such PGs don't flush unstable entries on secondary OSDs so they can't remove these + // entries from their journals... pg.state = PG_INCOMPLETE; report_pg_state(pg); return;