From 06634054c9f456ae97ab8e1d0e7c360a11d14980 Mon Sep 17 00:00:00 2001 From: Vitaliy Filippov Date: Wed, 27 Nov 2019 02:23:35 +0300 Subject: [PATCH] Note to add no-fsync mode in the future --- blockstore_sync.cpp | 2 ++ fio_engine.cpp | 1 + 2 files changed, 3 insertions(+) diff --git a/blockstore_sync.cpp b/blockstore_sync.cpp index c5ab19db9..d8f793307 100644 --- a/blockstore_sync.cpp +++ b/blockstore_sync.cpp @@ -39,6 +39,7 @@ int blockstore::continue_sync(blockstore_operation *op) if (op->sync_state == SYNC_HAS_SMALL) { // No big writes, just fsync the journal + // FIXME: Add no-fsync mode BS_SUBMIT_GET_SQE(sqe, data); my_uring_prep_fsync(sqe, journal.fd, 0); data->iov = { 0 }; @@ -50,6 +51,7 @@ int blockstore::continue_sync(blockstore_operation *op) else if (op->sync_state == SYNC_HAS_BIG) { // 1st step: fsync data + // FIXME: Add no-fsync mode BS_SUBMIT_GET_SQE(sqe, data); my_uring_prep_fsync(sqe, data_fd, 0); data->iov = { 0 }; diff --git a/fio_engine.cpp b/fio_engine.cpp index bdb0ea9d7..4d92eb080 100644 --- a/fio_engine.cpp +++ b/fio_engine.cpp @@ -1,4 +1,5 @@ // FIO engine to test Blockstore +// fio -thread -ioengine=./libfio_blockstore.so -name=test -bs=4k -direct=1 -fsync=16 -iodepth=16 -rw=randwrite -size=1G #include "blockstore.h" extern "C" {