Compare commits
7 Commits
v9.2.0-5+v
...
v9.0.2-5+v
Author | SHA1 | Date | |
---|---|---|---|
e8e5ff8315 | |||
![]() |
f55fd376da | ||
![]() |
9b31b9a603 | ||
![]() |
3f36e3b77c | ||
![]() |
d1386d3f15 | ||
![]() |
e62423e615 | ||
![]() |
c93a5bfd4f |
69
debian/changelog
vendored
69
debian/changelog
vendored
@@ -1,50 +1,10 @@
|
|||||||
pve-qemu-kvm (9.2.0-5+vitastor1) bookworm; urgency=medium
|
pve-qemu-kvm (9.0.2-5+vitastor1) bookworm; urgency=medium
|
||||||
|
|
||||||
* Add Vitastor support
|
* Add Vitastor support
|
||||||
|
|
||||||
-- Vitaliy Filippov <vitalif@yourcmc.ru> Fri, 11 Apr 2025 02:07:44 +0300
|
-- Vitaliy Filippov <vitalif@yourcmc.ru> Sun, 09 Feb 2025 21:49:46 +0300
|
||||||
|
|
||||||
pve-qemu-kvm (9.2.0-5) bookworm; urgency=medium
|
pve-qemu-kvm (9.0.2-5) bookworm; urgency=medium
|
||||||
|
|
||||||
* pve backup: backup-access api: simplify bitmap logic
|
|
||||||
|
|
||||||
-- Proxmox Support Team <support@proxmox.com> Fri, 04 Apr 2025 16:15:58 +0200
|
|
||||||
|
|
||||||
pve-qemu-kvm (9.2.0-4) bookworm; urgency=medium
|
|
||||||
|
|
||||||
* various async snapshot improvements, inclduing using a dedicated IO thread
|
|
||||||
for the state file when doing a live snapshot. That should reduce load on
|
|
||||||
the main thread and for it to get stuck on IO, i.e. same benefits as using
|
|
||||||
a dedicated IO thread for regular drives. This is particularly interesting
|
|
||||||
when the VM state storage is a network storage like NFS. It should also
|
|
||||||
address #6262.
|
|
||||||
|
|
||||||
* pve backup: implement basic features and API in preperation for external
|
|
||||||
backup provider storage plugins.
|
|
||||||
|
|
||||||
-- Proxmox Support Team <support@proxmox.com> Thu, 03 Apr 2025 17:00:34 +0200
|
|
||||||
|
|
||||||
pve-qemu-kvm (9.2.0-3) bookworm; urgency=medium
|
|
||||||
|
|
||||||
* revert changes to the High Precision Event Timer (HPET) to fix performance
|
|
||||||
regression
|
|
||||||
|
|
||||||
-- Proxmox Support Team <support@proxmox.com> Wed, 26 Mar 2025 09:56:01 +0100
|
|
||||||
|
|
||||||
pve-qemu-kvm (9.2.0-2) bookworm; urgency=medium
|
|
||||||
|
|
||||||
* fix assertion failure when migrating a VM with multiple disks on a
|
|
||||||
replicated ZFS.
|
|
||||||
|
|
||||||
-- Proxmox Support Team <support@proxmox.com> Mon, 24 Feb 2025 17:33:34 +0100
|
|
||||||
|
|
||||||
pve-qemu-kvm (9.2.0-1) bookworm; urgency=medium
|
|
||||||
|
|
||||||
* update submodule and patches to QEMU 9.2.0
|
|
||||||
|
|
||||||
-- Proxmox Support Team <support@proxmox.com> Tue, 04 Feb 2025 08:49:20 +0100
|
|
||||||
|
|
||||||
pve-qemu-kvm (9.1.2-3) bookworm; urgency=medium
|
|
||||||
|
|
||||||
* async snapshot: explicitly specify raw format when loading the VM state
|
* async snapshot: explicitly specify raw format when loading the VM state
|
||||||
file
|
file
|
||||||
@@ -52,22 +12,7 @@ pve-qemu-kvm (9.1.2-3) bookworm; urgency=medium
|
|||||||
* vma create: rework CLI parameters for passing disk to a more structured
|
* vma create: rework CLI parameters for passing disk to a more structured
|
||||||
style and use that to allow explicitly specifying the format
|
style and use that to allow explicitly specifying the format
|
||||||
|
|
||||||
-- Proxmox Support Team <support@proxmox.com> Fri, 24 Jan 2025 16:12:34 +0100
|
-- Proxmox Support Team <support@proxmox.com> Fri, 24 Jan 2025 14:59:17 +0100
|
||||||
|
|
||||||
pve-qemu-kvm (9.1.2-2) bookworm; urgency=medium
|
|
||||||
|
|
||||||
* adapt machine version deprecation for Proxmox VE release and support
|
|
||||||
cycle.
|
|
||||||
|
|
||||||
-- Proxmox Support Team <support@proxmox.com> Fri, 17 Jan 2025 16:34:06 +0100
|
|
||||||
|
|
||||||
pve-qemu-kvm (9.1.2-1) bookworm; urgency=medium
|
|
||||||
|
|
||||||
* update submodule and patches to QEMU 9.1.2
|
|
||||||
|
|
||||||
* improve error handling and edge cases with fleecing backups.
|
|
||||||
|
|
||||||
-- Proxmox Support Team <support@proxmox.com> Wed, 11 Dec 2024 16:47:21 +0100
|
|
||||||
|
|
||||||
pve-qemu-kvm (9.0.2-4) bookworm; urgency=medium
|
pve-qemu-kvm (9.0.2-4) bookworm; urgency=medium
|
||||||
|
|
||||||
@@ -168,6 +113,12 @@ pve-qemu-kvm (9.0.0-2) bookworm; urgency=medium
|
|||||||
|
|
||||||
-- Proxmox Support Team <support@proxmox.com> Fri, 17 May 2024 17:04:52 +0200
|
-- Proxmox Support Team <support@proxmox.com> Fri, 17 May 2024 17:04:52 +0200
|
||||||
|
|
||||||
|
pve-qemu-kvm (8.1.5-6) bookworm; urgency=medium
|
||||||
|
|
||||||
|
* fix #5409: backup: fix copy-before-write timeout
|
||||||
|
|
||||||
|
-- Proxmox Support Team <support@proxmox.com> Mon, 29 Apr 2024 16:39:38 +0200
|
||||||
|
|
||||||
pve-qemu-kvm (9.0.0-1) bookworm; urgency=medium
|
pve-qemu-kvm (9.0.0-1) bookworm; urgency=medium
|
||||||
|
|
||||||
* update submodule and patches to QEMU 9.0.0
|
* update submodule and patches to QEMU 9.0.0
|
||||||
|
@@ -27,7 +27,7 @@ Signed-off-by: Ma Haocong <mahaocong@didichuxing.com>
|
|||||||
Signed-off-by: John Snow <jsnow@redhat.com>
|
Signed-off-by: John Snow <jsnow@redhat.com>
|
||||||
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
|
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
[FE: rebased for 9.1.2]
|
[FE: rebased for 8.2.2]
|
||||||
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
---
|
---
|
||||||
block/mirror.c | 99 ++++++++++++++++++++------
|
block/mirror.c | 99 ++++++++++++++++++++------
|
||||||
@@ -38,7 +38,7 @@ Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|||||||
5 files changed, 142 insertions(+), 28 deletions(-)
|
5 files changed, 142 insertions(+), 28 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/mirror.c b/block/mirror.c
|
diff --git a/block/mirror.c b/block/mirror.c
|
||||||
index 2afe700b4d..c3d4be9b15 100644
|
index 1bdce3b657..0c5c72df2e 100644
|
||||||
--- a/block/mirror.c
|
--- a/block/mirror.c
|
||||||
+++ b/block/mirror.c
|
+++ b/block/mirror.c
|
||||||
@@ -51,7 +51,7 @@ typedef struct MirrorBlockJob {
|
@@ -51,7 +51,7 @@ typedef struct MirrorBlockJob {
|
||||||
@@ -59,7 +59,7 @@ index 2afe700b4d..c3d4be9b15 100644
|
|||||||
BdrvDirtyBitmap *dirty_bitmap;
|
BdrvDirtyBitmap *dirty_bitmap;
|
||||||
BdrvDirtyBitmapIter *dbi;
|
BdrvDirtyBitmapIter *dbi;
|
||||||
uint8_t *buf;
|
uint8_t *buf;
|
||||||
@@ -723,7 +725,8 @@ static int mirror_exit_common(Job *job)
|
@@ -722,7 +724,8 @@ static int mirror_exit_common(Job *job)
|
||||||
&error_abort);
|
&error_abort);
|
||||||
|
|
||||||
if (!abort && s->backing_mode == MIRROR_SOURCE_BACKING_CHAIN) {
|
if (!abort && s->backing_mode == MIRROR_SOURCE_BACKING_CHAIN) {
|
||||||
@@ -69,7 +69,7 @@ index 2afe700b4d..c3d4be9b15 100644
|
|||||||
BlockDriverState *unfiltered_target = bdrv_skip_filters(target_bs);
|
BlockDriverState *unfiltered_target = bdrv_skip_filters(target_bs);
|
||||||
|
|
||||||
if (bdrv_cow_bs(unfiltered_target) != backing) {
|
if (bdrv_cow_bs(unfiltered_target) != backing) {
|
||||||
@@ -824,6 +827,16 @@ static void mirror_abort(Job *job)
|
@@ -819,6 +822,16 @@ static void mirror_abort(Job *job)
|
||||||
assert(ret == 0);
|
assert(ret == 0);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -86,7 +86,7 @@ index 2afe700b4d..c3d4be9b15 100644
|
|||||||
static void coroutine_fn mirror_throttle(MirrorBlockJob *s)
|
static void coroutine_fn mirror_throttle(MirrorBlockJob *s)
|
||||||
{
|
{
|
||||||
int64_t now = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
|
int64_t now = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
|
||||||
@@ -1020,7 +1033,8 @@ static int coroutine_fn mirror_run(Job *job, Error **errp)
|
@@ -1015,7 +1028,8 @@ static int coroutine_fn mirror_run(Job *job, Error **errp)
|
||||||
mirror_free_init(s);
|
mirror_free_init(s);
|
||||||
|
|
||||||
s->last_pause_ns = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
|
s->last_pause_ns = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
|
||||||
@@ -96,7 +96,7 @@ index 2afe700b4d..c3d4be9b15 100644
|
|||||||
ret = mirror_dirty_init(s);
|
ret = mirror_dirty_init(s);
|
||||||
if (ret < 0 || job_is_cancelled(&s->common.job)) {
|
if (ret < 0 || job_is_cancelled(&s->common.job)) {
|
||||||
goto immediate_exit;
|
goto immediate_exit;
|
||||||
@@ -1309,6 +1323,7 @@ static const BlockJobDriver mirror_job_driver = {
|
@@ -1304,6 +1318,7 @@ static const BlockJobDriver mirror_job_driver = {
|
||||||
.run = mirror_run,
|
.run = mirror_run,
|
||||||
.prepare = mirror_prepare,
|
.prepare = mirror_prepare,
|
||||||
.abort = mirror_abort,
|
.abort = mirror_abort,
|
||||||
@@ -104,7 +104,7 @@ index 2afe700b4d..c3d4be9b15 100644
|
|||||||
.pause = mirror_pause,
|
.pause = mirror_pause,
|
||||||
.complete = mirror_complete,
|
.complete = mirror_complete,
|
||||||
.cancel = mirror_cancel,
|
.cancel = mirror_cancel,
|
||||||
@@ -1327,6 +1342,7 @@ static const BlockJobDriver commit_active_job_driver = {
|
@@ -1322,6 +1337,7 @@ static const BlockJobDriver commit_active_job_driver = {
|
||||||
.run = mirror_run,
|
.run = mirror_run,
|
||||||
.prepare = mirror_prepare,
|
.prepare = mirror_prepare,
|
||||||
.abort = mirror_abort,
|
.abort = mirror_abort,
|
||||||
@@ -112,7 +112,7 @@ index 2afe700b4d..c3d4be9b15 100644
|
|||||||
.pause = mirror_pause,
|
.pause = mirror_pause,
|
||||||
.complete = mirror_complete,
|
.complete = mirror_complete,
|
||||||
.cancel = commit_active_cancel,
|
.cancel = commit_active_cancel,
|
||||||
@@ -1719,7 +1735,10 @@ static BlockJob *mirror_start_job(
|
@@ -1714,7 +1730,10 @@ static BlockJob *mirror_start_job(
|
||||||
BlockCompletionFunc *cb,
|
BlockCompletionFunc *cb,
|
||||||
void *opaque,
|
void *opaque,
|
||||||
const BlockJobDriver *driver,
|
const BlockJobDriver *driver,
|
||||||
@@ -123,8 +123,8 @@ index 2afe700b4d..c3d4be9b15 100644
|
|||||||
+ BlockDriverState *base,
|
+ BlockDriverState *base,
|
||||||
bool auto_complete, const char *filter_node_name,
|
bool auto_complete, const char *filter_node_name,
|
||||||
bool is_mirror, MirrorCopyMode copy_mode,
|
bool is_mirror, MirrorCopyMode copy_mode,
|
||||||
bool base_ro,
|
Error **errp)
|
||||||
@@ -1734,10 +1753,39 @@ static BlockJob *mirror_start_job(
|
@@ -1728,10 +1747,39 @@ static BlockJob *mirror_start_job(
|
||||||
|
|
||||||
GLOBAL_STATE_CODE();
|
GLOBAL_STATE_CODE();
|
||||||
|
|
||||||
@@ -166,7 +166,7 @@ index 2afe700b4d..c3d4be9b15 100644
|
|||||||
assert(is_power_of_2(granularity));
|
assert(is_power_of_2(granularity));
|
||||||
|
|
||||||
if (buf_size < 0) {
|
if (buf_size < 0) {
|
||||||
@@ -1878,7 +1926,9 @@ static BlockJob *mirror_start_job(
|
@@ -1871,7 +1919,9 @@ static BlockJob *mirror_start_job(
|
||||||
s->replaces = g_strdup(replaces);
|
s->replaces = g_strdup(replaces);
|
||||||
s->on_source_error = on_source_error;
|
s->on_source_error = on_source_error;
|
||||||
s->on_target_error = on_target_error;
|
s->on_target_error = on_target_error;
|
||||||
@@ -177,7 +177,7 @@ index 2afe700b4d..c3d4be9b15 100644
|
|||||||
s->backing_mode = backing_mode;
|
s->backing_mode = backing_mode;
|
||||||
s->zero_target = zero_target;
|
s->zero_target = zero_target;
|
||||||
qatomic_set(&s->copy_mode, copy_mode);
|
qatomic_set(&s->copy_mode, copy_mode);
|
||||||
@@ -1904,6 +1954,18 @@ static BlockJob *mirror_start_job(
|
@@ -1897,6 +1947,18 @@ static BlockJob *mirror_start_job(
|
||||||
*/
|
*/
|
||||||
bdrv_disable_dirty_bitmap(s->dirty_bitmap);
|
bdrv_disable_dirty_bitmap(s->dirty_bitmap);
|
||||||
|
|
||||||
@@ -196,7 +196,7 @@ index 2afe700b4d..c3d4be9b15 100644
|
|||||||
bdrv_graph_wrlock();
|
bdrv_graph_wrlock();
|
||||||
ret = block_job_add_bdrv(&s->common, "source", bs, 0,
|
ret = block_job_add_bdrv(&s->common, "source", bs, 0,
|
||||||
BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE |
|
BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE |
|
||||||
@@ -1986,6 +2048,9 @@ fail:
|
@@ -1979,6 +2041,9 @@ fail:
|
||||||
if (s->dirty_bitmap) {
|
if (s->dirty_bitmap) {
|
||||||
bdrv_release_dirty_bitmap(s->dirty_bitmap);
|
bdrv_release_dirty_bitmap(s->dirty_bitmap);
|
||||||
}
|
}
|
||||||
@@ -206,7 +206,7 @@ index 2afe700b4d..c3d4be9b15 100644
|
|||||||
job_early_fail(&s->common.job);
|
job_early_fail(&s->common.job);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -2008,35 +2073,28 @@ void mirror_start(const char *job_id, BlockDriverState *bs,
|
@@ -2001,35 +2066,28 @@ void mirror_start(const char *job_id, BlockDriverState *bs,
|
||||||
BlockDriverState *target, const char *replaces,
|
BlockDriverState *target, const char *replaces,
|
||||||
int creation_flags, int64_t speed,
|
int creation_flags, int64_t speed,
|
||||||
uint32_t granularity, int64_t buf_size,
|
uint32_t granularity, int64_t buf_size,
|
||||||
@@ -241,13 +241,13 @@ index 2afe700b4d..c3d4be9b15 100644
|
|||||||
speed, granularity, buf_size, backing_mode, zero_target,
|
speed, granularity, buf_size, backing_mode, zero_target,
|
||||||
on_source_error, on_target_error, unmap, NULL, NULL,
|
on_source_error, on_target_error, unmap, NULL, NULL,
|
||||||
- &mirror_job_driver, is_none_mode, base, false,
|
- &mirror_job_driver, is_none_mode, base, false,
|
||||||
- filter_node_name, true, copy_mode, false, errp);
|
- filter_node_name, true, copy_mode, errp);
|
||||||
+ &mirror_job_driver, mode, bitmap, bitmap_mode, base,
|
+ &mirror_job_driver, mode, bitmap, bitmap_mode, base,
|
||||||
+ false, filter_node_name, true, copy_mode, false, errp);
|
+ false, filter_node_name, true, copy_mode, errp);
|
||||||
}
|
}
|
||||||
|
|
||||||
BlockJob *commit_active_start(const char *job_id, BlockDriverState *bs,
|
BlockJob *commit_active_start(const char *job_id, BlockDriverState *bs,
|
||||||
@@ -2063,7 +2121,8 @@ BlockJob *commit_active_start(const char *job_id, BlockDriverState *bs,
|
@@ -2056,7 +2114,8 @@ BlockJob *commit_active_start(const char *job_id, BlockDriverState *bs,
|
||||||
job_id, bs, creation_flags, base, NULL, speed, 0, 0,
|
job_id, bs, creation_flags, base, NULL, speed, 0, 0,
|
||||||
MIRROR_LEAVE_BACKING_CHAIN, false,
|
MIRROR_LEAVE_BACKING_CHAIN, false,
|
||||||
on_error, on_error, true, cb, opaque,
|
on_error, on_error, true, cb, opaque,
|
||||||
@@ -255,13 +255,13 @@ index 2afe700b4d..c3d4be9b15 100644
|
|||||||
+ &commit_active_job_driver, MIRROR_SYNC_MODE_FULL,
|
+ &commit_active_job_driver, MIRROR_SYNC_MODE_FULL,
|
||||||
+ NULL, 0, base, auto_complete,
|
+ NULL, 0, base, auto_complete,
|
||||||
filter_node_name, false, MIRROR_COPY_MODE_BACKGROUND,
|
filter_node_name, false, MIRROR_COPY_MODE_BACKGROUND,
|
||||||
base_read_only, errp);
|
errp);
|
||||||
if (!job) {
|
if (!job) {
|
||||||
diff --git a/blockdev.c b/blockdev.c
|
diff --git a/blockdev.c b/blockdev.c
|
||||||
index 6740663fda..38fa63155c 100644
|
index 4c33c3f5f0..f3e508a6a7 100644
|
||||||
--- a/blockdev.c
|
--- a/blockdev.c
|
||||||
+++ b/blockdev.c
|
+++ b/blockdev.c
|
||||||
@@ -2781,6 +2781,9 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
@@ -2776,6 +2776,9 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
||||||
BlockDriverState *target,
|
BlockDriverState *target,
|
||||||
const char *replaces,
|
const char *replaces,
|
||||||
enum MirrorSyncMode sync,
|
enum MirrorSyncMode sync,
|
||||||
@@ -271,7 +271,7 @@ index 6740663fda..38fa63155c 100644
|
|||||||
BlockMirrorBackingMode backing_mode,
|
BlockMirrorBackingMode backing_mode,
|
||||||
bool zero_target,
|
bool zero_target,
|
||||||
bool has_speed, int64_t speed,
|
bool has_speed, int64_t speed,
|
||||||
@@ -2799,6 +2802,7 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
@@ -2794,6 +2797,7 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
||||||
{
|
{
|
||||||
BlockDriverState *unfiltered_bs;
|
BlockDriverState *unfiltered_bs;
|
||||||
int job_flags = JOB_DEFAULT;
|
int job_flags = JOB_DEFAULT;
|
||||||
@@ -279,7 +279,7 @@ index 6740663fda..38fa63155c 100644
|
|||||||
|
|
||||||
GLOBAL_STATE_CODE();
|
GLOBAL_STATE_CODE();
|
||||||
GRAPH_RDLOCK_GUARD_MAINLOOP();
|
GRAPH_RDLOCK_GUARD_MAINLOOP();
|
||||||
@@ -2853,6 +2857,29 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
@@ -2848,6 +2852,29 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
||||||
sync = MIRROR_SYNC_MODE_FULL;
|
sync = MIRROR_SYNC_MODE_FULL;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -309,7 +309,7 @@ index 6740663fda..38fa63155c 100644
|
|||||||
if (!replaces) {
|
if (!replaces) {
|
||||||
/* We want to mirror from @bs, but keep implicit filters on top */
|
/* We want to mirror from @bs, but keep implicit filters on top */
|
||||||
unfiltered_bs = bdrv_skip_implicit_filters(bs);
|
unfiltered_bs = bdrv_skip_implicit_filters(bs);
|
||||||
@@ -2894,8 +2921,8 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
@@ -2889,8 +2916,8 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
||||||
* and will allow to check whether the node still exist at mirror completion
|
* and will allow to check whether the node still exist at mirror completion
|
||||||
*/
|
*/
|
||||||
mirror_start(job_id, bs, target,
|
mirror_start(job_id, bs, target,
|
||||||
@@ -320,7 +320,7 @@ index 6740663fda..38fa63155c 100644
|
|||||||
on_source_error, on_target_error, unmap, filter_node_name,
|
on_source_error, on_target_error, unmap, filter_node_name,
|
||||||
copy_mode, errp);
|
copy_mode, errp);
|
||||||
}
|
}
|
||||||
@@ -3039,6 +3066,8 @@ void qmp_drive_mirror(DriveMirror *arg, Error **errp)
|
@@ -3034,6 +3061,8 @@ void qmp_drive_mirror(DriveMirror *arg, Error **errp)
|
||||||
|
|
||||||
blockdev_mirror_common(arg->job_id, bs, target_bs,
|
blockdev_mirror_common(arg->job_id, bs, target_bs,
|
||||||
arg->replaces, arg->sync,
|
arg->replaces, arg->sync,
|
||||||
@@ -329,7 +329,7 @@ index 6740663fda..38fa63155c 100644
|
|||||||
backing_mode, zero_target,
|
backing_mode, zero_target,
|
||||||
arg->has_speed, arg->speed,
|
arg->has_speed, arg->speed,
|
||||||
arg->has_granularity, arg->granularity,
|
arg->has_granularity, arg->granularity,
|
||||||
@@ -3058,6 +3087,8 @@ void qmp_blockdev_mirror(const char *job_id,
|
@@ -3053,6 +3082,8 @@ void qmp_blockdev_mirror(const char *job_id,
|
||||||
const char *device, const char *target,
|
const char *device, const char *target,
|
||||||
const char *replaces,
|
const char *replaces,
|
||||||
MirrorSyncMode sync,
|
MirrorSyncMode sync,
|
||||||
@@ -338,7 +338,7 @@ index 6740663fda..38fa63155c 100644
|
|||||||
bool has_speed, int64_t speed,
|
bool has_speed, int64_t speed,
|
||||||
bool has_granularity, uint32_t granularity,
|
bool has_granularity, uint32_t granularity,
|
||||||
bool has_buf_size, int64_t buf_size,
|
bool has_buf_size, int64_t buf_size,
|
||||||
@@ -3098,7 +3129,8 @@ void qmp_blockdev_mirror(const char *job_id,
|
@@ -3093,7 +3124,8 @@ void qmp_blockdev_mirror(const char *job_id,
|
||||||
}
|
}
|
||||||
|
|
||||||
blockdev_mirror_common(job_id, bs, target_bs,
|
blockdev_mirror_common(job_id, bs, target_bs,
|
||||||
@@ -364,10 +364,10 @@ index eb2d92a226..f0c642b194 100644
|
|||||||
BlockdevOnError on_source_error,
|
BlockdevOnError on_source_error,
|
||||||
BlockdevOnError on_target_error,
|
BlockdevOnError on_target_error,
|
||||||
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
||||||
index fd3bcc1c17..48ba32049f 100644
|
index b179d65520..905da8be72 100644
|
||||||
--- a/qapi/block-core.json
|
--- a/qapi/block-core.json
|
||||||
+++ b/qapi/block-core.json
|
+++ b/qapi/block-core.json
|
||||||
@@ -2178,6 +2178,15 @@
|
@@ -2174,6 +2174,15 @@
|
||||||
# destination (all the disk, only the sectors allocated in the
|
# destination (all the disk, only the sectors allocated in the
|
||||||
# topmost image, or only new I/O).
|
# topmost image, or only new I/O).
|
||||||
#
|
#
|
||||||
@@ -383,7 +383,7 @@ index fd3bcc1c17..48ba32049f 100644
|
|||||||
# @granularity: granularity of the dirty bitmap, default is 64K if the
|
# @granularity: granularity of the dirty bitmap, default is 64K if the
|
||||||
# image format doesn't have clusters, 4K if the clusters are
|
# image format doesn't have clusters, 4K if the clusters are
|
||||||
# smaller than that, else the cluster size. Must be a power of 2
|
# smaller than that, else the cluster size. Must be a power of 2
|
||||||
@@ -2220,7 +2229,9 @@
|
@@ -2216,7 +2225,9 @@
|
||||||
{ 'struct': 'DriveMirror',
|
{ 'struct': 'DriveMirror',
|
||||||
'data': { '*job-id': 'str', 'device': 'str', 'target': 'str',
|
'data': { '*job-id': 'str', 'device': 'str', 'target': 'str',
|
||||||
'*format': 'str', '*node-name': 'str', '*replaces': 'str',
|
'*format': 'str', '*node-name': 'str', '*replaces': 'str',
|
||||||
@@ -394,7 +394,7 @@ index fd3bcc1c17..48ba32049f 100644
|
|||||||
'*speed': 'int', '*granularity': 'uint32',
|
'*speed': 'int', '*granularity': 'uint32',
|
||||||
'*buf-size': 'int', '*on-source-error': 'BlockdevOnError',
|
'*buf-size': 'int', '*on-source-error': 'BlockdevOnError',
|
||||||
'*on-target-error': 'BlockdevOnError',
|
'*on-target-error': 'BlockdevOnError',
|
||||||
@@ -2499,6 +2510,15 @@
|
@@ -2496,6 +2507,15 @@
|
||||||
# destination (all the disk, only the sectors allocated in the
|
# destination (all the disk, only the sectors allocated in the
|
||||||
# topmost image, or only new I/O).
|
# topmost image, or only new I/O).
|
||||||
#
|
#
|
||||||
@@ -410,7 +410,7 @@ index fd3bcc1c17..48ba32049f 100644
|
|||||||
# @granularity: granularity of the dirty bitmap, default is 64K if the
|
# @granularity: granularity of the dirty bitmap, default is 64K if the
|
||||||
# image format doesn't have clusters, 4K if the clusters are
|
# image format doesn't have clusters, 4K if the clusters are
|
||||||
# smaller than that, else the cluster size. Must be a power of 2
|
# smaller than that, else the cluster size. Must be a power of 2
|
||||||
@@ -2547,7 +2567,8 @@
|
@@ -2544,7 +2564,8 @@
|
||||||
{ 'command': 'blockdev-mirror',
|
{ 'command': 'blockdev-mirror',
|
||||||
'data': { '*job-id': 'str', 'device': 'str', 'target': 'str',
|
'data': { '*job-id': 'str', 'device': 'str', 'target': 'str',
|
||||||
'*replaces': 'str',
|
'*replaces': 'str',
|
||||||
@@ -421,7 +421,7 @@ index fd3bcc1c17..48ba32049f 100644
|
|||||||
'*buf-size': 'int', '*on-source-error': 'BlockdevOnError',
|
'*buf-size': 'int', '*on-source-error': 'BlockdevOnError',
|
||||||
'*on-target-error': 'BlockdevOnError',
|
'*on-target-error': 'BlockdevOnError',
|
||||||
diff --git a/tests/unit/test-block-iothread.c b/tests/unit/test-block-iothread.c
|
diff --git a/tests/unit/test-block-iothread.c b/tests/unit/test-block-iothread.c
|
||||||
index 20ed54f570..4f50a99334 100644
|
index 3766d5de6b..afa44cbd34 100644
|
||||||
--- a/tests/unit/test-block-iothread.c
|
--- a/tests/unit/test-block-iothread.c
|
||||||
+++ b/tests/unit/test-block-iothread.c
|
+++ b/tests/unit/test-block-iothread.c
|
||||||
@@ -755,8 +755,8 @@ static void test_propagate_mirror(void)
|
@@ -755,8 +755,8 @@ static void test_propagate_mirror(void)
|
||||||
|
@@ -24,10 +24,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 18 insertions(+), 6 deletions(-)
|
1 file changed, 18 insertions(+), 6 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/mirror.c b/block/mirror.c
|
diff --git a/block/mirror.c b/block/mirror.c
|
||||||
index c3d4be9b15..7b6f7c0068 100644
|
index 0c5c72df2e..37fee3fa25 100644
|
||||||
--- a/block/mirror.c
|
--- a/block/mirror.c
|
||||||
+++ b/block/mirror.c
|
+++ b/block/mirror.c
|
||||||
@@ -694,8 +694,6 @@ static int mirror_exit_common(Job *job)
|
@@ -693,8 +693,6 @@ static int mirror_exit_common(Job *job)
|
||||||
bdrv_unfreeze_backing_chain(mirror_top_bs, target_bs);
|
bdrv_unfreeze_backing_chain(mirror_top_bs, target_bs);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -36,7 +36,7 @@ index c3d4be9b15..7b6f7c0068 100644
|
|||||||
/* Make sure that the source BDS doesn't go away during bdrv_replace_node,
|
/* Make sure that the source BDS doesn't go away during bdrv_replace_node,
|
||||||
* before we can call bdrv_drained_end */
|
* before we can call bdrv_drained_end */
|
||||||
bdrv_ref(src);
|
bdrv_ref(src);
|
||||||
@@ -805,6 +803,18 @@ static int mirror_exit_common(Job *job)
|
@@ -800,6 +798,18 @@ static int mirror_exit_common(Job *job)
|
||||||
bdrv_drained_end(target_bs);
|
bdrv_drained_end(target_bs);
|
||||||
bdrv_unref(target_bs);
|
bdrv_unref(target_bs);
|
||||||
|
|
||||||
@@ -55,7 +55,7 @@ index c3d4be9b15..7b6f7c0068 100644
|
|||||||
bs_opaque->job = NULL;
|
bs_opaque->job = NULL;
|
||||||
|
|
||||||
bdrv_drained_end(src);
|
bdrv_drained_end(src);
|
||||||
@@ -1763,10 +1773,6 @@ static BlockJob *mirror_start_job(
|
@@ -1757,10 +1767,6 @@ static BlockJob *mirror_start_job(
|
||||||
" sync mode",
|
" sync mode",
|
||||||
MirrorSyncMode_str(sync_mode));
|
MirrorSyncMode_str(sync_mode));
|
||||||
return NULL;
|
return NULL;
|
||||||
@@ -66,7 +66,7 @@ index c3d4be9b15..7b6f7c0068 100644
|
|||||||
}
|
}
|
||||||
} else if (bitmap) {
|
} else if (bitmap) {
|
||||||
error_setg(errp,
|
error_setg(errp,
|
||||||
@@ -1783,6 +1789,12 @@ static BlockJob *mirror_start_job(
|
@@ -1777,6 +1783,12 @@ static BlockJob *mirror_start_job(
|
||||||
return NULL;
|
return NULL;
|
||||||
}
|
}
|
||||||
granularity = bdrv_dirty_bitmap_granularity(bitmap);
|
granularity = bdrv_dirty_bitmap_granularity(bitmap);
|
||||||
|
@@ -16,10 +16,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 3 insertions(+)
|
1 file changed, 3 insertions(+)
|
||||||
|
|
||||||
diff --git a/blockdev.c b/blockdev.c
|
diff --git a/blockdev.c b/blockdev.c
|
||||||
index 38fa63155c..204cf6fad1 100644
|
index f3e508a6a7..37b8437f3e 100644
|
||||||
--- a/blockdev.c
|
--- a/blockdev.c
|
||||||
+++ b/blockdev.c
|
+++ b/blockdev.c
|
||||||
@@ -2878,6 +2878,9 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
@@ -2873,6 +2873,9 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
||||||
if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_ALLOW_RO, errp)) {
|
if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_ALLOW_RO, errp)) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
@@ -16,10 +16,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 4 insertions(+), 7 deletions(-)
|
1 file changed, 4 insertions(+), 7 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/mirror.c b/block/mirror.c
|
diff --git a/block/mirror.c b/block/mirror.c
|
||||||
index 7b6f7c0068..2b1c07095d 100644
|
index 37fee3fa25..6b3cce1007 100644
|
||||||
--- a/block/mirror.c
|
--- a/block/mirror.c
|
||||||
+++ b/block/mirror.c
|
+++ b/block/mirror.c
|
||||||
@@ -809,8 +809,8 @@ static int mirror_exit_common(Job *job)
|
@@ -804,8 +804,8 @@ static int mirror_exit_common(Job *job)
|
||||||
job->ret == 0 && ret == 0)) {
|
job->ret == 0 && ret == 0)) {
|
||||||
/* Success; synchronize copy back to sync. */
|
/* Success; synchronize copy back to sync. */
|
||||||
bdrv_clear_dirty_bitmap(s->sync_bitmap, NULL);
|
bdrv_clear_dirty_bitmap(s->sync_bitmap, NULL);
|
||||||
@@ -30,7 +30,7 @@ index 7b6f7c0068..2b1c07095d 100644
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
bdrv_release_dirty_bitmap(s->dirty_bitmap);
|
bdrv_release_dirty_bitmap(s->dirty_bitmap);
|
||||||
@@ -1971,11 +1971,8 @@ static BlockJob *mirror_start_job(
|
@@ -1964,11 +1964,8 @@ static BlockJob *mirror_start_job(
|
||||||
}
|
}
|
||||||
|
|
||||||
if (s->sync_mode == MIRROR_SYNC_MODE_BITMAP) {
|
if (s->sync_mode == MIRROR_SYNC_MODE_BITMAP) {
|
||||||
|
@@ -21,10 +21,10 @@ Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|||||||
3 files changed, 70 insertions(+), 59 deletions(-)
|
3 files changed, 70 insertions(+), 59 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/mirror.c b/block/mirror.c
|
diff --git a/block/mirror.c b/block/mirror.c
|
||||||
index 2b1c07095d..f5787b380c 100644
|
index 6b3cce1007..2f1223852b 100644
|
||||||
--- a/block/mirror.c
|
--- a/block/mirror.c
|
||||||
+++ b/block/mirror.c
|
+++ b/block/mirror.c
|
||||||
@@ -1763,31 +1763,13 @@ static BlockJob *mirror_start_job(
|
@@ -1757,31 +1757,13 @@ static BlockJob *mirror_start_job(
|
||||||
|
|
||||||
GLOBAL_STATE_CODE();
|
GLOBAL_STATE_CODE();
|
||||||
|
|
||||||
@@ -62,10 +62,10 @@ index 2b1c07095d..f5787b380c 100644
|
|||||||
|
|
||||||
if (bitmap_mode != BITMAP_SYNC_MODE_NEVER) {
|
if (bitmap_mode != BITMAP_SYNC_MODE_NEVER) {
|
||||||
diff --git a/blockdev.c b/blockdev.c
|
diff --git a/blockdev.c b/blockdev.c
|
||||||
index 204cf6fad1..79d47b1920 100644
|
index 37b8437f3e..ed8198f351 100644
|
||||||
--- a/blockdev.c
|
--- a/blockdev.c
|
||||||
+++ b/blockdev.c
|
+++ b/blockdev.c
|
||||||
@@ -2857,7 +2857,36 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
@@ -2852,7 +2852,36 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
|
||||||
sync = MIRROR_SYNC_MODE_FULL;
|
sync = MIRROR_SYNC_MODE_FULL;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@@ -48,7 +48,7 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
6 files changed, 59 insertions(+), 5 deletions(-)
|
6 files changed, 59 insertions(+), 5 deletions(-)
|
||||||
|
|
||||||
diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h
|
diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h
|
||||||
index c3740ec616..7f38ce6b8b 100644
|
index 965f5d5450..e04bd059b6 100644
|
||||||
--- a/include/monitor/monitor.h
|
--- a/include/monitor/monitor.h
|
||||||
+++ b/include/monitor/monitor.h
|
+++ b/include/monitor/monitor.h
|
||||||
@@ -16,6 +16,7 @@ extern QemuOptsList qemu_mon_opts;
|
@@ -16,6 +16,7 @@ extern QemuOptsList qemu_mon_opts;
|
||||||
@@ -60,7 +60,7 @@ index c3740ec616..7f38ce6b8b 100644
|
|||||||
void monitor_init_globals(void);
|
void monitor_init_globals(void);
|
||||||
void monitor_init_globals_core(void);
|
void monitor_init_globals_core(void);
|
||||||
diff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h
|
diff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h
|
||||||
index cb628f681d..93dbd62fc2 100644
|
index 252de85681..8db28f9272 100644
|
||||||
--- a/monitor/monitor-internal.h
|
--- a/monitor/monitor-internal.h
|
||||||
+++ b/monitor/monitor-internal.h
|
+++ b/monitor/monitor-internal.h
|
||||||
@@ -151,6 +151,13 @@ typedef struct {
|
@@ -151,6 +151,13 @@ typedef struct {
|
||||||
@@ -78,10 +78,10 @@ index cb628f681d..93dbd62fc2 100644
|
|||||||
|
|
||||||
/**
|
/**
|
||||||
diff --git a/monitor/monitor.c b/monitor/monitor.c
|
diff --git a/monitor/monitor.c b/monitor/monitor.c
|
||||||
index 56786c0ccc..30071d0c8a 100644
|
index 01ede1babd..5681bca346 100644
|
||||||
--- a/monitor/monitor.c
|
--- a/monitor/monitor.c
|
||||||
+++ b/monitor/monitor.c
|
+++ b/monitor/monitor.c
|
||||||
@@ -116,6 +116,21 @@ bool monitor_cur_is_qmp(void)
|
@@ -117,6 +117,21 @@ bool monitor_cur_is_qmp(void)
|
||||||
return cur_mon && monitor_is_qmp(cur_mon);
|
return cur_mon && monitor_is_qmp(cur_mon);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -104,7 +104,7 @@ index 56786c0ccc..30071d0c8a 100644
|
|||||||
* Is @mon is using readline?
|
* Is @mon is using readline?
|
||||||
* Note: not all HMP monitors use readline, e.g., gdbserver has a
|
* Note: not all HMP monitors use readline, e.g., gdbserver has a
|
||||||
diff --git a/monitor/qmp.c b/monitor/qmp.c
|
diff --git a/monitor/qmp.c b/monitor/qmp.c
|
||||||
index 5e538f34c0..eb181d5979 100644
|
index a239945e8d..589c9524f8 100644
|
||||||
--- a/monitor/qmp.c
|
--- a/monitor/qmp.c
|
||||||
+++ b/monitor/qmp.c
|
+++ b/monitor/qmp.c
|
||||||
@@ -165,6 +165,8 @@ static void monitor_qmp_dispatch(MonitorQMP *mon, QObject *req)
|
@@ -165,6 +165,8 @@ static void monitor_qmp_dispatch(MonitorQMP *mon, QObject *req)
|
||||||
@@ -189,7 +189,7 @@ index 176b549473..790bb7d1da 100644
|
|||||||
aio_bh_schedule_oneshot(iohandler_get_aio_context(), do_qmp_dispatch_bh,
|
aio_bh_schedule_oneshot(iohandler_get_aio_context(), do_qmp_dispatch_bh,
|
||||||
&data);
|
&data);
|
||||||
diff --git a/stubs/monitor-core.c b/stubs/monitor-core.c
|
diff --git a/stubs/monitor-core.c b/stubs/monitor-core.c
|
||||||
index 1894cdfe1f..d74d0459f0 100644
|
index afa477aae6..d3ff124bf3 100644
|
||||||
--- a/stubs/monitor-core.c
|
--- a/stubs/monitor-core.c
|
||||||
+++ b/stubs/monitor-core.c
|
+++ b/stubs/monitor-core.c
|
||||||
@@ -12,6 +12,11 @@ Monitor *monitor_set_cur(Coroutine *co, Monitor *mon)
|
@@ -12,6 +12,11 @@ Monitor *monitor_set_cur(Coroutine *co, Monitor *mon)
|
||||||
@@ -201,6 +201,6 @@ index 1894cdfe1f..d74d0459f0 100644
|
|||||||
+ return -1;
|
+ return -1;
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
void qapi_event_emit(QAPIEvent event, QDict *qdict)
|
void monitor_init_qmp(Chardev *chr, bool pretty, Error **errp)
|
||||||
{
|
{
|
||||||
}
|
}
|
||||||
|
69
debian/patches/extra/0002-scsi-megasas-Internal-cdbs-have-16-byte-length.patch
vendored
Normal file
69
debian/patches/extra/0002-scsi-megasas-Internal-cdbs-have-16-byte-length.patch
vendored
Normal file
@@ -0,0 +1,69 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Guenter Roeck <linux@roeck-us.net>
|
||||||
|
Date: Tue, 28 Feb 2023 09:11:29 -0800
|
||||||
|
Subject: [PATCH] scsi: megasas: Internal cdbs have 16-byte length
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
Host drivers do not necessarily set cdb_len in megasas io commands.
|
||||||
|
With commits 6d1511cea0 ("scsi: Reject commands if the CDB length
|
||||||
|
exceeds buf_len") and fe9d8927e2 ("scsi: Add buf_len parameter to
|
||||||
|
scsi_req_new()"), this results in failures to boot Linux from affected
|
||||||
|
SCSI drives because cdb_len is set to 0 by the host driver.
|
||||||
|
Set the cdb length to its actual size to solve the problem.
|
||||||
|
|
||||||
|
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
|
||||||
|
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
||||||
|
(picked-up from https://lists.nongnu.org/archive/html/qemu-devel/2023-02/msg08653.html)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
hw/scsi/megasas.c | 14 ++------------
|
||||||
|
1 file changed, 2 insertions(+), 12 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
|
||||||
|
index 2d0c607177..97e51733af 100644
|
||||||
|
--- a/hw/scsi/megasas.c
|
||||||
|
+++ b/hw/scsi/megasas.c
|
||||||
|
@@ -1781,7 +1781,7 @@ static int megasas_handle_io(MegasasState *s, MegasasCmd *cmd, int frame_cmd)
|
||||||
|
uint8_t cdb[16];
|
||||||
|
int len;
|
||||||
|
struct SCSIDevice *sdev = NULL;
|
||||||
|
- int target_id, lun_id, cdb_len;
|
||||||
|
+ int target_id, lun_id;
|
||||||
|
|
||||||
|
lba_count = le32_to_cpu(cmd->frame->io.header.data_len);
|
||||||
|
lba_start_lo = le32_to_cpu(cmd->frame->io.lba_lo);
|
||||||
|
@@ -1790,7 +1790,6 @@ static int megasas_handle_io(MegasasState *s, MegasasCmd *cmd, int frame_cmd)
|
||||||
|
|
||||||
|
target_id = cmd->frame->header.target_id;
|
||||||
|
lun_id = cmd->frame->header.lun_id;
|
||||||
|
- cdb_len = cmd->frame->header.cdb_len;
|
||||||
|
|
||||||
|
if (target_id < MFI_MAX_LD && lun_id == 0) {
|
||||||
|
sdev = scsi_device_find(&s->bus, 0, target_id, lun_id);
|
||||||
|
@@ -1805,15 +1804,6 @@ static int megasas_handle_io(MegasasState *s, MegasasCmd *cmd, int frame_cmd)
|
||||||
|
return MFI_STAT_DEVICE_NOT_FOUND;
|
||||||
|
}
|
||||||
|
|
||||||
|
- if (cdb_len > 16) {
|
||||||
|
- trace_megasas_scsi_invalid_cdb_len(
|
||||||
|
- mfi_frame_desc(frame_cmd), 1, target_id, lun_id, cdb_len);
|
||||||
|
- megasas_write_sense(cmd, SENSE_CODE(INVALID_OPCODE));
|
||||||
|
- cmd->frame->header.scsi_status = CHECK_CONDITION;
|
||||||
|
- s->event_count++;
|
||||||
|
- return MFI_STAT_SCSI_DONE_WITH_ERROR;
|
||||||
|
- }
|
||||||
|
-
|
||||||
|
cmd->iov_size = lba_count * sdev->blocksize;
|
||||||
|
if (megasas_map_sgl(s, cmd, &cmd->frame->io.sgl)) {
|
||||||
|
megasas_write_sense(cmd, SENSE_CODE(TARGET_FAILURE));
|
||||||
|
@@ -1824,7 +1814,7 @@ static int megasas_handle_io(MegasasState *s, MegasasCmd *cmd, int frame_cmd)
|
||||||
|
|
||||||
|
megasas_encode_lba(cdb, lba_start, lba_count, is_write);
|
||||||
|
cmd->req = scsi_req_new(sdev, cmd->index,
|
||||||
|
- lun_id, cdb, cdb_len, cmd);
|
||||||
|
+ lun_id, cdb, sizeof(cdb), cmd);
|
||||||
|
if (!cmd->req) {
|
||||||
|
trace_megasas_scsi_req_alloc_failed(
|
||||||
|
mfi_frame_desc(frame_cmd), target_id, lun_id);
|
@@ -55,7 +55,7 @@ Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|||||||
1 file changed, 6 insertions(+), 6 deletions(-)
|
1 file changed, 6 insertions(+), 6 deletions(-)
|
||||||
|
|
||||||
diff --git a/hw/ide/core.c b/hw/ide/core.c
|
diff --git a/hw/ide/core.c b/hw/ide/core.c
|
||||||
index 08d9218455..20d8c0cf66 100644
|
index e8cb2dac92..3b21acf651 100644
|
||||||
--- a/hw/ide/core.c
|
--- a/hw/ide/core.c
|
||||||
+++ b/hw/ide/core.c
|
+++ b/hw/ide/core.c
|
||||||
@@ -456,7 +456,7 @@ static void ide_trim_bh_cb(void *opaque)
|
@@ -456,7 +456,7 @@ static void ide_trim_bh_cb(void *opaque)
|
@@ -1,82 +0,0 @@
|
|||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Richard Henderson <richard.henderson@linaro.org>
|
|
||||||
Date: Sat, 7 Dec 2024 18:14:45 +0000
|
|
||||||
Subject: [PATCH] tcg: Reset free_temps before tcg_optimize
|
|
||||||
MIME-Version: 1.0
|
|
||||||
Content-Type: text/plain; charset=UTF-8
|
|
||||||
Content-Transfer-Encoding: 8bit
|
|
||||||
|
|
||||||
When allocating new temps during tcg_optmize, do not re-use
|
|
||||||
any EBB temps that were used within the TB. We do not have
|
|
||||||
any idea what span of the TB in which the temp was live.
|
|
||||||
|
|
||||||
Introduce tcg_temp_ebb_reset_freed and use before tcg_optimize,
|
|
||||||
as well as replacing the equivalent in plugin_gen_inject and
|
|
||||||
tcg_func_start.
|
|
||||||
|
|
||||||
Cc: qemu-stable@nongnu.org
|
|
||||||
Fixes: fb04ab7ddd8 ("tcg/optimize: Lower TCG_COND_TST{EQ,NE} if unsupported")
|
|
||||||
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2711
|
|
||||||
Reported-by: wannacu <wannacu2049@gmail.com>
|
|
||||||
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
|
|
||||||
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
|
|
||||||
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
|
||||||
(cherry picked from commit 04e006ab36a8565b92d4e21dd346367fbade7d74)
|
|
||||||
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
---
|
|
||||||
accel/tcg/plugin-gen.c | 2 +-
|
|
||||||
include/tcg/tcg-temp-internal.h | 6 ++++++
|
|
||||||
tcg/tcg.c | 5 ++++-
|
|
||||||
3 files changed, 11 insertions(+), 2 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c
|
|
||||||
index 0f47bfbb48..1ef075552c 100644
|
|
||||||
--- a/accel/tcg/plugin-gen.c
|
|
||||||
+++ b/accel/tcg/plugin-gen.c
|
|
||||||
@@ -275,7 +275,7 @@ static void plugin_gen_inject(struct qemu_plugin_tb *plugin_tb)
|
|
||||||
* that might be live within the existing opcode stream.
|
|
||||||
* The simplest solution is to release them all and create new.
|
|
||||||
*/
|
|
||||||
- memset(tcg_ctx->free_temps, 0, sizeof(tcg_ctx->free_temps));
|
|
||||||
+ tcg_temp_ebb_reset_freed(tcg_ctx);
|
|
||||||
|
|
||||||
QTAILQ_FOREACH_SAFE(op, &tcg_ctx->ops, link, next) {
|
|
||||||
switch (op->opc) {
|
|
||||||
diff --git a/include/tcg/tcg-temp-internal.h b/include/tcg/tcg-temp-internal.h
|
|
||||||
index 44192c55a9..98f91e68b7 100644
|
|
||||||
--- a/include/tcg/tcg-temp-internal.h
|
|
||||||
+++ b/include/tcg/tcg-temp-internal.h
|
|
||||||
@@ -42,4 +42,10 @@ TCGv_i64 tcg_temp_ebb_new_i64(void);
|
|
||||||
TCGv_ptr tcg_temp_ebb_new_ptr(void);
|
|
||||||
TCGv_i128 tcg_temp_ebb_new_i128(void);
|
|
||||||
|
|
||||||
+/* Forget all freed EBB temps, so that new allocations produce new temps. */
|
|
||||||
+static inline void tcg_temp_ebb_reset_freed(TCGContext *s)
|
|
||||||
+{
|
|
||||||
+ memset(s->free_temps, 0, sizeof(s->free_temps));
|
|
||||||
+}
|
|
||||||
+
|
|
||||||
#endif /* TCG_TEMP_FREE_H */
|
|
||||||
diff --git a/tcg/tcg.c b/tcg/tcg.c
|
|
||||||
index 0babae1b88..4578b185be 100644
|
|
||||||
--- a/tcg/tcg.c
|
|
||||||
+++ b/tcg/tcg.c
|
|
||||||
@@ -1489,7 +1489,7 @@ void tcg_func_start(TCGContext *s)
|
|
||||||
s->nb_temps = s->nb_globals;
|
|
||||||
|
|
||||||
/* No temps have been previously allocated for size or locality. */
|
|
||||||
- memset(s->free_temps, 0, sizeof(s->free_temps));
|
|
||||||
+ tcg_temp_ebb_reset_freed(s);
|
|
||||||
|
|
||||||
/* No constant temps have been previously allocated. */
|
|
||||||
for (int i = 0; i < TCG_TYPE_COUNT; ++i) {
|
|
||||||
@@ -6120,6 +6120,9 @@ int tcg_gen_code(TCGContext *s, TranslationBlock *tb, uint64_t pc_start)
|
|
||||||
}
|
|
||||||
#endif
|
|
||||||
|
|
||||||
+ /* Do not reuse any EBB that may be allocated within the TB. */
|
|
||||||
+ tcg_temp_ebb_reset_freed(s);
|
|
||||||
+
|
|
||||||
tcg_optimize(s);
|
|
||||||
|
|
||||||
reachable_code_pass(s);
|
|
45
debian/patches/extra/0004-Revert-x86-acpi-workaround-Windows-not-handling-name.patch
vendored
Normal file
45
debian/patches/extra/0004-Revert-x86-acpi-workaround-Windows-not-handling-name.patch
vendored
Normal file
@@ -0,0 +1,45 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Fri, 17 Nov 2023 11:18:06 +0100
|
||||||
|
Subject: [PATCH] Revert "x86: acpi: workaround Windows not handling name
|
||||||
|
references in Package properly"
|
||||||
|
|
||||||
|
This reverts commit 44d975ef340e2f21f236f9520c53e1b30d2213a4.
|
||||||
|
|
||||||
|
As reported in the community forum [0] and reproduced locally this
|
||||||
|
breaks VirtIO network adapters in (at least) the German ISO of Windows
|
||||||
|
Server 2022. The fix itself was for
|
||||||
|
|
||||||
|
> Issue is not fatal but as result acpi-index/"PCI Label ID" property
|
||||||
|
> is either not shown in device details page or shows incorrect value.
|
||||||
|
|
||||||
|
so revert and tolerate that as a stop-gap, rather than have the
|
||||||
|
devices not working at all.
|
||||||
|
|
||||||
|
[0]: https://forum.proxmox.com/threads/92094/post-605684
|
||||||
|
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
hw/i386/acpi-build.c | 8 ++------
|
||||||
|
1 file changed, 2 insertions(+), 6 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
|
||||||
|
index 53f804ac16..9b1b9f0412 100644
|
||||||
|
--- a/hw/i386/acpi-build.c
|
||||||
|
+++ b/hw/i386/acpi-build.c
|
||||||
|
@@ -347,13 +347,9 @@ Aml *aml_pci_device_dsm(void)
|
||||||
|
{
|
||||||
|
Aml *params = aml_local(0);
|
||||||
|
Aml *pkg = aml_package(2);
|
||||||
|
- aml_append(pkg, aml_int(0));
|
||||||
|
- aml_append(pkg, aml_int(0));
|
||||||
|
+ aml_append(pkg, aml_name("BSEL"));
|
||||||
|
+ aml_append(pkg, aml_name("ASUN"));
|
||||||
|
aml_append(method, aml_store(pkg, params));
|
||||||
|
- aml_append(method,
|
||||||
|
- aml_store(aml_name("BSEL"), aml_index(params, aml_int(0))));
|
||||||
|
- aml_append(method,
|
||||||
|
- aml_store(aml_name("ASUN"), aml_index(params, aml_int(1))));
|
||||||
|
aml_append(method,
|
||||||
|
aml_return(aml_call5("PDSM", aml_arg(0), aml_arg(1),
|
||||||
|
aml_arg(2), aml_arg(3), params))
|
@@ -1,149 +0,0 @@
|
|||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>
|
|
||||||
Date: Thu, 12 Dec 2024 15:51:15 +0100
|
|
||||||
Subject: [PATCH] target/i386: Reset TSCs of parked vCPUs too on VM reset
|
|
||||||
|
|
||||||
Since commit 5286c3662294 ("target/i386: properly reset TSC on reset")
|
|
||||||
QEMU writes the special value of "1" to each online vCPU TSC on VM reset
|
|
||||||
to reset it.
|
|
||||||
|
|
||||||
However parked vCPUs don't get that handling and due to that their TSCs
|
|
||||||
get desynchronized when the VM gets reset.
|
|
||||||
This in turn causes KVM to turn off PVCLOCK_TSC_STABLE_BIT in its exported
|
|
||||||
PV clock.
|
|
||||||
Note that KVM has no understanding of vCPU being currently parked.
|
|
||||||
|
|
||||||
Without PVCLOCK_TSC_STABLE_BIT the sched clock is marked unstable in
|
|
||||||
the guest's kvm_sched_clock_init().
|
|
||||||
This causes a performance regressions to show in some tests.
|
|
||||||
|
|
||||||
Fix this issue by writing the special value of "1" also to TSCs of parked
|
|
||||||
vCPUs on VM reset.
|
|
||||||
|
|
||||||
Reproducing the issue:
|
|
||||||
1) Boot a VM with "-smp 2,maxcpus=3" or similar
|
|
||||||
|
|
||||||
2) device_add host-x86_64-cpu,id=vcpu,node-id=0,socket-id=0,core-id=2,thread-id=0
|
|
||||||
|
|
||||||
3) Wait a few seconds
|
|
||||||
|
|
||||||
4) device_del vcpu
|
|
||||||
|
|
||||||
5) Inside the VM run:
|
|
||||||
# echo "t" >/proc/sysrq-trigger; dmesg | grep sched_clock_stable
|
|
||||||
Observe the sched_clock_stable() value is 1.
|
|
||||||
|
|
||||||
6) Reboot the VM
|
|
||||||
|
|
||||||
7) Once the VM boots once again run inside it:
|
|
||||||
# echo "t" >/proc/sysrq-trigger; dmesg | grep sched_clock_stable
|
|
||||||
Observe the sched_clock_stable() value is now 0.
|
|
||||||
|
|
||||||
Fixes: 5286c3662294 ("target/i386: properly reset TSC on reset")
|
|
||||||
Signed-off-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
|
|
||||||
Link: https://lore.kernel.org/r/5a605a88e9a231386dc803c60f5fed9b48108139.1734014926.git.maciej.szmigiero@oracle.com
|
|
||||||
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
||||||
(cherry picked from commit 3f2a05b31ee9ce2ddb6c75a9bc3f5e7f7af9a76f)
|
|
||||||
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
---
|
|
||||||
accel/kvm/kvm-all.c | 11 +++++++++++
|
|
||||||
configs/targets/i386-softmmu.mak | 1 +
|
|
||||||
configs/targets/x86_64-softmmu.mak | 1 +
|
|
||||||
include/sysemu/kvm.h | 8 ++++++++
|
|
||||||
target/i386/kvm/kvm.c | 15 +++++++++++++++
|
|
||||||
5 files changed, 36 insertions(+)
|
|
||||||
|
|
||||||
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
|
|
||||||
index 801cff16a5..dec1d1c16a 100644
|
|
||||||
--- a/accel/kvm/kvm-all.c
|
|
||||||
+++ b/accel/kvm/kvm-all.c
|
|
||||||
@@ -437,6 +437,16 @@ int kvm_unpark_vcpu(KVMState *s, unsigned long vcpu_id)
|
|
||||||
return kvm_fd;
|
|
||||||
}
|
|
||||||
|
|
||||||
+static void kvm_reset_parked_vcpus(void *param)
|
|
||||||
+{
|
|
||||||
+ KVMState *s = param;
|
|
||||||
+ struct KVMParkedVcpu *cpu;
|
|
||||||
+
|
|
||||||
+ QLIST_FOREACH(cpu, &s->kvm_parked_vcpus, node) {
|
|
||||||
+ kvm_arch_reset_parked_vcpu(cpu->vcpu_id, cpu->kvm_fd);
|
|
||||||
+ }
|
|
||||||
+}
|
|
||||||
+
|
|
||||||
int kvm_create_vcpu(CPUState *cpu)
|
|
||||||
{
|
|
||||||
unsigned long vcpu_id = kvm_arch_vcpu_id(cpu);
|
|
||||||
@@ -2728,6 +2738,7 @@ static int kvm_init(MachineState *ms)
|
|
||||||
}
|
|
||||||
|
|
||||||
qemu_register_reset(kvm_unpoison_all, NULL);
|
|
||||||
+ qemu_register_reset(kvm_reset_parked_vcpus, s);
|
|
||||||
|
|
||||||
if (s->kernel_irqchip_allowed) {
|
|
||||||
kvm_irqchip_create(s);
|
|
||||||
diff --git a/configs/targets/i386-softmmu.mak b/configs/targets/i386-softmmu.mak
|
|
||||||
index 2ac69d5ba3..2eb0e86250 100644
|
|
||||||
--- a/configs/targets/i386-softmmu.mak
|
|
||||||
+++ b/configs/targets/i386-softmmu.mak
|
|
||||||
@@ -1,4 +1,5 @@
|
|
||||||
TARGET_ARCH=i386
|
|
||||||
TARGET_SUPPORTS_MTTCG=y
|
|
||||||
TARGET_KVM_HAVE_GUEST_DEBUG=y
|
|
||||||
+TARGET_KVM_HAVE_RESET_PARKED_VCPU=y
|
|
||||||
TARGET_XML_FILES= gdb-xml/i386-32bit.xml
|
|
||||||
diff --git a/configs/targets/x86_64-softmmu.mak b/configs/targets/x86_64-softmmu.mak
|
|
||||||
index e12ac3dc59..920e9a4200 100644
|
|
||||||
--- a/configs/targets/x86_64-softmmu.mak
|
|
||||||
+++ b/configs/targets/x86_64-softmmu.mak
|
|
||||||
@@ -2,4 +2,5 @@ TARGET_ARCH=x86_64
|
|
||||||
TARGET_BASE_ARCH=i386
|
|
||||||
TARGET_SUPPORTS_MTTCG=y
|
|
||||||
TARGET_KVM_HAVE_GUEST_DEBUG=y
|
|
||||||
+TARGET_KVM_HAVE_RESET_PARKED_VCPU=y
|
|
||||||
TARGET_XML_FILES= gdb-xml/i386-64bit.xml
|
|
||||||
diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
|
|
||||||
index c3a60b2890..ab17c09a55 100644
|
|
||||||
--- a/include/sysemu/kvm.h
|
|
||||||
+++ b/include/sysemu/kvm.h
|
|
||||||
@@ -377,6 +377,14 @@ int kvm_arch_init(MachineState *ms, KVMState *s);
|
|
||||||
int kvm_arch_init_vcpu(CPUState *cpu);
|
|
||||||
int kvm_arch_destroy_vcpu(CPUState *cpu);
|
|
||||||
|
|
||||||
+#ifdef TARGET_KVM_HAVE_RESET_PARKED_VCPU
|
|
||||||
+void kvm_arch_reset_parked_vcpu(unsigned long vcpu_id, int kvm_fd);
|
|
||||||
+#else
|
|
||||||
+static inline void kvm_arch_reset_parked_vcpu(unsigned long vcpu_id, int kvm_fd)
|
|
||||||
+{
|
|
||||||
+}
|
|
||||||
+#endif
|
|
||||||
+
|
|
||||||
bool kvm_vcpu_id_is_valid(int vcpu_id);
|
|
||||||
|
|
||||||
/* Returns VCPU ID to be used on KVM_CREATE_VCPU ioctl() */
|
|
||||||
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
|
|
||||||
index 8e17942c3b..2ff618fbf1 100644
|
|
||||||
--- a/target/i386/kvm/kvm.c
|
|
||||||
+++ b/target/i386/kvm/kvm.c
|
|
||||||
@@ -2415,6 +2415,21 @@ void kvm_arch_after_reset_vcpu(X86CPU *cpu)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
+void kvm_arch_reset_parked_vcpu(unsigned long vcpu_id, int kvm_fd)
|
|
||||||
+{
|
|
||||||
+ g_autofree struct kvm_msrs *msrs = NULL;
|
|
||||||
+
|
|
||||||
+ msrs = g_malloc0(sizeof(*msrs) + sizeof(msrs->entries[0]));
|
|
||||||
+ msrs->entries[0].index = MSR_IA32_TSC;
|
|
||||||
+ msrs->entries[0].data = 1; /* match the value in x86_cpu_reset() */
|
|
||||||
+ msrs->nmsrs++;
|
|
||||||
+
|
|
||||||
+ if (ioctl(kvm_fd, KVM_SET_MSRS, msrs) != 1) {
|
|
||||||
+ warn_report("parked vCPU %lu TSC reset failed: %d",
|
|
||||||
+ vcpu_id, errno);
|
|
||||||
+ }
|
|
||||||
+}
|
|
||||||
+
|
|
||||||
void kvm_arch_do_init_vcpu(X86CPU *cpu)
|
|
||||||
{
|
|
||||||
CPUX86State *env = &cpu->env;
|
|
35
debian/patches/extra/0005-block-copy-before-write-use-uint64_t-for-timeout-in-.patch
vendored
Normal file
35
debian/patches/extra/0005-block-copy-before-write-use-uint64_t-for-timeout-in-.patch
vendored
Normal file
@@ -0,0 +1,35 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Mon, 29 Apr 2024 15:41:11 +0200
|
||||||
|
Subject: [PATCH] block/copy-before-write: use uint64_t for timeout in
|
||||||
|
nanoseconds
|
||||||
|
|
||||||
|
rather than the uint32_t for which the maximum is slightly more than 4
|
||||||
|
seconds and larger values would overflow. The QAPI interface allows
|
||||||
|
specifying the number of seconds, so only values 0 to 4 are safe right
|
||||||
|
now, other values lead to a much lower timeout than a user expects.
|
||||||
|
|
||||||
|
The block_copy() call where this is used already takes a uint64_t for
|
||||||
|
the timeout, so no change required there.
|
||||||
|
|
||||||
|
Fixes: 6db7fd1ca9 ("block/copy-before-write: implement cbw-timeout option")
|
||||||
|
Reported-by: Friedrich Weber <f.weber@proxmox.com>
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Tested-by: Friedrich Weber <f.weber@proxmox.com>
|
||||||
|
---
|
||||||
|
block/copy-before-write.c | 2 +-
|
||||||
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
|
||||||
|
index 8aba27a71d..026fa9840f 100644
|
||||||
|
--- a/block/copy-before-write.c
|
||||||
|
+++ b/block/copy-before-write.c
|
||||||
|
@@ -43,7 +43,7 @@ typedef struct BDRVCopyBeforeWriteState {
|
||||||
|
BlockCopyState *bcs;
|
||||||
|
BdrvChild *target;
|
||||||
|
OnCbwError on_cbw_error;
|
||||||
|
- uint32_t cbw_timeout_ns;
|
||||||
|
+ uint64_t cbw_timeout_ns;
|
||||||
|
|
||||||
|
/*
|
||||||
|
* @lock: protects access to @access_bitmap, @done_bitmap and
|
@@ -1,41 +0,0 @@
|
|||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Zhao Liu <zhao1.liu@intel.com>
|
|
||||||
Date: Wed, 6 Nov 2024 11:07:18 +0800
|
|
||||||
Subject: [PATCH] i386/cpu: Mark avx10_version filtered when prefix is NULL
|
|
||||||
|
|
||||||
In x86_cpu_filter_features(), if host doesn't support AVX10, the
|
|
||||||
configured avx10_version should be marked as filtered regardless of
|
|
||||||
whether prefix is NULL or not.
|
|
||||||
|
|
||||||
Check prefix before warn_report() instead of checking for
|
|
||||||
have_filtered_features.
|
|
||||||
|
|
||||||
Cc: qemu-stable@nongnu.org
|
|
||||||
Fixes: commit bccfb846fd52 ("target/i386: add AVX10 feature and AVX10 version property")
|
|
||||||
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
|
|
||||||
Reviewed-by: Tao Su <tao1.su@linux.intel.com>
|
|
||||||
Link: https://lore.kernel.org/r/20241106030728.553238-2-zhao1.liu@intel.com
|
|
||||||
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
||||||
(cherry picked from commit cf4c263551886964c5d58bd7b675b13fd497b402)
|
|
||||||
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
---
|
|
||||||
target/i386/cpu.c | 6 ++++--
|
|
||||||
1 file changed, 4 insertions(+), 2 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
|
|
||||||
index 3725dbbc4b..1981aeaba5 100644
|
|
||||||
--- a/target/i386/cpu.c
|
|
||||||
+++ b/target/i386/cpu.c
|
|
||||||
@@ -7718,8 +7718,10 @@ static bool x86_cpu_filter_features(X86CPU *cpu, bool verbose)
|
|
||||||
env->avx10_version = version;
|
|
||||||
have_filtered_features = true;
|
|
||||||
}
|
|
||||||
- } else if (env->avx10_version && prefix) {
|
|
||||||
- warn_report("%s: avx10.%d.", prefix, env->avx10_version);
|
|
||||||
+ } else if (env->avx10_version) {
|
|
||||||
+ if (prefix) {
|
|
||||||
+ warn_report("%s: avx10.%d.", prefix, env->avx10_version);
|
|
||||||
+ }
|
|
||||||
have_filtered_features = true;
|
|
||||||
}
|
|
||||||
|
|
55
debian/patches/extra/0006-block-copy-before-write-fix-permission.patch
vendored
Normal file
55
debian/patches/extra/0006-block-copy-before-write-fix-permission.patch
vendored
Normal file
@@ -0,0 +1,55 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
|
||||||
|
Date: Thu, 11 Apr 2024 11:29:22 +0200
|
||||||
|
Subject: [PATCH] block/copy-before-write: fix permission
|
||||||
|
|
||||||
|
In case when source node does not have any parents, the condition still
|
||||||
|
works as required: backup job do create the parent by
|
||||||
|
|
||||||
|
block_job_create -> block_job_add_bdrv -> bdrv_root_attach_child
|
||||||
|
|
||||||
|
Still, in this case checking @perm variable doesn't work, as backup job
|
||||||
|
creates the root blk with empty permissions (as it rely on CBW filter
|
||||||
|
to require correct permissions and don't want to create extra
|
||||||
|
conflicts).
|
||||||
|
|
||||||
|
So, we should not check @perm.
|
||||||
|
|
||||||
|
The hack may be dropped entirely when transactional insertion of
|
||||||
|
filter (when we don't try to recalculate permissions in intermediate
|
||||||
|
state, when filter does conflict with original parent of the source
|
||||||
|
node) merged (old big series
|
||||||
|
"[PATCH v5 00/45] Transactional block-graph modifying API"[1] and it's
|
||||||
|
current in-flight part is "[PATCH v8 0/7] blockdev-replace"[2])
|
||||||
|
|
||||||
|
[1] https://patchew.org/QEMU/20220330212902.590099-1-vsementsov@openvz.org/
|
||||||
|
[2] https://patchew.org/QEMU/20231017184444.932733-1-vsementsov@yandex-team.ru/
|
||||||
|
|
||||||
|
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
block/copy-before-write.c | 10 +++++++---
|
||||||
|
1 file changed, 7 insertions(+), 3 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
|
||||||
|
index 026fa9840f..5a9456d426 100644
|
||||||
|
--- a/block/copy-before-write.c
|
||||||
|
+++ b/block/copy-before-write.c
|
||||||
|
@@ -364,9 +364,13 @@ cbw_child_perm(BlockDriverState *bs, BdrvChild *c, BdrvChildRole role,
|
||||||
|
perm, shared, nperm, nshared);
|
||||||
|
|
||||||
|
if (!QLIST_EMPTY(&bs->parents)) {
|
||||||
|
- if (perm & BLK_PERM_WRITE) {
|
||||||
|
- *nperm = *nperm | BLK_PERM_CONSISTENT_READ;
|
||||||
|
- }
|
||||||
|
+ /*
|
||||||
|
+ * Note, that source child may be shared with backup job. Backup job
|
||||||
|
+ * does create own blk parent on copy-before-write node, so this
|
||||||
|
+ * works even if source node does not have any parents before backup
|
||||||
|
+ * start
|
||||||
|
+ */
|
||||||
|
+ *nperm = *nperm | BLK_PERM_CONSISTENT_READ;
|
||||||
|
*nshared &= ~(BLK_PERM_WRITE | BLK_PERM_RESIZE);
|
||||||
|
}
|
||||||
|
}
|
@@ -1,67 +0,0 @@
|
|||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Laurent Vivier <lvivier@redhat.com>
|
|
||||||
Date: Fri, 17 Jan 2025 12:17:08 +0100
|
|
||||||
Subject: [PATCH] net: Fix announce_self
|
|
||||||
|
|
||||||
b9ad513e1876 ("net: Remove receive_raw()") adds an iovec entry
|
|
||||||
in qemu_deliver_packet_iov() to add the virtio-net header
|
|
||||||
in the data when QEMU_NET_PACKET_FLAG_RAW is set but forgets
|
|
||||||
to increase the number of iovec entries in the array, so
|
|
||||||
receive_iov() will only send the first entry (the virtio-net
|
|
||||||
entry, full of 0) and no data. The packet will be discarded.
|
|
||||||
|
|
||||||
The only user of QEMU_NET_PACKET_FLAG_RAW is announce_self.
|
|
||||||
|
|
||||||
We can see the problem with tcpdump:
|
|
||||||
|
|
||||||
- QEMU parameters:
|
|
||||||
|
|
||||||
.. -monitor stdio \
|
|
||||||
-netdev bridge,id=netdev0,br=virbr0 \
|
|
||||||
-device virtio-net,mac=9a:2b:2c:2d:2e:2f,netdev=netdev0 \
|
|
||||||
|
|
||||||
- HMP command:
|
|
||||||
|
|
||||||
(qemu) announce_self
|
|
||||||
|
|
||||||
- TCP dump:
|
|
||||||
|
|
||||||
$ sudo tcpdump -nxi virbr0
|
|
||||||
|
|
||||||
without the fix:
|
|
||||||
|
|
||||||
<nothing>
|
|
||||||
|
|
||||||
with the fix:
|
|
||||||
|
|
||||||
ARP, Reverse Request who-is 9a:2b:2c:2d:2e:2f tell 9a:2b:2c:2d:2e:2f, length 46
|
|
||||||
0x0000: 0001 0800 0604 0003 9a2b 2c2d 2e2f 0000
|
|
||||||
0x0010: 0000 9a2b 2c2d 2e2f 0000 0000 0000 0000
|
|
||||||
0x0020: 0000 0000 0000 0000 0000 0000 0000
|
|
||||||
|
|
||||||
Reported-by: Xiaohui Li <xiaohli@redhat.com>
|
|
||||||
Bug: https://issues.redhat.com/browse/RHEL-73891
|
|
||||||
Fixes: b9ad513e1876 ("net: Remove receive_raw()")
|
|
||||||
Cc: akihiko.odaki@daynix.com
|
|
||||||
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
|
|
||||||
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
|
|
||||||
Acked-by: Jason Wang <jasowang@redhat.com>
|
|
||||||
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
|
|
||||||
(picked from https://lore.kernel.org/qemu-devel/20250117111709.970789-2-lvivier@redhat.com/)
|
|
||||||
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
---
|
|
||||||
net/net.c | 1 +
|
|
||||||
1 file changed, 1 insertion(+)
|
|
||||||
|
|
||||||
diff --git a/net/net.c b/net/net.c
|
|
||||||
index 7ef6885876..fefa701bb2 100644
|
|
||||||
--- a/net/net.c
|
|
||||||
+++ b/net/net.c
|
|
||||||
@@ -822,6 +822,7 @@ static ssize_t qemu_deliver_packet_iov(NetClientState *sender,
|
|
||||||
iov_copy[0].iov_len = nc->vnet_hdr_len;
|
|
||||||
memcpy(&iov_copy[1], iov, iovcnt * sizeof(*iov));
|
|
||||||
iov = iov_copy;
|
|
||||||
+ iovcnt++;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (nc->info->receive_iov) {
|
|
48
debian/patches/extra/0007-block-copy-before-write-support-unligned-snapshot-di.patch
vendored
Normal file
48
debian/patches/extra/0007-block-copy-before-write-support-unligned-snapshot-di.patch
vendored
Normal file
@@ -0,0 +1,48 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
|
||||||
|
Date: Thu, 11 Apr 2024 11:29:23 +0200
|
||||||
|
Subject: [PATCH] block/copy-before-write: support unligned snapshot-discard
|
||||||
|
|
||||||
|
First thing that crashes on unligned access here is
|
||||||
|
bdrv_reset_dirty_bitmap(). Correct way is to align-down the
|
||||||
|
snapshot-discard request.
|
||||||
|
|
||||||
|
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
block/copy-before-write.c | 16 +++++++++++++---
|
||||||
|
1 file changed, 13 insertions(+), 3 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
|
||||||
|
index 5a9456d426..c0e70669a2 100644
|
||||||
|
--- a/block/copy-before-write.c
|
||||||
|
+++ b/block/copy-before-write.c
|
||||||
|
@@ -325,14 +325,24 @@ static int coroutine_fn GRAPH_RDLOCK
|
||||||
|
cbw_co_pdiscard_snapshot(BlockDriverState *bs, int64_t offset, int64_t bytes)
|
||||||
|
{
|
||||||
|
BDRVCopyBeforeWriteState *s = bs->opaque;
|
||||||
|
+ uint32_t cluster_size = block_copy_cluster_size(s->bcs);
|
||||||
|
+ int64_t aligned_offset = QEMU_ALIGN_UP(offset, cluster_size);
|
||||||
|
+ int64_t aligned_end = QEMU_ALIGN_DOWN(offset + bytes, cluster_size);
|
||||||
|
+ int64_t aligned_bytes;
|
||||||
|
+
|
||||||
|
+ if (aligned_end <= aligned_offset) {
|
||||||
|
+ return 0;
|
||||||
|
+ }
|
||||||
|
+ aligned_bytes = aligned_end - aligned_offset;
|
||||||
|
|
||||||
|
WITH_QEMU_LOCK_GUARD(&s->lock) {
|
||||||
|
- bdrv_reset_dirty_bitmap(s->access_bitmap, offset, bytes);
|
||||||
|
+ bdrv_reset_dirty_bitmap(s->access_bitmap, aligned_offset,
|
||||||
|
+ aligned_bytes);
|
||||||
|
}
|
||||||
|
|
||||||
|
- block_copy_reset(s->bcs, offset, bytes);
|
||||||
|
+ block_copy_reset(s->bcs, aligned_offset, aligned_bytes);
|
||||||
|
|
||||||
|
- return bdrv_co_pdiscard(s->target, offset, bytes);
|
||||||
|
+ return bdrv_co_pdiscard(s->target, aligned_offset, aligned_bytes);
|
||||||
|
}
|
||||||
|
|
||||||
|
static void GRAPH_RDLOCK cbw_refresh_filename(BlockDriverState *bs)
|
@@ -1,67 +0,0 @@
|
|||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Laurent Vivier <lvivier@redhat.com>
|
|
||||||
Date: Fri, 17 Jan 2025 12:17:09 +0100
|
|
||||||
Subject: [PATCH] net/dump: Correctly compute Ethernet packet offset
|
|
||||||
|
|
||||||
When a packet is sent with QEMU_NET_PACKET_FLAG_RAW by QEMU it
|
|
||||||
never includes virtio-net header even if qemu_get_vnet_hdr_len()
|
|
||||||
is not 0, and filter-dump is not managing this case.
|
|
||||||
|
|
||||||
The only user of QEMU_NET_PACKET_FLAG_RAW is announce_self,
|
|
||||||
we can show the problem using it and tcpddump:
|
|
||||||
|
|
||||||
- QEMU parameters:
|
|
||||||
|
|
||||||
.. -monitor stdio \
|
|
||||||
-netdev bridge,id=netdev0,br=virbr0 \
|
|
||||||
-device virtio-net,mac=9a:2b:2c:2d:2e:2f,netdev=netdev0 \
|
|
||||||
-object filter-dump,netdev=netdev0,file=log.pcap,id=pcap0
|
|
||||||
|
|
||||||
- HMP command:
|
|
||||||
|
|
||||||
(qemu) announce_self
|
|
||||||
|
|
||||||
- TCP dump:
|
|
||||||
|
|
||||||
$ tcpdump -nxr log.pcap
|
|
||||||
|
|
||||||
without the fix:
|
|
||||||
|
|
||||||
08:00:06:04:00:03 > 2e:2f:80:35:00:01, ethertype Unknown (0x9a2b), length 50:
|
|
||||||
0x0000: 2c2d 2e2f 0000 0000 9a2b 2c2d 2e2f 0000
|
|
||||||
0x0010: 0000 0000 0000 0000 0000 0000 0000 0000
|
|
||||||
0x0020: 0000 0000
|
|
||||||
|
|
||||||
with the fix:
|
|
||||||
|
|
||||||
ARP, Reverse Request who-is 9a:2b:2c:2d:2e:2f tell 9a:2b:2c:2d:2e:2f, length 46
|
|
||||||
0x0000: 0001 0800 0604 0003 9a2b 2c2d 2e2f 0000
|
|
||||||
0x0010: 0000 9a2b 2c2d 2e2f 0000 0000 0000 0000
|
|
||||||
0x0020: 0000 0000 0000 0000 0000 0000 0000
|
|
||||||
|
|
||||||
Fixes: 481c52320a26 ("net: Strip virtio-net header when dumping")
|
|
||||||
Cc: akihiko.odaki@daynix.com
|
|
||||||
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
|
|
||||||
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
|
|
||||||
Acked-by: Jason Wang <jasowang@redhat.com>
|
|
||||||
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
|
|
||||||
(picked from https://lore.kernel.org/qemu-devel/20250117111709.970789-3-lvivier@redhat.com/)
|
|
||||||
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
---
|
|
||||||
net/dump.c | 3 ++-
|
|
||||||
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
||||||
|
|
||||||
diff --git a/net/dump.c b/net/dump.c
|
|
||||||
index 956e34a123..42ab8d7716 100644
|
|
||||||
--- a/net/dump.c
|
|
||||||
+++ b/net/dump.c
|
|
||||||
@@ -155,7 +155,8 @@ static ssize_t filter_dump_receive_iov(NetFilterState *nf, NetClientState *sndr,
|
|
||||||
{
|
|
||||||
NetFilterDumpState *nfds = FILTER_DUMP(nf);
|
|
||||||
|
|
||||||
- dump_receive_iov(&nfds->ds, iov, iovcnt, qemu_get_vnet_hdr_len(nf->netdev));
|
|
||||||
+ dump_receive_iov(&nfds->ds, iov, iovcnt, flags & QEMU_NET_PACKET_FLAG_RAW ?
|
|
||||||
+ 0 : qemu_get_vnet_hdr_len(nf->netdev));
|
|
||||||
return 0;
|
|
||||||
}
|
|
||||||
|
|
373
debian/patches/extra/0008-block-copy-before-write-create-block_copy-bitmap-in-.patch
vendored
Normal file
373
debian/patches/extra/0008-block-copy-before-write-create-block_copy-bitmap-in-.patch
vendored
Normal file
@@ -0,0 +1,373 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
|
||||||
|
Date: Thu, 11 Apr 2024 11:29:24 +0200
|
||||||
|
Subject: [PATCH] block/copy-before-write: create block_copy bitmap in filter
|
||||||
|
node
|
||||||
|
|
||||||
|
Currently block_copy creates copy_bitmap in source node. But that is in
|
||||||
|
bad relation with .independent_close=true of copy-before-write filter:
|
||||||
|
source node may be detached and removed before .bdrv_close() handler
|
||||||
|
called, which should call block_copy_state_free(), which in turn should
|
||||||
|
remove copy_bitmap.
|
||||||
|
|
||||||
|
That's all not ideal: it would be better if internal bitmap of
|
||||||
|
block-copy object is not attached to any node. But that is not possible
|
||||||
|
now.
|
||||||
|
|
||||||
|
The simplest solution is just create copy_bitmap in filter node, where
|
||||||
|
anyway two other bitmaps are created.
|
||||||
|
|
||||||
|
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
block/block-copy.c | 3 +-
|
||||||
|
block/copy-before-write.c | 2 +-
|
||||||
|
include/block/block-copy.h | 1 +
|
||||||
|
tests/qemu-iotests/257.out | 112 ++++++++++++++++++-------------------
|
||||||
|
4 files changed, 60 insertions(+), 58 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/block-copy.c b/block/block-copy.c
|
||||||
|
index 9ee3dd7ef5..8fca2c3698 100644
|
||||||
|
--- a/block/block-copy.c
|
||||||
|
+++ b/block/block-copy.c
|
||||||
|
@@ -351,6 +351,7 @@ static int64_t block_copy_calculate_cluster_size(BlockDriverState *target,
|
||||||
|
}
|
||||||
|
|
||||||
|
BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||||||
|
+ BlockDriverState *copy_bitmap_bs,
|
||||||
|
const BdrvDirtyBitmap *bitmap,
|
||||||
|
Error **errp)
|
||||||
|
{
|
||||||
|
@@ -367,7 +368,7 @@ BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||||||
|
return NULL;
|
||||||
|
}
|
||||||
|
|
||||||
|
- copy_bitmap = bdrv_create_dirty_bitmap(source->bs, cluster_size, NULL,
|
||||||
|
+ copy_bitmap = bdrv_create_dirty_bitmap(copy_bitmap_bs, cluster_size, NULL,
|
||||||
|
errp);
|
||||||
|
if (!copy_bitmap) {
|
||||||
|
return NULL;
|
||||||
|
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
|
||||||
|
index c0e70669a2..94db31512d 100644
|
||||||
|
--- a/block/copy-before-write.c
|
||||||
|
+++ b/block/copy-before-write.c
|
||||||
|
@@ -468,7 +468,7 @@ static int cbw_open(BlockDriverState *bs, QDict *options, int flags,
|
||||||
|
((BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP | BDRV_REQ_NO_FALLBACK) &
|
||||||
|
bs->file->bs->supported_zero_flags);
|
||||||
|
|
||||||
|
- s->bcs = block_copy_state_new(bs->file, s->target, bitmap, errp);
|
||||||
|
+ s->bcs = block_copy_state_new(bs->file, s->target, bs, bitmap, errp);
|
||||||
|
if (!s->bcs) {
|
||||||
|
error_prepend(errp, "Cannot create block-copy-state: ");
|
||||||
|
return -EINVAL;
|
||||||
|
diff --git a/include/block/block-copy.h b/include/block/block-copy.h
|
||||||
|
index 0700953ab8..8b41643bfa 100644
|
||||||
|
--- a/include/block/block-copy.h
|
||||||
|
+++ b/include/block/block-copy.h
|
||||||
|
@@ -25,6 +25,7 @@ typedef struct BlockCopyState BlockCopyState;
|
||||||
|
typedef struct BlockCopyCallState BlockCopyCallState;
|
||||||
|
|
||||||
|
BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||||||
|
+ BlockDriverState *copy_bitmap_bs,
|
||||||
|
const BdrvDirtyBitmap *bitmap,
|
||||||
|
Error **errp);
|
||||||
|
|
||||||
|
diff --git a/tests/qemu-iotests/257.out b/tests/qemu-iotests/257.out
|
||||||
|
index aa76131ca9..c33dd7f3a9 100644
|
||||||
|
--- a/tests/qemu-iotests/257.out
|
||||||
|
+++ b/tests/qemu-iotests/257.out
|
||||||
|
@@ -120,16 +120,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -596,16 +596,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -865,16 +865,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -1341,16 +1341,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -1610,16 +1610,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -2086,16 +2086,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -2355,16 +2355,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -2831,16 +2831,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -3100,16 +3100,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -3576,16 +3576,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -3845,16 +3845,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -4321,16 +4321,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -4590,16 +4590,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
||||||
|
@@ -5066,16 +5066,16 @@ write -P0x67 0x3fe0000 0x20000
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- }
|
||||||
|
- ],
|
||||||
|
- "drive0": [
|
||||||
|
+ },
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 0,
|
||||||
|
"granularity": 65536,
|
||||||
|
"persistent": false,
|
||||||
|
"recording": false
|
||||||
|
- },
|
||||||
|
+ }
|
||||||
|
+ ],
|
||||||
|
+ "drive0": [
|
||||||
|
{
|
||||||
|
"busy": false,
|
||||||
|
"count": 458752,
|
@@ -1,96 +0,0 @@
|
|||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Igor Mammedov <imammedo@redhat.com>
|
|
||||||
Date: Wed, 15 Jan 2025 13:53:41 +0100
|
|
||||||
Subject: [PATCH] pci: acpi: Windows 'PCI Label Id' bug workaround
|
|
||||||
|
|
||||||
Current versions of Windows call _DSM(func=7) regardless
|
|
||||||
of whether it is supported or not. It leads to NICs having bogus
|
|
||||||
'PCI Label Id = 0', where none should be set at all.
|
|
||||||
|
|
||||||
Also presence of 'PCI Label Id' triggers another Windows bug
|
|
||||||
on localized versions that leads to hangs. The later bug is fixed
|
|
||||||
in latest updates for 'Windows Server' but not in consumer
|
|
||||||
versions of Windows (and there is no plans to fix it
|
|
||||||
as far as I'm aware).
|
|
||||||
|
|
||||||
Given it's easy, implement Microsoft suggested workaround
|
|
||||||
(return invalid Package) so that affected Windows versions
|
|
||||||
could boot on QEMU.
|
|
||||||
This would effectvely remove bogus 'PCI Label Id's on NICs,
|
|
||||||
but MS teem confirmed that flipping 'PCI Label Id' should not
|
|
||||||
change 'Network Connection' ennumeration, so it should be safe
|
|
||||||
for QEMU to change _DSM without any compat code.
|
|
||||||
|
|
||||||
Smoke tested with WinXP and WS2022
|
|
||||||
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/774
|
|
||||||
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
|
|
||||||
Message-Id: <20250115125342.3883374-3-imammedo@redhat.com>
|
|
||||||
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
|
||||||
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
|
||||||
(cherry picked from commit 0b053391985abcc40b16ac8fc4a7f6588d1d95c1)
|
|
||||||
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
---
|
|
||||||
hw/i386/acpi-build.c | 33 +++++++++++++++++++++++----------
|
|
||||||
1 file changed, 23 insertions(+), 10 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
|
|
||||||
index 9fcc2897b8..f7b961e04c 100644
|
|
||||||
--- a/hw/i386/acpi-build.c
|
|
||||||
+++ b/hw/i386/acpi-build.c
|
|
||||||
@@ -654,6 +654,7 @@ static Aml *aml_pci_pdsm(void)
|
|
||||||
Aml *acpi_index = aml_local(2);
|
|
||||||
Aml *zero = aml_int(0);
|
|
||||||
Aml *one = aml_int(1);
|
|
||||||
+ Aml *not_supp = aml_int(0xFFFFFFFF);
|
|
||||||
Aml *func = aml_arg(2);
|
|
||||||
Aml *params = aml_arg(4);
|
|
||||||
Aml *bnum = aml_derefof(aml_index(params, aml_int(0)));
|
|
||||||
@@ -678,7 +679,7 @@ static Aml *aml_pci_pdsm(void)
|
|
||||||
*/
|
|
||||||
ifctx1 = aml_if(aml_lnot(
|
|
||||||
aml_or(aml_equal(acpi_index, zero),
|
|
||||||
- aml_equal(acpi_index, aml_int(0xFFFFFFFF)), NULL)
|
|
||||||
+ aml_equal(acpi_index, not_supp), NULL)
|
|
||||||
));
|
|
||||||
{
|
|
||||||
/* have supported functions */
|
|
||||||
@@ -704,18 +705,30 @@ static Aml *aml_pci_pdsm(void)
|
|
||||||
{
|
|
||||||
Aml *pkg = aml_package(2);
|
|
||||||
|
|
||||||
- aml_append(pkg, zero);
|
|
||||||
- /*
|
|
||||||
- * optional, if not impl. should return null string
|
|
||||||
- */
|
|
||||||
- aml_append(pkg, aml_string("%s", ""));
|
|
||||||
- aml_append(ifctx, aml_store(pkg, ret));
|
|
||||||
-
|
|
||||||
aml_append(ifctx, aml_store(aml_call2("AIDX", bnum, sunum), acpi_index));
|
|
||||||
+ aml_append(ifctx, aml_store(pkg, ret));
|
|
||||||
/*
|
|
||||||
- * update acpi-index to actual value
|
|
||||||
+ * Windows calls func=7 without checking if it's available,
|
|
||||||
+ * as workaround Microsoft has suggested to return invalid for func7
|
|
||||||
+ * Package, so return 2 elements package but only initialize elements
|
|
||||||
+ * when acpi_index is supported and leave them uninitialized, which
|
|
||||||
+ * leads elements to being Uninitialized ObjectType and should trip
|
|
||||||
+ * Windows into discarding result as an unexpected and prevent setting
|
|
||||||
+ * bogus 'PCI Label' on the device.
|
|
||||||
*/
|
|
||||||
- aml_append(ifctx, aml_store(acpi_index, aml_index(ret, zero)));
|
|
||||||
+ ifctx1 = aml_if(aml_lnot(aml_lor(
|
|
||||||
+ aml_equal(acpi_index, zero), aml_equal(acpi_index, not_supp)
|
|
||||||
+ )));
|
|
||||||
+ {
|
|
||||||
+ aml_append(ifctx1, aml_store(acpi_index, aml_index(ret, zero)));
|
|
||||||
+ /*
|
|
||||||
+ * optional, if not impl. should return null string
|
|
||||||
+ */
|
|
||||||
+ aml_append(ifctx1, aml_store(aml_string("%s", ""),
|
|
||||||
+ aml_index(ret, one)));
|
|
||||||
+ }
|
|
||||||
+ aml_append(ifctx, ifctx1);
|
|
||||||
+
|
|
||||||
aml_append(ifctx, aml_return(ret));
|
|
||||||
}
|
|
||||||
|
|
@@ -1,53 +0,0 @@
|
|||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Phil Dennis-Jordan <phil@philjordan.eu>
|
|
||||||
Date: Fri, 13 Dec 2024 17:06:14 +0100
|
|
||||||
Subject: [PATCH] hw/usb/hcd-xhci-pci: Use modulo to select MSI vector as per
|
|
||||||
spec
|
|
||||||
MIME-Version: 1.0
|
|
||||||
Content-Type: text/plain; charset=UTF-8
|
|
||||||
Content-Transfer-Encoding: 8bit
|
|
||||||
|
|
||||||
QEMU would crash with a failed assertion if the XHCI controller
|
|
||||||
attempted to raise the interrupt on an interrupter corresponding
|
|
||||||
to a MSI vector with a higher index than the highest configured
|
|
||||||
for the device by the guest driver.
|
|
||||||
|
|
||||||
This behaviour is correct on the MSI/PCI side: per PCI 3.0 spec,
|
|
||||||
devices must ensure they do not send MSI notifications for
|
|
||||||
vectors beyond the range of those allocated by the system/driver
|
|
||||||
software. Unlike MSI-X, there is no generic way for handling
|
|
||||||
aliasing in the case of fewer allocated vectors than requested,
|
|
||||||
so the specifics are up to device implementors. (Section
|
|
||||||
6.8.3.4. "Sending Messages")
|
|
||||||
|
|
||||||
It turns out the XHCI spec (Implementation Note in section 4.17,
|
|
||||||
"Interrupters") requires that the host controller signal the MSI
|
|
||||||
vector with the number computed by taking the interrupter number
|
|
||||||
modulo the number of enabled MSI vectors.
|
|
||||||
|
|
||||||
This change introduces that modulo calculation, fixing the
|
|
||||||
failed assertion. This makes the device work correctly in MSI mode
|
|
||||||
with macOS's XHCI driver, which only allocates a single vector.
|
|
||||||
|
|
||||||
Signed-off-by: Phil Dennis-Jordan <phil@philjordan.eu>
|
|
||||||
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
|
||||||
Message-ID: <20250112210056.16658-2-phil@philjordan.eu>
|
|
||||||
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
|
||||||
(cherry picked from commit bb5b7fced6b5d3334ab20702fc846e47bb1fb731)
|
|
||||||
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
---
|
|
||||||
hw/usb/hcd-xhci-pci.c | 1 +
|
|
||||||
1 file changed, 1 insertion(+)
|
|
||||||
|
|
||||||
diff --git a/hw/usb/hcd-xhci-pci.c b/hw/usb/hcd-xhci-pci.c
|
|
||||||
index a039f5778a..516e6909d2 100644
|
|
||||||
--- a/hw/usb/hcd-xhci-pci.c
|
|
||||||
+++ b/hw/usb/hcd-xhci-pci.c
|
|
||||||
@@ -74,6 +74,7 @@ static bool xhci_pci_intr_raise(XHCIState *xhci, int n, bool level)
|
|
||||||
}
|
|
||||||
|
|
||||||
if (msi_enabled(pci_dev) && level) {
|
|
||||||
+ n %= msi_nr_vectors_allocated(pci_dev);
|
|
||||||
msi_notify(pci_dev, n);
|
|
||||||
return true;
|
|
||||||
}
|
|
277
debian/patches/extra/0009-qapi-blockdev-backup-add-discard-source-parameter.patch
vendored
Normal file
277
debian/patches/extra/0009-qapi-blockdev-backup-add-discard-source-parameter.patch
vendored
Normal file
@@ -0,0 +1,277 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
|
||||||
|
Date: Thu, 11 Apr 2024 11:29:25 +0200
|
||||||
|
Subject: [PATCH] qapi: blockdev-backup: add discard-source parameter
|
||||||
|
|
||||||
|
Add a parameter that enables discard-after-copy. That is mostly useful
|
||||||
|
in "push backup with fleecing" scheme, when source is snapshot-access
|
||||||
|
format driver node, based on copy-before-write filter snapshot-access
|
||||||
|
API:
|
||||||
|
|
||||||
|
[guest] [snapshot-access] ~~ blockdev-backup ~~> [backup target]
|
||||||
|
| |
|
||||||
|
| root | file
|
||||||
|
v v
|
||||||
|
[copy-before-write]
|
||||||
|
| |
|
||||||
|
| file | target
|
||||||
|
v v
|
||||||
|
[active disk] [temp.img]
|
||||||
|
|
||||||
|
In this case discard-after-copy does two things:
|
||||||
|
|
||||||
|
- discard data in temp.img to save disk space
|
||||||
|
- avoid further copy-before-write operation in discarded area
|
||||||
|
|
||||||
|
Note that we have to declare WRITE permission on source in
|
||||||
|
copy-before-write filter, for discard to work. Still we can't take it
|
||||||
|
unconditionally, as it will break normal backup from RO source. So, we
|
||||||
|
have to add a parameter and pass it thorough bdrv_open flags.
|
||||||
|
|
||||||
|
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
block/backup.c | 5 +++--
|
||||||
|
block/block-copy.c | 9 +++++++++
|
||||||
|
block/copy-before-write.c | 15 +++++++++++++--
|
||||||
|
block/copy-before-write.h | 1 +
|
||||||
|
block/replication.c | 4 ++--
|
||||||
|
blockdev.c | 2 +-
|
||||||
|
include/block/block-common.h | 2 ++
|
||||||
|
include/block/block-copy.h | 1 +
|
||||||
|
include/block/block_int-global-state.h | 2 +-
|
||||||
|
qapi/block-core.json | 4 ++++
|
||||||
|
10 files changed, 37 insertions(+), 8 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/backup.c b/block/backup.c
|
||||||
|
index ec29d6b810..3dd2e229d2 100644
|
||||||
|
--- a/block/backup.c
|
||||||
|
+++ b/block/backup.c
|
||||||
|
@@ -356,7 +356,7 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
|
||||||
|
BlockDriverState *target, int64_t speed,
|
||||||
|
MirrorSyncMode sync_mode, BdrvDirtyBitmap *sync_bitmap,
|
||||||
|
BitmapSyncMode bitmap_mode,
|
||||||
|
- bool compress,
|
||||||
|
+ bool compress, bool discard_source,
|
||||||
|
const char *filter_node_name,
|
||||||
|
BackupPerf *perf,
|
||||||
|
BlockdevOnError on_source_error,
|
||||||
|
@@ -457,7 +457,8 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
|
||||||
|
goto error;
|
||||||
|
}
|
||||||
|
|
||||||
|
- cbw = bdrv_cbw_append(bs, target, filter_node_name, &bcs, errp);
|
||||||
|
+ cbw = bdrv_cbw_append(bs, target, filter_node_name, discard_source,
|
||||||
|
+ &bcs, errp);
|
||||||
|
if (!cbw) {
|
||||||
|
goto error;
|
||||||
|
}
|
||||||
|
diff --git a/block/block-copy.c b/block/block-copy.c
|
||||||
|
index 8fca2c3698..7e3b378528 100644
|
||||||
|
--- a/block/block-copy.c
|
||||||
|
+++ b/block/block-copy.c
|
||||||
|
@@ -137,6 +137,7 @@ typedef struct BlockCopyState {
|
||||||
|
CoMutex lock;
|
||||||
|
int64_t in_flight_bytes;
|
||||||
|
BlockCopyMethod method;
|
||||||
|
+ bool discard_source;
|
||||||
|
BlockReqList reqs;
|
||||||
|
QLIST_HEAD(, BlockCopyCallState) calls;
|
||||||
|
/*
|
||||||
|
@@ -353,6 +354,7 @@ static int64_t block_copy_calculate_cluster_size(BlockDriverState *target,
|
||||||
|
BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||||||
|
BlockDriverState *copy_bitmap_bs,
|
||||||
|
const BdrvDirtyBitmap *bitmap,
|
||||||
|
+ bool discard_source,
|
||||||
|
Error **errp)
|
||||||
|
{
|
||||||
|
ERRP_GUARD();
|
||||||
|
@@ -418,6 +420,7 @@ BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||||||
|
cluster_size),
|
||||||
|
};
|
||||||
|
|
||||||
|
+ s->discard_source = discard_source;
|
||||||
|
block_copy_set_copy_opts(s, false, false);
|
||||||
|
|
||||||
|
ratelimit_init(&s->rate_limit);
|
||||||
|
@@ -589,6 +592,12 @@ static coroutine_fn int block_copy_task_entry(AioTask *task)
|
||||||
|
co_put_to_shres(s->mem, t->req.bytes);
|
||||||
|
block_copy_task_end(t, ret);
|
||||||
|
|
||||||
|
+ if (s->discard_source && ret == 0) {
|
||||||
|
+ int64_t nbytes =
|
||||||
|
+ MIN(t->req.offset + t->req.bytes, s->len) - t->req.offset;
|
||||||
|
+ bdrv_co_pdiscard(s->source, t->req.offset, nbytes);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
return ret;
|
||||||
|
}
|
||||||
|
|
||||||
|
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
|
||||||
|
index 94db31512d..853e01a1eb 100644
|
||||||
|
--- a/block/copy-before-write.c
|
||||||
|
+++ b/block/copy-before-write.c
|
||||||
|
@@ -44,6 +44,7 @@ typedef struct BDRVCopyBeforeWriteState {
|
||||||
|
BdrvChild *target;
|
||||||
|
OnCbwError on_cbw_error;
|
||||||
|
uint64_t cbw_timeout_ns;
|
||||||
|
+ bool discard_source;
|
||||||
|
|
||||||
|
/*
|
||||||
|
* @lock: protects access to @access_bitmap, @done_bitmap and
|
||||||
|
@@ -357,6 +358,8 @@ cbw_child_perm(BlockDriverState *bs, BdrvChild *c, BdrvChildRole role,
|
||||||
|
uint64_t perm, uint64_t shared,
|
||||||
|
uint64_t *nperm, uint64_t *nshared)
|
||||||
|
{
|
||||||
|
+ BDRVCopyBeforeWriteState *s = bs->opaque;
|
||||||
|
+
|
||||||
|
if (!(role & BDRV_CHILD_FILTERED)) {
|
||||||
|
/*
|
||||||
|
* Target child
|
||||||
|
@@ -381,6 +384,10 @@ cbw_child_perm(BlockDriverState *bs, BdrvChild *c, BdrvChildRole role,
|
||||||
|
* start
|
||||||
|
*/
|
||||||
|
*nperm = *nperm | BLK_PERM_CONSISTENT_READ;
|
||||||
|
+ if (s->discard_source) {
|
||||||
|
+ *nperm = *nperm | BLK_PERM_WRITE;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
*nshared &= ~(BLK_PERM_WRITE | BLK_PERM_RESIZE);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
@@ -468,7 +475,9 @@ static int cbw_open(BlockDriverState *bs, QDict *options, int flags,
|
||||||
|
((BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP | BDRV_REQ_NO_FALLBACK) &
|
||||||
|
bs->file->bs->supported_zero_flags);
|
||||||
|
|
||||||
|
- s->bcs = block_copy_state_new(bs->file, s->target, bs, bitmap, errp);
|
||||||
|
+ s->discard_source = flags & BDRV_O_CBW_DISCARD_SOURCE;
|
||||||
|
+ s->bcs = block_copy_state_new(bs->file, s->target, bs, bitmap,
|
||||||
|
+ flags & BDRV_O_CBW_DISCARD_SOURCE, errp);
|
||||||
|
if (!s->bcs) {
|
||||||
|
error_prepend(errp, "Cannot create block-copy-state: ");
|
||||||
|
return -EINVAL;
|
||||||
|
@@ -535,12 +544,14 @@ static BlockDriver bdrv_cbw_filter = {
|
||||||
|
BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
|
||||||
|
BlockDriverState *target,
|
||||||
|
const char *filter_node_name,
|
||||||
|
+ bool discard_source,
|
||||||
|
BlockCopyState **bcs,
|
||||||
|
Error **errp)
|
||||||
|
{
|
||||||
|
BDRVCopyBeforeWriteState *state;
|
||||||
|
BlockDriverState *top;
|
||||||
|
QDict *opts;
|
||||||
|
+ int flags = BDRV_O_RDWR | (discard_source ? BDRV_O_CBW_DISCARD_SOURCE : 0);
|
||||||
|
|
||||||
|
assert(source->total_sectors == target->total_sectors);
|
||||||
|
GLOBAL_STATE_CODE();
|
||||||
|
@@ -553,7 +564,7 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
|
||||||
|
qdict_put_str(opts, "file", bdrv_get_node_name(source));
|
||||||
|
qdict_put_str(opts, "target", bdrv_get_node_name(target));
|
||||||
|
|
||||||
|
- top = bdrv_insert_node(source, opts, BDRV_O_RDWR, errp);
|
||||||
|
+ top = bdrv_insert_node(source, opts, flags, errp);
|
||||||
|
if (!top) {
|
||||||
|
return NULL;
|
||||||
|
}
|
||||||
|
diff --git a/block/copy-before-write.h b/block/copy-before-write.h
|
||||||
|
index 6e72bb25e9..01af0cd3c4 100644
|
||||||
|
--- a/block/copy-before-write.h
|
||||||
|
+++ b/block/copy-before-write.h
|
||||||
|
@@ -39,6 +39,7 @@
|
||||||
|
BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
|
||||||
|
BlockDriverState *target,
|
||||||
|
const char *filter_node_name,
|
||||||
|
+ bool discard_source,
|
||||||
|
BlockCopyState **bcs,
|
||||||
|
Error **errp);
|
||||||
|
void bdrv_cbw_drop(BlockDriverState *bs);
|
||||||
|
diff --git a/block/replication.c b/block/replication.c
|
||||||
|
index ca6bd0a720..0415a5e8b7 100644
|
||||||
|
--- a/block/replication.c
|
||||||
|
+++ b/block/replication.c
|
||||||
|
@@ -582,8 +582,8 @@ static void replication_start(ReplicationState *rs, ReplicationMode mode,
|
||||||
|
|
||||||
|
s->backup_job = backup_job_create(
|
||||||
|
NULL, s->secondary_disk->bs, s->hidden_disk->bs,
|
||||||
|
- 0, MIRROR_SYNC_MODE_NONE, NULL, 0, false, NULL,
|
||||||
|
- &perf,
|
||||||
|
+ 0, MIRROR_SYNC_MODE_NONE, NULL, 0, false, false,
|
||||||
|
+ NULL, &perf,
|
||||||
|
BLOCKDEV_ON_ERROR_REPORT,
|
||||||
|
BLOCKDEV_ON_ERROR_REPORT, JOB_INTERNAL,
|
||||||
|
backup_job_completed, bs, NULL, &local_err);
|
||||||
|
diff --git a/blockdev.c b/blockdev.c
|
||||||
|
index 057601dcf0..4c33c3f5f0 100644
|
||||||
|
--- a/blockdev.c
|
||||||
|
+++ b/blockdev.c
|
||||||
|
@@ -2726,7 +2726,7 @@ static BlockJob *do_backup_common(BackupCommon *backup,
|
||||||
|
|
||||||
|
job = backup_job_create(backup->job_id, bs, target_bs, backup->speed,
|
||||||
|
backup->sync, bmap, backup->bitmap_mode,
|
||||||
|
- backup->compress,
|
||||||
|
+ backup->compress, backup->discard_source,
|
||||||
|
backup->filter_node_name,
|
||||||
|
&perf,
|
||||||
|
backup->on_source_error,
|
||||||
|
diff --git a/include/block/block-common.h b/include/block/block-common.h
|
||||||
|
index a846023a09..338fe5ff7a 100644
|
||||||
|
--- a/include/block/block-common.h
|
||||||
|
+++ b/include/block/block-common.h
|
||||||
|
@@ -243,6 +243,8 @@ typedef enum {
|
||||||
|
read-write fails */
|
||||||
|
#define BDRV_O_IO_URING 0x40000 /* use io_uring instead of the thread pool */
|
||||||
|
|
||||||
|
+#define BDRV_O_CBW_DISCARD_SOURCE 0x80000 /* for copy-before-write filter */
|
||||||
|
+
|
||||||
|
#define BDRV_O_CACHE_MASK (BDRV_O_NOCACHE | BDRV_O_NO_FLUSH)
|
||||||
|
|
||||||
|
|
||||||
|
diff --git a/include/block/block-copy.h b/include/block/block-copy.h
|
||||||
|
index 8b41643bfa..bdc703bacd 100644
|
||||||
|
--- a/include/block/block-copy.h
|
||||||
|
+++ b/include/block/block-copy.h
|
||||||
|
@@ -27,6 +27,7 @@ typedef struct BlockCopyCallState BlockCopyCallState;
|
||||||
|
BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||||||
|
BlockDriverState *copy_bitmap_bs,
|
||||||
|
const BdrvDirtyBitmap *bitmap,
|
||||||
|
+ bool discard_source,
|
||||||
|
Error **errp);
|
||||||
|
|
||||||
|
/* Function should be called prior any actual copy request */
|
||||||
|
diff --git a/include/block/block_int-global-state.h b/include/block/block_int-global-state.h
|
||||||
|
index d2201e27f4..eb2d92a226 100644
|
||||||
|
--- a/include/block/block_int-global-state.h
|
||||||
|
+++ b/include/block/block_int-global-state.h
|
||||||
|
@@ -193,7 +193,7 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
|
||||||
|
MirrorSyncMode sync_mode,
|
||||||
|
BdrvDirtyBitmap *sync_bitmap,
|
||||||
|
BitmapSyncMode bitmap_mode,
|
||||||
|
- bool compress,
|
||||||
|
+ bool compress, bool discard_source,
|
||||||
|
const char *filter_node_name,
|
||||||
|
BackupPerf *perf,
|
||||||
|
BlockdevOnError on_source_error,
|
||||||
|
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
||||||
|
index 4b18e01b85..b179d65520 100644
|
||||||
|
--- a/qapi/block-core.json
|
||||||
|
+++ b/qapi/block-core.json
|
||||||
|
@@ -1610,6 +1610,9 @@
|
||||||
|
# node specified by @drive. If this option is not given, a node
|
||||||
|
# name is autogenerated. (Since: 4.2)
|
||||||
|
#
|
||||||
|
+# @discard-source: Discard blocks on source which are already copied
|
||||||
|
+# to the target. (Since 9.0)
|
||||||
|
+#
|
||||||
|
# @x-perf: Performance options. (Since 6.0)
|
||||||
|
#
|
||||||
|
# Features:
|
||||||
|
@@ -1631,6 +1634,7 @@
|
||||||
|
'*on-target-error': 'BlockdevOnError',
|
||||||
|
'*auto-finalize': 'bool', '*auto-dismiss': 'bool',
|
||||||
|
'*filter-node-name': 'str',
|
||||||
|
+ '*discard-source': 'bool',
|
||||||
|
'*x-perf': { 'type': 'BackupPerf',
|
||||||
|
'features': [ 'unstable' ] } } }
|
||||||
|
|
92
debian/patches/extra/0010-hw-virtio-Fix-the-de-initialization-of-vhost-user-de.patch
vendored
Normal file
92
debian/patches/extra/0010-hw-virtio-Fix-the-de-initialization-of-vhost-user-de.patch
vendored
Normal file
@@ -0,0 +1,92 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Thomas Huth <thuth@redhat.com>
|
||||||
|
Date: Tue, 18 Jun 2024 14:19:58 +0200
|
||||||
|
Subject: [PATCH] hw/virtio: Fix the de-initialization of vhost-user devices
|
||||||
|
|
||||||
|
The unrealize functions of the various vhost-user devices are
|
||||||
|
calling the corresponding vhost_*_set_status() functions with a
|
||||||
|
status of 0 to shut down the device correctly.
|
||||||
|
|
||||||
|
Now these vhost_*_set_status() functions all follow this scheme:
|
||||||
|
|
||||||
|
bool should_start = virtio_device_should_start(vdev, status);
|
||||||
|
|
||||||
|
if (vhost_dev_is_started(&vvc->vhost_dev) == should_start) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (should_start) {
|
||||||
|
/* ... do the initialization stuff ... */
|
||||||
|
} else {
|
||||||
|
/* ... do the cleanup stuff ... */
|
||||||
|
}
|
||||||
|
|
||||||
|
The problem here is virtio_device_should_start(vdev, 0) currently
|
||||||
|
always returns "true" since it internally only looks at vdev->started
|
||||||
|
instead of looking at the "status" parameter. Thus once the device
|
||||||
|
got started once, virtio_device_should_start() always returns true
|
||||||
|
and thus the vhost_*_set_status() functions return early, without
|
||||||
|
ever doing any clean-up when being called with status == 0. This
|
||||||
|
causes e.g. problems when trying to hot-plug and hot-unplug a vhost
|
||||||
|
user devices multiple times since the de-initialization step is
|
||||||
|
completely skipped during the unplug operation.
|
||||||
|
|
||||||
|
This bug has been introduced in commit 9f6bcfd99f ("hw/virtio: move
|
||||||
|
vm_running check to virtio_device_started") which replaced
|
||||||
|
|
||||||
|
should_start = status & VIRTIO_CONFIG_S_DRIVER_OK;
|
||||||
|
|
||||||
|
with
|
||||||
|
|
||||||
|
should_start = virtio_device_started(vdev, status);
|
||||||
|
|
||||||
|
which later got replaced by virtio_device_should_start(). This blocked
|
||||||
|
the possibility to set should_start to false in case the status flag
|
||||||
|
VIRTIO_CONFIG_S_DRIVER_OK was not set.
|
||||||
|
|
||||||
|
Fix it by adjusting the virtio_device_should_start() function to
|
||||||
|
only consider the status flag instead of vdev->started. Since this
|
||||||
|
function is only used in the various vhost_*_set_status() functions
|
||||||
|
for exactly the same purpose, it should be fine to fix it in this
|
||||||
|
central place there without any risk to change the behavior of other
|
||||||
|
code.
|
||||||
|
|
||||||
|
Fixes: 9f6bcfd99f ("hw/virtio: move vm_running check to virtio_device_started")
|
||||||
|
Buglink: https://issues.redhat.com/browse/RHEL-40708
|
||||||
|
Signed-off-by: Thomas Huth <thuth@redhat.com>
|
||||||
|
Message-Id: <20240618121958.88673-1-thuth@redhat.com>
|
||||||
|
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
|
||||||
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
||||||
|
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
||||||
|
(cherry picked from commit d72479b11797c28893e1e3fc565497a9cae5ca16)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
include/hw/virtio/virtio.h | 8 ++++----
|
||||||
|
1 file changed, 4 insertions(+), 4 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
|
||||||
|
index 7d5ffdc145..2eafad17b8 100644
|
||||||
|
--- a/include/hw/virtio/virtio.h
|
||||||
|
+++ b/include/hw/virtio/virtio.h
|
||||||
|
@@ -470,9 +470,9 @@ static inline bool virtio_device_started(VirtIODevice *vdev, uint8_t status)
|
||||||
|
* @vdev - the VirtIO device
|
||||||
|
* @status - the devices status bits
|
||||||
|
*
|
||||||
|
- * This is similar to virtio_device_started() but also encapsulates a
|
||||||
|
- * check on the VM status which would prevent a device starting
|
||||||
|
- * anyway.
|
||||||
|
+ * This is similar to virtio_device_started() but ignores vdev->started
|
||||||
|
+ * and also encapsulates a check on the VM status which would prevent a
|
||||||
|
+ * device from starting anyway.
|
||||||
|
*/
|
||||||
|
static inline bool virtio_device_should_start(VirtIODevice *vdev, uint8_t status)
|
||||||
|
{
|
||||||
|
@@ -480,7 +480,7 @@ static inline bool virtio_device_should_start(VirtIODevice *vdev, uint8_t status
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
- return virtio_device_started(vdev, status);
|
||||||
|
+ return status & VIRTIO_CONFIG_S_DRIVER_OK;
|
||||||
|
}
|
||||||
|
|
||||||
|
static inline void virtio_set_started(VirtIODevice *vdev, bool started)
|
@@ -1,63 +0,0 @@
|
|||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Sebastian Ott <sebott@redhat.com>
|
|
||||||
Date: Tue, 3 Dec 2024 13:19:28 +0100
|
|
||||||
Subject: [PATCH] pci: ensure valid link status bits for downstream ports
|
|
||||||
|
|
||||||
PCI hotplug for downstream endpoints on arm fails because Linux'
|
|
||||||
PCIe hotplug driver doesn't like the QEMU provided LNKSTA:
|
|
||||||
|
|
||||||
pcieport 0000:08:01.0: pciehp: Slot(2): Card present
|
|
||||||
pcieport 0000:08:01.0: pciehp: Slot(2): Link Up
|
|
||||||
pcieport 0000:08:01.0: pciehp: Slot(2): Cannot train link: status 0x2000
|
|
||||||
|
|
||||||
There's 2 cases where LNKSTA isn't setup properly:
|
|
||||||
* the downstream device has no express capability
|
|
||||||
* max link width of the bridge is 0
|
|
||||||
|
|
||||||
Move the sanity checks added via 88c869198aa63
|
|
||||||
("pci: Sanity test minimum downstream LNKSTA") outside of the
|
|
||||||
branch to make sure downstream ports always have a valid LNKSTA.
|
|
||||||
|
|
||||||
Signed-off-by: Sebastian Ott <sebott@redhat.com>
|
|
||||||
Tested-by: Zhenyu Zhang <zhenyzha@redhat.com>
|
|
||||||
Message-Id: <20241203121928.14861-1-sebott@redhat.com>
|
|
||||||
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
|
|
||||||
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
|
||||||
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
|
||||||
(cherry picked from commit 694632fd44987cc4618612a38ad151047524a590)
|
|
||||||
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
---
|
|
||||||
hw/pci/pcie.c | 12 ++++++++----
|
|
||||||
1 file changed, 8 insertions(+), 4 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
|
|
||||||
index 0b455c8654..1b12db6fa2 100644
|
|
||||||
--- a/hw/pci/pcie.c
|
|
||||||
+++ b/hw/pci/pcie.c
|
|
||||||
@@ -1113,18 +1113,22 @@ void pcie_sync_bridge_lnk(PCIDevice *bridge_dev)
|
|
||||||
if ((lnksta & PCI_EXP_LNKSTA_NLW) > (lnkcap & PCI_EXP_LNKCAP_MLW)) {
|
|
||||||
lnksta &= ~PCI_EXP_LNKSTA_NLW;
|
|
||||||
lnksta |= lnkcap & PCI_EXP_LNKCAP_MLW;
|
|
||||||
- } else if (!(lnksta & PCI_EXP_LNKSTA_NLW)) {
|
|
||||||
- lnksta |= QEMU_PCI_EXP_LNKSTA_NLW(QEMU_PCI_EXP_LNK_X1);
|
|
||||||
}
|
|
||||||
|
|
||||||
if ((lnksta & PCI_EXP_LNKSTA_CLS) > (lnkcap & PCI_EXP_LNKCAP_SLS)) {
|
|
||||||
lnksta &= ~PCI_EXP_LNKSTA_CLS;
|
|
||||||
lnksta |= lnkcap & PCI_EXP_LNKCAP_SLS;
|
|
||||||
- } else if (!(lnksta & PCI_EXP_LNKSTA_CLS)) {
|
|
||||||
- lnksta |= QEMU_PCI_EXP_LNKSTA_CLS(QEMU_PCI_EXP_LNK_2_5GT);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
+ if (!(lnksta & PCI_EXP_LNKSTA_NLW)) {
|
|
||||||
+ lnksta |= QEMU_PCI_EXP_LNKSTA_NLW(QEMU_PCI_EXP_LNK_X1);
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ if (!(lnksta & PCI_EXP_LNKSTA_CLS)) {
|
|
||||||
+ lnksta |= QEMU_PCI_EXP_LNKSTA_CLS(QEMU_PCI_EXP_LNK_2_5GT);
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
pci_word_test_and_clear_mask(exp_cap + PCI_EXP_LNKSTA,
|
|
||||||
PCI_EXP_LNKSTA_CLS | PCI_EXP_LNKSTA_NLW);
|
|
||||||
pci_word_test_and_set_mask(exp_cap + PCI_EXP_LNKSTA, lnksta &
|
|
@@ -1,36 +0,0 @@
|
|||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Nicholas Piggin <npiggin@gmail.com>
|
|
||||||
Date: Thu, 12 Dec 2024 22:04:02 +1000
|
|
||||||
Subject: [PATCH] pci/msix: Fix msix pba read vector poll end calculation
|
|
||||||
MIME-Version: 1.0
|
|
||||||
Content-Type: text/plain; charset=UTF-8
|
|
||||||
Content-Transfer-Encoding: 8bit
|
|
||||||
|
|
||||||
The end vector calculation has a bug that results in polling fewer
|
|
||||||
than required vectors when reading at a non-zero offset in PBA memory.
|
|
||||||
|
|
||||||
Fixes: bbef882cc193 ("msi: add API to get notified about pending bit poll")
|
|
||||||
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
|
|
||||||
Message-Id: <20241212120402.1475053-1-npiggin@gmail.com>
|
|
||||||
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
|
||||||
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
|
||||||
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
|
||||||
(cherry picked from commit 42e2a7a0ab23784e44fcb18369e06067abc89305)
|
|
||||||
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
---
|
|
||||||
hw/pci/msix.c | 2 +-
|
|
||||||
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
||||||
|
|
||||||
diff --git a/hw/pci/msix.c b/hw/pci/msix.c
|
|
||||||
index 487e49834e..cc6e79ec67 100644
|
|
||||||
--- a/hw/pci/msix.c
|
|
||||||
+++ b/hw/pci/msix.c
|
|
||||||
@@ -250,7 +250,7 @@ static uint64_t msix_pba_mmio_read(void *opaque, hwaddr addr,
|
|
||||||
PCIDevice *dev = opaque;
|
|
||||||
if (dev->msix_vector_poll_notifier) {
|
|
||||||
unsigned vector_start = addr * 8;
|
|
||||||
- unsigned vector_end = MIN(addr + size * 8, dev->msix_entries_nr);
|
|
||||||
+ unsigned vector_end = MIN((addr + size) * 8, dev->msix_entries_nr);
|
|
||||||
dev->msix_vector_poll_notifier(dev, vector_start, vector_end);
|
|
||||||
}
|
|
||||||
|
|
43
debian/patches/extra/0011-target-arm-Use-float_status-copy-in-sme_fmopa_s.patch
vendored
Normal file
43
debian/patches/extra/0011-target-arm-Use-float_status-copy-in-sme_fmopa_s.patch
vendored
Normal file
@@ -0,0 +1,43 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Daniyal Khan <danikhan632@gmail.com>
|
||||||
|
Date: Wed, 17 Jul 2024 16:01:47 +1000
|
||||||
|
Subject: [PATCH] target/arm: Use float_status copy in sme_fmopa_s
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
We made a copy above because the fp exception flags
|
||||||
|
are not propagated back to the FPST register, but
|
||||||
|
then failed to use the copy.
|
||||||
|
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Fixes: 558e956c719 ("target/arm: Implement FMOPA, FMOPS (non-widening)")
|
||||||
|
Signed-off-by: Daniyal Khan <danikhan632@gmail.com>
|
||||||
|
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
|
||||||
|
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
||||||
|
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
|
||||||
|
Message-id: 20240717060149.204788-2-richard.henderson@linaro.org
|
||||||
|
[rth: Split from a larger patch]
|
||||||
|
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
|
||||||
|
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
||||||
|
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
|
||||||
|
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
|
||||||
|
(cherry picked from commit 31d93fedf41c24b0badb38cd9317590d1ef74e37)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
target/arm/tcg/sme_helper.c | 2 +-
|
||||||
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/target/arm/tcg/sme_helper.c b/target/arm/tcg/sme_helper.c
|
||||||
|
index e2e0575039..5a6dd76489 100644
|
||||||
|
--- a/target/arm/tcg/sme_helper.c
|
||||||
|
+++ b/target/arm/tcg/sme_helper.c
|
||||||
|
@@ -916,7 +916,7 @@ void HELPER(sme_fmopa_s)(void *vza, void *vzn, void *vzm, void *vpn,
|
||||||
|
if (pb & 1) {
|
||||||
|
uint32_t *a = vza_row + H1_4(col);
|
||||||
|
uint32_t *m = vzm + H1_4(col);
|
||||||
|
- *a = float32_muladd(n, *m, *a, 0, vst);
|
||||||
|
+ *a = float32_muladd(n, *m, *a, 0, &fpst);
|
||||||
|
}
|
||||||
|
col += 4;
|
||||||
|
pb >>= 4;
|
62
debian/patches/extra/0012-target-arm-Use-FPST_F16-for-SME-FMOPA-widening.patch
vendored
Normal file
62
debian/patches/extra/0012-target-arm-Use-FPST_F16-for-SME-FMOPA-widening.patch
vendored
Normal file
@@ -0,0 +1,62 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Richard Henderson <richard.henderson@linaro.org>
|
||||||
|
Date: Wed, 17 Jul 2024 16:01:48 +1000
|
||||||
|
Subject: [PATCH] target/arm: Use FPST_F16 for SME FMOPA (widening)
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
This operation has float16 inputs and thus must use
|
||||||
|
the FZ16 control not the FZ control.
|
||||||
|
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Fixes: 3916841ac75 ("target/arm: Implement FMOPA, FMOPS (widening)")
|
||||||
|
Reported-by: Daniyal Khan <danikhan632@gmail.com>
|
||||||
|
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
|
||||||
|
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
|
||||||
|
Message-id: 20240717060149.204788-3-richard.henderson@linaro.org
|
||||||
|
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2374
|
||||||
|
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
|
||||||
|
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
|
||||||
|
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
|
||||||
|
(cherry picked from commit 207d30b5fdb5b45a36f26eefcf52fe2c1714dd4f)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
target/arm/tcg/translate-sme.c | 12 ++++++++----
|
||||||
|
1 file changed, 8 insertions(+), 4 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c
|
||||||
|
index 46c7fce8b4..185a8a917b 100644
|
||||||
|
--- a/target/arm/tcg/translate-sme.c
|
||||||
|
+++ b/target/arm/tcg/translate-sme.c
|
||||||
|
@@ -304,6 +304,7 @@ static bool do_outprod(DisasContext *s, arg_op *a, MemOp esz,
|
||||||
|
}
|
||||||
|
|
||||||
|
static bool do_outprod_fpst(DisasContext *s, arg_op *a, MemOp esz,
|
||||||
|
+ ARMFPStatusFlavour e_fpst,
|
||||||
|
gen_helper_gvec_5_ptr *fn)
|
||||||
|
{
|
||||||
|
int svl = streaming_vec_reg_size(s);
|
||||||
|
@@ -319,15 +320,18 @@ static bool do_outprod_fpst(DisasContext *s, arg_op *a, MemOp esz,
|
||||||
|
zm = vec_full_reg_ptr(s, a->zm);
|
||||||
|
pn = pred_full_reg_ptr(s, a->pn);
|
||||||
|
pm = pred_full_reg_ptr(s, a->pm);
|
||||||
|
- fpst = fpstatus_ptr(FPST_FPCR);
|
||||||
|
+ fpst = fpstatus_ptr(e_fpst);
|
||||||
|
|
||||||
|
fn(za, zn, zm, pn, pm, fpst, tcg_constant_i32(desc));
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
-TRANS_FEAT(FMOPA_h, aa64_sme, do_outprod_fpst, a, MO_32, gen_helper_sme_fmopa_h)
|
||||||
|
-TRANS_FEAT(FMOPA_s, aa64_sme, do_outprod_fpst, a, MO_32, gen_helper_sme_fmopa_s)
|
||||||
|
-TRANS_FEAT(FMOPA_d, aa64_sme_f64f64, do_outprod_fpst, a, MO_64, gen_helper_sme_fmopa_d)
|
||||||
|
+TRANS_FEAT(FMOPA_h, aa64_sme, do_outprod_fpst, a,
|
||||||
|
+ MO_32, FPST_FPCR_F16, gen_helper_sme_fmopa_h)
|
||||||
|
+TRANS_FEAT(FMOPA_s, aa64_sme, do_outprod_fpst, a,
|
||||||
|
+ MO_32, FPST_FPCR, gen_helper_sme_fmopa_s)
|
||||||
|
+TRANS_FEAT(FMOPA_d, aa64_sme_f64f64, do_outprod_fpst, a,
|
||||||
|
+ MO_64, FPST_FPCR, gen_helper_sme_fmopa_d)
|
||||||
|
|
||||||
|
/* TODO: FEAT_EBF16 */
|
||||||
|
TRANS_FEAT(BFMOPA, aa64_sme, do_outprod, a, MO_32, gen_helper_sme_bfmopa)
|
60
debian/patches/extra/0013-scsi-fix-regression-and-honor-bootindex-again-for-le.patch
vendored
Normal file
60
debian/patches/extra/0013-scsi-fix-regression-and-honor-bootindex-again-for-le.patch
vendored
Normal file
@@ -0,0 +1,60 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Wed, 10 Jul 2024 17:25:29 +0200
|
||||||
|
Subject: [PATCH] scsi: fix regression and honor bootindex again for legacy
|
||||||
|
drives
|
||||||
|
|
||||||
|
Commit 3089637461 ("scsi: Don't ignore most usb-storage properties")
|
||||||
|
removed the call to object_property_set_int() and thus the 'set'
|
||||||
|
method for the bootindex property was also not called anymore. Here
|
||||||
|
that method is device_set_bootindex() (as configured by
|
||||||
|
scsi_dev_instance_init() -> device_add_bootindex_property()) which as
|
||||||
|
a side effect registers the device via add_boot_device_path().
|
||||||
|
|
||||||
|
As reported by a downstream user [0], the bootindex property did not
|
||||||
|
have the desired effect anymore for legacy drives. Fix the regression
|
||||||
|
by explicitly calling the add_boot_device_path() function after
|
||||||
|
checking that the bootindex is not yet used (to avoid
|
||||||
|
add_boot_device_path() calling exit()).
|
||||||
|
|
||||||
|
[0]: https://forum.proxmox.com/threads/149772/post-679433
|
||||||
|
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Fixes: 3089637461 ("scsi: Don't ignore most usb-storage properties")
|
||||||
|
Suggested-by: Kevin Wolf <kwolf@redhat.com>
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Link: https://lore.kernel.org/r/20240710152529.1737407-1-f.ebner@proxmox.com
|
||||||
|
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
||||||
|
(cherry picked from commit 57a8a80d1a5b28797b21d30bfc60601945820e51)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
hw/scsi/scsi-bus.c | 9 +++++++++
|
||||||
|
1 file changed, 9 insertions(+)
|
||||||
|
|
||||||
|
diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
|
||||||
|
index 9e40b0c920..53eff5dd3d 100644
|
||||||
|
--- a/hw/scsi/scsi-bus.c
|
||||||
|
+++ b/hw/scsi/scsi-bus.c
|
||||||
|
@@ -384,6 +384,7 @@ SCSIDevice *scsi_bus_legacy_add_drive(SCSIBus *bus, BlockBackend *blk,
|
||||||
|
DeviceState *dev;
|
||||||
|
SCSIDevice *s;
|
||||||
|
DriveInfo *dinfo;
|
||||||
|
+ Error *local_err = NULL;
|
||||||
|
|
||||||
|
if (blk_is_sg(blk)) {
|
||||||
|
driver = "scsi-generic";
|
||||||
|
@@ -403,6 +404,14 @@ SCSIDevice *scsi_bus_legacy_add_drive(SCSIBus *bus, BlockBackend *blk,
|
||||||
|
s = SCSI_DEVICE(dev);
|
||||||
|
s->conf = *conf;
|
||||||
|
|
||||||
|
+ check_boot_index(conf->bootindex, &local_err);
|
||||||
|
+ if (local_err) {
|
||||||
|
+ object_unparent(OBJECT(dev));
|
||||||
|
+ error_propagate(errp, local_err);
|
||||||
|
+ return NULL;
|
||||||
|
+ }
|
||||||
|
+ add_boot_device_path(conf->bootindex, dev, NULL);
|
||||||
|
+
|
||||||
|
qdev_prop_set_uint32(dev, "scsi-id", unit);
|
||||||
|
if (object_property_find(OBJECT(dev), "removable")) {
|
||||||
|
qdev_prop_set_bit(dev, "removable", removable);
|
35
debian/patches/extra/0014-block-copy-before-write-use-uint64_t-for-timeout-in-.patch
vendored
Normal file
35
debian/patches/extra/0014-block-copy-before-write-use-uint64_t-for-timeout-in-.patch
vendored
Normal file
@@ -0,0 +1,35 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Mon, 29 Apr 2024 15:41:11 +0200
|
||||||
|
Subject: [PATCH] block/copy-before-write: use uint64_t for timeout in
|
||||||
|
nanoseconds
|
||||||
|
|
||||||
|
rather than the uint32_t for which the maximum is slightly more than 4
|
||||||
|
seconds and larger values would overflow. The QAPI interface allows
|
||||||
|
specifying the number of seconds, so only values 0 to 4 are safe right
|
||||||
|
now, other values lead to a much lower timeout than a user expects.
|
||||||
|
|
||||||
|
The block_copy() call where this is used already takes a uint64_t for
|
||||||
|
the timeout, so no change required there.
|
||||||
|
|
||||||
|
Fixes: 6db7fd1ca9 ("block/copy-before-write: implement cbw-timeout option")
|
||||||
|
Reported-by: Friedrich Weber <f.weber@proxmox.com>
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Tested-by: Friedrich Weber <f.weber@proxmox.com>
|
||||||
|
---
|
||||||
|
block/copy-before-write.c | 2 +-
|
||||||
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
|
||||||
|
index b866e42271..3ee95c0e7a 100644
|
||||||
|
--- a/block/copy-before-write.c
|
||||||
|
+++ b/block/copy-before-write.c
|
||||||
|
@@ -43,7 +43,7 @@ typedef struct BDRVCopyBeforeWriteState {
|
||||||
|
BlockCopyState *bcs;
|
||||||
|
BdrvChild *target;
|
||||||
|
OnCbwError on_cbw_error;
|
||||||
|
- uint32_t cbw_timeout_ns;
|
||||||
|
+ uint64_t cbw_timeout_ns;
|
||||||
|
|
||||||
|
/*
|
||||||
|
* @lock: protects access to @access_bitmap, @done_bitmap and
|
48
debian/patches/extra/0014-hw-scsi-lsi53c895a-bump-instruction-limit-in-scripts.patch
vendored
Normal file
48
debian/patches/extra/0014-hw-scsi-lsi53c895a-bump-instruction-limit-in-scripts.patch
vendored
Normal file
@@ -0,0 +1,48 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Mon, 15 Jul 2024 15:14:03 +0200
|
||||||
|
Subject: [PATCH] hw/scsi/lsi53c895a: bump instruction limit in scripts
|
||||||
|
processing to fix regression
|
||||||
|
|
||||||
|
Commit 9876359990 ("hw/scsi/lsi53c895a: add timer to scripts
|
||||||
|
processing") reduced the maximum allowed instruction count by
|
||||||
|
a factor of 100 all the way down to 100.
|
||||||
|
|
||||||
|
This causes the "Check Point R81.20 Gaia" appliance [0] to fail to
|
||||||
|
boot after fully finishing the installation via the appliance's web
|
||||||
|
interface (there is already one reboot before that).
|
||||||
|
|
||||||
|
With a limit of 150, the appliance still fails to boot, while with a
|
||||||
|
limit of 200, it works. Bump to 500 to fix the regression and be on
|
||||||
|
the safe side.
|
||||||
|
|
||||||
|
Originally reported in the Proxmox community forum[1].
|
||||||
|
|
||||||
|
[0]: https://support.checkpoint.com/results/download/124397
|
||||||
|
[1]: https://forum.proxmox.com/threads/149772/post-683459
|
||||||
|
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Fixes: 9876359990 ("hw/scsi/lsi53c895a: add timer to scripts processing")
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Acked-by: Sven Schnelle <svens@stackframe.org>
|
||||||
|
Link: https://lore.kernel.org/r/20240715131403.223239-1-f.ebner@proxmox.com
|
||||||
|
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
||||||
|
(cherry picked from commit a4975023fb13cf229bd59c9ceec1b8cbdc5b9a20)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
hw/scsi/lsi53c895a.c | 2 +-
|
||||||
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
|
||||||
|
index eb9828dd5e..f1935e5328 100644
|
||||||
|
--- a/hw/scsi/lsi53c895a.c
|
||||||
|
+++ b/hw/scsi/lsi53c895a.c
|
||||||
|
@@ -188,7 +188,7 @@ static const char *names[] = {
|
||||||
|
#define LSI_TAG_VALID (1 << 16)
|
||||||
|
|
||||||
|
/* Maximum instructions to process. */
|
||||||
|
-#define LSI_MAX_INSN 100
|
||||||
|
+#define LSI_MAX_INSN 500
|
||||||
|
|
||||||
|
typedef struct lsi_request {
|
||||||
|
SCSIRequest *req;
|
38
debian/patches/extra/0015-block-copy-Fix-missing-graph-lock.patch
vendored
Normal file
38
debian/patches/extra/0015-block-copy-Fix-missing-graph-lock.patch
vendored
Normal file
@@ -0,0 +1,38 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Kevin Wolf <kwolf@redhat.com>
|
||||||
|
Date: Thu, 27 Jun 2024 20:12:44 +0200
|
||||||
|
Subject: [PATCH] block-copy: Fix missing graph lock
|
||||||
|
|
||||||
|
The graph lock needs to be held when calling bdrv_co_pdiscard(). Fix
|
||||||
|
block_copy_task_entry() to take it for the call.
|
||||||
|
|
||||||
|
WITH_GRAPH_RDLOCK_GUARD() was implemented in a weak way because of
|
||||||
|
limitations in clang's Thread Safety Analysis at the time, so that it
|
||||||
|
only asserts that the lock is held (which allows calling functions that
|
||||||
|
require the lock), but we never deal with the unlocking (so even after
|
||||||
|
the scope of the guard, the compiler assumes that the lock is still
|
||||||
|
held). This is why the compiler didn't catch this locking error.
|
||||||
|
|
||||||
|
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
||||||
|
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
|
||||||
|
(picked from https://lore.kernel.org/qemu-devel/20240627181245.281403-2-kwolf@redhat.com/)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
block/block-copy.c | 4 +++-
|
||||||
|
1 file changed, 3 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/block/block-copy.c b/block/block-copy.c
|
||||||
|
index 7e3b378528..cc618e4561 100644
|
||||||
|
--- a/block/block-copy.c
|
||||||
|
+++ b/block/block-copy.c
|
||||||
|
@@ -595,7 +595,9 @@ static coroutine_fn int block_copy_task_entry(AioTask *task)
|
||||||
|
if (s->discard_source && ret == 0) {
|
||||||
|
int64_t nbytes =
|
||||||
|
MIN(t->req.offset + t->req.bytes, s->len) - t->req.offset;
|
||||||
|
- bdrv_co_pdiscard(s->source, t->req.offset, nbytes);
|
||||||
|
+ WITH_GRAPH_RDLOCK_GUARD() {
|
||||||
|
+ bdrv_co_pdiscard(s->source, t->req.offset, nbytes);
|
||||||
|
+ }
|
||||||
|
}
|
||||||
|
|
||||||
|
return ret;
|
93
debian/patches/extra/0016-Revert-qemu-char-do-not-operate-on-sources-from-fina.patch
vendored
Normal file
93
debian/patches/extra/0016-Revert-qemu-char-do-not-operate-on-sources-from-fina.patch
vendored
Normal file
@@ -0,0 +1,93 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Sergey Dyasli <sergey.dyasli@nutanix.com>
|
||||||
|
Date: Fri, 12 Jul 2024 09:26:59 +0000
|
||||||
|
Subject: [PATCH] Revert "qemu-char: do not operate on sources from finalize
|
||||||
|
callbacks"
|
||||||
|
|
||||||
|
This reverts commit 2b316774f60291f57ca9ecb6a9f0712c532cae34.
|
||||||
|
|
||||||
|
After 038b4217884c ("Revert "chardev: use a child source for qio input
|
||||||
|
source"") we've been observing the "iwp->src == NULL" assertion
|
||||||
|
triggering periodically during the initial capabilities querying by
|
||||||
|
libvirtd. One of possible backtraces:
|
||||||
|
|
||||||
|
Thread 1 (Thread 0x7f16cd4f0700 (LWP 43858)):
|
||||||
|
0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
|
||||||
|
1 0x00007f16c6c21e65 in __GI_abort () at abort.c:79
|
||||||
|
2 0x00007f16c6c21d39 in __assert_fail_base at assert.c:92
|
||||||
|
3 0x00007f16c6c46e86 in __GI___assert_fail (assertion=assertion@entry=0x562e9bcdaadd "iwp->src == NULL", file=file@entry=0x562e9bcdaac8 "../chardev/char-io.c", line=line@entry=99, function=function@entry=0x562e9bcdab10 <__PRETTY_FUNCTION__.20549> "io_watch_poll_finalize") at assert.c:101
|
||||||
|
4 0x0000562e9ba20c2c in io_watch_poll_finalize (source=<optimized out>) at ../chardev/char-io.c:99
|
||||||
|
5 io_watch_poll_finalize (source=<optimized out>) at ../chardev/char-io.c:88
|
||||||
|
6 0x00007f16c904aae0 in g_source_unref_internal () from /lib64/libglib-2.0.so.0
|
||||||
|
7 0x00007f16c904baf9 in g_source_destroy_internal () from /lib64/libglib-2.0.so.0
|
||||||
|
8 0x0000562e9ba20db0 in io_remove_watch_poll (source=0x562e9d6720b0) at ../chardev/char-io.c:147
|
||||||
|
9 remove_fd_in_watch (chr=chr@entry=0x562e9d5f3800) at ../chardev/char-io.c:153
|
||||||
|
10 0x0000562e9ba23ffb in update_ioc_handlers (s=0x562e9d5f3800) at ../chardev/char-socket.c:592
|
||||||
|
11 0x0000562e9ba2072f in qemu_chr_fe_set_handlers_full at ../chardev/char-fe.c:279
|
||||||
|
12 0x0000562e9ba207a9 in qemu_chr_fe_set_handlers at ../chardev/char-fe.c:304
|
||||||
|
13 0x0000562e9ba2ca75 in monitor_qmp_setup_handlers_bh (opaque=0x562e9d4c2c60) at ../monitor/qmp.c:509
|
||||||
|
14 0x0000562e9bb6222e in aio_bh_poll (ctx=ctx@entry=0x562e9d4c2f20) at ../util/async.c:216
|
||||||
|
15 0x0000562e9bb4de0a in aio_poll (ctx=0x562e9d4c2f20, blocking=blocking@entry=true) at ../util/aio-posix.c:722
|
||||||
|
16 0x0000562e9b99dfaa in iothread_run (opaque=0x562e9d4c26f0) at ../iothread.c:63
|
||||||
|
17 0x0000562e9bb505a4 in qemu_thread_start (args=0x562e9d4c7ea0) at ../util/qemu-thread-posix.c:543
|
||||||
|
18 0x00007f16c70081ca in start_thread (arg=<optimized out>) at pthread_create.c:479
|
||||||
|
19 0x00007f16c6c398d3 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
|
||||||
|
|
||||||
|
io_remove_watch_poll(), which makes sure that iwp->src is NULL, calls
|
||||||
|
g_source_destroy() which finds that iwp->src is not NULL in the finalize
|
||||||
|
callback. This can only happen if another thread has managed to trigger
|
||||||
|
io_watch_poll_prepare() callback in the meantime.
|
||||||
|
|
||||||
|
Move iwp->src destruction back to the finalize callback to prevent the
|
||||||
|
described race, and also remove the stale comment. The deadlock glib bug
|
||||||
|
was fixed back in 2010 by b35820285668 ("gmain: move finalization of
|
||||||
|
GSource outside of context lock").
|
||||||
|
|
||||||
|
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
|
||||||
|
Signed-off-by: Sergey Dyasli <sergey.dyasli@nutanix.com>
|
||||||
|
Link: https://lore.kernel.org/r/20240712092659.216206-1-sergey.dyasli@nutanix.com
|
||||||
|
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
||||||
|
(cherry picked from commit e0bf95443ee9326d44031373420cf9f3513ee255)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
chardev/char-io.c | 19 +++++--------------
|
||||||
|
1 file changed, 5 insertions(+), 14 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/chardev/char-io.c b/chardev/char-io.c
|
||||||
|
index dab77b112e..3be17b51ca 100644
|
||||||
|
--- a/chardev/char-io.c
|
||||||
|
+++ b/chardev/char-io.c
|
||||||
|
@@ -87,16 +87,12 @@ static gboolean io_watch_poll_dispatch(GSource *source, GSourceFunc callback,
|
||||||
|
|
||||||
|
static void io_watch_poll_finalize(GSource *source)
|
||||||
|
{
|
||||||
|
- /*
|
||||||
|
- * Due to a glib bug, removing the last reference to a source
|
||||||
|
- * inside a finalize callback causes recursive locking (and a
|
||||||
|
- * deadlock). This is not a problem inside other callbacks,
|
||||||
|
- * including dispatch callbacks, so we call io_remove_watch_poll
|
||||||
|
- * to remove this source. At this point, iwp->src must
|
||||||
|
- * be NULL, or we would leak it.
|
||||||
|
- */
|
||||||
|
IOWatchPoll *iwp = io_watch_poll_from_source(source);
|
||||||
|
- assert(iwp->src == NULL);
|
||||||
|
+ if (iwp->src) {
|
||||||
|
+ g_source_destroy(iwp->src);
|
||||||
|
+ g_source_unref(iwp->src);
|
||||||
|
+ iwp->src = NULL;
|
||||||
|
+ }
|
||||||
|
}
|
||||||
|
|
||||||
|
static GSourceFuncs io_watch_poll_funcs = {
|
||||||
|
@@ -139,11 +135,6 @@ static void io_remove_watch_poll(GSource *source)
|
||||||
|
IOWatchPoll *iwp;
|
||||||
|
|
||||||
|
iwp = io_watch_poll_from_source(source);
|
||||||
|
- if (iwp->src) {
|
||||||
|
- g_source_destroy(iwp->src);
|
||||||
|
- g_source_unref(iwp->src);
|
||||||
|
- iwp->src = NULL;
|
||||||
|
- }
|
||||||
|
g_source_destroy(&iwp->parent);
|
||||||
|
}
|
||||||
|
|
77
debian/patches/extra/0017-virtio-pci-Fix-the-use-of-an-uninitialized-irqfd.patch
vendored
Normal file
77
debian/patches/extra/0017-virtio-pci-Fix-the-use-of-an-uninitialized-irqfd.patch
vendored
Normal file
@@ -0,0 +1,77 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Cindy Lu <lulu@redhat.com>
|
||||||
|
Date: Tue, 6 Aug 2024 17:37:12 +0800
|
||||||
|
Subject: [PATCH] virtio-pci: Fix the use of an uninitialized irqfd
|
||||||
|
|
||||||
|
The crash was reported in MAC OS and NixOS, here is the link for this bug
|
||||||
|
https://gitlab.com/qemu-project/qemu/-/issues/2334
|
||||||
|
https://gitlab.com/qemu-project/qemu/-/issues/2321
|
||||||
|
|
||||||
|
In this bug, they are using the virtio_input device. The guest notifier was
|
||||||
|
not supported for this device, The function virtio_pci_set_guest_notifiers()
|
||||||
|
was not called, and the vector_irqfd was not initialized.
|
||||||
|
|
||||||
|
So the fix is adding the check for vector_irqfd in virtio_pci_get_notifier()
|
||||||
|
|
||||||
|
The function virtio_pci_get_notifier() can be used in various devices.
|
||||||
|
It could also be called when VIRTIO_CONFIG_S_DRIVER_OK is not set. In this situation,
|
||||||
|
the vector_irqfd being NULL is acceptable. We can allow the device continue to boot
|
||||||
|
|
||||||
|
If the vector_irqfd still hasn't been initialized after VIRTIO_CONFIG_S_DRIVER_OK
|
||||||
|
is set, it means that the function set_guest_notifiers was not called before the
|
||||||
|
driver started. This indicates that the device is not using the notifier.
|
||||||
|
At this point, we will let the check fail.
|
||||||
|
|
||||||
|
This fix is verified in vyatta,MacOS,NixOS,fedora system.
|
||||||
|
|
||||||
|
The bt tree for this bug is:
|
||||||
|
Thread 6 "CPU 0/KVM" received signal SIGSEGV, Segmentation fault.
|
||||||
|
[Switching to Thread 0x7c817be006c0 (LWP 1269146)]
|
||||||
|
kvm_virtio_pci_vq_vector_use () at ../qemu-9.0.0/hw/virtio/virtio-pci.c:817
|
||||||
|
817 if (irqfd->users == 0) {
|
||||||
|
(gdb) thread apply all bt
|
||||||
|
...
|
||||||
|
Thread 6 (Thread 0x7c817be006c0 (LWP 1269146) "CPU 0/KVM"):
|
||||||
|
0 kvm_virtio_pci_vq_vector_use () at ../qemu-9.0.0/hw/virtio/virtio-pci.c:817
|
||||||
|
1 kvm_virtio_pci_vector_use_one () at ../qemu-9.0.0/hw/virtio/virtio-pci.c:893
|
||||||
|
2 0x00005983657045e2 in memory_region_write_accessor () at ../qemu-9.0.0/system/memory.c:497
|
||||||
|
3 0x0000598365704ba6 in access_with_adjusted_size () at ../qemu-9.0.0/system/memory.c:573
|
||||||
|
4 0x0000598365705059 in memory_region_dispatch_write () at ../qemu-9.0.0/system/memory.c:1528
|
||||||
|
5 0x00005983659b8e1f in flatview_write_continue_step.isra.0 () at ../qemu-9.0.0/system/physmem.c:2713
|
||||||
|
6 0x000059836570ba7d in flatview_write_continue () at ../qemu-9.0.0/system/physmem.c:2743
|
||||||
|
7 flatview_write () at ../qemu-9.0.0/system/physmem.c:2774
|
||||||
|
8 0x000059836570bb76 in address_space_write () at ../qemu-9.0.0/system/physmem.c:2894
|
||||||
|
9 0x0000598365763afe in address_space_rw () at ../qemu-9.0.0/system/physmem.c:2904
|
||||||
|
10 kvm_cpu_exec () at ../qemu-9.0.0/accel/kvm/kvm-all.c:2917
|
||||||
|
11 0x000059836576656e in kvm_vcpu_thread_fn () at ../qemu-9.0.0/accel/kvm/kvm-accel-ops.c:50
|
||||||
|
12 0x0000598365926ca8 in qemu_thread_start () at ../qemu-9.0.0/util/qemu-thread-posix.c:541
|
||||||
|
13 0x00007c8185bcd1cf in ??? () at /usr/lib/libc.so.6
|
||||||
|
14 0x00007c8185c4e504 in clone () at /usr/lib/libc.so.6
|
||||||
|
|
||||||
|
Fixes: 2ce6cff94d ("virtio-pci: fix use of a released vector")
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Signed-off-by: Cindy Lu <lulu@redhat.com>
|
||||||
|
Message-Id: <20240806093715.65105-1-lulu@redhat.com>
|
||||||
|
Acked-by: Jason Wang <jasowang@redhat.com>
|
||||||
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
||||||
|
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
||||||
|
(cherry picked from commit a8e63ff289d137197ad7a701a587cc432872d798)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
hw/virtio/virtio-pci.c | 3 +++
|
||||||
|
1 file changed, 3 insertions(+)
|
||||||
|
|
||||||
|
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
|
||||||
|
index e04218a9fb..389bab003f 100644
|
||||||
|
--- a/hw/virtio/virtio-pci.c
|
||||||
|
+++ b/hw/virtio/virtio-pci.c
|
||||||
|
@@ -860,6 +860,9 @@ static int virtio_pci_get_notifier(VirtIOPCIProxy *proxy, int queue_no,
|
||||||
|
VirtIODevice *vdev = virtio_bus_get_device(&proxy->bus);
|
||||||
|
VirtQueue *vq;
|
||||||
|
|
||||||
|
+ if (!proxy->vector_irqfd && vdev->status & VIRTIO_CONFIG_S_DRIVER_OK)
|
||||||
|
+ return -1;
|
||||||
|
+
|
||||||
|
if (queue_no == VIRTIO_CONFIG_IRQ_IDX) {
|
||||||
|
*n = virtio_config_get_guest_notifier(vdev);
|
||||||
|
*vector = vdev->config_vector;
|
35
debian/patches/extra/0018-virtio-net-Ensure-queue-index-fits-with-RSS.patch
vendored
Normal file
35
debian/patches/extra/0018-virtio-net-Ensure-queue-index-fits-with-RSS.patch
vendored
Normal file
@@ -0,0 +1,35 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Akihiko Odaki <akihiko.odaki@daynix.com>
|
||||||
|
Date: Mon, 1 Jul 2024 20:58:04 +0900
|
||||||
|
Subject: [PATCH] virtio-net: Ensure queue index fits with RSS
|
||||||
|
|
||||||
|
Ensure the queue index points to a valid queue when software RSS
|
||||||
|
enabled. The new calculation matches with the behavior of Linux's TAP
|
||||||
|
device with the RSS eBPF program.
|
||||||
|
|
||||||
|
Fixes: 4474e37a5b3a ("virtio-net: implement RX RSS processing")
|
||||||
|
Reported-by: Zhibin Hu <huzhibin5@huawei.com>
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
|
||||||
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
||||||
|
Signed-off-by: Jason Wang <jasowang@redhat.com>
|
||||||
|
(cherry picked from commit f1595ceb9aad36a6c1da95bcb77ab9509b38822d)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
hw/net/virtio-net.c | 3 ++-
|
||||||
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
|
||||||
|
index 3644bfd91b..f48588638d 100644
|
||||||
|
--- a/hw/net/virtio-net.c
|
||||||
|
+++ b/hw/net/virtio-net.c
|
||||||
|
@@ -1949,7 +1949,8 @@ static ssize_t virtio_net_receive_rcu(NetClientState *nc, const uint8_t *buf,
|
||||||
|
if (!no_rss && n->rss_data.enabled && n->rss_data.enabled_software_rss) {
|
||||||
|
int index = virtio_net_process_rss(nc, buf, size);
|
||||||
|
if (index >= 0) {
|
||||||
|
- NetClientState *nc2 = qemu_get_subqueue(n->nic, index);
|
||||||
|
+ NetClientState *nc2 =
|
||||||
|
+ qemu_get_subqueue(n->nic, index % n->curr_queue_pairs);
|
||||||
|
return virtio_net_receive_rcu(nc2, buf, size, true);
|
||||||
|
}
|
||||||
|
}
|
338
debian/patches/extra/0019-virtio-net-Fix-network-stall-at-the-host-side-waitin.patch
vendored
Normal file
338
debian/patches/extra/0019-virtio-net-Fix-network-stall-at-the-host-side-waitin.patch
vendored
Normal file
@@ -0,0 +1,338 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: thomas <east.moutain.yang@gmail.com>
|
||||||
|
Date: Fri, 12 Jul 2024 11:10:53 +0800
|
||||||
|
Subject: [PATCH] virtio-net: Fix network stall at the host side waiting for
|
||||||
|
kick
|
||||||
|
|
||||||
|
Patch 06b12970174 ("virtio-net: fix network stall under load")
|
||||||
|
added double-check to test whether the available buffer size
|
||||||
|
can satisfy the request or not, in case the guest has added
|
||||||
|
some buffers to the avail ring simultaneously after the first
|
||||||
|
check. It will be lucky if the available buffer size becomes
|
||||||
|
okay after the double-check, then the host can send the packet
|
||||||
|
to the guest. If the buffer size still can't satisfy the request,
|
||||||
|
even if the guest has added some buffers, viritio-net would
|
||||||
|
stall at the host side forever.
|
||||||
|
|
||||||
|
The patch enables notification and checks whether the guest has
|
||||||
|
added some buffers since last check of available buffers when
|
||||||
|
the available buffers are insufficient. If no buffer is added,
|
||||||
|
return false, else recheck the available buffers in the loop.
|
||||||
|
If the available buffers are sufficient, disable notification
|
||||||
|
and return true.
|
||||||
|
|
||||||
|
Changes:
|
||||||
|
1. Change the return type of virtqueue_get_avail_bytes() from void
|
||||||
|
to int, it returns an opaque that represents the shadow_avail_idx
|
||||||
|
of the virtqueue on success, else -1 on error.
|
||||||
|
2. Add a new API: virtio_queue_enable_notification_and_check(),
|
||||||
|
it takes an opaque as input arg which is returned from
|
||||||
|
virtqueue_get_avail_bytes(). It enables notification firstly,
|
||||||
|
then checks whether the guest has added some buffers since
|
||||||
|
last check of available buffers or not by virtio_queue_poll(),
|
||||||
|
return ture if yes.
|
||||||
|
|
||||||
|
The patch also reverts patch "06b12970174".
|
||||||
|
|
||||||
|
The case below can reproduce the stall.
|
||||||
|
|
||||||
|
Guest 0
|
||||||
|
+--------+
|
||||||
|
| iperf |
|
||||||
|
---------------> | server |
|
||||||
|
Host | +--------+
|
||||||
|
+--------+ | ...
|
||||||
|
| iperf |----
|
||||||
|
| client |---- Guest n
|
||||||
|
+--------+ | +--------+
|
||||||
|
| | iperf |
|
||||||
|
---------------> | server |
|
||||||
|
+--------+
|
||||||
|
|
||||||
|
Boot many guests from qemu with virtio network:
|
||||||
|
qemu ... -netdev tap,id=net_x \
|
||||||
|
-device virtio-net-pci-non-transitional,\
|
||||||
|
iommu_platform=on,mac=xx:xx:xx:xx:xx:xx,netdev=net_x
|
||||||
|
|
||||||
|
Each guest acts as iperf server with commands below:
|
||||||
|
iperf3 -s -D -i 10 -p 8001
|
||||||
|
iperf3 -s -D -i 10 -p 8002
|
||||||
|
|
||||||
|
The host as iperf client:
|
||||||
|
iperf3 -c guest_IP -p 8001 -i 30 -w 256k -P 20 -t 40000
|
||||||
|
iperf3 -c guest_IP -p 8002 -i 30 -w 256k -P 20 -t 40000
|
||||||
|
|
||||||
|
After some time, the host loses connection to the guest,
|
||||||
|
the guest can send packet to the host, but can't receive
|
||||||
|
packet from the host.
|
||||||
|
|
||||||
|
It's more likely to happen if SWIOTLB is enabled in the guest,
|
||||||
|
allocating and freeing bounce buffer takes some CPU ticks,
|
||||||
|
copying from/to bounce buffer takes more CPU ticks, compared
|
||||||
|
with that there is no bounce buffer in the guest.
|
||||||
|
Once the rate of producing packets from the host approximates
|
||||||
|
the rate of receiveing packets in the guest, the guest would
|
||||||
|
loop in NAPI.
|
||||||
|
|
||||||
|
receive packets ---
|
||||||
|
| |
|
||||||
|
v |
|
||||||
|
free buf virtnet_poll
|
||||||
|
| |
|
||||||
|
v |
|
||||||
|
add buf to avail ring ---
|
||||||
|
|
|
||||||
|
| need kick the host?
|
||||||
|
| NAPI continues
|
||||||
|
v
|
||||||
|
receive packets ---
|
||||||
|
| |
|
||||||
|
v |
|
||||||
|
free buf virtnet_poll
|
||||||
|
| |
|
||||||
|
v |
|
||||||
|
add buf to avail ring ---
|
||||||
|
|
|
||||||
|
v
|
||||||
|
... ...
|
||||||
|
|
||||||
|
On the other hand, the host fetches free buf from avail
|
||||||
|
ring, if the buf in the avail ring is not enough, the
|
||||||
|
host notifies the guest the event by writing the avail
|
||||||
|
idx read from avail ring to the event idx of used ring,
|
||||||
|
then the host goes to sleep, waiting for the kick signal
|
||||||
|
from the guest.
|
||||||
|
|
||||||
|
Once the guest finds the host is waiting for kick singal
|
||||||
|
(in virtqueue_kick_prepare_split()), it kicks the host.
|
||||||
|
|
||||||
|
The host may stall forever at the sequences below:
|
||||||
|
|
||||||
|
Host Guest
|
||||||
|
------------ -----------
|
||||||
|
fetch buf, send packet receive packet ---
|
||||||
|
... ... |
|
||||||
|
fetch buf, send packet add buf |
|
||||||
|
... add buf virtnet_poll
|
||||||
|
buf not enough avail idx-> add buf |
|
||||||
|
read avail idx add buf |
|
||||||
|
add buf ---
|
||||||
|
receive packet ---
|
||||||
|
write event idx ... |
|
||||||
|
wait for kick add buf virtnet_poll
|
||||||
|
... |
|
||||||
|
---
|
||||||
|
no more packet, exit NAPI
|
||||||
|
|
||||||
|
In the first loop of NAPI above, indicated in the range of
|
||||||
|
virtnet_poll above, the host is sending packets while the
|
||||||
|
guest is receiving packets and adding buffers.
|
||||||
|
step 1: The buf is not enough, for example, a big packet
|
||||||
|
needs 5 buf, but the available buf count is 3.
|
||||||
|
The host read current avail idx.
|
||||||
|
step 2: The guest adds some buf, then checks whether the
|
||||||
|
host is waiting for kick signal, not at this time.
|
||||||
|
The used ring is not empty, the guest continues
|
||||||
|
the second loop of NAPI.
|
||||||
|
step 3: The host writes the avail idx read from avail
|
||||||
|
ring to used ring as event idx via
|
||||||
|
virtio_queue_set_notification(q->rx_vq, 1).
|
||||||
|
step 4: At the end of the second loop of NAPI, recheck
|
||||||
|
whether kick is needed, as the event idx in the
|
||||||
|
used ring written by the host is beyound the
|
||||||
|
range of kick condition, the guest will not
|
||||||
|
send kick signal to the host.
|
||||||
|
|
||||||
|
Fixes: 06b12970174 ("virtio-net: fix network stall under load")
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Signed-off-by: Wencheng Yang <east.moutain.yang@gmail.com>
|
||||||
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
||||||
|
Signed-off-by: Jason Wang <jasowang@redhat.com>
|
||||||
|
(cherry picked from commit f937309fbdbb48c354220a3e7110c202ae4aa7fa)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
hw/net/virtio-net.c | 28 ++++++++++-------
|
||||||
|
hw/virtio/virtio.c | 64 +++++++++++++++++++++++++++++++++++---
|
||||||
|
include/hw/virtio/virtio.h | 21 +++++++++++--
|
||||||
|
3 files changed, 94 insertions(+), 19 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
|
||||||
|
index f48588638d..d4b979d343 100644
|
||||||
|
--- a/hw/net/virtio-net.c
|
||||||
|
+++ b/hw/net/virtio-net.c
|
||||||
|
@@ -1680,24 +1680,28 @@ static bool virtio_net_can_receive(NetClientState *nc)
|
||||||
|
|
||||||
|
static int virtio_net_has_buffers(VirtIONetQueue *q, int bufsize)
|
||||||
|
{
|
||||||
|
+ int opaque;
|
||||||
|
+ unsigned int in_bytes;
|
||||||
|
VirtIONet *n = q->n;
|
||||||
|
- if (virtio_queue_empty(q->rx_vq) ||
|
||||||
|
- (n->mergeable_rx_bufs &&
|
||||||
|
- !virtqueue_avail_bytes(q->rx_vq, bufsize, 0))) {
|
||||||
|
- virtio_queue_set_notification(q->rx_vq, 1);
|
||||||
|
-
|
||||||
|
- /* To avoid a race condition where the guest has made some buffers
|
||||||
|
- * available after the above check but before notification was
|
||||||
|
- * enabled, check for available buffers again.
|
||||||
|
- */
|
||||||
|
- if (virtio_queue_empty(q->rx_vq) ||
|
||||||
|
- (n->mergeable_rx_bufs &&
|
||||||
|
- !virtqueue_avail_bytes(q->rx_vq, bufsize, 0))) {
|
||||||
|
+
|
||||||
|
+ while (virtio_queue_empty(q->rx_vq) || n->mergeable_rx_bufs) {
|
||||||
|
+ opaque = virtqueue_get_avail_bytes(q->rx_vq, &in_bytes, NULL,
|
||||||
|
+ bufsize, 0);
|
||||||
|
+ /* Buffer is enough, disable notifiaction */
|
||||||
|
+ if (bufsize <= in_bytes) {
|
||||||
|
+ break;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ if (virtio_queue_enable_notification_and_check(q->rx_vq, opaque)) {
|
||||||
|
+ /* Guest has added some buffers, try again */
|
||||||
|
+ continue;
|
||||||
|
+ } else {
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
virtio_queue_set_notification(q->rx_vq, 0);
|
||||||
|
+
|
||||||
|
return 1;
|
||||||
|
}
|
||||||
|
|
||||||
|
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
|
||||||
|
index fd2dfe3a6b..08fba6b2d8 100644
|
||||||
|
--- a/hw/virtio/virtio.c
|
||||||
|
+++ b/hw/virtio/virtio.c
|
||||||
|
@@ -743,6 +743,60 @@ int virtio_queue_empty(VirtQueue *vq)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
+static bool virtio_queue_split_poll(VirtQueue *vq, unsigned shadow_idx)
|
||||||
|
+{
|
||||||
|
+ if (unlikely(!vq->vring.avail)) {
|
||||||
|
+ return false;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ return (uint16_t)shadow_idx != vring_avail_idx(vq);
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+static bool virtio_queue_packed_poll(VirtQueue *vq, unsigned shadow_idx)
|
||||||
|
+{
|
||||||
|
+ VRingPackedDesc desc;
|
||||||
|
+ VRingMemoryRegionCaches *caches;
|
||||||
|
+
|
||||||
|
+ if (unlikely(!vq->vring.desc)) {
|
||||||
|
+ return false;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ caches = vring_get_region_caches(vq);
|
||||||
|
+ if (!caches) {
|
||||||
|
+ return false;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ vring_packed_desc_read(vq->vdev, &desc, &caches->desc,
|
||||||
|
+ shadow_idx, true);
|
||||||
|
+
|
||||||
|
+ return is_desc_avail(desc.flags, vq->shadow_avail_wrap_counter);
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+static bool virtio_queue_poll(VirtQueue *vq, unsigned shadow_idx)
|
||||||
|
+{
|
||||||
|
+ if (virtio_device_disabled(vq->vdev)) {
|
||||||
|
+ return false;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ if (virtio_vdev_has_feature(vq->vdev, VIRTIO_F_RING_PACKED)) {
|
||||||
|
+ return virtio_queue_packed_poll(vq, shadow_idx);
|
||||||
|
+ } else {
|
||||||
|
+ return virtio_queue_split_poll(vq, shadow_idx);
|
||||||
|
+ }
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+bool virtio_queue_enable_notification_and_check(VirtQueue *vq,
|
||||||
|
+ int opaque)
|
||||||
|
+{
|
||||||
|
+ virtio_queue_set_notification(vq, 1);
|
||||||
|
+
|
||||||
|
+ if (opaque >= 0) {
|
||||||
|
+ return virtio_queue_poll(vq, (unsigned)opaque);
|
||||||
|
+ } else {
|
||||||
|
+ return false;
|
||||||
|
+ }
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
static void virtqueue_unmap_sg(VirtQueue *vq, const VirtQueueElement *elem,
|
||||||
|
unsigned int len)
|
||||||
|
{
|
||||||
|
@@ -1330,9 +1384,9 @@ err:
|
||||||
|
goto done;
|
||||||
|
}
|
||||||
|
|
||||||
|
-void virtqueue_get_avail_bytes(VirtQueue *vq, unsigned int *in_bytes,
|
||||||
|
- unsigned int *out_bytes,
|
||||||
|
- unsigned max_in_bytes, unsigned max_out_bytes)
|
||||||
|
+int virtqueue_get_avail_bytes(VirtQueue *vq, unsigned int *in_bytes,
|
||||||
|
+ unsigned int *out_bytes, unsigned max_in_bytes,
|
||||||
|
+ unsigned max_out_bytes)
|
||||||
|
{
|
||||||
|
uint16_t desc_size;
|
||||||
|
VRingMemoryRegionCaches *caches;
|
||||||
|
@@ -1365,7 +1419,7 @@ void virtqueue_get_avail_bytes(VirtQueue *vq, unsigned int *in_bytes,
|
||||||
|
caches);
|
||||||
|
}
|
||||||
|
|
||||||
|
- return;
|
||||||
|
+ return (int)vq->shadow_avail_idx;
|
||||||
|
err:
|
||||||
|
if (in_bytes) {
|
||||||
|
*in_bytes = 0;
|
||||||
|
@@ -1373,6 +1427,8 @@ err:
|
||||||
|
if (out_bytes) {
|
||||||
|
*out_bytes = 0;
|
||||||
|
}
|
||||||
|
+
|
||||||
|
+ return -1;
|
||||||
|
}
|
||||||
|
|
||||||
|
int virtqueue_avail_bytes(VirtQueue *vq, unsigned int in_bytes,
|
||||||
|
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
|
||||||
|
index 2eafad17b8..8b4da92889 100644
|
||||||
|
--- a/include/hw/virtio/virtio.h
|
||||||
|
+++ b/include/hw/virtio/virtio.h
|
||||||
|
@@ -271,9 +271,13 @@ void qemu_put_virtqueue_element(VirtIODevice *vdev, QEMUFile *f,
|
||||||
|
VirtQueueElement *elem);
|
||||||
|
int virtqueue_avail_bytes(VirtQueue *vq, unsigned int in_bytes,
|
||||||
|
unsigned int out_bytes);
|
||||||
|
-void virtqueue_get_avail_bytes(VirtQueue *vq, unsigned int *in_bytes,
|
||||||
|
- unsigned int *out_bytes,
|
||||||
|
- unsigned max_in_bytes, unsigned max_out_bytes);
|
||||||
|
+/**
|
||||||
|
+ * Return <0 on error or an opaque >=0 to pass to
|
||||||
|
+ * virtio_queue_enable_notification_and_check on success.
|
||||||
|
+ */
|
||||||
|
+int virtqueue_get_avail_bytes(VirtQueue *vq, unsigned int *in_bytes,
|
||||||
|
+ unsigned int *out_bytes, unsigned max_in_bytes,
|
||||||
|
+ unsigned max_out_bytes);
|
||||||
|
|
||||||
|
void virtio_notify_irqfd(VirtIODevice *vdev, VirtQueue *vq);
|
||||||
|
void virtio_notify(VirtIODevice *vdev, VirtQueue *vq);
|
||||||
|
@@ -307,6 +311,17 @@ int virtio_queue_ready(VirtQueue *vq);
|
||||||
|
|
||||||
|
int virtio_queue_empty(VirtQueue *vq);
|
||||||
|
|
||||||
|
+/**
|
||||||
|
+ * Enable notification and check whether guest has added some
|
||||||
|
+ * buffers since last call to virtqueue_get_avail_bytes.
|
||||||
|
+ *
|
||||||
|
+ * @opaque: value returned from virtqueue_get_avail_bytes
|
||||||
|
+ */
|
||||||
|
+bool virtio_queue_enable_notification_and_check(VirtQueue *vq,
|
||||||
|
+ int opaque);
|
||||||
|
+
|
||||||
|
+void virtio_queue_set_shadow_avail_idx(VirtQueue *vq, uint16_t idx);
|
||||||
|
+
|
||||||
|
/* Host binding interface. */
|
||||||
|
|
||||||
|
uint32_t virtio_config_readb(VirtIODevice *vdev, uint32_t addr);
|
70
debian/patches/extra/0020-net-Reinstate-net-nic-model-help-output-as-documente.patch
vendored
Normal file
70
debian/patches/extra/0020-net-Reinstate-net-nic-model-help-output-as-documente.patch
vendored
Normal file
@@ -0,0 +1,70 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: David Woodhouse <dwmw@amazon.co.uk>
|
||||||
|
Date: Tue, 9 Jul 2024 13:34:44 +0100
|
||||||
|
Subject: [PATCH] net: Reinstate '-net nic, model=help' output as documented in
|
||||||
|
man page
|
||||||
|
|
||||||
|
While refactoring the NIC initialization code, I broke '-net nic,model=help'
|
||||||
|
which no longer outputs a list of available NIC models.
|
||||||
|
|
||||||
|
Fixes: 2cdeca04adab ("net: report list of available models according to platform")
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
|
||||||
|
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
|
||||||
|
Signed-off-by: Jason Wang <jasowang@redhat.com>
|
||||||
|
(cherry picked from commit 64f75f57f9d2c8c12ac6d9355fa5d3a2af5879ca)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
net/net.c | 25 ++++++++++++++++++++++---
|
||||||
|
1 file changed, 22 insertions(+), 3 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/net/net.c b/net/net.c
|
||||||
|
index a2f0c828bb..e6ca2529bb 100644
|
||||||
|
--- a/net/net.c
|
||||||
|
+++ b/net/net.c
|
||||||
|
@@ -1150,6 +1150,21 @@ NICInfo *qemu_find_nic_info(const char *typename, bool match_default,
|
||||||
|
return NULL;
|
||||||
|
}
|
||||||
|
|
||||||
|
+static bool is_nic_model_help_option(const char *model)
|
||||||
|
+{
|
||||||
|
+ if (model && is_help_option(model)) {
|
||||||
|
+ /*
|
||||||
|
+ * Trigger the help output by instantiating the hash table which
|
||||||
|
+ * will gather tha available models as they get registered.
|
||||||
|
+ */
|
||||||
|
+ if (!nic_model_help) {
|
||||||
|
+ nic_model_help = g_hash_table_new_full(g_str_hash, g_str_equal,
|
||||||
|
+ g_free, NULL);
|
||||||
|
+ }
|
||||||
|
+ return true;
|
||||||
|
+ }
|
||||||
|
+ return false;
|
||||||
|
+}
|
||||||
|
|
||||||
|
/* "I have created a device. Please configure it if you can" */
|
||||||
|
bool qemu_configure_nic_device(DeviceState *dev, bool match_default,
|
||||||
|
@@ -1733,6 +1748,12 @@ void net_check_clients(void)
|
||||||
|
|
||||||
|
static int net_init_client(void *dummy, QemuOpts *opts, Error **errp)
|
||||||
|
{
|
||||||
|
+ const char *model = qemu_opt_get_del(opts, "model");
|
||||||
|
+
|
||||||
|
+ if (is_nic_model_help_option(model)) {
|
||||||
|
+ return 0;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
return net_client_init(opts, false, errp);
|
||||||
|
}
|
||||||
|
|
||||||
|
@@ -1789,9 +1810,7 @@ static int net_param_nic(void *dummy, QemuOpts *opts, Error **errp)
|
||||||
|
memset(ni, 0, sizeof(*ni));
|
||||||
|
ni->model = qemu_opt_get_del(opts, "model");
|
||||||
|
|
||||||
|
- if (!nic_model_help && !g_strcmp0(ni->model, "help")) {
|
||||||
|
- nic_model_help = g_hash_table_new_full(g_str_hash, g_str_equal,
|
||||||
|
- g_free, NULL);
|
||||||
|
+ if (is_nic_model_help_option(ni->model)) {
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
32
debian/patches/extra/0021-net-Fix-net-nic-model-for-non-help-arguments.patch
vendored
Normal file
32
debian/patches/extra/0021-net-Fix-net-nic-model-for-non-help-arguments.patch
vendored
Normal file
@@ -0,0 +1,32 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: David Woodhouse <dwmw@amazon.co.uk>
|
||||||
|
Date: Tue, 6 Aug 2024 18:21:37 +0100
|
||||||
|
Subject: [PATCH] net: Fix '-net nic,model=' for non-help arguments
|
||||||
|
|
||||||
|
Oops, don't *delete* the model option when checking for 'help'.
|
||||||
|
|
||||||
|
Fixes: 64f75f57f9d2 ("net: Reinstate '-net nic, model=help' output as documented in man page")
|
||||||
|
Reported-by: Hans <sungdgdhtryrt@gmail.com>
|
||||||
|
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
|
||||||
|
Signed-off-by: Jason Wang <jasowang@redhat.com>
|
||||||
|
(cherry picked from commit fa62cb989a9146c82f8f172715042852f5d36200)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
net/net.c | 2 +-
|
||||||
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/net/net.c b/net/net.c
|
||||||
|
index e6ca2529bb..897bb936cf 100644
|
||||||
|
--- a/net/net.c
|
||||||
|
+++ b/net/net.c
|
||||||
|
@@ -1748,7 +1748,7 @@ void net_check_clients(void)
|
||||||
|
|
||||||
|
static int net_init_client(void *dummy, QemuOpts *opts, Error **errp)
|
||||||
|
{
|
||||||
|
- const char *model = qemu_opt_get_del(opts, "model");
|
||||||
|
+ const char *model = qemu_opt_get(opts, "model");
|
||||||
|
|
||||||
|
if (is_nic_model_help_option(model)) {
|
||||||
|
return 0;
|
57
debian/patches/extra/0022-target-arm-Don-t-assert-for-128-bit-tile-accesses-wh.patch
vendored
Normal file
57
debian/patches/extra/0022-target-arm-Don-t-assert-for-128-bit-tile-accesses-wh.patch
vendored
Normal file
@@ -0,0 +1,57 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Peter Maydell <peter.maydell@linaro.org>
|
||||||
|
Date: Mon, 22 Jul 2024 18:29:54 +0100
|
||||||
|
Subject: [PATCH] target/arm: Don't assert for 128-bit tile accesses when SVL
|
||||||
|
is 128
|
||||||
|
|
||||||
|
For an instruction which accesses a 128-bit element tile when
|
||||||
|
the SVL is also 128 (for example MOV z0.Q, p0/M, ZA0H.Q[w0,0]),
|
||||||
|
we will assert in get_tile_rowcol():
|
||||||
|
|
||||||
|
qemu-system-aarch64: ../../tcg/tcg-op.c:926: tcg_gen_deposit_z_i32: Assertion `len > 0' failed.
|
||||||
|
|
||||||
|
This happens because we calculate
|
||||||
|
len = ctz32(streaming_vec_reg_size(s)) - esz;$
|
||||||
|
but if the SVL and the element size are the same len is 0, and
|
||||||
|
the deposit operation asserts.
|
||||||
|
|
||||||
|
In this case the ZA storage contains exactly one 128 bit
|
||||||
|
element ZA tile, and the horizontal or vertical slice is just
|
||||||
|
that tile. This means that regardless of the index value in
|
||||||
|
the Ws register, we always access that tile. (In pseudocode terms,
|
||||||
|
we calculate (index + offset) MOD 1, which is 0.)
|
||||||
|
|
||||||
|
Special case the len == 0 case to avoid hitting the assertion
|
||||||
|
in tcg_gen_deposit_z_i32().
|
||||||
|
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
|
||||||
|
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
|
||||||
|
Message-id: 20240722172957.1041231-2-peter.maydell@linaro.org
|
||||||
|
(cherry picked from commit 56f1c0db928aae0b83fd91c89ddb226b137e2b21)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
target/arm/tcg/translate-sme.c | 10 +++++++++-
|
||||||
|
1 file changed, 9 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c
|
||||||
|
index 185a8a917b..a50a419af2 100644
|
||||||
|
--- a/target/arm/tcg/translate-sme.c
|
||||||
|
+++ b/target/arm/tcg/translate-sme.c
|
||||||
|
@@ -49,7 +49,15 @@ static TCGv_ptr get_tile_rowcol(DisasContext *s, int esz, int rs,
|
||||||
|
/* Prepare a power-of-two modulo via extraction of @len bits. */
|
||||||
|
len = ctz32(streaming_vec_reg_size(s)) - esz;
|
||||||
|
|
||||||
|
- if (vertical) {
|
||||||
|
+ if (!len) {
|
||||||
|
+ /*
|
||||||
|
+ * SVL is 128 and the element size is 128. There is exactly
|
||||||
|
+ * one 128x128 tile in the ZA storage, and so we calculate
|
||||||
|
+ * (Rs + imm) MOD 1, which is always 0. We need to special case
|
||||||
|
+ * this because TCG doesn't allow deposit ops with len 0.
|
||||||
|
+ */
|
||||||
|
+ tcg_gen_movi_i32(tmp, 0);
|
||||||
|
+ } else if (vertical) {
|
||||||
|
/*
|
||||||
|
* Compute the byte offset of the index within the tile:
|
||||||
|
* (index % (svl / size)) * size
|
59
debian/patches/extra/0023-target-arm-Fix-UMOPA-UMOPS-of-16-bit-values.patch
vendored
Normal file
59
debian/patches/extra/0023-target-arm-Fix-UMOPA-UMOPS-of-16-bit-values.patch
vendored
Normal file
@@ -0,0 +1,59 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Peter Maydell <peter.maydell@linaro.org>
|
||||||
|
Date: Mon, 22 Jul 2024 18:29:55 +0100
|
||||||
|
Subject: [PATCH] target/arm: Fix UMOPA/UMOPS of 16-bit values
|
||||||
|
|
||||||
|
The UMOPA/UMOPS instructions are supposed to multiply unsigned 8 or
|
||||||
|
16 bit elements and accumulate the products into a 64-bit element.
|
||||||
|
In the Arm ARM pseudocode, this is done with the usual
|
||||||
|
infinite-precision signed arithmetic. However our implementation
|
||||||
|
doesn't quite get it right, because in the DEF_IMOP_64() macro we do:
|
||||||
|
sum += (NTYPE)(n >> 0) * (MTYPE)(m >> 0);
|
||||||
|
|
||||||
|
where NTYPE and MTYPE are uint16_t or int16_t. In the uint16_t case,
|
||||||
|
the C usual arithmetic conversions mean the values are converted to
|
||||||
|
"int" type and the multiply is done as a 32-bit multiply. This means
|
||||||
|
that if the inputs are, for example, 0xffff and 0xffff then the
|
||||||
|
result is 0xFFFE0001 as an int, which is then promoted to uint64_t
|
||||||
|
for the accumulation into sum; this promotion incorrectly sign
|
||||||
|
extends the multiply.
|
||||||
|
|
||||||
|
Avoid the incorrect sign extension by casting to int64_t before
|
||||||
|
the multiply, so we do the multiply as 64-bit signed arithmetic,
|
||||||
|
which is a type large enough that the multiply can never
|
||||||
|
overflow into the sign bit.
|
||||||
|
|
||||||
|
(The equivalent 8-bit operations in DEF_IMOP_32() are fine, because
|
||||||
|
the 8-bit multiplies can never overflow into the sign bit of a
|
||||||
|
32-bit integer.)
|
||||||
|
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2372
|
||||||
|
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
|
||||||
|
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
|
||||||
|
Message-id: 20240722172957.1041231-3-peter.maydell@linaro.org
|
||||||
|
(cherry picked from commit ea3f5a90f036734522e9af3bffd77e69e9f47355)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
target/arm/tcg/sme_helper.c | 8 ++++----
|
||||||
|
1 file changed, 4 insertions(+), 4 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/target/arm/tcg/sme_helper.c b/target/arm/tcg/sme_helper.c
|
||||||
|
index 5a6dd76489..f9001f5213 100644
|
||||||
|
--- a/target/arm/tcg/sme_helper.c
|
||||||
|
+++ b/target/arm/tcg/sme_helper.c
|
||||||
|
@@ -1146,10 +1146,10 @@ static uint64_t NAME(uint64_t n, uint64_t m, uint64_t a, uint8_t p, bool neg) \
|
||||||
|
uint64_t sum = 0; \
|
||||||
|
/* Apply P to N as a mask, making the inactive elements 0. */ \
|
||||||
|
n &= expand_pred_h(p); \
|
||||||
|
- sum += (NTYPE)(n >> 0) * (MTYPE)(m >> 0); \
|
||||||
|
- sum += (NTYPE)(n >> 16) * (MTYPE)(m >> 16); \
|
||||||
|
- sum += (NTYPE)(n >> 32) * (MTYPE)(m >> 32); \
|
||||||
|
- sum += (NTYPE)(n >> 48) * (MTYPE)(m >> 48); \
|
||||||
|
+ sum += (int64_t)(NTYPE)(n >> 0) * (MTYPE)(m >> 0); \
|
||||||
|
+ sum += (int64_t)(NTYPE)(n >> 16) * (MTYPE)(m >> 16); \
|
||||||
|
+ sum += (int64_t)(NTYPE)(n >> 32) * (MTYPE)(m >> 32); \
|
||||||
|
+ sum += (int64_t)(NTYPE)(n >> 48) * (MTYPE)(m >> 48); \
|
||||||
|
return neg ? a - sum : a + sum; \
|
||||||
|
}
|
||||||
|
|
62
debian/patches/extra/0024-target-arm-Avoid-shifts-by-1-in-tszimm_shr-and-tszim.patch
vendored
Normal file
62
debian/patches/extra/0024-target-arm-Avoid-shifts-by-1-in-tszimm_shr-and-tszim.patch
vendored
Normal file
@@ -0,0 +1,62 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Peter Maydell <peter.maydell@linaro.org>
|
||||||
|
Date: Mon, 22 Jul 2024 18:29:56 +0100
|
||||||
|
Subject: [PATCH] target/arm: Avoid shifts by -1 in tszimm_shr() and
|
||||||
|
tszimm_shl()
|
||||||
|
|
||||||
|
The function tszimm_esz() returns a shift amount, or possibly -1 in
|
||||||
|
certain cases that correspond to unallocated encodings in the
|
||||||
|
instruction set. We catch these later in the trans_ functions
|
||||||
|
(generally with an "a-esz < 0" check), but before we do the
|
||||||
|
decodetree-generated code will also call tszimm_shr() or tszimm_sl(),
|
||||||
|
which will use the tszimm_esz() return value as a shift count without
|
||||||
|
checking that it is not negative, which is undefined behaviour.
|
||||||
|
|
||||||
|
Avoid the UB by checking the return value in tszimm_shr() and
|
||||||
|
tszimm_shl().
|
||||||
|
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Resolves: Coverity CID 1547617, 1547694
|
||||||
|
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
|
||||||
|
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
|
||||||
|
Message-id: 20240722172957.1041231-4-peter.maydell@linaro.org
|
||||||
|
(cherry picked from commit 76916dfa89e8900639c1055c07a295c06628a0bc)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
target/arm/tcg/translate-sve.c | 18 ++++++++++++++++--
|
||||||
|
1 file changed, 16 insertions(+), 2 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
|
||||||
|
index ada05aa530..466a19c25a 100644
|
||||||
|
--- a/target/arm/tcg/translate-sve.c
|
||||||
|
+++ b/target/arm/tcg/translate-sve.c
|
||||||
|
@@ -50,13 +50,27 @@ static int tszimm_esz(DisasContext *s, int x)
|
||||||
|
|
||||||
|
static int tszimm_shr(DisasContext *s, int x)
|
||||||
|
{
|
||||||
|
- return (16 << tszimm_esz(s, x)) - x;
|
||||||
|
+ /*
|
||||||
|
+ * We won't use the tszimm_shr() value if tszimm_esz() returns -1 (the
|
||||||
|
+ * trans function will check for esz < 0), so we can return any
|
||||||
|
+ * value we like from here in that case as long as we avoid UB.
|
||||||
|
+ */
|
||||||
|
+ int esz = tszimm_esz(s, x);
|
||||||
|
+ if (esz < 0) {
|
||||||
|
+ return esz;
|
||||||
|
+ }
|
||||||
|
+ return (16 << esz) - x;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* See e.g. LSL (immediate, predicated). */
|
||||||
|
static int tszimm_shl(DisasContext *s, int x)
|
||||||
|
{
|
||||||
|
- return x - (8 << tszimm_esz(s, x));
|
||||||
|
+ /* As with tszimm_shr(), value will be unused if esz < 0 */
|
||||||
|
+ int esz = tszimm_esz(s, x);
|
||||||
|
+ if (esz < 0) {
|
||||||
|
+ return esz;
|
||||||
|
+ }
|
||||||
|
+ return x - (8 << esz);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* The SH bit is in bit 8. Extract the low 8 and shift. */
|
41
debian/patches/extra/0025-target-arm-Ignore-SMCR_EL2.LEN-and-SVCR_EL2.LEN-if-E.patch
vendored
Normal file
41
debian/patches/extra/0025-target-arm-Ignore-SMCR_EL2.LEN-and-SVCR_EL2.LEN-if-E.patch
vendored
Normal file
@@ -0,0 +1,41 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Peter Maydell <peter.maydell@linaro.org>
|
||||||
|
Date: Mon, 22 Jul 2024 18:29:57 +0100
|
||||||
|
Subject: [PATCH] target/arm: Ignore SMCR_EL2.LEN and SVCR_EL2.LEN if EL2 is
|
||||||
|
not enabled
|
||||||
|
|
||||||
|
When determining the current vector length, the SMCR_EL2.LEN and
|
||||||
|
SVCR_EL2.LEN settings should only be considered if EL2 is enabled
|
||||||
|
(compare the pseudocode CurrentSVL and CurrentNSVL which call
|
||||||
|
EL2Enabled()).
|
||||||
|
|
||||||
|
We were checking against ARM_FEATURE_EL2 rather than calling
|
||||||
|
arm_is_el2_enabled(), which meant that we would look at
|
||||||
|
SMCR_EL2/SVCR_EL2 when in Secure EL1 or Secure EL0 even if Secure EL2
|
||||||
|
was not enabled.
|
||||||
|
|
||||||
|
Use the correct check in sve_vqm1_for_el_sm().
|
||||||
|
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
|
||||||
|
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
|
||||||
|
Message-id: 20240722172957.1041231-5-peter.maydell@linaro.org
|
||||||
|
(cherry picked from commit f573ac059ed060234fcef4299fae9e500d357c33)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
target/arm/helper.c | 2 +-
|
||||||
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/target/arm/helper.c b/target/arm/helper.c
|
||||||
|
index a620481d7c..42044ae14b 100644
|
||||||
|
--- a/target/arm/helper.c
|
||||||
|
+++ b/target/arm/helper.c
|
||||||
|
@@ -7191,7 +7191,7 @@ uint32_t sve_vqm1_for_el_sm(CPUARMState *env, int el, bool sm)
|
||||||
|
if (el <= 1 && !el_is_in_host(env, el)) {
|
||||||
|
len = MIN(len, 0xf & (uint32_t)cr[1]);
|
||||||
|
}
|
||||||
|
- if (el <= 2 && arm_feature(env, ARM_FEATURE_EL2)) {
|
||||||
|
+ if (el <= 2 && arm_is_el2_enabled(env)) {
|
||||||
|
len = MIN(len, 0xf & (uint32_t)cr[2]);
|
||||||
|
}
|
||||||
|
if (arm_feature(env, ARM_FEATURE_EL3)) {
|
164
debian/patches/extra/0026-target-arm-Handle-denormals-correctly-for-FMOPA-wide.patch
vendored
Normal file
164
debian/patches/extra/0026-target-arm-Handle-denormals-correctly-for-FMOPA-wide.patch
vendored
Normal file
@@ -0,0 +1,164 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Peter Maydell <peter.maydell@linaro.org>
|
||||||
|
Date: Thu, 1 Aug 2024 10:15:03 +0100
|
||||||
|
Subject: [PATCH] target/arm: Handle denormals correctly for FMOPA (widening)
|
||||||
|
|
||||||
|
The FMOPA (widening) SME instruction takes pairs of half-precision
|
||||||
|
floating point values, widens them to single-precision, does a
|
||||||
|
two-way dot product and accumulates the results into a
|
||||||
|
single-precision destination. We don't quite correctly handle the
|
||||||
|
FPCR bits FZ and FZ16 which control flushing of denormal inputs and
|
||||||
|
outputs. This is because at the moment we pass a single float_status
|
||||||
|
value to the helper function, which then uses that configuration for
|
||||||
|
all the fp operations it does. However, because the inputs to this
|
||||||
|
operation are float16 and the outputs are float32 we need to use the
|
||||||
|
fp_status_f16 for the float16 input widening but the normal fp_status
|
||||||
|
for everything else. Otherwise we will apply the flushing control
|
||||||
|
FPCR.FZ16 to the 32-bit output rather than the FPCR.FZ control, and
|
||||||
|
incorrectly flush a denormal output to zero when we should not (or
|
||||||
|
vice-versa).
|
||||||
|
|
||||||
|
(In commit 207d30b5fdb5b we tried to fix the FZ handling but
|
||||||
|
didn't get it right, switching from "use FPCR.FZ for everything" to
|
||||||
|
"use FPCR.FZ16 for everything".)
|
||||||
|
|
||||||
|
Pass the CPU env to the sme_fmopa_h helper instead of an fp_status
|
||||||
|
pointer, and have the helper pass an extra fp_status into the
|
||||||
|
f16_dotadd() function so that we can use the right status for the
|
||||||
|
right parts of this operation.
|
||||||
|
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Fixes: 207d30b5fdb5 ("target/arm: Use FPST_F16 for SME FMOPA (widening)")
|
||||||
|
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2373
|
||||||
|
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
|
||||||
|
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
|
||||||
|
(cherry picked from commit 55f9f4ee018c5ccea81d8c8c586756d7711ae46f)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
target/arm/tcg/helper-sme.h | 2 +-
|
||||||
|
target/arm/tcg/sme_helper.c | 39 +++++++++++++++++++++++-----------
|
||||||
|
target/arm/tcg/translate-sme.c | 25 ++++++++++++++++++++--
|
||||||
|
3 files changed, 51 insertions(+), 15 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/target/arm/tcg/helper-sme.h b/target/arm/tcg/helper-sme.h
|
||||||
|
index 27eef49a11..d22bf9d21b 100644
|
||||||
|
--- a/target/arm/tcg/helper-sme.h
|
||||||
|
+++ b/target/arm/tcg/helper-sme.h
|
||||||
|
@@ -121,7 +121,7 @@ DEF_HELPER_FLAGS_5(sme_addha_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, i32)
|
||||||
|
DEF_HELPER_FLAGS_5(sme_addva_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, i32)
|
||||||
|
|
||||||
|
DEF_HELPER_FLAGS_7(sme_fmopa_h, TCG_CALL_NO_RWG,
|
||||||
|
- void, ptr, ptr, ptr, ptr, ptr, ptr, i32)
|
||||||
|
+ void, ptr, ptr, ptr, ptr, ptr, env, i32)
|
||||||
|
DEF_HELPER_FLAGS_7(sme_fmopa_s, TCG_CALL_NO_RWG,
|
||||||
|
void, ptr, ptr, ptr, ptr, ptr, ptr, i32)
|
||||||
|
DEF_HELPER_FLAGS_7(sme_fmopa_d, TCG_CALL_NO_RWG,
|
||||||
|
diff --git a/target/arm/tcg/sme_helper.c b/target/arm/tcg/sme_helper.c
|
||||||
|
index f9001f5213..3906bb51c0 100644
|
||||||
|
--- a/target/arm/tcg/sme_helper.c
|
||||||
|
+++ b/target/arm/tcg/sme_helper.c
|
||||||
|
@@ -976,12 +976,23 @@ static inline uint32_t f16mop_adj_pair(uint32_t pair, uint32_t pg, uint32_t neg)
|
||||||
|
}
|
||||||
|
|
||||||
|
static float32 f16_dotadd(float32 sum, uint32_t e1, uint32_t e2,
|
||||||
|
- float_status *s_std, float_status *s_odd)
|
||||||
|
+ float_status *s_f16, float_status *s_std,
|
||||||
|
+ float_status *s_odd)
|
||||||
|
{
|
||||||
|
- float64 e1r = float16_to_float64(e1 & 0xffff, true, s_std);
|
||||||
|
- float64 e1c = float16_to_float64(e1 >> 16, true, s_std);
|
||||||
|
- float64 e2r = float16_to_float64(e2 & 0xffff, true, s_std);
|
||||||
|
- float64 e2c = float16_to_float64(e2 >> 16, true, s_std);
|
||||||
|
+ /*
|
||||||
|
+ * We need three different float_status for different parts of this
|
||||||
|
+ * operation:
|
||||||
|
+ * - the input conversion of the float16 values must use the
|
||||||
|
+ * f16-specific float_status, so that the FPCR.FZ16 control is applied
|
||||||
|
+ * - operations on float32 including the final accumulation must use
|
||||||
|
+ * the normal float_status, so that FPCR.FZ is applied
|
||||||
|
+ * - we have pre-set-up copy of s_std which is set to round-to-odd,
|
||||||
|
+ * for the multiply (see below)
|
||||||
|
+ */
|
||||||
|
+ float64 e1r = float16_to_float64(e1 & 0xffff, true, s_f16);
|
||||||
|
+ float64 e1c = float16_to_float64(e1 >> 16, true, s_f16);
|
||||||
|
+ float64 e2r = float16_to_float64(e2 & 0xffff, true, s_f16);
|
||||||
|
+ float64 e2c = float16_to_float64(e2 >> 16, true, s_f16);
|
||||||
|
float64 t64;
|
||||||
|
float32 t32;
|
||||||
|
|
||||||
|
@@ -1003,20 +1014,23 @@ static float32 f16_dotadd(float32 sum, uint32_t e1, uint32_t e2,
|
||||||
|
}
|
||||||
|
|
||||||
|
void HELPER(sme_fmopa_h)(void *vza, void *vzn, void *vzm, void *vpn,
|
||||||
|
- void *vpm, void *vst, uint32_t desc)
|
||||||
|
+ void *vpm, CPUARMState *env, uint32_t desc)
|
||||||
|
{
|
||||||
|
intptr_t row, col, oprsz = simd_maxsz(desc);
|
||||||
|
uint32_t neg = simd_data(desc) * 0x80008000u;
|
||||||
|
uint16_t *pn = vpn, *pm = vpm;
|
||||||
|
- float_status fpst_odd, fpst_std;
|
||||||
|
+ float_status fpst_odd, fpst_std, fpst_f16;
|
||||||
|
|
||||||
|
/*
|
||||||
|
- * Make a copy of float_status because this operation does not
|
||||||
|
- * update the cumulative fp exception status. It also produces
|
||||||
|
- * default nans. Make a second copy with round-to-odd -- see above.
|
||||||
|
+ * Make copies of fp_status and fp_status_f16, because this operation
|
||||||
|
+ * does not update the cumulative fp exception status. It also
|
||||||
|
+ * produces default NaNs. We also need a second copy of fp_status with
|
||||||
|
+ * round-to-odd -- see above.
|
||||||
|
*/
|
||||||
|
- fpst_std = *(float_status *)vst;
|
||||||
|
+ fpst_f16 = env->vfp.fp_status_f16;
|
||||||
|
+ fpst_std = env->vfp.fp_status;
|
||||||
|
set_default_nan_mode(true, &fpst_std);
|
||||||
|
+ set_default_nan_mode(true, &fpst_f16);
|
||||||
|
fpst_odd = fpst_std;
|
||||||
|
set_float_rounding_mode(float_round_to_odd, &fpst_odd);
|
||||||
|
|
||||||
|
@@ -1036,7 +1050,8 @@ void HELPER(sme_fmopa_h)(void *vza, void *vzn, void *vzm, void *vpn,
|
||||||
|
uint32_t m = *(uint32_t *)(vzm + H1_4(col));
|
||||||
|
|
||||||
|
m = f16mop_adj_pair(m, pcol, 0);
|
||||||
|
- *a = f16_dotadd(*a, n, m, &fpst_std, &fpst_odd);
|
||||||
|
+ *a = f16_dotadd(*a, n, m,
|
||||||
|
+ &fpst_f16, &fpst_std, &fpst_odd);
|
||||||
|
}
|
||||||
|
col += 4;
|
||||||
|
pcol >>= 4;
|
||||||
|
diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c
|
||||||
|
index a50a419af2..ae42ddef7b 100644
|
||||||
|
--- a/target/arm/tcg/translate-sme.c
|
||||||
|
+++ b/target/arm/tcg/translate-sme.c
|
||||||
|
@@ -334,8 +334,29 @@ static bool do_outprod_fpst(DisasContext *s, arg_op *a, MemOp esz,
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
-TRANS_FEAT(FMOPA_h, aa64_sme, do_outprod_fpst, a,
|
||||||
|
- MO_32, FPST_FPCR_F16, gen_helper_sme_fmopa_h)
|
||||||
|
+static bool do_outprod_env(DisasContext *s, arg_op *a, MemOp esz,
|
||||||
|
+ gen_helper_gvec_5_ptr *fn)
|
||||||
|
+{
|
||||||
|
+ int svl = streaming_vec_reg_size(s);
|
||||||
|
+ uint32_t desc = simd_desc(svl, svl, a->sub);
|
||||||
|
+ TCGv_ptr za, zn, zm, pn, pm;
|
||||||
|
+
|
||||||
|
+ if (!sme_smza_enabled_check(s)) {
|
||||||
|
+ return true;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ za = get_tile(s, esz, a->zad);
|
||||||
|
+ zn = vec_full_reg_ptr(s, a->zn);
|
||||||
|
+ zm = vec_full_reg_ptr(s, a->zm);
|
||||||
|
+ pn = pred_full_reg_ptr(s, a->pn);
|
||||||
|
+ pm = pred_full_reg_ptr(s, a->pm);
|
||||||
|
+
|
||||||
|
+ fn(za, zn, zm, pn, pm, tcg_env, tcg_constant_i32(desc));
|
||||||
|
+ return true;
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+TRANS_FEAT(FMOPA_h, aa64_sme, do_outprod_env, a,
|
||||||
|
+ MO_32, gen_helper_sme_fmopa_h)
|
||||||
|
TRANS_FEAT(FMOPA_s, aa64_sme, do_outprod_fpst, a,
|
||||||
|
MO_32, FPST_FPCR, gen_helper_sme_fmopa_s)
|
||||||
|
TRANS_FEAT(FMOPA_d, aa64_sme_f64f64, do_outprod_fpst, a,
|
39
debian/patches/extra/0027-intel_iommu-fix-FRCD-construction-macro.patch
vendored
Normal file
39
debian/patches/extra/0027-intel_iommu-fix-FRCD-construction-macro.patch
vendored
Normal file
@@ -0,0 +1,39 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: =?UTF-8?q?Cl=C3=A9ment=20Mathieu--Drif?=
|
||||||
|
<clement.mathieu--drif@eviden.com>
|
||||||
|
Date: Tue, 9 Jul 2024 14:26:08 +0000
|
||||||
|
Subject: [PATCH] intel_iommu: fix FRCD construction macro
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
The constant must be unsigned, otherwise the two's complement
|
||||||
|
overrides the other fields when a PASID is present.
|
||||||
|
|
||||||
|
Fixes: 1b2b12376c8a ("intel-iommu: PASID support")
|
||||||
|
Signed-off-by: Clément Mathieu--Drif <clement.mathieu--drif@eviden.com>
|
||||||
|
Reviewed-by: Yi Liu <yi.l.liu@intel.com>
|
||||||
|
Reviewed-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
|
||||||
|
Reviewed-by: Minwoo Im <minwoo.im@samsung.com>
|
||||||
|
Message-Id: <20240709142557.317271-2-clement.mathieu--drif@eviden.com>
|
||||||
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
||||||
|
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
||||||
|
(cherry picked from commit a3c8d7e38550c3d5a46e6fa94ffadfa625a4861d)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
hw/i386/intel_iommu_internal.h | 2 +-
|
||||||
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h
|
||||||
|
index f8cf99bddf..cbc4030031 100644
|
||||||
|
--- a/hw/i386/intel_iommu_internal.h
|
||||||
|
+++ b/hw/i386/intel_iommu_internal.h
|
||||||
|
@@ -267,7 +267,7 @@
|
||||||
|
/* For the low 64-bit of 128-bit */
|
||||||
|
#define VTD_FRCD_FI(val) ((val) & ~0xfffULL)
|
||||||
|
#define VTD_FRCD_PV(val) (((val) & 0xffffULL) << 40)
|
||||||
|
-#define VTD_FRCD_PP(val) (((val) & 0x1) << 31)
|
||||||
|
+#define VTD_FRCD_PP(val) (((val) & 0x1ULL) << 31)
|
||||||
|
#define VTD_FRCD_IR_IDX(val) (((val) & 0xffffULL) << 48)
|
||||||
|
|
||||||
|
/* DMA Remapping Fault Conditions */
|
33
debian/patches/extra/0028-target-i386-Do-not-apply-REX-to-MMX-operands.patch
vendored
Normal file
33
debian/patches/extra/0028-target-i386-Do-not-apply-REX-to-MMX-operands.patch
vendored
Normal file
@@ -0,0 +1,33 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Richard Henderson <richard.henderson@linaro.org>
|
||||||
|
Date: Mon, 12 Aug 2024 12:58:42 +1000
|
||||||
|
Subject: [PATCH] target/i386: Do not apply REX to MMX operands
|
||||||
|
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Fixes: b3e22b2318a ("target/i386: add core of new i386 decoder")
|
||||||
|
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2495
|
||||||
|
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
|
||||||
|
Link: https://lore.kernel.org/r/20240812025844.58956-2-richard.henderson@linaro.org
|
||||||
|
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
||||||
|
(cherry picked from commit 416f2b16c02c618c0f233372ebfe343f9ee667d4)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
target/i386/tcg/decode-new.c.inc | 5 ++++-
|
||||||
|
1 file changed, 4 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.c.inc
|
||||||
|
index 4209d59ca8..09b8d2314a 100644
|
||||||
|
--- a/target/i386/tcg/decode-new.c.inc
|
||||||
|
+++ b/target/i386/tcg/decode-new.c.inc
|
||||||
|
@@ -1271,7 +1271,10 @@ static bool decode_op(DisasContext *s, CPUX86State *env, X86DecodedInsn *decode,
|
||||||
|
op->unit = X86_OP_SSE;
|
||||||
|
}
|
||||||
|
get_reg:
|
||||||
|
- op->n = ((get_modrm(s, env) >> 3) & 7) | REX_R(s);
|
||||||
|
+ op->n = ((get_modrm(s, env) >> 3) & 7);
|
||||||
|
+ if (op->unit != X86_OP_MMX) {
|
||||||
|
+ op->n |= REX_R(s);
|
||||||
|
+ }
|
||||||
|
break;
|
||||||
|
|
||||||
|
case X86_TYPE_E: /* ALU modrm operand */
|
42
debian/patches/extra/0029-module-Prevent-crash-by-resetting-local_err-in-modul.patch
vendored
Normal file
42
debian/patches/extra/0029-module-Prevent-crash-by-resetting-local_err-in-modul.patch
vendored
Normal file
@@ -0,0 +1,42 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
|
||||||
|
Date: Fri, 9 Aug 2024 14:13:40 +0200
|
||||||
|
Subject: [PATCH] module: Prevent crash by resetting local_err in
|
||||||
|
module_load_qom_all()
|
||||||
|
|
||||||
|
Set local_err to NULL after it has been freed in error_report_err(). This
|
||||||
|
avoids triggering assert(*errp == NULL) failure in error_setv() when
|
||||||
|
local_err is reused in the loop.
|
||||||
|
|
||||||
|
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
|
||||||
|
Reviewed-by: Claudio Fontana <cfontana@suse.de>
|
||||||
|
Reviewed-by: Denis V. Lunev <den@openvz.org>
|
||||||
|
Link: https://lore.kernel.org/r/20240809121340.992049-2-alexander.ivanov@virtuozzo.com
|
||||||
|
[Do the same by moving the declaration instead. - Paolo]
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
||||||
|
(cherry picked from commit 940d802b24e63650e0eacad3714e2ce171cba17c)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
util/module.c | 2 +-
|
||||||
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/util/module.c b/util/module.c
|
||||||
|
index 32e263163c..3eb0f06df1 100644
|
||||||
|
--- a/util/module.c
|
||||||
|
+++ b/util/module.c
|
||||||
|
@@ -354,13 +354,13 @@ int module_load_qom(const char *type, Error **errp)
|
||||||
|
void module_load_qom_all(void)
|
||||||
|
{
|
||||||
|
const QemuModinfo *modinfo;
|
||||||
|
- Error *local_err = NULL;
|
||||||
|
|
||||||
|
if (module_loaded_qom_all) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
for (modinfo = module_info; modinfo->name != NULL; modinfo++) {
|
||||||
|
+ Error *local_err = NULL;
|
||||||
|
if (!modinfo->objs) {
|
||||||
|
continue;
|
||||||
|
}
|
164
debian/patches/extra/0030-nbd-server-Plumb-in-new-args-to-nbd_client_add.patch
vendored
Normal file
164
debian/patches/extra/0030-nbd-server-Plumb-in-new-args-to-nbd_client_add.patch
vendored
Normal file
@@ -0,0 +1,164 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Eric Blake <eblake@redhat.com>
|
||||||
|
Date: Wed, 7 Aug 2024 08:50:01 -0500
|
||||||
|
Subject: [PATCH] nbd/server: Plumb in new args to nbd_client_add()
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
Upcoming patches to fix a CVE need to track an opaque pointer passed
|
||||||
|
in by the owner of a client object, as well as request for a time
|
||||||
|
limit on how fast negotiation must complete. Prepare for that by
|
||||||
|
changing the signature of nbd_client_new() and adding an accessor to
|
||||||
|
get at the opaque pointer, although for now the two servers
|
||||||
|
(qemu-nbd.c and blockdev-nbd.c) do not change behavior even though
|
||||||
|
they pass in a new default timeout value.
|
||||||
|
|
||||||
|
Suggested-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
|
||||||
|
Signed-off-by: Eric Blake <eblake@redhat.com>
|
||||||
|
Message-ID: <20240807174943.771624-11-eblake@redhat.com>
|
||||||
|
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
|
||||||
|
[eblake: s/LIMIT/MAX_SECS/ as suggested by Dan]
|
||||||
|
Signed-off-by: Eric Blake <eblake@redhat.com>
|
||||||
|
(cherry picked from commit fb1c2aaa981e0a2fa6362c9985f1296b74f055ac)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
blockdev-nbd.c | 6 ++++--
|
||||||
|
include/block/nbd.h | 11 ++++++++++-
|
||||||
|
nbd/server.c | 20 +++++++++++++++++---
|
||||||
|
qemu-nbd.c | 4 +++-
|
||||||
|
4 files changed, 34 insertions(+), 7 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/blockdev-nbd.c b/blockdev-nbd.c
|
||||||
|
index 213012435f..267a1de903 100644
|
||||||
|
--- a/blockdev-nbd.c
|
||||||
|
+++ b/blockdev-nbd.c
|
||||||
|
@@ -64,8 +64,10 @@ static void nbd_accept(QIONetListener *listener, QIOChannelSocket *cioc,
|
||||||
|
nbd_update_server_watch(nbd_server);
|
||||||
|
|
||||||
|
qio_channel_set_name(QIO_CHANNEL(cioc), "nbd-server");
|
||||||
|
- nbd_client_new(cioc, nbd_server->tlscreds, nbd_server->tlsauthz,
|
||||||
|
- nbd_blockdev_client_closed);
|
||||||
|
+ /* TODO - expose handshake timeout as QMP option */
|
||||||
|
+ nbd_client_new(cioc, NBD_DEFAULT_HANDSHAKE_MAX_SECS,
|
||||||
|
+ nbd_server->tlscreds, nbd_server->tlsauthz,
|
||||||
|
+ nbd_blockdev_client_closed, NULL);
|
||||||
|
}
|
||||||
|
|
||||||
|
static void nbd_update_server_watch(NBDServerData *s)
|
||||||
|
diff --git a/include/block/nbd.h b/include/block/nbd.h
|
||||||
|
index 4e7bd6342f..1d4d65922d 100644
|
||||||
|
--- a/include/block/nbd.h
|
||||||
|
+++ b/include/block/nbd.h
|
||||||
|
@@ -33,6 +33,12 @@ typedef struct NBDMetaContexts NBDMetaContexts;
|
||||||
|
|
||||||
|
extern const BlockExportDriver blk_exp_nbd;
|
||||||
|
|
||||||
|
+/*
|
||||||
|
+ * NBD_DEFAULT_HANDSHAKE_MAX_SECS: Number of seconds in which client must
|
||||||
|
+ * succeed at NBD_OPT_GO before being forcefully dropped as too slow.
|
||||||
|
+ */
|
||||||
|
+#define NBD_DEFAULT_HANDSHAKE_MAX_SECS 10
|
||||||
|
+
|
||||||
|
/* Handshake phase structs - this struct is passed on the wire */
|
||||||
|
|
||||||
|
typedef struct NBDOption {
|
||||||
|
@@ -403,9 +409,12 @@ AioContext *nbd_export_aio_context(NBDExport *exp);
|
||||||
|
NBDExport *nbd_export_find(const char *name);
|
||||||
|
|
||||||
|
void nbd_client_new(QIOChannelSocket *sioc,
|
||||||
|
+ uint32_t handshake_max_secs,
|
||||||
|
QCryptoTLSCreds *tlscreds,
|
||||||
|
const char *tlsauthz,
|
||||||
|
- void (*close_fn)(NBDClient *, bool));
|
||||||
|
+ void (*close_fn)(NBDClient *, bool),
|
||||||
|
+ void *owner);
|
||||||
|
+void *nbd_client_owner(NBDClient *client);
|
||||||
|
void nbd_client_get(NBDClient *client);
|
||||||
|
void nbd_client_put(NBDClient *client);
|
||||||
|
|
||||||
|
diff --git a/nbd/server.c b/nbd/server.c
|
||||||
|
index 892797bb11..e50012499f 100644
|
||||||
|
--- a/nbd/server.c
|
||||||
|
+++ b/nbd/server.c
|
||||||
|
@@ -124,12 +124,14 @@ struct NBDMetaContexts {
|
||||||
|
struct NBDClient {
|
||||||
|
int refcount; /* atomic */
|
||||||
|
void (*close_fn)(NBDClient *client, bool negotiated);
|
||||||
|
+ void *owner;
|
||||||
|
|
||||||
|
QemuMutex lock;
|
||||||
|
|
||||||
|
NBDExport *exp;
|
||||||
|
QCryptoTLSCreds *tlscreds;
|
||||||
|
char *tlsauthz;
|
||||||
|
+ uint32_t handshake_max_secs;
|
||||||
|
QIOChannelSocket *sioc; /* The underlying data channel */
|
||||||
|
QIOChannel *ioc; /* The current I/O channel which may differ (eg TLS) */
|
||||||
|
|
||||||
|
@@ -3191,6 +3193,7 @@ static coroutine_fn void nbd_co_client_start(void *opaque)
|
||||||
|
|
||||||
|
qemu_co_mutex_init(&client->send_lock);
|
||||||
|
|
||||||
|
+ /* TODO - utilize client->handshake_max_secs */
|
||||||
|
if (nbd_negotiate(client, &local_err)) {
|
||||||
|
if (local_err) {
|
||||||
|
error_report_err(local_err);
|
||||||
|
@@ -3205,14 +3208,17 @@ static coroutine_fn void nbd_co_client_start(void *opaque)
|
||||||
|
}
|
||||||
|
|
||||||
|
/*
|
||||||
|
- * Create a new client listener using the given channel @sioc.
|
||||||
|
+ * Create a new client listener using the given channel @sioc and @owner.
|
||||||
|
* Begin servicing it in a coroutine. When the connection closes, call
|
||||||
|
- * @close_fn with an indication of whether the client completed negotiation.
|
||||||
|
+ * @close_fn with an indication of whether the client completed negotiation
|
||||||
|
+ * within @handshake_max_secs seconds (0 for unbounded).
|
||||||
|
*/
|
||||||
|
void nbd_client_new(QIOChannelSocket *sioc,
|
||||||
|
+ uint32_t handshake_max_secs,
|
||||||
|
QCryptoTLSCreds *tlscreds,
|
||||||
|
const char *tlsauthz,
|
||||||
|
- void (*close_fn)(NBDClient *, bool))
|
||||||
|
+ void (*close_fn)(NBDClient *, bool),
|
||||||
|
+ void *owner)
|
||||||
|
{
|
||||||
|
NBDClient *client;
|
||||||
|
Coroutine *co;
|
||||||
|
@@ -3225,13 +3231,21 @@ void nbd_client_new(QIOChannelSocket *sioc,
|
||||||
|
object_ref(OBJECT(client->tlscreds));
|
||||||
|
}
|
||||||
|
client->tlsauthz = g_strdup(tlsauthz);
|
||||||
|
+ client->handshake_max_secs = handshake_max_secs;
|
||||||
|
client->sioc = sioc;
|
||||||
|
qio_channel_set_delay(QIO_CHANNEL(sioc), false);
|
||||||
|
object_ref(OBJECT(client->sioc));
|
||||||
|
client->ioc = QIO_CHANNEL(sioc);
|
||||||
|
object_ref(OBJECT(client->ioc));
|
||||||
|
client->close_fn = close_fn;
|
||||||
|
+ client->owner = owner;
|
||||||
|
|
||||||
|
co = qemu_coroutine_create(nbd_co_client_start, client);
|
||||||
|
qemu_coroutine_enter(co);
|
||||||
|
}
|
||||||
|
+
|
||||||
|
+void *
|
||||||
|
+nbd_client_owner(NBDClient *client)
|
||||||
|
+{
|
||||||
|
+ return client->owner;
|
||||||
|
+}
|
||||||
|
diff --git a/qemu-nbd.c b/qemu-nbd.c
|
||||||
|
index d7b3ccab21..48e2fa5858 100644
|
||||||
|
--- a/qemu-nbd.c
|
||||||
|
+++ b/qemu-nbd.c
|
||||||
|
@@ -390,7 +390,9 @@ static void nbd_accept(QIONetListener *listener, QIOChannelSocket *cioc,
|
||||||
|
|
||||||
|
nb_fds++;
|
||||||
|
nbd_update_server_watch();
|
||||||
|
- nbd_client_new(cioc, tlscreds, tlsauthz, nbd_client_closed);
|
||||||
|
+ /* TODO - expose handshake timeout as command line option */
|
||||||
|
+ nbd_client_new(cioc, NBD_DEFAULT_HANDSHAKE_MAX_SECS,
|
||||||
|
+ tlscreds, tlsauthz, nbd_client_closed, NULL);
|
||||||
|
}
|
||||||
|
|
||||||
|
static void nbd_update_server_watch(void)
|
172
debian/patches/extra/0031-nbd-server-CVE-2024-7409-Cap-default-max-connections.patch
vendored
Normal file
172
debian/patches/extra/0031-nbd-server-CVE-2024-7409-Cap-default-max-connections.patch
vendored
Normal file
@@ -0,0 +1,172 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Eric Blake <eblake@redhat.com>
|
||||||
|
Date: Tue, 6 Aug 2024 13:53:00 -0500
|
||||||
|
Subject: [PATCH] nbd/server: CVE-2024-7409: Cap default max-connections to 100
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
Allowing an unlimited number of clients to any web service is a recipe
|
||||||
|
for a rudimentary denial of service attack: the client merely needs to
|
||||||
|
open lots of sockets without closing them, until qemu no longer has
|
||||||
|
any more fds available to allocate.
|
||||||
|
|
||||||
|
For qemu-nbd, we default to allowing only 1 connection unless more are
|
||||||
|
explicitly asked for (-e or --shared); this was historically picked as
|
||||||
|
a nice default (without an explicit -t, a non-persistent qemu-nbd goes
|
||||||
|
away after a client disconnects, without needing any additional
|
||||||
|
follow-up commands), and we are not going to change that interface now
|
||||||
|
(besides, someday we want to point people towards qemu-storage-daemon
|
||||||
|
instead of qemu-nbd).
|
||||||
|
|
||||||
|
But for qemu proper, and the newer qemu-storage-daemon, the QMP
|
||||||
|
nbd-server-start command has historically had a default of unlimited
|
||||||
|
number of connections, in part because unlike qemu-nbd it is
|
||||||
|
inherently persistent until nbd-server-stop. Allowing multiple client
|
||||||
|
sockets is particularly useful for clients that can take advantage of
|
||||||
|
MULTI_CONN (creating parallel sockets to increase throughput),
|
||||||
|
although known clients that do so (such as libnbd's nbdcopy) typically
|
||||||
|
use only 8 or 16 connections (the benefits of scaling diminish once
|
||||||
|
more sockets are competing for kernel attention). Picking a number
|
||||||
|
large enough for typical use cases, but not unlimited, makes it
|
||||||
|
slightly harder for a malicious client to perform a denial of service
|
||||||
|
merely by opening lots of connections withot progressing through the
|
||||||
|
handshake.
|
||||||
|
|
||||||
|
This change does not eliminate CVE-2024-7409 on its own, but reduces
|
||||||
|
the chance for fd exhaustion or unlimited memory usage as an attack
|
||||||
|
surface. On the other hand, by itself, it makes it more obvious that
|
||||||
|
with a finite limit, we have the problem of an unauthenticated client
|
||||||
|
holding 100 fds opened as a way to block out a legitimate client from
|
||||||
|
being able to connect; thus, later patches will further add timeouts
|
||||||
|
to reject clients that are not making progress.
|
||||||
|
|
||||||
|
This is an INTENTIONAL change in behavior, and will break any client
|
||||||
|
of nbd-server-start that was not passing an explicit max-connections
|
||||||
|
parameter, yet expects more than 100 simultaneous connections. We are
|
||||||
|
not aware of any such client (as stated above, most clients aware of
|
||||||
|
MULTI_CONN get by just fine on 8 or 16 connections, and probably cope
|
||||||
|
with later connections failing by relying on the earlier connections;
|
||||||
|
libvirt has not yet been passing max-connections, but generally
|
||||||
|
creates NBD servers with the intent for a single client for the sake
|
||||||
|
of live storage migration; meanwhile, the KubeSAN project anticipates
|
||||||
|
a large cluster sharing multiple clients [up to 8 per node, and up to
|
||||||
|
100 nodes in a cluster], but it currently uses qemu-nbd with an
|
||||||
|
explicit --shared=0 rather than qemu-storage-daemon with
|
||||||
|
nbd-server-start).
|
||||||
|
|
||||||
|
We considered using a deprecation period (declare that omitting
|
||||||
|
max-parameters is deprecated, and make it mandatory in 3 releases -
|
||||||
|
then we don't need to pick an arbitrary default); that has zero risk
|
||||||
|
of breaking any apps that accidentally depended on more than 100
|
||||||
|
connections, and where such breakage might not be noticed under unit
|
||||||
|
testing but only under the larger loads of production usage. But it
|
||||||
|
does not close the denial-of-service hole until far into the future,
|
||||||
|
and requires all apps to change to add the parameter even if 100 was
|
||||||
|
good enough. It also has a drawback that any app (like libvirt) that
|
||||||
|
is accidentally relying on an unlimited default should seriously
|
||||||
|
consider their own CVE now, at which point they are going to change to
|
||||||
|
pass explicit max-connections sooner than waiting for 3 qemu releases.
|
||||||
|
Finally, if our changed default breaks an app, that app can always
|
||||||
|
pass in an explicit max-parameters with a larger value.
|
||||||
|
|
||||||
|
It is also intentional that the HMP interface to nbd-server-start is
|
||||||
|
not changed to expose max-connections (any client needing to fine-tune
|
||||||
|
things should be using QMP).
|
||||||
|
|
||||||
|
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
|
||||||
|
Signed-off-by: Eric Blake <eblake@redhat.com>
|
||||||
|
Message-ID: <20240807174943.771624-12-eblake@redhat.com>
|
||||||
|
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
|
||||||
|
[ericb: Expand commit message to summarize Dan's argument for why we
|
||||||
|
break corner-case back-compat behavior without a deprecation period]
|
||||||
|
Signed-off-by: Eric Blake <eblake@redhat.com>
|
||||||
|
(cherry picked from commit c8a76dbd90c2f48df89b75bef74917f90a59b623)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
block/monitor/block-hmp-cmds.c | 3 ++-
|
||||||
|
blockdev-nbd.c | 8 ++++++++
|
||||||
|
include/block/nbd.h | 7 +++++++
|
||||||
|
qapi/block-export.json | 4 ++--
|
||||||
|
4 files changed, 19 insertions(+), 3 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/monitor/block-hmp-cmds.c b/block/monitor/block-hmp-cmds.c
|
||||||
|
index d954bec6f1..bdf2eb50b6 100644
|
||||||
|
--- a/block/monitor/block-hmp-cmds.c
|
||||||
|
+++ b/block/monitor/block-hmp-cmds.c
|
||||||
|
@@ -402,7 +402,8 @@ void hmp_nbd_server_start(Monitor *mon, const QDict *qdict)
|
||||||
|
goto exit;
|
||||||
|
}
|
||||||
|
|
||||||
|
- nbd_server_start(addr, NULL, NULL, 0, &local_err);
|
||||||
|
+ nbd_server_start(addr, NULL, NULL, NBD_DEFAULT_MAX_CONNECTIONS,
|
||||||
|
+ &local_err);
|
||||||
|
qapi_free_SocketAddress(addr);
|
||||||
|
if (local_err != NULL) {
|
||||||
|
goto exit;
|
||||||
|
diff --git a/blockdev-nbd.c b/blockdev-nbd.c
|
||||||
|
index 267a1de903..24ba5382db 100644
|
||||||
|
--- a/blockdev-nbd.c
|
||||||
|
+++ b/blockdev-nbd.c
|
||||||
|
@@ -170,6 +170,10 @@ void nbd_server_start(SocketAddress *addr, const char *tls_creds,
|
||||||
|
|
||||||
|
void nbd_server_start_options(NbdServerOptions *arg, Error **errp)
|
||||||
|
{
|
||||||
|
+ if (!arg->has_max_connections) {
|
||||||
|
+ arg->max_connections = NBD_DEFAULT_MAX_CONNECTIONS;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
nbd_server_start(arg->addr, arg->tls_creds, arg->tls_authz,
|
||||||
|
arg->max_connections, errp);
|
||||||
|
}
|
||||||
|
@@ -182,6 +186,10 @@ void qmp_nbd_server_start(SocketAddressLegacy *addr,
|
||||||
|
{
|
||||||
|
SocketAddress *addr_flat = socket_address_flatten(addr);
|
||||||
|
|
||||||
|
+ if (!has_max_connections) {
|
||||||
|
+ max_connections = NBD_DEFAULT_MAX_CONNECTIONS;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
nbd_server_start(addr_flat, tls_creds, tls_authz, max_connections, errp);
|
||||||
|
qapi_free_SocketAddress(addr_flat);
|
||||||
|
}
|
||||||
|
diff --git a/include/block/nbd.h b/include/block/nbd.h
|
||||||
|
index 1d4d65922d..d4f8b21aec 100644
|
||||||
|
--- a/include/block/nbd.h
|
||||||
|
+++ b/include/block/nbd.h
|
||||||
|
@@ -39,6 +39,13 @@ extern const BlockExportDriver blk_exp_nbd;
|
||||||
|
*/
|
||||||
|
#define NBD_DEFAULT_HANDSHAKE_MAX_SECS 10
|
||||||
|
|
||||||
|
+/*
|
||||||
|
+ * NBD_DEFAULT_MAX_CONNECTIONS: Number of client sockets to allow at
|
||||||
|
+ * once; must be large enough to allow a MULTI_CONN-aware client like
|
||||||
|
+ * nbdcopy to create its typical number of 8-16 sockets.
|
||||||
|
+ */
|
||||||
|
+#define NBD_DEFAULT_MAX_CONNECTIONS 100
|
||||||
|
+
|
||||||
|
/* Handshake phase structs - this struct is passed on the wire */
|
||||||
|
|
||||||
|
typedef struct NBDOption {
|
||||||
|
diff --git a/qapi/block-export.json b/qapi/block-export.json
|
||||||
|
index 3919a2d5b9..f45e4fd481 100644
|
||||||
|
--- a/qapi/block-export.json
|
||||||
|
+++ b/qapi/block-export.json
|
||||||
|
@@ -28,7 +28,7 @@
|
||||||
|
# @max-connections: The maximum number of connections to allow at the
|
||||||
|
# same time, 0 for unlimited. Setting this to 1 also stops the
|
||||||
|
# server from advertising multiple client support (since 5.2;
|
||||||
|
-# default: 0)
|
||||||
|
+# default: 100)
|
||||||
|
#
|
||||||
|
# Since: 4.2
|
||||||
|
##
|
||||||
|
@@ -63,7 +63,7 @@
|
||||||
|
# @max-connections: The maximum number of connections to allow at the
|
||||||
|
# same time, 0 for unlimited. Setting this to 1 also stops the
|
||||||
|
# server from advertising multiple client support (since 5.2;
|
||||||
|
-# default: 0).
|
||||||
|
+# default: 100).
|
||||||
|
#
|
||||||
|
# Errors:
|
||||||
|
# - if the server is already running
|
123
debian/patches/extra/0032-nbd-server-CVE-2024-7409-Drop-non-negotiating-client.patch
vendored
Normal file
123
debian/patches/extra/0032-nbd-server-CVE-2024-7409-Drop-non-negotiating-client.patch
vendored
Normal file
@@ -0,0 +1,123 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Eric Blake <eblake@redhat.com>
|
||||||
|
Date: Thu, 8 Aug 2024 16:05:08 -0500
|
||||||
|
Subject: [PATCH] nbd/server: CVE-2024-7409: Drop non-negotiating clients
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
A client that opens a socket but does not negotiate is merely hogging
|
||||||
|
qemu's resources (an open fd and a small amount of memory); and a
|
||||||
|
malicious client that can access the port where NBD is listening can
|
||||||
|
attempt a denial of service attack by intentionally opening and
|
||||||
|
abandoning lots of unfinished connections. The previous patch put a
|
||||||
|
default bound on the number of such ongoing connections, but once that
|
||||||
|
limit is hit, no more clients can connect (including legitimate ones).
|
||||||
|
The solution is to insist that clients complete handshake within a
|
||||||
|
reasonable time limit, defaulting to 10 seconds. A client that has
|
||||||
|
not successfully completed NBD_OPT_GO by then (including the case of
|
||||||
|
where the client didn't know TLS credentials to even reach the point
|
||||||
|
of NBD_OPT_GO) is wasting our time and does not deserve to stay
|
||||||
|
connected. Later patches will allow fine-tuning the limit away from
|
||||||
|
the default value (including disabling it for doing integration
|
||||||
|
testing of the handshake process itself).
|
||||||
|
|
||||||
|
Note that this patch in isolation actually makes it more likely to see
|
||||||
|
qemu SEGV after nbd-server-stop, as any client socket still connected
|
||||||
|
when the server shuts down will now be closed after 10 seconds rather
|
||||||
|
than at the client's whims. That will be addressed in the next patch.
|
||||||
|
|
||||||
|
For a demo of this patch in action:
|
||||||
|
$ qemu-nbd -f raw -r -t -e 10 file &
|
||||||
|
$ nbdsh --opt-mode -c '
|
||||||
|
H = list()
|
||||||
|
for i in range(20):
|
||||||
|
print(i)
|
||||||
|
H.insert(i, nbd.NBD())
|
||||||
|
H[i].set_opt_mode(True)
|
||||||
|
H[i].connect_uri("nbd://localhost")
|
||||||
|
'
|
||||||
|
$ kill $!
|
||||||
|
|
||||||
|
where later connections get to start progressing once earlier ones are
|
||||||
|
forcefully dropped for taking too long, rather than hanging.
|
||||||
|
|
||||||
|
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
|
||||||
|
Signed-off-by: Eric Blake <eblake@redhat.com>
|
||||||
|
Message-ID: <20240807174943.771624-13-eblake@redhat.com>
|
||||||
|
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
|
||||||
|
[eblake: rebase to changes earlier in series, reduce scope of timer]
|
||||||
|
Signed-off-by: Eric Blake <eblake@redhat.com>
|
||||||
|
(cherry picked from commit b9b72cb3ce15b693148bd09cef7e50110566d8a0)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
nbd/server.c | 28 +++++++++++++++++++++++++++-
|
||||||
|
nbd/trace-events | 1 +
|
||||||
|
2 files changed, 28 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/nbd/server.c b/nbd/server.c
|
||||||
|
index e50012499f..39285cc971 100644
|
||||||
|
--- a/nbd/server.c
|
||||||
|
+++ b/nbd/server.c
|
||||||
|
@@ -3186,22 +3186,48 @@ static void nbd_client_receive_next_request(NBDClient *client)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
+static void nbd_handshake_timer_cb(void *opaque)
|
||||||
|
+{
|
||||||
|
+ QIOChannel *ioc = opaque;
|
||||||
|
+
|
||||||
|
+ trace_nbd_handshake_timer_cb();
|
||||||
|
+ qio_channel_shutdown(ioc, QIO_CHANNEL_SHUTDOWN_BOTH, NULL);
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
static coroutine_fn void nbd_co_client_start(void *opaque)
|
||||||
|
{
|
||||||
|
NBDClient *client = opaque;
|
||||||
|
Error *local_err = NULL;
|
||||||
|
+ QEMUTimer *handshake_timer = NULL;
|
||||||
|
|
||||||
|
qemu_co_mutex_init(&client->send_lock);
|
||||||
|
|
||||||
|
- /* TODO - utilize client->handshake_max_secs */
|
||||||
|
+ /*
|
||||||
|
+ * Create a timer to bound the time spent in negotiation. If the
|
||||||
|
+ * timer expires, it is likely nbd_negotiate will fail because the
|
||||||
|
+ * socket was shutdown.
|
||||||
|
+ */
|
||||||
|
+ if (client->handshake_max_secs > 0) {
|
||||||
|
+ handshake_timer = aio_timer_new(qemu_get_aio_context(),
|
||||||
|
+ QEMU_CLOCK_REALTIME,
|
||||||
|
+ SCALE_NS,
|
||||||
|
+ nbd_handshake_timer_cb,
|
||||||
|
+ client->sioc);
|
||||||
|
+ timer_mod(handshake_timer,
|
||||||
|
+ qemu_clock_get_ns(QEMU_CLOCK_REALTIME) +
|
||||||
|
+ client->handshake_max_secs * NANOSECONDS_PER_SECOND);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
if (nbd_negotiate(client, &local_err)) {
|
||||||
|
if (local_err) {
|
||||||
|
error_report_err(local_err);
|
||||||
|
}
|
||||||
|
+ timer_free(handshake_timer);
|
||||||
|
client_close(client, false);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
+ timer_free(handshake_timer);
|
||||||
|
WITH_QEMU_LOCK_GUARD(&client->lock) {
|
||||||
|
nbd_client_receive_next_request(client);
|
||||||
|
}
|
||||||
|
diff --git a/nbd/trace-events b/nbd/trace-events
|
||||||
|
index 00ae3216a1..cbd0a4ab7e 100644
|
||||||
|
--- a/nbd/trace-events
|
||||||
|
+++ b/nbd/trace-events
|
||||||
|
@@ -76,6 +76,7 @@ nbd_co_receive_request_payload_received(uint64_t cookie, uint64_t len) "Payload
|
||||||
|
nbd_co_receive_ext_payload_compliance(uint64_t from, uint64_t len) "client sent non-compliant write without payload flag: from=0x%" PRIx64 ", len=0x%" PRIx64
|
||||||
|
nbd_co_receive_align_compliance(const char *op, uint64_t from, uint64_t len, uint32_t align) "client sent non-compliant unaligned %s request: from=0x%" PRIx64 ", len=0x%" PRIx64 ", align=0x%" PRIx32
|
||||||
|
nbd_trip(void) "Reading request"
|
||||||
|
+nbd_handshake_timer_cb(void) "client took too long to negotiate"
|
||||||
|
|
||||||
|
# client-connection.c
|
||||||
|
nbd_connect_thread_sleep(uint64_t timeout) "timeout %" PRIu64
|
161
debian/patches/extra/0033-nbd-server-CVE-2024-7409-Close-stray-clients-at-serv.patch
vendored
Normal file
161
debian/patches/extra/0033-nbd-server-CVE-2024-7409-Close-stray-clients-at-serv.patch
vendored
Normal file
@@ -0,0 +1,161 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Eric Blake <eblake@redhat.com>
|
||||||
|
Date: Wed, 7 Aug 2024 12:23:13 -0500
|
||||||
|
Subject: [PATCH] nbd/server: CVE-2024-7409: Close stray clients at server-stop
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
A malicious client can attempt to connect to an NBD server, and then
|
||||||
|
intentionally delay progress in the handshake, including if it does
|
||||||
|
not know the TLS secrets. Although the previous two patches reduce
|
||||||
|
this behavior by capping the default max-connections parameter and
|
||||||
|
killing slow clients, they did not eliminate the possibility of a
|
||||||
|
client waiting to close the socket until after the QMP nbd-server-stop
|
||||||
|
command is executed, at which point qemu would SEGV when trying to
|
||||||
|
dereference the NULL nbd_server global which is no longer present.
|
||||||
|
This amounts to a denial of service attack. Worse, if another NBD
|
||||||
|
server is started before the malicious client disconnects, I cannot
|
||||||
|
rule out additional adverse effects when the old client interferes
|
||||||
|
with the connection count of the new server (although the most likely
|
||||||
|
is a crash due to an assertion failure when checking
|
||||||
|
nbd_server->connections > 0).
|
||||||
|
|
||||||
|
For environments without this patch, the CVE can be mitigated by
|
||||||
|
ensuring (such as via a firewall) that only trusted clients can
|
||||||
|
connect to an NBD server. Note that using frameworks like libvirt
|
||||||
|
that ensure that TLS is used and that nbd-server-stop is not executed
|
||||||
|
while any trusted clients are still connected will only help if there
|
||||||
|
is also no possibility for an untrusted client to open a connection
|
||||||
|
but then stall on the NBD handshake.
|
||||||
|
|
||||||
|
Given the previous patches, it would be possible to guarantee that no
|
||||||
|
clients remain connected by having nbd-server-stop sleep for longer
|
||||||
|
than the default handshake deadline before finally freeing the global
|
||||||
|
nbd_server object, but that could make QMP non-responsive for a long
|
||||||
|
time. So intead, this patch fixes the problem by tracking all client
|
||||||
|
sockets opened while the server is running, and forcefully closing any
|
||||||
|
such sockets remaining without a completed handshake at the time of
|
||||||
|
nbd-server-stop, then waiting until the coroutines servicing those
|
||||||
|
sockets notice the state change. nbd-server-stop now has a second
|
||||||
|
AIO_WAIT_WHILE_UNLOCKED (the first is indirectly through the
|
||||||
|
blk_exp_close_all_type() that disconnects all clients that completed
|
||||||
|
handshakes), but forced socket shutdown is enough to progress the
|
||||||
|
coroutines and quickly tear down all clients before the server is
|
||||||
|
freed, thus finally fixing the CVE.
|
||||||
|
|
||||||
|
This patch relies heavily on the fact that nbd/server.c guarantees
|
||||||
|
that it only calls nbd_blockdev_client_closed() from the main loop
|
||||||
|
(see the assertion in nbd_client_put() and the hoops used in
|
||||||
|
nbd_client_put_nonzero() to achieve that); if we did not have that
|
||||||
|
guarantee, we would also need a mutex protecting our accesses of the
|
||||||
|
list of connections to survive re-entrancy from independent iothreads.
|
||||||
|
|
||||||
|
Although I did not actually try to test old builds, it looks like this
|
||||||
|
problem has existed since at least commit 862172f45c (v2.12.0, 2017) -
|
||||||
|
even back when that patch started using a QIONetListener to handle
|
||||||
|
listening on multiple sockets, nbd_server_free() was already unaware
|
||||||
|
that the nbd_blockdev_client_closed callback can be reached later by a
|
||||||
|
client thread that has not completed handshakes (and therefore the
|
||||||
|
client's socket never got added to the list closed in
|
||||||
|
nbd_export_close_all), despite that patch intentionally tearing down
|
||||||
|
the QIONetListener to prevent new clients.
|
||||||
|
|
||||||
|
Reported-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
|
||||||
|
Fixes: CVE-2024-7409
|
||||||
|
CC: qemu-stable@nongnu.org
|
||||||
|
Signed-off-by: Eric Blake <eblake@redhat.com>
|
||||||
|
Message-ID: <20240807174943.771624-14-eblake@redhat.com>
|
||||||
|
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
|
||||||
|
(cherry picked from commit 3e7ef738c8462c45043a1d39f702a0990406a3b3)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
blockdev-nbd.c | 35 ++++++++++++++++++++++++++++++++++-
|
||||||
|
1 file changed, 34 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/blockdev-nbd.c b/blockdev-nbd.c
|
||||||
|
index 24ba5382db..f73409ae49 100644
|
||||||
|
--- a/blockdev-nbd.c
|
||||||
|
+++ b/blockdev-nbd.c
|
||||||
|
@@ -21,12 +21,18 @@
|
||||||
|
#include "io/channel-socket.h"
|
||||||
|
#include "io/net-listener.h"
|
||||||
|
|
||||||
|
+typedef struct NBDConn {
|
||||||
|
+ QIOChannelSocket *cioc;
|
||||||
|
+ QLIST_ENTRY(NBDConn) next;
|
||||||
|
+} NBDConn;
|
||||||
|
+
|
||||||
|
typedef struct NBDServerData {
|
||||||
|
QIONetListener *listener;
|
||||||
|
QCryptoTLSCreds *tlscreds;
|
||||||
|
char *tlsauthz;
|
||||||
|
uint32_t max_connections;
|
||||||
|
uint32_t connections;
|
||||||
|
+ QLIST_HEAD(, NBDConn) conns;
|
||||||
|
} NBDServerData;
|
||||||
|
|
||||||
|
static NBDServerData *nbd_server;
|
||||||
|
@@ -51,6 +57,14 @@ int nbd_server_max_connections(void)
|
||||||
|
|
||||||
|
static void nbd_blockdev_client_closed(NBDClient *client, bool ignored)
|
||||||
|
{
|
||||||
|
+ NBDConn *conn = nbd_client_owner(client);
|
||||||
|
+
|
||||||
|
+ assert(qemu_in_main_thread() && nbd_server);
|
||||||
|
+
|
||||||
|
+ object_unref(OBJECT(conn->cioc));
|
||||||
|
+ QLIST_REMOVE(conn, next);
|
||||||
|
+ g_free(conn);
|
||||||
|
+
|
||||||
|
nbd_client_put(client);
|
||||||
|
assert(nbd_server->connections > 0);
|
||||||
|
nbd_server->connections--;
|
||||||
|
@@ -60,14 +74,20 @@ static void nbd_blockdev_client_closed(NBDClient *client, bool ignored)
|
||||||
|
static void nbd_accept(QIONetListener *listener, QIOChannelSocket *cioc,
|
||||||
|
gpointer opaque)
|
||||||
|
{
|
||||||
|
+ NBDConn *conn = g_new0(NBDConn, 1);
|
||||||
|
+
|
||||||
|
+ assert(qemu_in_main_thread() && nbd_server);
|
||||||
|
nbd_server->connections++;
|
||||||
|
+ object_ref(OBJECT(cioc));
|
||||||
|
+ conn->cioc = cioc;
|
||||||
|
+ QLIST_INSERT_HEAD(&nbd_server->conns, conn, next);
|
||||||
|
nbd_update_server_watch(nbd_server);
|
||||||
|
|
||||||
|
qio_channel_set_name(QIO_CHANNEL(cioc), "nbd-server");
|
||||||
|
/* TODO - expose handshake timeout as QMP option */
|
||||||
|
nbd_client_new(cioc, NBD_DEFAULT_HANDSHAKE_MAX_SECS,
|
||||||
|
nbd_server->tlscreds, nbd_server->tlsauthz,
|
||||||
|
- nbd_blockdev_client_closed, NULL);
|
||||||
|
+ nbd_blockdev_client_closed, conn);
|
||||||
|
}
|
||||||
|
|
||||||
|
static void nbd_update_server_watch(NBDServerData *s)
|
||||||
|
@@ -81,12 +101,25 @@ static void nbd_update_server_watch(NBDServerData *s)
|
||||||
|
|
||||||
|
static void nbd_server_free(NBDServerData *server)
|
||||||
|
{
|
||||||
|
+ NBDConn *conn, *tmp;
|
||||||
|
+
|
||||||
|
if (!server) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
+ /*
|
||||||
|
+ * Forcefully close the listener socket, and any clients that have
|
||||||
|
+ * not yet disconnected on their own.
|
||||||
|
+ */
|
||||||
|
qio_net_listener_disconnect(server->listener);
|
||||||
|
object_unref(OBJECT(server->listener));
|
||||||
|
+ QLIST_FOREACH_SAFE(conn, &server->conns, next, tmp) {
|
||||||
|
+ qio_channel_shutdown(QIO_CHANNEL(conn->cioc), QIO_CHANNEL_SHUTDOWN_BOTH,
|
||||||
|
+ NULL);
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ AIO_WAIT_WHILE_UNLOCKED(NULL, server->connections > 0);
|
||||||
|
+
|
||||||
|
if (server->tlscreds) {
|
||||||
|
object_unref(OBJECT(server->tlscreds));
|
||||||
|
}
|
47
debian/patches/extra/0034-vnc-fix-crash-when-no-console-attached.patch
vendored
Normal file
47
debian/patches/extra/0034-vnc-fix-crash-when-no-console-attached.patch
vendored
Normal file
@@ -0,0 +1,47 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@redhat.com>
|
||||||
|
Date: Tue, 20 Aug 2024 17:11:12 +0400
|
||||||
|
Subject: [PATCH] vnc: fix crash when no console attached
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
Since commit e99441a3793b5 ("ui/curses: Do not use console_select()")
|
||||||
|
qemu_text_console_put_keysym() no longer checks for NULL console
|
||||||
|
argument, which leads to a later crash:
|
||||||
|
|
||||||
|
Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault.
|
||||||
|
0x00005555559ee186 in qemu_text_console_handle_keysym (s=0x0, keysym=31) at ../ui/console-vc.c:332
|
||||||
|
332 } else if (s->echo && (keysym == '\r' || keysym == '\n')) {
|
||||||
|
(gdb) bt
|
||||||
|
#0 0x00005555559ee186 in qemu_text_console_handle_keysym (s=0x0, keysym=31) at ../ui/console-vc.c:332
|
||||||
|
#1 0x00005555559e18e5 in qemu_text_console_put_keysym (s=<optimized out>, keysym=<optimized out>) at ../ui/console.c:303
|
||||||
|
#2 0x00005555559f2e88 in do_key_event (vs=vs@entry=0x5555579045c0, down=down@entry=1, keycode=keycode@entry=60, sym=sym@entry=65471) at ../ui/vnc.c:2034
|
||||||
|
#3 0x00005555559f845c in ext_key_event (vs=0x5555579045c0, down=1, sym=65471, keycode=<optimized out>) at ../ui/vnc.c:2070
|
||||||
|
#4 protocol_client_msg (vs=0x5555579045c0, data=<optimized out>, len=<optimized out>) at ../ui/vnc.c:2514
|
||||||
|
#5 0x00005555559f515c in vnc_client_read (vs=0x5555579045c0) at ../ui/vnc.c:1607
|
||||||
|
|
||||||
|
Fixes: e99441a3793b5 ("ui/curses: Do not use console_select()")
|
||||||
|
Fixes: https://issues.redhat.com/browse/RHEL-50529
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
|
||||||
|
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
|
||||||
|
(picked from https://lore.kernel.org/qemu-devel/20240820131112.1267954-1-marcandre.lureau@redhat.com/)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
ui/vnc.c | 2 +-
|
||||||
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||||
|
|
||||||
|
diff --git a/ui/vnc.c b/ui/vnc.c
|
||||||
|
index b3fd78022b..953ea38318 100644
|
||||||
|
--- a/ui/vnc.c
|
||||||
|
+++ b/ui/vnc.c
|
||||||
|
@@ -1935,7 +1935,7 @@ static void do_key_event(VncState *vs, int down, int keycode, int sym)
|
||||||
|
}
|
||||||
|
|
||||||
|
qkbd_state_key_event(vs->vd->kbd, qcode, down);
|
||||||
|
- if (!qemu_console_is_graphic(vs->vd->dcl.con)) {
|
||||||
|
+ if (QEMU_IS_TEXT_CONSOLE(vs->vd->dcl.con)) {
|
||||||
|
QemuTextConsole *con = QEMU_TEXT_CONSOLE(vs->vd->dcl.con);
|
||||||
|
bool numlock = qkbd_state_modifier_get(vs->vd->kbd, QKBD_MOD_NUMLOCK);
|
||||||
|
bool control = qkbd_state_modifier_get(vs->vd->kbd, QKBD_MOD_CTRL);
|
89
debian/patches/extra/0035-nbd-server-CVE-2024-7409-Avoid-use-after-free-when-c.patch
vendored
Normal file
89
debian/patches/extra/0035-nbd-server-CVE-2024-7409-Avoid-use-after-free-when-c.patch
vendored
Normal file
@@ -0,0 +1,89 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Eric Blake <eblake@redhat.com>
|
||||||
|
Date: Thu, 22 Aug 2024 09:35:29 -0500
|
||||||
|
Subject: [PATCH] nbd/server: CVE-2024-7409: Avoid use-after-free when closing
|
||||||
|
server
|
||||||
|
|
||||||
|
Commit 3e7ef738 plugged the use-after-free of the global nbd_server
|
||||||
|
object, but overlooked a use-after-free of nbd_server->listener.
|
||||||
|
Although this race is harder to hit, notice that our shutdown path
|
||||||
|
first drops the reference count of nbd_server->listener, then triggers
|
||||||
|
actions that can result in a pending client reaching the
|
||||||
|
nbd_blockdev_client_closed() callback, which in turn calls
|
||||||
|
qio_net_listener_set_client_func on a potentially stale object.
|
||||||
|
|
||||||
|
If we know we don't want any more clients to connect, and have already
|
||||||
|
told the listener socket to shut down, then we should not be trying to
|
||||||
|
update the listener socket's associated function.
|
||||||
|
|
||||||
|
Reproducer:
|
||||||
|
|
||||||
|
> #!/usr/bin/python3
|
||||||
|
>
|
||||||
|
> import os
|
||||||
|
> from threading import Thread
|
||||||
|
>
|
||||||
|
> def start_stop():
|
||||||
|
> while 1:
|
||||||
|
> os.system('virsh qemu-monitor-command VM \'{"execute": "nbd-server-start",
|
||||||
|
+"arguments":{"addr":{"type":"unix","data":{"path":"/tmp/nbd-sock"}}}}\'')
|
||||||
|
> os.system('virsh qemu-monitor-command VM \'{"execute": "nbd-server-stop"}\'')
|
||||||
|
>
|
||||||
|
> def nbd_list():
|
||||||
|
> while 1:
|
||||||
|
> os.system('/path/to/build/qemu-nbd -L -k /tmp/nbd-sock')
|
||||||
|
>
|
||||||
|
> def test():
|
||||||
|
> sst = Thread(target=start_stop)
|
||||||
|
> sst.start()
|
||||||
|
> nlt = Thread(target=nbd_list)
|
||||||
|
> nlt.start()
|
||||||
|
>
|
||||||
|
> sst.join()
|
||||||
|
> nlt.join()
|
||||||
|
>
|
||||||
|
> test()
|
||||||
|
|
||||||
|
Fixes: CVE-2024-7409
|
||||||
|
Fixes: 3e7ef738c8 ("nbd/server: CVE-2024-7409: Close stray clients at server-stop")
|
||||||
|
CC: qemu-stable@nongnu.org
|
||||||
|
Reported-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
|
||||||
|
Signed-off-by: Eric Blake <eblake@redhat.com>
|
||||||
|
Message-ID: <20240822143617.800419-2-eblake@redhat.com>
|
||||||
|
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
|
||||||
|
(cherry picked from commit 3874f5f73c441c52f1c699c848d463b0eda01e4c)
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
blockdev-nbd.c | 12 ++++++++----
|
||||||
|
1 file changed, 8 insertions(+), 4 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/blockdev-nbd.c b/blockdev-nbd.c
|
||||||
|
index f73409ae49..b36f41b7c5 100644
|
||||||
|
--- a/blockdev-nbd.c
|
||||||
|
+++ b/blockdev-nbd.c
|
||||||
|
@@ -92,10 +92,13 @@ static void nbd_accept(QIONetListener *listener, QIOChannelSocket *cioc,
|
||||||
|
|
||||||
|
static void nbd_update_server_watch(NBDServerData *s)
|
||||||
|
{
|
||||||
|
- if (!s->max_connections || s->connections < s->max_connections) {
|
||||||
|
- qio_net_listener_set_client_func(s->listener, nbd_accept, NULL, NULL);
|
||||||
|
- } else {
|
||||||
|
- qio_net_listener_set_client_func(s->listener, NULL, NULL, NULL);
|
||||||
|
+ if (s->listener) {
|
||||||
|
+ if (!s->max_connections || s->connections < s->max_connections) {
|
||||||
|
+ qio_net_listener_set_client_func(s->listener, nbd_accept, NULL,
|
||||||
|
+ NULL);
|
||||||
|
+ } else {
|
||||||
|
+ qio_net_listener_set_client_func(s->listener, NULL, NULL, NULL);
|
||||||
|
+ }
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
@@ -113,6 +116,7 @@ static void nbd_server_free(NBDServerData *server)
|
||||||
|
*/
|
||||||
|
qio_net_listener_disconnect(server->listener);
|
||||||
|
object_unref(OBJECT(server->listener));
|
||||||
|
+ server->listener = NULL;
|
||||||
|
QLIST_FOREACH_SAFE(conn, &server->conns, next, tmp) {
|
||||||
|
qio_channel_shutdown(QIO_CHANNEL(conn->cioc), QIO_CHANNEL_SHUTDOWN_BOTH,
|
||||||
|
NULL);
|
134
debian/patches/extra/0036-softmmu-physmem-fix-memory-leak-in-dirty_memory_exte.patch
vendored
Normal file
134
debian/patches/extra/0036-softmmu-physmem-fix-memory-leak-in-dirty_memory_exte.patch
vendored
Normal file
@@ -0,0 +1,134 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: David Hildenbrand <david@redhat.com>
|
||||||
|
Date: Wed, 28 Aug 2024 11:07:43 +0200
|
||||||
|
Subject: [PATCH] softmmu/physmem: fix memory leak in dirty_memory_extend()
|
||||||
|
MIME-Version: 1.0
|
||||||
|
Content-Type: text/plain; charset=UTF-8
|
||||||
|
Content-Transfer-Encoding: 8bit
|
||||||
|
|
||||||
|
As reported by Peter, we might be leaking memory when removing the
|
||||||
|
highest RAMBlock (in the weird ram_addr_t space), and adding a new one.
|
||||||
|
|
||||||
|
We will fail to realize that we already allocated bitmaps for more
|
||||||
|
dirty memory blocks, and effectively discard the pointers to them.
|
||||||
|
|
||||||
|
Fix it by getting rid of last_ram_page() and by remembering the number
|
||||||
|
of dirty memory blocks that have been allocated already.
|
||||||
|
|
||||||
|
While at it, let's use "unsigned int" for the number of blocks, which
|
||||||
|
should be sufficient until we reach ~32 exabytes.
|
||||||
|
|
||||||
|
Looks like this leak was introduced as we switched from using a single
|
||||||
|
bitmap_zero_extend() to allocating multiple bitmaps:
|
||||||
|
bitmap_zero_extend() relies on g_renew() which should have taken care of
|
||||||
|
this.
|
||||||
|
|
||||||
|
Resolves: https://lkml.kernel.org/r/CAFEAcA-k7a+VObGAfCFNygQNfCKL=AfX6A4kScq=VSSK0peqPg@mail.gmail.com
|
||||||
|
Reported-by: Peter Maydell <peter.maydell@linaro.org>
|
||||||
|
Fixes: 5b82b703b69a ("memory: RCU ram_list.dirty_memory[] for safe RAM hotplug")
|
||||||
|
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
|
||||||
|
Reviewed-by: Peter Xu <peterx@redhat.com>
|
||||||
|
Tested-by: Peter Maydell <peter.maydell@linaro.org>
|
||||||
|
Cc: qemu-stable@nongnu.org
|
||||||
|
Cc: Stefan Hajnoczi <stefanha@redhat.com>
|
||||||
|
Cc: Paolo Bonzini <pbonzini@redhat.com>
|
||||||
|
Cc: Peter Xu <peterx@redhat.com>
|
||||||
|
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>
|
||||||
|
Signed-off-by: David Hildenbrand <david@redhat.com>
|
||||||
|
(picked from https://lore.kernel.org/qemu-devel/20240828090743.128647-1-david@redhat.com/)
|
||||||
|
[FE: backport - remove not-yet-existing variable in context of hunk touching ram_block_add()]
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
---
|
||||||
|
include/exec/ramlist.h | 1 +
|
||||||
|
system/physmem.c | 35 +++++++++--------------------------
|
||||||
|
2 files changed, 10 insertions(+), 26 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/include/exec/ramlist.h b/include/exec/ramlist.h
|
||||||
|
index 2ad2a81acc..d9cfe530be 100644
|
||||||
|
--- a/include/exec/ramlist.h
|
||||||
|
+++ b/include/exec/ramlist.h
|
||||||
|
@@ -50,6 +50,7 @@ typedef struct RAMList {
|
||||||
|
/* RCU-enabled, writes protected by the ramlist lock. */
|
||||||
|
QLIST_HEAD(, RAMBlock) blocks;
|
||||||
|
DirtyMemoryBlocks *dirty_memory[DIRTY_MEMORY_NUM];
|
||||||
|
+ unsigned int num_dirty_blocks;
|
||||||
|
uint32_t version;
|
||||||
|
QLIST_HEAD(, RAMBlockNotifier) ramblock_notifiers;
|
||||||
|
} RAMList;
|
||||||
|
diff --git a/system/physmem.c b/system/physmem.c
|
||||||
|
index a4fe3d2bf8..78f7db1121 100644
|
||||||
|
--- a/system/physmem.c
|
||||||
|
+++ b/system/physmem.c
|
||||||
|
@@ -1497,18 +1497,6 @@ static ram_addr_t find_ram_offset(ram_addr_t size)
|
||||||
|
return offset;
|
||||||
|
}
|
||||||
|
|
||||||
|
-static unsigned long last_ram_page(void)
|
||||||
|
-{
|
||||||
|
- RAMBlock *block;
|
||||||
|
- ram_addr_t last = 0;
|
||||||
|
-
|
||||||
|
- RCU_READ_LOCK_GUARD();
|
||||||
|
- RAMBLOCK_FOREACH(block) {
|
||||||
|
- last = MAX(last, block->offset + block->max_length);
|
||||||
|
- }
|
||||||
|
- return last >> TARGET_PAGE_BITS;
|
||||||
|
-}
|
||||||
|
-
|
||||||
|
static void qemu_ram_setup_dump(void *addr, ram_addr_t size)
|
||||||
|
{
|
||||||
|
int ret;
|
||||||
|
@@ -1762,13 +1750,11 @@ void qemu_ram_msync(RAMBlock *block, ram_addr_t start, ram_addr_t length)
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Called with ram_list.mutex held */
|
||||||
|
-static void dirty_memory_extend(ram_addr_t old_ram_size,
|
||||||
|
- ram_addr_t new_ram_size)
|
||||||
|
+static void dirty_memory_extend(ram_addr_t new_ram_size)
|
||||||
|
{
|
||||||
|
- ram_addr_t old_num_blocks = DIV_ROUND_UP(old_ram_size,
|
||||||
|
- DIRTY_MEMORY_BLOCK_SIZE);
|
||||||
|
- ram_addr_t new_num_blocks = DIV_ROUND_UP(new_ram_size,
|
||||||
|
- DIRTY_MEMORY_BLOCK_SIZE);
|
||||||
|
+ unsigned int old_num_blocks = ram_list.num_dirty_blocks;
|
||||||
|
+ unsigned int new_num_blocks = DIV_ROUND_UP(new_ram_size,
|
||||||
|
+ DIRTY_MEMORY_BLOCK_SIZE);
|
||||||
|
int i;
|
||||||
|
|
||||||
|
/* Only need to extend if block count increased */
|
||||||
|
@@ -1800,6 +1786,8 @@ static void dirty_memory_extend(ram_addr_t old_ram_size,
|
||||||
|
g_free_rcu(old_blocks, rcu);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
+
|
||||||
|
+ ram_list.num_dirty_blocks = new_num_blocks;
|
||||||
|
}
|
||||||
|
|
||||||
|
static void ram_block_add(RAMBlock *new_block, Error **errp)
|
||||||
|
@@ -1808,11 +1796,9 @@ static void ram_block_add(RAMBlock *new_block, Error **errp)
|
||||||
|
const bool shared = qemu_ram_is_shared(new_block);
|
||||||
|
RAMBlock *block;
|
||||||
|
RAMBlock *last_block = NULL;
|
||||||
|
- ram_addr_t old_ram_size, new_ram_size;
|
||||||
|
+ ram_addr_t ram_size;
|
||||||
|
Error *err = NULL;
|
||||||
|
|
||||||
|
- old_ram_size = last_ram_page();
|
||||||
|
-
|
||||||
|
qemu_mutex_lock_ramlist();
|
||||||
|
new_block->offset = find_ram_offset(new_block->max_length);
|
||||||
|
|
||||||
|
@@ -1840,11 +1826,8 @@ static void ram_block_add(RAMBlock *new_block, Error **errp)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
- new_ram_size = MAX(old_ram_size,
|
||||||
|
- (new_block->offset + new_block->max_length) >> TARGET_PAGE_BITS);
|
||||||
|
- if (new_ram_size > old_ram_size) {
|
||||||
|
- dirty_memory_extend(old_ram_size, new_ram_size);
|
||||||
|
- }
|
||||||
|
+ ram_size = (new_block->offset + new_block->max_length) >> TARGET_PAGE_BITS;
|
||||||
|
+ dirty_memory_extend(ram_size);
|
||||||
|
/* Keep the list sorted from biggest to smallest block. Unlike QTAILQ,
|
||||||
|
* QLIST (which has an RCU-friendly variant) does not have insertion at
|
||||||
|
* tail, so save the last element in last_block.
|
@@ -1,7 +1,7 @@
|
|||||||
Index: pve-qemu-kvm-9.2.0/block/meson.build
|
Index: pve-qemu-kvm-9.0.0/block/meson.build
|
||||||
===================================================================
|
===================================================================
|
||||||
--- pve-qemu-kvm-9.2.0.orig/block/meson.build
|
--- pve-qemu-kvm-9.0.0.orig/block/meson.build
|
||||||
+++ pve-qemu-kvm-9.2.0/block/meson.build
|
+++ pve-qemu-kvm-9.0.0/block/meson.build
|
||||||
@@ -126,6 +126,7 @@ foreach m : [
|
@@ -126,6 +126,7 @@ foreach m : [
|
||||||
[libnfs, 'nfs', files('nfs.c')],
|
[libnfs, 'nfs', files('nfs.c')],
|
||||||
[libssh, 'ssh', files('ssh.c')],
|
[libssh, 'ssh', files('ssh.c')],
|
||||||
@@ -10,11 +10,11 @@ Index: pve-qemu-kvm-9.2.0/block/meson.build
|
|||||||
]
|
]
|
||||||
if m[0].found()
|
if m[0].found()
|
||||||
module_ss = ss.source_set()
|
module_ss = ss.source_set()
|
||||||
Index: pve-qemu-kvm-9.2.0/meson.build
|
Index: pve-qemu-kvm-9.0.0/meson.build
|
||||||
===================================================================
|
===================================================================
|
||||||
--- pve-qemu-kvm-9.2.0.orig/meson.build
|
--- pve-qemu-kvm-9.0.0.orig/meson.build
|
||||||
+++ pve-qemu-kvm-9.2.0/meson.build
|
+++ pve-qemu-kvm-9.0.0/meson.build
|
||||||
@@ -1590,6 +1590,26 @@ if not get_option('rbd').auto() or have_
|
@@ -1452,6 +1452,26 @@ if not get_option('rbd').auto() or have_
|
||||||
endif
|
endif
|
||||||
endif
|
endif
|
||||||
|
|
||||||
@@ -41,7 +41,7 @@ Index: pve-qemu-kvm-9.2.0/meson.build
|
|||||||
glusterfs = not_found
|
glusterfs = not_found
|
||||||
glusterfs_ftruncate_has_stat = false
|
glusterfs_ftruncate_has_stat = false
|
||||||
glusterfs_iocb_has_stat = false
|
glusterfs_iocb_has_stat = false
|
||||||
@@ -2478,6 +2498,7 @@ endif
|
@@ -2254,6 +2274,7 @@ endif
|
||||||
config_host_data.set('CONFIG_OPENGL', opengl.found())
|
config_host_data.set('CONFIG_OPENGL', opengl.found())
|
||||||
config_host_data.set('CONFIG_PLUGIN', get_option('plugins'))
|
config_host_data.set('CONFIG_PLUGIN', get_option('plugins'))
|
||||||
config_host_data.set('CONFIG_RBD', rbd.found())
|
config_host_data.set('CONFIG_RBD', rbd.found())
|
||||||
@@ -49,7 +49,7 @@ Index: pve-qemu-kvm-9.2.0/meson.build
|
|||||||
config_host_data.set('CONFIG_RDMA', rdma.found())
|
config_host_data.set('CONFIG_RDMA', rdma.found())
|
||||||
config_host_data.set('CONFIG_RELOCATABLE', get_option('relocatable'))
|
config_host_data.set('CONFIG_RELOCATABLE', get_option('relocatable'))
|
||||||
config_host_data.set('CONFIG_SAFESTACK', get_option('safe_stack'))
|
config_host_data.set('CONFIG_SAFESTACK', get_option('safe_stack'))
|
||||||
@@ -4789,6 +4810,7 @@ summary_info += {'fdt support': fd
|
@@ -4454,6 +4475,7 @@ summary_info += {'fdt support': fd
|
||||||
summary_info += {'libcap-ng support': libcap_ng}
|
summary_info += {'libcap-ng support': libcap_ng}
|
||||||
summary_info += {'bpf support': libbpf}
|
summary_info += {'bpf support': libbpf}
|
||||||
summary_info += {'rbd support': rbd}
|
summary_info += {'rbd support': rbd}
|
||||||
@@ -57,11 +57,11 @@ Index: pve-qemu-kvm-9.2.0/meson.build
|
|||||||
summary_info += {'smartcard support': cacard}
|
summary_info += {'smartcard support': cacard}
|
||||||
summary_info += {'U2F support': u2f}
|
summary_info += {'U2F support': u2f}
|
||||||
summary_info += {'libusb': libusb}
|
summary_info += {'libusb': libusb}
|
||||||
Index: pve-qemu-kvm-9.2.0/meson_options.txt
|
Index: pve-qemu-kvm-9.0.0/meson_options.txt
|
||||||
===================================================================
|
===================================================================
|
||||||
--- pve-qemu-kvm-9.2.0.orig/meson_options.txt
|
--- pve-qemu-kvm-9.0.0.orig/meson_options.txt
|
||||||
+++ pve-qemu-kvm-9.2.0/meson_options.txt
|
+++ pve-qemu-kvm-9.0.0/meson_options.txt
|
||||||
@@ -200,6 +200,8 @@ option('lzo', type : 'feature', value :
|
@@ -194,6 +194,8 @@ option('lzo', type : 'feature', value :
|
||||||
description: 'lzo compression support')
|
description: 'lzo compression support')
|
||||||
option('rbd', type : 'feature', value : 'auto',
|
option('rbd', type : 'feature', value : 'auto',
|
||||||
description: 'Ceph block device driver')
|
description: 'Ceph block device driver')
|
||||||
@@ -70,10 +70,10 @@ Index: pve-qemu-kvm-9.2.0/meson_options.txt
|
|||||||
option('opengl', type : 'feature', value : 'auto',
|
option('opengl', type : 'feature', value : 'auto',
|
||||||
description: 'OpenGL support')
|
description: 'OpenGL support')
|
||||||
option('rdma', type : 'feature', value : 'auto',
|
option('rdma', type : 'feature', value : 'auto',
|
||||||
Index: pve-qemu-kvm-9.2.0/qapi/block-core.json
|
Index: pve-qemu-kvm-9.0.0/qapi/block-core.json
|
||||||
===================================================================
|
===================================================================
|
||||||
--- pve-qemu-kvm-9.2.0.orig/qapi/block-core.json
|
--- pve-qemu-kvm-9.0.0.orig/qapi/block-core.json
|
||||||
+++ pve-qemu-kvm-9.2.0/qapi/block-core.json
|
+++ pve-qemu-kvm-9.0.0/qapi/block-core.json
|
||||||
@@ -3481,7 +3481,7 @@
|
@@ -3481,7 +3481,7 @@
|
||||||
'raw', 'rbd',
|
'raw', 'rbd',
|
||||||
{ 'name': 'replication', 'if': 'CONFIG_REPLICATION' },
|
{ 'name': 'replication', 'if': 'CONFIG_REPLICATION' },
|
||||||
@@ -83,7 +83,7 @@ Index: pve-qemu-kvm-9.2.0/qapi/block-core.json
|
|||||||
{ 'name': 'virtio-blk-vfio-pci', 'if': 'CONFIG_BLKIO' },
|
{ 'name': 'virtio-blk-vfio-pci', 'if': 'CONFIG_BLKIO' },
|
||||||
{ 'name': 'virtio-blk-vhost-user', 'if': 'CONFIG_BLKIO' },
|
{ 'name': 'virtio-blk-vhost-user', 'if': 'CONFIG_BLKIO' },
|
||||||
{ 'name': 'virtio-blk-vhost-vdpa', 'if': 'CONFIG_BLKIO' },
|
{ 'name': 'virtio-blk-vhost-vdpa', 'if': 'CONFIG_BLKIO' },
|
||||||
@@ -4592,6 +4592,28 @@
|
@@ -4591,6 +4591,28 @@
|
||||||
'*server': ['InetSocketAddressBase'] } }
|
'*server': ['InetSocketAddressBase'] } }
|
||||||
|
|
||||||
##
|
##
|
||||||
@@ -112,7 +112,7 @@ Index: pve-qemu-kvm-9.2.0/qapi/block-core.json
|
|||||||
# @ReplicationMode:
|
# @ReplicationMode:
|
||||||
#
|
#
|
||||||
# An enumeration of replication modes.
|
# An enumeration of replication modes.
|
||||||
@@ -5054,6 +5076,7 @@
|
@@ -5053,6 +5075,7 @@
|
||||||
'throttle': 'BlockdevOptionsThrottle',
|
'throttle': 'BlockdevOptionsThrottle',
|
||||||
'vdi': 'BlockdevOptionsGenericFormat',
|
'vdi': 'BlockdevOptionsGenericFormat',
|
||||||
'vhdx': 'BlockdevOptionsGenericFormat',
|
'vhdx': 'BlockdevOptionsGenericFormat',
|
||||||
@@ -120,7 +120,7 @@ Index: pve-qemu-kvm-9.2.0/qapi/block-core.json
|
|||||||
'virtio-blk-vfio-pci':
|
'virtio-blk-vfio-pci':
|
||||||
{ 'type': 'BlockdevOptionsVirtioBlkVfioPci',
|
{ 'type': 'BlockdevOptionsVirtioBlkVfioPci',
|
||||||
'if': 'CONFIG_BLKIO' },
|
'if': 'CONFIG_BLKIO' },
|
||||||
@@ -5501,6 +5524,20 @@
|
@@ -5498,6 +5521,20 @@
|
||||||
'*encrypt' : 'RbdEncryptionCreateOptions' } }
|
'*encrypt' : 'RbdEncryptionCreateOptions' } }
|
||||||
|
|
||||||
##
|
##
|
||||||
@@ -141,7 +141,7 @@ Index: pve-qemu-kvm-9.2.0/qapi/block-core.json
|
|||||||
# @BlockdevVmdkSubformat:
|
# @BlockdevVmdkSubformat:
|
||||||
#
|
#
|
||||||
# Subformat options for VMDK images
|
# Subformat options for VMDK images
|
||||||
@@ -5722,6 +5759,7 @@
|
@@ -5719,6 +5753,7 @@
|
||||||
'ssh': 'BlockdevCreateOptionsSsh',
|
'ssh': 'BlockdevCreateOptionsSsh',
|
||||||
'vdi': 'BlockdevCreateOptionsVdi',
|
'vdi': 'BlockdevCreateOptionsVdi',
|
||||||
'vhdx': 'BlockdevCreateOptionsVhdx',
|
'vhdx': 'BlockdevCreateOptionsVhdx',
|
||||||
@@ -149,20 +149,41 @@ Index: pve-qemu-kvm-9.2.0/qapi/block-core.json
|
|||||||
'vmdk': 'BlockdevCreateOptionsVmdk',
|
'vmdk': 'BlockdevCreateOptionsVmdk',
|
||||||
'vpc': 'BlockdevCreateOptionsVpc'
|
'vpc': 'BlockdevCreateOptionsVpc'
|
||||||
} }
|
} }
|
||||||
Index: pve-qemu-kvm-9.2.0/scripts/meson-buildoptions.sh
|
Index: pve-qemu-kvm-9.0.0/scripts/ci/org.centos/stream/8/x86_64/configure
|
||||||
===================================================================
|
===================================================================
|
||||||
--- pve-qemu-kvm-9.2.0.orig/scripts/meson-buildoptions.sh
|
--- pve-qemu-kvm-9.0.0.orig/scripts/ci/org.centos/stream/8/x86_64/configure
|
||||||
+++ pve-qemu-kvm-9.2.0/scripts/meson-buildoptions.sh
|
+++ pve-qemu-kvm-9.0.0/scripts/ci/org.centos/stream/8/x86_64/configure
|
||||||
@@ -174,6 +174,7 @@ meson_options_help() {
|
@@ -30,7 +30,7 @@
|
||||||
|
--with-suffix="qemu-kvm" \
|
||||||
|
--firmwarepath=/usr/share/qemu-firmware \
|
||||||
|
--target-list="x86_64-softmmu" \
|
||||||
|
---block-drv-rw-whitelist="qcow2,raw,file,host_device,nbd,iscsi,rbd,blkdebug,luks,null-co,nvme,copy-on-read,throttle,gluster" \
|
||||||
|
+--block-drv-rw-whitelist="qcow2,raw,file,host_device,nbd,iscsi,rbd,vitastor,blkdebug,luks,null-co,nvme,copy-on-read,throttle,gluster" \
|
||||||
|
--audio-drv-list="" \
|
||||||
|
--block-drv-ro-whitelist="vmdk,vhdx,vpc,https,ssh" \
|
||||||
|
--with-coroutine=ucontext \
|
||||||
|
@@ -176,6 +176,7 @@
|
||||||
|
--enable-opengl \
|
||||||
|
--enable-pie \
|
||||||
|
--enable-rbd \
|
||||||
|
+--enable-vitastor \
|
||||||
|
--enable-rdma \
|
||||||
|
--enable-seccomp \
|
||||||
|
--enable-snappy \
|
||||||
|
Index: pve-qemu-kvm-9.0.0/scripts/meson-buildoptions.sh
|
||||||
|
===================================================================
|
||||||
|
--- pve-qemu-kvm-9.0.0.orig/scripts/meson-buildoptions.sh
|
||||||
|
+++ pve-qemu-kvm-9.0.0/scripts/meson-buildoptions.sh
|
||||||
|
@@ -168,6 +168,7 @@ meson_options_help() {
|
||||||
|
printf "%s\n" ' qed qed image format support'
|
||||||
printf "%s\n" ' qga-vss build QGA VSS support (broken with MinGW)'
|
printf "%s\n" ' qga-vss build QGA VSS support (broken with MinGW)'
|
||||||
printf "%s\n" ' qpl Query Processing Library support'
|
|
||||||
printf "%s\n" ' rbd Ceph block device driver'
|
printf "%s\n" ' rbd Ceph block device driver'
|
||||||
+ printf "%s\n" ' vitastor Vitastor block device driver'
|
+ printf "%s\n" ' vitastor Vitastor block device driver'
|
||||||
printf "%s\n" ' rdma Enable RDMA-based migration'
|
printf "%s\n" ' rdma Enable RDMA-based migration'
|
||||||
printf "%s\n" ' replication replication support'
|
printf "%s\n" ' replication replication support'
|
||||||
printf "%s\n" ' rust Rust support'
|
printf "%s\n" ' rutabaga-gfx rutabaga_gfx support'
|
||||||
@@ -455,6 +456,8 @@ _meson_option_parse() {
|
@@ -445,6 +446,8 @@ _meson_option_parse() {
|
||||||
--disable-qpl) printf "%s" -Dqpl=disabled ;;
|
--disable-qom-cast-debug) printf "%s" -Dqom_cast_debug=false ;;
|
||||||
--enable-rbd) printf "%s" -Drbd=enabled ;;
|
--enable-rbd) printf "%s" -Drbd=enabled ;;
|
||||||
--disable-rbd) printf "%s" -Drbd=disabled ;;
|
--disable-rbd) printf "%s" -Drbd=disabled ;;
|
||||||
+ --enable-vitastor) printf "%s" -Dvitastor=enabled ;;
|
+ --enable-vitastor) printf "%s" -Dvitastor=enabled ;;
|
||||||
@@ -174,7 +195,7 @@ Index: a/block/vitastor.c
|
|||||||
===================================================================
|
===================================================================
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ a/block/vitastor.c
|
+++ a/block/vitastor.c
|
||||||
@@ -0,0 +1,1105 @@
|
@@ -0,0 +1,1079 @@
|
||||||
+// Copyright (c) Vitaliy Filippov, 2019+
|
+// Copyright (c) Vitaliy Filippov, 2019+
|
||||||
+// License: VNPL-1.1 or GNU GPL-2.0+ (see README.md for details)
|
+// License: VNPL-1.1 or GNU GPL-2.0+ (see README.md for details)
|
||||||
+
|
+
|
||||||
@@ -471,9 +492,7 @@ Index: a/block/vitastor.c
|
|||||||
+
|
+
|
||||||
+ qemu_mutex_lock(&client->mutex);
|
+ qemu_mutex_lock(&client->mutex);
|
||||||
+ vitastor_c_watch_inode(client->proxy, client->image, vitastor_co_generic_cb, task);
|
+ vitastor_c_watch_inode(client->proxy, client->image, vitastor_co_generic_cb, task);
|
||||||
+#if !defined VITASTOR_C_API_VERSION || VITASTOR_C_API_VERSION < 5
|
|
||||||
+ vitastor_schedule_uring_handler(client);
|
+ vitastor_schedule_uring_handler(client);
|
||||||
+#endif
|
|
||||||
+ qemu_mutex_unlock(&client->mutex);
|
+ qemu_mutex_unlock(&client->mutex);
|
||||||
+
|
+
|
||||||
+ while (!task->complete)
|
+ while (!task->complete)
|
||||||
@@ -745,22 +764,6 @@ Index: a/block/vitastor.c
|
|||||||
+static void vitastor_close(BlockDriverState *bs)
|
+static void vitastor_close(BlockDriverState *bs)
|
||||||
+{
|
+{
|
||||||
+ VitastorClient *client = bs->opaque;
|
+ VitastorClient *client = bs->opaque;
|
||||||
+ if (client->uring_eventfd >= 0)
|
|
||||||
+ {
|
|
||||||
+ // clear the eventfd handler
|
|
||||||
+ universal_aio_set_fd_handler(client->ctx, client->uring_eventfd, NULL, NULL, NULL);
|
|
||||||
+ int wait_bh = 0;
|
|
||||||
+ qemu_mutex_lock(&client->mutex);
|
|
||||||
+ // clear uring_eventfd itself to prevent future scheduling of new B/H
|
|
||||||
+ client->uring_eventfd = -1;
|
|
||||||
+ wait_bh = client->bh_uring_scheduled;
|
|
||||||
+ qemu_mutex_unlock(&client->mutex);
|
|
||||||
+ if (wait_bh)
|
|
||||||
+ {
|
|
||||||
+ // wait until existing scheduled B/H is ran
|
|
||||||
+ BDRV_POLL_WHILE(bs, client->bh_uring_scheduled);
|
|
||||||
+ }
|
|
||||||
+ }
|
|
||||||
+ vitastor_c_destroy(client->proxy);
|
+ vitastor_c_destroy(client->proxy);
|
||||||
+ if (client->fds)
|
+ if (client->fds)
|
||||||
+ {
|
+ {
|
||||||
@@ -944,9 +947,7 @@ Index: a/block/vitastor.c
|
|||||||
+ uint64_t inode = client->watch ? vitastor_c_inode_get_num(client->watch) : client->inode;
|
+ uint64_t inode = client->watch ? vitastor_c_inode_get_num(client->watch) : client->inode;
|
||||||
+ qemu_mutex_lock(&client->mutex);
|
+ qemu_mutex_lock(&client->mutex);
|
||||||
+ vitastor_c_read(client->proxy, inode, offset, bytes, iov->iov, iov->niov, vitastor_co_read_cb, &task);
|
+ vitastor_c_read(client->proxy, inode, offset, bytes, iov->iov, iov->niov, vitastor_co_read_cb, &task);
|
||||||
+#if !defined VITASTOR_C_API_VERSION || VITASTOR_C_API_VERSION < 5
|
|
||||||
+ vitastor_schedule_uring_handler(client);
|
+ vitastor_schedule_uring_handler(client);
|
||||||
+#endif
|
|
||||||
+ qemu_mutex_unlock(&client->mutex);
|
+ qemu_mutex_unlock(&client->mutex);
|
||||||
+
|
+
|
||||||
+ while (!task.complete)
|
+ while (!task.complete)
|
||||||
@@ -980,9 +981,7 @@ Index: a/block/vitastor.c
|
|||||||
+ uint64_t inode = client->watch ? vitastor_c_inode_get_num(client->watch) : client->inode;
|
+ uint64_t inode = client->watch ? vitastor_c_inode_get_num(client->watch) : client->inode;
|
||||||
+ qemu_mutex_lock(&client->mutex);
|
+ qemu_mutex_lock(&client->mutex);
|
||||||
+ vitastor_c_write(client->proxy, inode, offset, bytes, 0, iov->iov, iov->niov, vitastor_co_generic_cb, &task);
|
+ vitastor_c_write(client->proxy, inode, offset, bytes, 0, iov->iov, iov->niov, vitastor_co_generic_cb, &task);
|
||||||
+#if !defined VITASTOR_C_API_VERSION || VITASTOR_C_API_VERSION < 5
|
|
||||||
+ vitastor_schedule_uring_handler(client);
|
+ vitastor_schedule_uring_handler(client);
|
||||||
+#endif
|
|
||||||
+ qemu_mutex_unlock(&client->mutex);
|
+ qemu_mutex_unlock(&client->mutex);
|
||||||
+
|
+
|
||||||
+ while (!task.complete)
|
+ while (!task.complete)
|
||||||
@@ -1062,9 +1061,7 @@ Index: a/block/vitastor.c
|
|||||||
+ task.bitmap = client->last_bitmap = NULL;
|
+ task.bitmap = client->last_bitmap = NULL;
|
||||||
+ qemu_mutex_lock(&client->mutex);
|
+ qemu_mutex_lock(&client->mutex);
|
||||||
+ vitastor_c_read_bitmap(client->proxy, task.inode, task.offset, task.len, !client->skip_parents, vitastor_co_read_bitmap_cb, &task);
|
+ vitastor_c_read_bitmap(client->proxy, task.inode, task.offset, task.len, !client->skip_parents, vitastor_co_read_bitmap_cb, &task);
|
||||||
+#if !defined VITASTOR_C_API_VERSION || VITASTOR_C_API_VERSION < 5
|
|
||||||
+ vitastor_schedule_uring_handler(client);
|
+ vitastor_schedule_uring_handler(client);
|
||||||
+#endif
|
|
||||||
+ qemu_mutex_unlock(&client->mutex);
|
+ qemu_mutex_unlock(&client->mutex);
|
||||||
+ while (!task.complete)
|
+ while (!task.complete)
|
||||||
+ {
|
+ {
|
||||||
@@ -1151,9 +1148,7 @@ Index: a/block/vitastor.c
|
|||||||
+
|
+
|
||||||
+ qemu_mutex_lock(&client->mutex);
|
+ qemu_mutex_lock(&client->mutex);
|
||||||
+ vitastor_c_sync(client->proxy, vitastor_co_generic_cb, &task);
|
+ vitastor_c_sync(client->proxy, vitastor_co_generic_cb, &task);
|
||||||
+#if !defined VITASTOR_C_API_VERSION || VITASTOR_C_API_VERSION < 5
|
|
||||||
+ vitastor_schedule_uring_handler(client);
|
+ vitastor_schedule_uring_handler(client);
|
||||||
+#endif
|
|
||||||
+ qemu_mutex_unlock(&client->mutex);
|
+ qemu_mutex_unlock(&client->mutex);
|
||||||
+
|
+
|
||||||
+ while (!task.complete)
|
+ while (!task.complete)
|
@@ -14,10 +14,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 2 insertions(+), 2 deletions(-)
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/file-posix.c b/block/file-posix.c
|
diff --git a/block/file-posix.c b/block/file-posix.c
|
||||||
index 90fa54352c..e2ea071315 100644
|
index 35684f7e21..43bc0bd520 100644
|
||||||
--- a/block/file-posix.c
|
--- a/block/file-posix.c
|
||||||
+++ b/block/file-posix.c
|
+++ b/block/file-posix.c
|
||||||
@@ -564,7 +564,7 @@ static QemuOptsList raw_runtime_opts = {
|
@@ -563,7 +563,7 @@ static QemuOptsList raw_runtime_opts = {
|
||||||
{
|
{
|
||||||
.name = "locking",
|
.name = "locking",
|
||||||
.type = QEMU_OPT_STRING,
|
.type = QEMU_OPT_STRING,
|
||||||
@@ -26,7 +26,7 @@ index 90fa54352c..e2ea071315 100644
|
|||||||
},
|
},
|
||||||
{
|
{
|
||||||
.name = "pr-manager",
|
.name = "pr-manager",
|
||||||
@@ -664,7 +664,7 @@ static int raw_open_common(BlockDriverState *bs, QDict *options,
|
@@ -663,7 +663,7 @@ static int raw_open_common(BlockDriverState *bs, QDict *options,
|
||||||
s->use_lock = false;
|
s->use_lock = false;
|
||||||
break;
|
break;
|
||||||
case ON_OFF_AUTO_AUTO:
|
case ON_OFF_AUTO_AUTO:
|
||||||
|
@@ -9,12 +9,12 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 2 insertions(+), 2 deletions(-)
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
||||||
|
|
||||||
diff --git a/include/net/net.h b/include/net/net.h
|
diff --git a/include/net/net.h b/include/net/net.h
|
||||||
index cdd5b109b0..653a37e9d1 100644
|
index b1f9b35fcc..096c0d52e4 100644
|
||||||
--- a/include/net/net.h
|
--- a/include/net/net.h
|
||||||
+++ b/include/net/net.h
|
+++ b/include/net/net.h
|
||||||
@@ -305,8 +305,8 @@ void netdev_add(QemuOpts *opts, Error **errp);
|
@@ -317,8 +317,8 @@ void netdev_add(QemuOpts *opts, Error **errp);
|
||||||
|
|
||||||
int net_hub_id_for_client(NetClientState *nc, int *id);
|
int net_hub_id_for_client(NetClientState *nc, int *id);
|
||||||
|
NetClientState *net_hub_port_find(int hub_id);
|
||||||
|
|
||||||
-#define DEFAULT_NETWORK_SCRIPT CONFIG_SYSCONFDIR "/qemu-ifup"
|
-#define DEFAULT_NETWORK_SCRIPT CONFIG_SYSCONFDIR "/qemu-ifup"
|
||||||
-#define DEFAULT_NETWORK_DOWN_SCRIPT CONFIG_SYSCONFDIR "/qemu-ifdown"
|
-#define DEFAULT_NETWORK_DOWN_SCRIPT CONFIG_SYSCONFDIR "/qemu-ifdown"
|
||||||
|
@@ -10,10 +10,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 2 insertions(+), 2 deletions(-)
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
||||||
|
|
||||||
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
|
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
|
||||||
index 4c239a6970..be09263fb0 100644
|
index 6b05738079..d82869900a 100644
|
||||||
--- a/target/i386/cpu.h
|
--- a/target/i386/cpu.h
|
||||||
+++ b/target/i386/cpu.h
|
+++ b/target/i386/cpu.h
|
||||||
@@ -2475,9 +2475,9 @@ uint64_t cpu_get_tsc(CPUX86State *env);
|
@@ -2291,9 +2291,9 @@ uint64_t cpu_get_tsc(CPUX86State *env);
|
||||||
#define CPU_RESOLVING_TYPE TYPE_X86_CPU
|
#define CPU_RESOLVING_TYPE TYPE_X86_CPU
|
||||||
|
|
||||||
#ifdef TARGET_X86_64
|
#ifdef TARGET_X86_64
|
||||||
|
@@ -9,7 +9,7 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 9 insertions(+), 6 deletions(-)
|
1 file changed, 9 insertions(+), 6 deletions(-)
|
||||||
|
|
||||||
diff --git a/ui/spice-core.c b/ui/spice-core.c
|
diff --git a/ui/spice-core.c b/ui/spice-core.c
|
||||||
index bd9dbe03f1..a7ecaad9c7 100644
|
index 15be640286..ea20e6153c 100644
|
||||||
--- a/ui/spice-core.c
|
--- a/ui/spice-core.c
|
||||||
+++ b/ui/spice-core.c
|
+++ b/ui/spice-core.c
|
||||||
@@ -690,32 +690,35 @@ static void qemu_spice_init(void)
|
@@ -690,32 +690,35 @@ static void qemu_spice_init(void)
|
||||||
|
@@ -9,10 +9,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 11 insertions(+), 4 deletions(-)
|
1 file changed, 11 insertions(+), 4 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/gluster.c b/block/gluster.c
|
diff --git a/block/gluster.c b/block/gluster.c
|
||||||
index e9c038042b..c8457a5014 100644
|
index cc74af06dc..3ba9bbfa5e 100644
|
||||||
--- a/block/gluster.c
|
--- a/block/gluster.c
|
||||||
+++ b/block/gluster.c
|
+++ b/block/gluster.c
|
||||||
@@ -42,7 +42,7 @@
|
@@ -43,7 +43,7 @@
|
||||||
#define GLUSTER_DEBUG_DEFAULT 4
|
#define GLUSTER_DEBUG_DEFAULT 4
|
||||||
#define GLUSTER_DEBUG_MAX 9
|
#define GLUSTER_DEBUG_MAX 9
|
||||||
#define GLUSTER_OPT_LOGFILE "logfile"
|
#define GLUSTER_OPT_LOGFILE "logfile"
|
||||||
@@ -21,7 +21,7 @@ index e9c038042b..c8457a5014 100644
|
|||||||
/*
|
/*
|
||||||
* Several versions of GlusterFS (3.12? -> 6.0.1) fail when the transfer size
|
* Several versions of GlusterFS (3.12? -> 6.0.1) fail when the transfer size
|
||||||
* is greater or equal to 1024 MiB, so we are limiting the transfer size to 512
|
* is greater or equal to 1024 MiB, so we are limiting the transfer size to 512
|
||||||
@@ -421,6 +421,7 @@ static struct glfs *qemu_gluster_glfs_init(BlockdevOptionsGluster *gconf,
|
@@ -425,6 +425,7 @@ static struct glfs *qemu_gluster_glfs_init(BlockdevOptionsGluster *gconf,
|
||||||
int old_errno;
|
int old_errno;
|
||||||
SocketAddressList *server;
|
SocketAddressList *server;
|
||||||
uint64_t port;
|
uint64_t port;
|
||||||
@@ -29,7 +29,7 @@ index e9c038042b..c8457a5014 100644
|
|||||||
|
|
||||||
glfs = glfs_find_preopened(gconf->volume);
|
glfs = glfs_find_preopened(gconf->volume);
|
||||||
if (glfs) {
|
if (glfs) {
|
||||||
@@ -463,9 +464,15 @@ static struct glfs *qemu_gluster_glfs_init(BlockdevOptionsGluster *gconf,
|
@@ -467,9 +468,15 @@ static struct glfs *qemu_gluster_glfs_init(BlockdevOptionsGluster *gconf,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@@ -18,7 +18,7 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 2 insertions(+)
|
1 file changed, 2 insertions(+)
|
||||||
|
|
||||||
diff --git a/block/rbd.c b/block/rbd.c
|
diff --git a/block/rbd.c b/block/rbd.c
|
||||||
index 04ed0e242e..728bce3b1e 100644
|
index 84bb2fa5d7..63f60d41be 100644
|
||||||
--- a/block/rbd.c
|
--- a/block/rbd.c
|
||||||
+++ b/block/rbd.c
|
+++ b/block/rbd.c
|
||||||
@@ -963,6 +963,8 @@ static int qemu_rbd_connect(rados_t *cluster, rados_ioctx_t *io_ctx,
|
@@ -963,6 +963,8 @@ static int qemu_rbd_connect(rados_t *cluster, rados_ioctx_t *io_ctx,
|
||||||
|
@@ -16,10 +16,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 9 insertions(+), 1 deletion(-)
|
1 file changed, 9 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
diff --git a/block/gluster.c b/block/gluster.c
|
diff --git a/block/gluster.c b/block/gluster.c
|
||||||
index c8457a5014..c3a9555591 100644
|
index 3ba9bbfa5e..34936eb855 100644
|
||||||
--- a/block/gluster.c
|
--- a/block/gluster.c
|
||||||
+++ b/block/gluster.c
|
+++ b/block/gluster.c
|
||||||
@@ -57,6 +57,7 @@ typedef struct GlusterAIOCB {
|
@@ -58,6 +58,7 @@ typedef struct GlusterAIOCB {
|
||||||
int ret;
|
int ret;
|
||||||
Coroutine *coroutine;
|
Coroutine *coroutine;
|
||||||
AioContext *aio_context;
|
AioContext *aio_context;
|
||||||
@@ -27,7 +27,7 @@ index c8457a5014..c3a9555591 100644
|
|||||||
} GlusterAIOCB;
|
} GlusterAIOCB;
|
||||||
|
|
||||||
typedef struct BDRVGlusterState {
|
typedef struct BDRVGlusterState {
|
||||||
@@ -746,8 +747,10 @@ static void gluster_finish_aiocb(struct glfs_fd *fd, ssize_t ret,
|
@@ -753,8 +754,10 @@ static void gluster_finish_aiocb(struct glfs_fd *fd, ssize_t ret,
|
||||||
acb->ret = 0; /* Success */
|
acb->ret = 0; /* Success */
|
||||||
} else if (ret < 0) {
|
} else if (ret < 0) {
|
||||||
acb->ret = -errno; /* Read/Write failed */
|
acb->ret = -errno; /* Read/Write failed */
|
||||||
@@ -39,7 +39,7 @@ index c8457a5014..c3a9555591 100644
|
|||||||
}
|
}
|
||||||
|
|
||||||
aio_co_schedule(acb->aio_context, acb->coroutine);
|
aio_co_schedule(acb->aio_context, acb->coroutine);
|
||||||
@@ -1018,6 +1021,7 @@ static coroutine_fn int qemu_gluster_co_pwrite_zeroes(BlockDriverState *bs,
|
@@ -1023,6 +1026,7 @@ static coroutine_fn int qemu_gluster_co_pwrite_zeroes(BlockDriverState *bs,
|
||||||
acb.ret = 0;
|
acb.ret = 0;
|
||||||
acb.coroutine = qemu_coroutine_self();
|
acb.coroutine = qemu_coroutine_self();
|
||||||
acb.aio_context = bdrv_get_aio_context(bs);
|
acb.aio_context = bdrv_get_aio_context(bs);
|
||||||
@@ -47,7 +47,7 @@ index c8457a5014..c3a9555591 100644
|
|||||||
|
|
||||||
ret = glfs_zerofill_async(s->fd, offset, bytes, gluster_finish_aiocb, &acb);
|
ret = glfs_zerofill_async(s->fd, offset, bytes, gluster_finish_aiocb, &acb);
|
||||||
if (ret < 0) {
|
if (ret < 0) {
|
||||||
@@ -1198,9 +1202,11 @@ static coroutine_fn int qemu_gluster_co_rw(BlockDriverState *bs,
|
@@ -1203,9 +1207,11 @@ static coroutine_fn int qemu_gluster_co_rw(BlockDriverState *bs,
|
||||||
acb.aio_context = bdrv_get_aio_context(bs);
|
acb.aio_context = bdrv_get_aio_context(bs);
|
||||||
|
|
||||||
if (write) {
|
if (write) {
|
||||||
@@ -59,7 +59,7 @@ index c8457a5014..c3a9555591 100644
|
|||||||
ret = glfs_preadv_async(s->fd, qiov->iov, qiov->niov, offset, 0,
|
ret = glfs_preadv_async(s->fd, qiov->iov, qiov->niov, offset, 0,
|
||||||
gluster_finish_aiocb, &acb);
|
gluster_finish_aiocb, &acb);
|
||||||
}
|
}
|
||||||
@@ -1263,6 +1269,7 @@ static coroutine_fn int qemu_gluster_co_flush_to_disk(BlockDriverState *bs)
|
@@ -1268,6 +1274,7 @@ static coroutine_fn int qemu_gluster_co_flush_to_disk(BlockDriverState *bs)
|
||||||
acb.ret = 0;
|
acb.ret = 0;
|
||||||
acb.coroutine = qemu_coroutine_self();
|
acb.coroutine = qemu_coroutine_self();
|
||||||
acb.aio_context = bdrv_get_aio_context(bs);
|
acb.aio_context = bdrv_get_aio_context(bs);
|
||||||
@@ -67,7 +67,7 @@ index c8457a5014..c3a9555591 100644
|
|||||||
|
|
||||||
ret = glfs_fsync_async(s->fd, gluster_finish_aiocb, &acb);
|
ret = glfs_fsync_async(s->fd, gluster_finish_aiocb, &acb);
|
||||||
if (ret < 0) {
|
if (ret < 0) {
|
||||||
@@ -1311,6 +1318,7 @@ static coroutine_fn int qemu_gluster_co_pdiscard(BlockDriverState *bs,
|
@@ -1316,6 +1323,7 @@ static coroutine_fn int qemu_gluster_co_pdiscard(BlockDriverState *bs,
|
||||||
acb.ret = 0;
|
acb.ret = 0;
|
||||||
acb.coroutine = qemu_coroutine_self();
|
acb.coroutine = qemu_coroutine_self();
|
||||||
acb.aio_context = bdrv_get_aio_context(bs);
|
acb.aio_context = bdrv_get_aio_context(bs);
|
||||||
|
@@ -18,10 +18,10 @@ Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|||||||
4 files changed, 82 insertions(+), 4 deletions(-)
|
4 files changed, 82 insertions(+), 4 deletions(-)
|
||||||
|
|
||||||
diff --git a/hw/core/machine-hmp-cmds.c b/hw/core/machine-hmp-cmds.c
|
diff --git a/hw/core/machine-hmp-cmds.c b/hw/core/machine-hmp-cmds.c
|
||||||
index 8701f00cc7..3b4c5ef403 100644
|
index a6ff6a4875..e7f74d1c63 100644
|
||||||
--- a/hw/core/machine-hmp-cmds.c
|
--- a/hw/core/machine-hmp-cmds.c
|
||||||
+++ b/hw/core/machine-hmp-cmds.c
|
+++ b/hw/core/machine-hmp-cmds.c
|
||||||
@@ -179,7 +179,35 @@ void hmp_info_balloon(Monitor *mon, const QDict *qdict)
|
@@ -175,7 +175,35 @@ void hmp_info_balloon(Monitor *mon, const QDict *qdict)
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -59,10 +59,10 @@ index 8701f00cc7..3b4c5ef403 100644
|
|||||||
qapi_free_BalloonInfo(info);
|
qapi_free_BalloonInfo(info);
|
||||||
}
|
}
|
||||||
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
|
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
|
||||||
index afd2ad6dd6..c724218c17 100644
|
index 609e39a821..8cb6dfcac3 100644
|
||||||
--- a/hw/virtio/virtio-balloon.c
|
--- a/hw/virtio/virtio-balloon.c
|
||||||
+++ b/hw/virtio/virtio-balloon.c
|
+++ b/hw/virtio/virtio-balloon.c
|
||||||
@@ -795,8 +795,37 @@ static uint64_t virtio_balloon_get_features(VirtIODevice *vdev, uint64_t f,
|
@@ -781,8 +781,37 @@ static uint64_t virtio_balloon_get_features(VirtIODevice *vdev, uint64_t f,
|
||||||
static void virtio_balloon_stat(void *opaque, BalloonInfo *info)
|
static void virtio_balloon_stat(void *opaque, BalloonInfo *info)
|
||||||
{
|
{
|
||||||
VirtIOBalloon *dev = opaque;
|
VirtIOBalloon *dev = opaque;
|
||||||
@@ -103,10 +103,10 @@ index afd2ad6dd6..c724218c17 100644
|
|||||||
|
|
||||||
static void virtio_balloon_to_target(void *opaque, ram_addr_t target)
|
static void virtio_balloon_to_target(void *opaque, ram_addr_t target)
|
||||||
diff --git a/qapi/machine.json b/qapi/machine.json
|
diff --git a/qapi/machine.json b/qapi/machine.json
|
||||||
index a6b8795b09..9f7ed0eaa0 100644
|
index e8b60641f2..2054cdc70d 100644
|
||||||
--- a/qapi/machine.json
|
--- a/qapi/machine.json
|
||||||
+++ b/qapi/machine.json
|
+++ b/qapi/machine.json
|
||||||
@@ -1163,9 +1163,29 @@
|
@@ -1079,9 +1079,29 @@
|
||||||
# @actual: the logical size of the VM in bytes Formula used:
|
# @actual: the logical size of the VM in bytes Formula used:
|
||||||
# logical_vm_size = vm_ram_size - balloon_size
|
# logical_vm_size = vm_ram_size - balloon_size
|
||||||
#
|
#
|
||||||
@@ -138,10 +138,10 @@ index a6b8795b09..9f7ed0eaa0 100644
|
|||||||
##
|
##
|
||||||
# @query-balloon:
|
# @query-balloon:
|
||||||
diff --git a/qapi/pragma.json b/qapi/pragma.json
|
diff --git a/qapi/pragma.json b/qapi/pragma.json
|
||||||
index 023a2ef7bc..6aaa9cb975 100644
|
index 59fbe74b8c..be8fa304c5 100644
|
||||||
--- a/qapi/pragma.json
|
--- a/qapi/pragma.json
|
||||||
+++ b/qapi/pragma.json
|
+++ b/qapi/pragma.json
|
||||||
@@ -81,6 +81,7 @@
|
@@ -90,6 +90,7 @@
|
||||||
'member-name-exceptions': [ # visible in:
|
'member-name-exceptions': [ # visible in:
|
||||||
'ACPISlotType', # query-acpi-ospm-status
|
'ACPISlotType', # query-acpi-ospm-status
|
||||||
'AcpiTableOptions', # -acpitable
|
'AcpiTableOptions', # -acpitable
|
||||||
|
@@ -13,10 +13,10 @@ Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
|
|||||||
2 files changed, 9 insertions(+), 1 deletion(-)
|
2 files changed, 9 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c
|
diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c
|
||||||
index 130217da8f..52a6d74820 100644
|
index 4b72009cd3..314351cdff 100644
|
||||||
--- a/hw/core/machine-qmp-cmds.c
|
--- a/hw/core/machine-qmp-cmds.c
|
||||||
+++ b/hw/core/machine-qmp-cmds.c
|
+++ b/hw/core/machine-qmp-cmds.c
|
||||||
@@ -90,6 +90,12 @@ MachineInfoList *qmp_query_machines(bool has_compat_props, bool compat_props,
|
@@ -90,6 +90,12 @@ MachineInfoList *qmp_query_machines(Error **errp)
|
||||||
info->numa_mem_supported = mc->numa_mem_supported;
|
info->numa_mem_supported = mc->numa_mem_supported;
|
||||||
info->deprecated = !!mc->deprecation_reason;
|
info->deprecated = !!mc->deprecation_reason;
|
||||||
info->acpi = !!object_class_property_find(OBJECT_CLASS(mc), "acpi");
|
info->acpi = !!object_class_property_find(OBJECT_CLASS(mc), "acpi");
|
||||||
@@ -30,10 +30,10 @@ index 130217da8f..52a6d74820 100644
|
|||||||
info->default_cpu_type = g_strdup(mc->default_cpu_type);
|
info->default_cpu_type = g_strdup(mc->default_cpu_type);
|
||||||
}
|
}
|
||||||
diff --git a/qapi/machine.json b/qapi/machine.json
|
diff --git a/qapi/machine.json b/qapi/machine.json
|
||||||
index 9f7ed0eaa0..16366b774a 100644
|
index 2054cdc70d..a024d5b05d 100644
|
||||||
--- a/qapi/machine.json
|
--- a/qapi/machine.json
|
||||||
+++ b/qapi/machine.json
|
+++ b/qapi/machine.json
|
||||||
@@ -167,6 +167,8 @@
|
@@ -146,6 +146,8 @@
|
||||||
#
|
#
|
||||||
# @is-default: whether the machine is default
|
# @is-default: whether the machine is default
|
||||||
#
|
#
|
||||||
@@ -42,7 +42,7 @@ index 9f7ed0eaa0..16366b774a 100644
|
|||||||
# @cpu-max: maximum number of CPUs supported by the machine type
|
# @cpu-max: maximum number of CPUs supported by the machine type
|
||||||
# (since 1.5)
|
# (since 1.5)
|
||||||
#
|
#
|
||||||
@@ -199,7 +201,7 @@
|
@@ -170,7 +172,7 @@
|
||||||
##
|
##
|
||||||
{ 'struct': 'MachineInfo',
|
{ 'struct': 'MachineInfo',
|
||||||
'data': { 'name': 'str', '*alias': 'str',
|
'data': { 'name': 'str', '*alias': 'str',
|
||||||
@@ -50,4 +50,4 @@ index 9f7ed0eaa0..16366b774a 100644
|
|||||||
+ '*is-default': 'bool', '*is-current': 'bool', 'cpu-max': 'int',
|
+ '*is-default': 'bool', '*is-current': 'bool', 'cpu-max': 'int',
|
||||||
'hotpluggable-cpus': 'bool', 'numa-mem-supported': 'bool',
|
'hotpluggable-cpus': 'bool', 'numa-mem-supported': 'bool',
|
||||||
'deprecated': 'bool', '*default-cpu-type': 'str',
|
'deprecated': 'bool', '*default-cpu-type': 'str',
|
||||||
'*default-ram-id': 'str', 'acpi': 'bool',
|
'*default-ram-id': 'str', 'acpi': 'bool' } }
|
||||||
|
@@ -14,10 +14,10 @@ Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|||||||
2 files changed, 7 insertions(+)
|
2 files changed, 7 insertions(+)
|
||||||
|
|
||||||
diff --git a/qapi/ui.json b/qapi/ui.json
|
diff --git a/qapi/ui.json b/qapi/ui.json
|
||||||
index 460a26b981..42b911bda3 100644
|
index f610bce118..6ea26a9acb 100644
|
||||||
--- a/qapi/ui.json
|
--- a/qapi/ui.json
|
||||||
+++ b/qapi/ui.json
|
+++ b/qapi/ui.json
|
||||||
@@ -312,11 +312,14 @@
|
@@ -314,11 +314,14 @@
|
||||||
#
|
#
|
||||||
# @channels: a list of @SpiceChannel for each active spice channel
|
# @channels: a list of @SpiceChannel for each active spice channel
|
||||||
#
|
#
|
||||||
@@ -33,7 +33,7 @@ index 460a26b981..42b911bda3 100644
|
|||||||
'if': 'CONFIG_SPICE' }
|
'if': 'CONFIG_SPICE' }
|
||||||
|
|
||||||
diff --git a/ui/spice-core.c b/ui/spice-core.c
|
diff --git a/ui/spice-core.c b/ui/spice-core.c
|
||||||
index a7ecaad9c7..fecf002d50 100644
|
index ea20e6153c..55a15fba8b 100644
|
||||||
--- a/ui/spice-core.c
|
--- a/ui/spice-core.c
|
||||||
+++ b/ui/spice-core.c
|
+++ b/ui/spice-core.c
|
||||||
@@ -548,6 +548,10 @@ static SpiceInfo *qmp_query_spice_real(Error **errp)
|
@@ -548,6 +548,10 @@ static SpiceInfo *qmp_query_spice_real(Error **errp)
|
||||||
|
@@ -271,7 +271,7 @@ index 0000000000..17ae2cb261
|
|||||||
+
|
+
|
||||||
+#endif /* QIO_CHANNEL_SAVEVM_ASYNC_H */
|
+#endif /* QIO_CHANNEL_SAVEVM_ASYNC_H */
|
||||||
diff --git a/migration/meson.build b/migration/meson.build
|
diff --git a/migration/meson.build b/migration/meson.build
|
||||||
index d53cf3417a..b00d58064d 100644
|
index 1eeb915ff6..95d1cf2250 100644
|
||||||
--- a/migration/meson.build
|
--- a/migration/meson.build
|
||||||
+++ b/migration/meson.build
|
+++ b/migration/meson.build
|
||||||
@@ -13,6 +13,7 @@ system_ss.add(files(
|
@@ -13,6 +13,7 @@ system_ss.add(files(
|
||||||
@@ -279,6 +279,6 @@ index d53cf3417a..b00d58064d 100644
|
|||||||
'channel.c',
|
'channel.c',
|
||||||
'channel-block.c',
|
'channel-block.c',
|
||||||
+ 'channel-savevm-async.c',
|
+ 'channel-savevm-async.c',
|
||||||
'cpu-throttle.c',
|
|
||||||
'dirtyrate.c',
|
'dirtyrate.c',
|
||||||
'exec.c',
|
'exec.c',
|
||||||
|
'fd.c',
|
||||||
|
@@ -38,20 +38,20 @@ Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|||||||
include/migration/snapshot.h | 2 +
|
include/migration/snapshot.h | 2 +
|
||||||
include/monitor/hmp.h | 3 +
|
include/monitor/hmp.h | 3 +
|
||||||
migration/meson.build | 1 +
|
migration/meson.build | 1 +
|
||||||
migration/savevm-async.c | 571 +++++++++++++++++++++++++++++++++++
|
migration/savevm-async.c | 549 +++++++++++++++++++++++++++++++++++
|
||||||
monitor/hmp-cmds.c | 38 +++
|
monitor/hmp-cmds.c | 38 +++
|
||||||
qapi/migration.json | 34 +++
|
qapi/migration.json | 34 +++
|
||||||
qapi/misc.json | 18 ++
|
qapi/misc.json | 18 ++
|
||||||
qemu-options.hx | 12 +
|
qemu-options.hx | 12 +
|
||||||
system/vl.c | 10 +
|
system/vl.c | 10 +
|
||||||
11 files changed, 719 insertions(+)
|
11 files changed, 697 insertions(+)
|
||||||
create mode 100644 migration/savevm-async.c
|
create mode 100644 migration/savevm-async.c
|
||||||
|
|
||||||
diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
|
diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
|
||||||
index c59cd6637b..d1a7b99add 100644
|
index ad1b1306e3..d5ab880492 100644
|
||||||
--- a/hmp-commands-info.hx
|
--- a/hmp-commands-info.hx
|
||||||
+++ b/hmp-commands-info.hx
|
+++ b/hmp-commands-info.hx
|
||||||
@@ -512,6 +512,19 @@ SRST
|
@@ -525,6 +525,19 @@ SRST
|
||||||
Show current migration parameters.
|
Show current migration parameters.
|
||||||
ERST
|
ERST
|
||||||
|
|
||||||
@@ -72,10 +72,10 @@ index c59cd6637b..d1a7b99add 100644
|
|||||||
.name = "balloon",
|
.name = "balloon",
|
||||||
.args_type = "",
|
.args_type = "",
|
||||||
diff --git a/hmp-commands.hx b/hmp-commands.hx
|
diff --git a/hmp-commands.hx b/hmp-commands.hx
|
||||||
index 06746f0afc..0c7c6f2c16 100644
|
index 2e2a3bcf98..7506de251c 100644
|
||||||
--- a/hmp-commands.hx
|
--- a/hmp-commands.hx
|
||||||
+++ b/hmp-commands.hx
|
+++ b/hmp-commands.hx
|
||||||
@@ -1859,3 +1859,20 @@ SRST
|
@@ -1862,3 +1862,20 @@ SRST
|
||||||
List event channels in the guest
|
List event channels in the guest
|
||||||
ERST
|
ERST
|
||||||
#endif
|
#endif
|
||||||
@@ -108,7 +108,7 @@ index 9e4dcaaa75..2581730d74 100644
|
|||||||
+
|
+
|
||||||
#endif
|
#endif
|
||||||
diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h
|
diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h
|
||||||
index ae116d9804..2596cc2426 100644
|
index 13f9a2dedb..7a7def7530 100644
|
||||||
--- a/include/monitor/hmp.h
|
--- a/include/monitor/hmp.h
|
||||||
+++ b/include/monitor/hmp.h
|
+++ b/include/monitor/hmp.h
|
||||||
@@ -28,6 +28,7 @@ void hmp_info_status(Monitor *mon, const QDict *qdict);
|
@@ -28,6 +28,7 @@ void hmp_info_status(Monitor *mon, const QDict *qdict);
|
||||||
@@ -119,7 +119,7 @@ index ae116d9804..2596cc2426 100644
|
|||||||
void hmp_info_migrate(Monitor *mon, const QDict *qdict);
|
void hmp_info_migrate(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict);
|
void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict);
|
void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict);
|
||||||
@@ -92,6 +93,8 @@ void hmp_closefd(Monitor *mon, const QDict *qdict);
|
@@ -94,6 +95,8 @@ void hmp_closefd(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_mouse_move(Monitor *mon, const QDict *qdict);
|
void hmp_mouse_move(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_mouse_button(Monitor *mon, const QDict *qdict);
|
void hmp_mouse_button(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_mouse_set(Monitor *mon, const QDict *qdict);
|
void hmp_mouse_set(Monitor *mon, const QDict *qdict);
|
||||||
@@ -129,10 +129,10 @@ index ae116d9804..2596cc2426 100644
|
|||||||
void coroutine_fn hmp_screendump(Monitor *mon, const QDict *qdict);
|
void coroutine_fn hmp_screendump(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_chardev_add(Monitor *mon, const QDict *qdict);
|
void hmp_chardev_add(Monitor *mon, const QDict *qdict);
|
||||||
diff --git a/migration/meson.build b/migration/meson.build
|
diff --git a/migration/meson.build b/migration/meson.build
|
||||||
index b00d58064d..075b013971 100644
|
index 95d1cf2250..800f12a60d 100644
|
||||||
--- a/migration/meson.build
|
--- a/migration/meson.build
|
||||||
+++ b/migration/meson.build
|
+++ b/migration/meson.build
|
||||||
@@ -29,6 +29,7 @@ system_ss.add(files(
|
@@ -28,6 +28,7 @@ system_ss.add(files(
|
||||||
'options.c',
|
'options.c',
|
||||||
'postcopy-ram.c',
|
'postcopy-ram.c',
|
||||||
'savevm.c',
|
'savevm.c',
|
||||||
@@ -142,10 +142,10 @@ index b00d58064d..075b013971 100644
|
|||||||
'threadinfo.c',
|
'threadinfo.c',
|
||||||
diff --git a/migration/savevm-async.c b/migration/savevm-async.c
|
diff --git a/migration/savevm-async.c b/migration/savevm-async.c
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..ee8ef316d0
|
index 0000000000..ae7ed68651
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/migration/savevm-async.c
|
+++ b/migration/savevm-async.c
|
||||||
@@ -0,0 +1,571 @@
|
@@ -0,0 +1,549 @@
|
||||||
+#include "qemu/osdep.h"
|
+#include "qemu/osdep.h"
|
||||||
+#include "migration/channel-savevm-async.h"
|
+#include "migration/channel-savevm-async.h"
|
||||||
+#include "migration/migration.h"
|
+#include "migration/migration.h"
|
||||||
@@ -168,7 +168,6 @@ index 0000000000..ee8ef316d0
|
|||||||
+#include "qapi/qapi-commands-misc.h"
|
+#include "qapi/qapi-commands-misc.h"
|
||||||
+#include "qapi/qapi-commands-block.h"
|
+#include "qapi/qapi-commands-block.h"
|
||||||
+#include "qemu/cutils.h"
|
+#include "qemu/cutils.h"
|
||||||
+#include "qemu/error-report.h"
|
|
||||||
+#include "qemu/timer.h"
|
+#include "qemu/timer.h"
|
||||||
+#include "qemu/main-loop.h"
|
+#include "qemu/main-loop.h"
|
||||||
+#include "qemu/rcu.h"
|
+#include "qemu/rcu.h"
|
||||||
@@ -262,7 +261,6 @@ index 0000000000..ee8ef316d0
|
|||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ if (snap_state.target) {
|
+ if (snap_state.target) {
|
||||||
+ BlockDriverState *target_bs = blk_bs(snap_state.target);
|
|
||||||
+ if (!savevm_aborted()) {
|
+ if (!savevm_aborted()) {
|
||||||
+ /* try to truncate, but ignore errors (will fail on block devices).
|
+ /* try to truncate, but ignore errors (will fail on block devices).
|
||||||
+ * note1: bdrv_read() need whole blocks, so we need to round up
|
+ * note1: bdrv_read() need whole blocks, so we need to round up
|
||||||
@@ -271,9 +269,7 @@ index 0000000000..ee8ef316d0
|
|||||||
+ size_t size = QEMU_ALIGN_UP(snap_state.bs_pos, BDRV_SECTOR_SIZE*2);
|
+ size_t size = QEMU_ALIGN_UP(snap_state.bs_pos, BDRV_SECTOR_SIZE*2);
|
||||||
+ blk_truncate(snap_state.target, size, false, PREALLOC_MODE_OFF, 0, NULL);
|
+ blk_truncate(snap_state.target, size, false, PREALLOC_MODE_OFF, 0, NULL);
|
||||||
+ }
|
+ }
|
||||||
+ if (target_bs) {
|
+ blk_op_unblock_all(snap_state.target, snap_state.blocker);
|
||||||
+ bdrv_op_unblock_all(target_bs, snap_state.blocker);
|
|
||||||
+ }
|
|
||||||
+ error_free(snap_state.blocker);
|
+ error_free(snap_state.blocker);
|
||||||
+ snap_state.blocker = NULL;
|
+ snap_state.blocker = NULL;
|
||||||
+ blk_unref(snap_state.target);
|
+ blk_unref(snap_state.target);
|
||||||
@@ -297,7 +293,7 @@ index 0000000000..ee8ef316d0
|
|||||||
+ DPRINTF("save_snapshot_error: %s\n", msg);
|
+ DPRINTF("save_snapshot_error: %s\n", msg);
|
||||||
+
|
+
|
||||||
+ if (!snap_state.error) {
|
+ if (!snap_state.error) {
|
||||||
+ error_setg(&snap_state.error, "%s", msg);
|
+ error_set(&snap_state.error, ERROR_CLASS_GENERIC_ERROR, "%s", msg);
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ g_free (msg);
|
+ g_free (msg);
|
||||||
@@ -484,18 +480,23 @@ index 0000000000..ee8ef316d0
|
|||||||
+ Error *local_err = NULL;
|
+ Error *local_err = NULL;
|
||||||
+ MigrationState *ms = migrate_get_current();
|
+ MigrationState *ms = migrate_get_current();
|
||||||
+ AioContext *iohandler_ctx = iohandler_get_aio_context();
|
+ AioContext *iohandler_ctx = iohandler_get_aio_context();
|
||||||
+ BlockDriverState *target_bs = NULL;
|
|
||||||
+ int ret = 0;
|
|
||||||
+
|
+
|
||||||
+ int bdrv_oflags = BDRV_O_RDWR | BDRV_O_RESIZE | BDRV_O_NO_FLUSH;
|
+ int bdrv_oflags = BDRV_O_RDWR | BDRV_O_RESIZE | BDRV_O_NO_FLUSH;
|
||||||
+
|
+
|
||||||
+ if (snap_state.state != SAVE_STATE_DONE) {
|
+ if (snap_state.state != SAVE_STATE_DONE) {
|
||||||
+ error_setg(errp, "VM snapshot already started\n");
|
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR,
|
||||||
|
+ "VM snapshot already started\n");
|
||||||
+ return;
|
+ return;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ if (migration_is_running()) {
|
+ if (migration_is_running()) {
|
||||||
+ error_setg(errp, "There's a migration process in progress");
|
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR, QERR_MIGRATION_ACTIVE);
|
||||||
|
+ return;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ if (migrate_block()) {
|
||||||
|
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR,
|
||||||
|
+ "Block migration and snapshots are incompatible");
|
||||||
+ return;
|
+ return;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
@@ -527,12 +528,7 @@ index 0000000000..ee8ef316d0
|
|||||||
+ qdict_put_str(options, "driver", "raw");
|
+ qdict_put_str(options, "driver", "raw");
|
||||||
+ snap_state.target = blk_new_open(statefile, NULL, options, bdrv_oflags, &local_err);
|
+ snap_state.target = blk_new_open(statefile, NULL, options, bdrv_oflags, &local_err);
|
||||||
+ if (!snap_state.target) {
|
+ if (!snap_state.target) {
|
||||||
+ error_setg(errp, "failed to open '%s'", statefile);
|
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR, "failed to open '%s'", statefile);
|
||||||
+ goto restart;
|
|
||||||
+ }
|
|
||||||
+ target_bs = blk_bs(snap_state.target);
|
|
||||||
+ if (!target_bs) {
|
|
||||||
+ error_setg(errp, "failed to open '%s' - no block driver state", statefile);
|
|
||||||
+ goto restart;
|
+ goto restart;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
@@ -541,7 +537,7 @@ index 0000000000..ee8ef316d0
|
|||||||
+ snap_state.file = qemu_file_new_output(ioc);
|
+ snap_state.file = qemu_file_new_output(ioc);
|
||||||
+
|
+
|
||||||
+ if (!snap_state.file) {
|
+ if (!snap_state.file) {
|
||||||
+ error_setg(errp, "failed to open '%s'", statefile);
|
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR, "failed to open '%s'", statefile);
|
||||||
+ goto restart;
|
+ goto restart;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
@@ -557,29 +553,19 @@ index 0000000000..ee8ef316d0
|
|||||||
+ ms->to_dst_file = snap_state.file;
|
+ ms->to_dst_file = snap_state.file;
|
||||||
+
|
+
|
||||||
+ error_setg(&snap_state.blocker, "block device is in use by savevm");
|
+ error_setg(&snap_state.blocker, "block device is in use by savevm");
|
||||||
+ bdrv_op_block_all(target_bs, snap_state.blocker);
|
+ blk_op_block_all(snap_state.target, snap_state.blocker);
|
||||||
+
|
+
|
||||||
+ snap_state.state = SAVE_STATE_ACTIVE;
|
+ snap_state.state = SAVE_STATE_ACTIVE;
|
||||||
+ snap_state.finalize_bh = qemu_bh_new(process_savevm_finalize, &snap_state);
|
+ snap_state.finalize_bh = qemu_bh_new(process_savevm_finalize, &snap_state);
|
||||||
|
+ snap_state.co = qemu_coroutine_create(&process_savevm_co, NULL);
|
||||||
+ qemu_savevm_state_header(snap_state.file);
|
+ qemu_savevm_state_header(snap_state.file);
|
||||||
+ ret = qemu_savevm_state_setup(snap_state.file, &local_err);
|
+ qemu_savevm_state_setup(snap_state.file);
|
||||||
+ if (ret != 0) {
|
|
||||||
+ error_setg_errno(errp, -ret, "savevm state setup failed: %s",
|
|
||||||
+ local_err ? error_get_pretty(local_err) : "unknown error");
|
|
||||||
+ return;
|
|
||||||
+ }
|
|
||||||
+
|
+
|
||||||
+ /* Async processing from here on out happens in iohandler context, so let
|
+ /* Async processing from here on out happens in iohandler context, so let
|
||||||
+ * the target bdrv have its home there.
|
+ * the target bdrv have its home there.
|
||||||
+ */
|
+ */
|
||||||
+ ret = blk_set_aio_context(snap_state.target, iohandler_ctx, &local_err);
|
+ blk_set_aio_context(snap_state.target, iohandler_ctx, &local_err);
|
||||||
+ if (ret != 0) {
|
|
||||||
+ warn_report("failed to set iohandler context for VM state target: %s %s",
|
|
||||||
+ local_err ? error_get_pretty(local_err) : "unknown error",
|
|
||||||
+ strerror(-ret));
|
|
||||||
+ }
|
|
||||||
+
|
+
|
||||||
+ snap_state.co = qemu_coroutine_create(&process_savevm_co, NULL);
|
|
||||||
+ aio_co_schedule(iohandler_ctx, snap_state.co);
|
+ aio_co_schedule(iohandler_ctx, snap_state.co);
|
||||||
+
|
+
|
||||||
+ return;
|
+ return;
|
||||||
@@ -628,7 +614,8 @@ index 0000000000..ee8ef316d0
|
|||||||
+void qmp_savevm_end(Error **errp)
|
+void qmp_savevm_end(Error **errp)
|
||||||
+{
|
+{
|
||||||
+ if (snap_state.state == SAVE_STATE_DONE) {
|
+ if (snap_state.state == SAVE_STATE_DONE) {
|
||||||
+ error_setg(errp, "VM snapshot not started\n");
|
+ error_set(errp, ERROR_CLASS_GENERIC_ERROR,
|
||||||
|
+ "VM snapshot not started\n");
|
||||||
+ return;
|
+ return;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
@@ -653,7 +640,6 @@ index 0000000000..ee8ef316d0
|
|||||||
+int load_snapshot_from_blockdev(const char *filename, Error **errp)
|
+int load_snapshot_from_blockdev(const char *filename, Error **errp)
|
||||||
+{
|
+{
|
||||||
+ BlockBackend *be;
|
+ BlockBackend *be;
|
||||||
+ BlockDriverState *bs = NULL;
|
|
||||||
+ Error *local_err = NULL;
|
+ Error *local_err = NULL;
|
||||||
+ Error *blocker = NULL;
|
+ Error *blocker = NULL;
|
||||||
+ QDict *options;
|
+ QDict *options;
|
||||||
@@ -672,14 +658,8 @@ index 0000000000..ee8ef316d0
|
|||||||
+ goto the_end;
|
+ goto the_end;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+ bs = blk_bs(be);
|
|
||||||
+ if (!bs) {
|
|
||||||
+ error_setg(errp, "Could not open VM state file - missing block driver state");
|
|
||||||
+ goto the_end;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ error_setg(&blocker, "block device is in use by load state");
|
+ error_setg(&blocker, "block device is in use by load state");
|
||||||
+ bdrv_op_block_all(bs, blocker);
|
+ blk_op_block_all(be, blocker);
|
||||||
+
|
+
|
||||||
+ /* restore the VM state */
|
+ /* restore the VM state */
|
||||||
+ f = qemu_file_new_input(QIO_CHANNEL(qio_channel_savevm_async_new(be, &bs_pos)));
|
+ f = qemu_file_new_input(QIO_CHANNEL(qio_channel_savevm_async_new(be, &bs_pos)));
|
||||||
@@ -709,30 +689,28 @@ index 0000000000..ee8ef316d0
|
|||||||
+
|
+
|
||||||
+ the_end:
|
+ the_end:
|
||||||
+ if (be) {
|
+ if (be) {
|
||||||
+ if (bs) {
|
+ blk_op_unblock_all(be, blocker);
|
||||||
+ bdrv_op_unblock_all(bs, blocker);
|
|
||||||
+ }
|
|
||||||
+ error_free(blocker);
|
+ error_free(blocker);
|
||||||
+ blk_unref(be);
|
+ blk_unref(be);
|
||||||
+ }
|
+ }
|
||||||
+ return ret;
|
+ return ret;
|
||||||
+}
|
+}
|
||||||
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
|
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
|
||||||
index f601d06ab8..874084565f 100644
|
index 871898ac46..ef4634e5c1 100644
|
||||||
--- a/monitor/hmp-cmds.c
|
--- a/monitor/hmp-cmds.c
|
||||||
+++ b/monitor/hmp-cmds.c
|
+++ b/monitor/hmp-cmds.c
|
||||||
@@ -24,6 +24,7 @@
|
@@ -22,6 +22,7 @@
|
||||||
|
#include "monitor/monitor-internal.h"
|
||||||
#include "qapi/error.h"
|
#include "qapi/error.h"
|
||||||
#include "qapi/qapi-commands-control.h"
|
#include "qapi/qapi-commands-control.h"
|
||||||
#include "qapi/qapi-commands-machine.h"
|
|
||||||
+#include "qapi/qapi-commands-migration.h"
|
+#include "qapi/qapi-commands-migration.h"
|
||||||
#include "qapi/qapi-commands-misc.h"
|
#include "qapi/qapi-commands-misc.h"
|
||||||
#include "qapi/qmp/qdict.h"
|
#include "qapi/qmp/qdict.h"
|
||||||
#include "qemu/cutils.h"
|
#include "qemu/cutils.h"
|
||||||
@@ -434,3 +435,40 @@ void hmp_dumpdtb(Monitor *mon, const QDict *qdict)
|
@@ -443,3 +444,40 @@ void hmp_info_mtree(Monitor *mon, const QDict *qdict)
|
||||||
monitor_printf(mon, "dtb dumped to %s", filename);
|
|
||||||
|
mtree_info(flatview, dispatch_tree, owner, disabled);
|
||||||
}
|
}
|
||||||
#endif
|
|
||||||
+
|
+
|
||||||
+void hmp_savevm_start(Monitor *mon, const QDict *qdict)
|
+void hmp_savevm_start(Monitor *mon, const QDict *qdict)
|
||||||
+{
|
+{
|
||||||
@@ -771,10 +749,10 @@ index f601d06ab8..874084565f 100644
|
|||||||
+ }
|
+ }
|
||||||
+}
|
+}
|
||||||
diff --git a/qapi/migration.json b/qapi/migration.json
|
diff --git a/qapi/migration.json b/qapi/migration.json
|
||||||
index a605dc26db..927b1e1c7d 100644
|
index 8c65b90328..ed20d066cd 100644
|
||||||
--- a/qapi/migration.json
|
--- a/qapi/migration.json
|
||||||
+++ b/qapi/migration.json
|
+++ b/qapi/migration.json
|
||||||
@@ -276,6 +276,40 @@
|
@@ -297,6 +297,40 @@
|
||||||
'*dirty-limit-throttle-time-per-round': 'uint64',
|
'*dirty-limit-throttle-time-per-round': 'uint64',
|
||||||
'*dirty-limit-ring-full-time': 'uint64'} }
|
'*dirty-limit-ring-full-time': 'uint64'} }
|
||||||
|
|
||||||
@@ -816,7 +794,7 @@ index a605dc26db..927b1e1c7d 100644
|
|||||||
# @query-migrate:
|
# @query-migrate:
|
||||||
#
|
#
|
||||||
diff --git a/qapi/misc.json b/qapi/misc.json
|
diff --git a/qapi/misc.json b/qapi/misc.json
|
||||||
index 559b66f201..7959e89c1e 100644
|
index ec30e5c570..3c68633f68 100644
|
||||||
--- a/qapi/misc.json
|
--- a/qapi/misc.json
|
||||||
+++ b/qapi/misc.json
|
+++ b/qapi/misc.json
|
||||||
@@ -454,6 +454,24 @@
|
@@ -454,6 +454,24 @@
|
||||||
@@ -845,10 +823,10 @@ index 559b66f201..7959e89c1e 100644
|
|||||||
# @CommandLineParameterType:
|
# @CommandLineParameterType:
|
||||||
#
|
#
|
||||||
diff --git a/qemu-options.hx b/qemu-options.hx
|
diff --git a/qemu-options.hx b/qemu-options.hx
|
||||||
index dacc9790a4..c05f411599 100644
|
index 8ce85d4559..511ab9415e 100644
|
||||||
--- a/qemu-options.hx
|
--- a/qemu-options.hx
|
||||||
+++ b/qemu-options.hx
|
+++ b/qemu-options.hx
|
||||||
@@ -4764,6 +4764,18 @@ SRST
|
@@ -4610,6 +4610,18 @@ SRST
|
||||||
Start right away with a saved state (``loadvm`` in monitor)
|
Start right away with a saved state (``loadvm`` in monitor)
|
||||||
ERST
|
ERST
|
||||||
|
|
||||||
@@ -868,10 +846,10 @@ index dacc9790a4..c05f411599 100644
|
|||||||
DEF("daemonize", 0, QEMU_OPTION_daemonize, \
|
DEF("daemonize", 0, QEMU_OPTION_daemonize, \
|
||||||
"-daemonize daemonize QEMU after initializing\n", QEMU_ARCH_ALL)
|
"-daemonize daemonize QEMU after initializing\n", QEMU_ARCH_ALL)
|
||||||
diff --git a/system/vl.c b/system/vl.c
|
diff --git a/system/vl.c b/system/vl.c
|
||||||
index 2f855d83fb..39d451bb41 100644
|
index c644222982..2738ab7c91 100644
|
||||||
--- a/system/vl.c
|
--- a/system/vl.c
|
||||||
+++ b/system/vl.c
|
+++ b/system/vl.c
|
||||||
@@ -164,6 +164,7 @@ static const char *accelerators;
|
@@ -163,6 +163,7 @@ static const char *accelerators;
|
||||||
static bool have_custom_ram_size;
|
static bool have_custom_ram_size;
|
||||||
static const char *ram_memdev_id;
|
static const char *ram_memdev_id;
|
||||||
static QDict *machine_opts_dict;
|
static QDict *machine_opts_dict;
|
||||||
@@ -879,7 +857,7 @@ index 2f855d83fb..39d451bb41 100644
|
|||||||
static QTAILQ_HEAD(, ObjectOption) object_opts = QTAILQ_HEAD_INITIALIZER(object_opts);
|
static QTAILQ_HEAD(, ObjectOption) object_opts = QTAILQ_HEAD_INITIALIZER(object_opts);
|
||||||
static QTAILQ_HEAD(, DeviceOption) device_opts = QTAILQ_HEAD_INITIALIZER(device_opts);
|
static QTAILQ_HEAD(, DeviceOption) device_opts = QTAILQ_HEAD_INITIALIZER(device_opts);
|
||||||
static int display_remote;
|
static int display_remote;
|
||||||
@@ -2725,6 +2726,12 @@ void qmp_x_exit_preconfig(Error **errp)
|
@@ -2712,6 +2713,12 @@ void qmp_x_exit_preconfig(Error **errp)
|
||||||
RunState state = autostart ? RUN_STATE_RUNNING : runstate_get();
|
RunState state = autostart ? RUN_STATE_RUNNING : runstate_get();
|
||||||
load_snapshot(loadvm, NULL, false, NULL, &error_fatal);
|
load_snapshot(loadvm, NULL, false, NULL, &error_fatal);
|
||||||
load_snapshot_resume(state);
|
load_snapshot_resume(state);
|
||||||
@@ -892,7 +870,7 @@ index 2f855d83fb..39d451bb41 100644
|
|||||||
}
|
}
|
||||||
if (replay_mode != REPLAY_MODE_NONE) {
|
if (replay_mode != REPLAY_MODE_NONE) {
|
||||||
replay_vmstate_init();
|
replay_vmstate_init();
|
||||||
@@ -3262,6 +3269,9 @@ void qemu_init(int argc, char **argv)
|
@@ -3259,6 +3266,9 @@ void qemu_init(int argc, char **argv)
|
||||||
case QEMU_OPTION_loadvm:
|
case QEMU_OPTION_loadvm:
|
||||||
loadvm = optarg;
|
loadvm = optarg;
|
||||||
break;
|
break;
|
||||||
|
@@ -13,16 +13,16 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
[FE: adapt to removal of QEMUFileOps]
|
[FE: adapt to removal of QEMUFileOps]
|
||||||
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
---
|
---
|
||||||
migration/qemu-file.c | 48 +++++++++++++++++++++++++++-------------
|
migration/qemu-file.c | 50 +++++++++++++++++++++++++++-------------
|
||||||
migration/qemu-file.h | 2 ++
|
migration/qemu-file.h | 2 ++
|
||||||
migration/savevm-async.c | 5 +++--
|
migration/savevm-async.c | 5 ++--
|
||||||
3 files changed, 38 insertions(+), 17 deletions(-)
|
3 files changed, 39 insertions(+), 18 deletions(-)
|
||||||
|
|
||||||
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
|
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
|
||||||
index b6d2f588bd..754dc0b3f7 100644
|
index a10882d47f..19c1de0472 100644
|
||||||
--- a/migration/qemu-file.c
|
--- a/migration/qemu-file.c
|
||||||
+++ b/migration/qemu-file.c
|
+++ b/migration/qemu-file.c
|
||||||
@@ -34,8 +34,8 @@
|
@@ -35,8 +35,8 @@
|
||||||
#include "rdma.h"
|
#include "rdma.h"
|
||||||
#include "io/channel-file.h"
|
#include "io/channel-file.h"
|
||||||
|
|
||||||
@@ -33,7 +33,7 @@ index b6d2f588bd..754dc0b3f7 100644
|
|||||||
|
|
||||||
struct QEMUFile {
|
struct QEMUFile {
|
||||||
QIOChannel *ioc;
|
QIOChannel *ioc;
|
||||||
@@ -43,7 +43,8 @@ struct QEMUFile {
|
@@ -44,7 +44,8 @@ struct QEMUFile {
|
||||||
|
|
||||||
int buf_index;
|
int buf_index;
|
||||||
int buf_size; /* 0 when writing */
|
int buf_size; /* 0 when writing */
|
||||||
@@ -43,7 +43,7 @@ index b6d2f588bd..754dc0b3f7 100644
|
|||||||
|
|
||||||
DECLARE_BITMAP(may_free, MAX_IOV_SIZE);
|
DECLARE_BITMAP(may_free, MAX_IOV_SIZE);
|
||||||
struct iovec iov[MAX_IOV_SIZE];
|
struct iovec iov[MAX_IOV_SIZE];
|
||||||
@@ -100,7 +101,9 @@ int qemu_file_shutdown(QEMUFile *f)
|
@@ -101,7 +102,9 @@ int qemu_file_shutdown(QEMUFile *f)
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -54,7 +54,7 @@ index b6d2f588bd..754dc0b3f7 100644
|
|||||||
{
|
{
|
||||||
QEMUFile *f;
|
QEMUFile *f;
|
||||||
|
|
||||||
@@ -109,6 +112,8 @@ static QEMUFile *qemu_file_new_impl(QIOChannel *ioc, bool is_writable)
|
@@ -110,6 +113,8 @@ static QEMUFile *qemu_file_new_impl(QIOChannel *ioc, bool is_writable)
|
||||||
object_ref(ioc);
|
object_ref(ioc);
|
||||||
f->ioc = ioc;
|
f->ioc = ioc;
|
||||||
f->is_writable = is_writable;
|
f->is_writable = is_writable;
|
||||||
@@ -63,7 +63,7 @@ index b6d2f588bd..754dc0b3f7 100644
|
|||||||
|
|
||||||
return f;
|
return f;
|
||||||
}
|
}
|
||||||
@@ -119,17 +124,27 @@ static QEMUFile *qemu_file_new_impl(QIOChannel *ioc, bool is_writable)
|
@@ -120,17 +125,27 @@ static QEMUFile *qemu_file_new_impl(QIOChannel *ioc, bool is_writable)
|
||||||
*/
|
*/
|
||||||
QEMUFile *qemu_file_get_return_path(QEMUFile *f)
|
QEMUFile *qemu_file_get_return_path(QEMUFile *f)
|
||||||
{
|
{
|
||||||
@@ -94,7 +94,7 @@ index b6d2f588bd..754dc0b3f7 100644
|
|||||||
}
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
@@ -327,7 +342,7 @@ static ssize_t coroutine_mixed_fn qemu_fill_buffer(QEMUFile *f)
|
@@ -328,7 +343,7 @@ static ssize_t coroutine_mixed_fn qemu_fill_buffer(QEMUFile *f)
|
||||||
do {
|
do {
|
||||||
len = qio_channel_read(f->ioc,
|
len = qio_channel_read(f->ioc,
|
||||||
(char *)f->buf + pending,
|
(char *)f->buf + pending,
|
||||||
@@ -103,7 +103,7 @@ index b6d2f588bd..754dc0b3f7 100644
|
|||||||
&local_error);
|
&local_error);
|
||||||
if (len == QIO_CHANNEL_ERR_BLOCK) {
|
if (len == QIO_CHANNEL_ERR_BLOCK) {
|
||||||
if (qemu_in_coroutine()) {
|
if (qemu_in_coroutine()) {
|
||||||
@@ -367,6 +382,9 @@ int qemu_fclose(QEMUFile *f)
|
@@ -368,6 +383,9 @@ int qemu_fclose(QEMUFile *f)
|
||||||
ret = ret2;
|
ret = ret2;
|
||||||
}
|
}
|
||||||
g_clear_pointer(&f->ioc, object_unref);
|
g_clear_pointer(&f->ioc, object_unref);
|
||||||
@@ -113,7 +113,7 @@ index b6d2f588bd..754dc0b3f7 100644
|
|||||||
error_free(f->last_error_obj);
|
error_free(f->last_error_obj);
|
||||||
g_free(f);
|
g_free(f);
|
||||||
trace_qemu_file_fclose();
|
trace_qemu_file_fclose();
|
||||||
@@ -415,7 +433,7 @@ static void add_buf_to_iovec(QEMUFile *f, size_t len)
|
@@ -416,7 +434,7 @@ static void add_buf_to_iovec(QEMUFile *f, size_t len)
|
||||||
{
|
{
|
||||||
if (!add_to_iovec(f, f->buf + f->buf_index, len, false)) {
|
if (!add_to_iovec(f, f->buf + f->buf_index, len, false)) {
|
||||||
f->buf_index += len;
|
f->buf_index += len;
|
||||||
@@ -122,7 +122,7 @@ index b6d2f588bd..754dc0b3f7 100644
|
|||||||
qemu_fflush(f);
|
qemu_fflush(f);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -440,7 +458,7 @@ void qemu_put_buffer(QEMUFile *f, const uint8_t *buf, size_t size)
|
@@ -441,7 +459,7 @@ void qemu_put_buffer(QEMUFile *f, const uint8_t *buf, size_t size)
|
||||||
}
|
}
|
||||||
|
|
||||||
while (size > 0) {
|
while (size > 0) {
|
||||||
@@ -131,7 +131,7 @@ index b6d2f588bd..754dc0b3f7 100644
|
|||||||
if (l > size) {
|
if (l > size) {
|
||||||
l = size;
|
l = size;
|
||||||
}
|
}
|
||||||
@@ -586,8 +604,8 @@ size_t coroutine_mixed_fn qemu_peek_buffer(QEMUFile *f, uint8_t **buf, size_t si
|
@@ -587,8 +605,8 @@ size_t coroutine_mixed_fn qemu_peek_buffer(QEMUFile *f, uint8_t **buf, size_t si
|
||||||
size_t index;
|
size_t index;
|
||||||
|
|
||||||
assert(!qemu_file_is_writable(f));
|
assert(!qemu_file_is_writable(f));
|
||||||
@@ -142,7 +142,7 @@ index b6d2f588bd..754dc0b3f7 100644
|
|||||||
|
|
||||||
/* The 1st byte to read from */
|
/* The 1st byte to read from */
|
||||||
index = f->buf_index + offset;
|
index = f->buf_index + offset;
|
||||||
@@ -637,7 +655,7 @@ size_t coroutine_mixed_fn qemu_get_buffer(QEMUFile *f, uint8_t *buf, size_t size
|
@@ -638,7 +656,7 @@ size_t coroutine_mixed_fn qemu_get_buffer(QEMUFile *f, uint8_t *buf, size_t size
|
||||||
size_t res;
|
size_t res;
|
||||||
uint8_t *src;
|
uint8_t *src;
|
||||||
|
|
||||||
@@ -151,7 +151,7 @@ index b6d2f588bd..754dc0b3f7 100644
|
|||||||
if (res == 0) {
|
if (res == 0) {
|
||||||
return done;
|
return done;
|
||||||
}
|
}
|
||||||
@@ -671,7 +689,7 @@ size_t coroutine_mixed_fn qemu_get_buffer(QEMUFile *f, uint8_t *buf, size_t size
|
@@ -672,7 +690,7 @@ size_t coroutine_mixed_fn qemu_get_buffer(QEMUFile *f, uint8_t *buf, size_t size
|
||||||
*/
|
*/
|
||||||
size_t coroutine_mixed_fn qemu_get_buffer_in_place(QEMUFile *f, uint8_t **buf, size_t size)
|
size_t coroutine_mixed_fn qemu_get_buffer_in_place(QEMUFile *f, uint8_t **buf, size_t size)
|
||||||
{
|
{
|
||||||
@@ -160,7 +160,7 @@ index b6d2f588bd..754dc0b3f7 100644
|
|||||||
size_t res;
|
size_t res;
|
||||||
uint8_t *src = NULL;
|
uint8_t *src = NULL;
|
||||||
|
|
||||||
@@ -696,7 +714,7 @@ int coroutine_mixed_fn qemu_peek_byte(QEMUFile *f, int offset)
|
@@ -697,7 +715,7 @@ int coroutine_mixed_fn qemu_peek_byte(QEMUFile *f, int offset)
|
||||||
int index = f->buf_index + offset;
|
int index = f->buf_index + offset;
|
||||||
|
|
||||||
assert(!qemu_file_is_writable(f));
|
assert(!qemu_file_is_writable(f));
|
||||||
@@ -169,8 +169,17 @@ index b6d2f588bd..754dc0b3f7 100644
|
|||||||
|
|
||||||
if (index >= f->buf_size) {
|
if (index >= f->buf_size) {
|
||||||
qemu_fill_buffer(f);
|
qemu_fill_buffer(f);
|
||||||
|
@@ -811,7 +829,7 @@ static int qemu_compress_data(z_stream *stream, uint8_t *dest, size_t dest_len,
|
||||||
|
ssize_t qemu_put_compression_data(QEMUFile *f, z_stream *stream,
|
||||||
|
const uint8_t *p, size_t size)
|
||||||
|
{
|
||||||
|
- ssize_t blen = IO_BUF_SIZE - f->buf_index - sizeof(int32_t);
|
||||||
|
+ ssize_t blen = f->buf_allocated_size - f->buf_index - sizeof(int32_t);
|
||||||
|
|
||||||
|
if (blen < compressBound(size)) {
|
||||||
|
return -1;
|
||||||
diff --git a/migration/qemu-file.h b/migration/qemu-file.h
|
diff --git a/migration/qemu-file.h b/migration/qemu-file.h
|
||||||
index 11c2120edd..edf3c5d147 100644
|
index 32fd4a34fd..36a0cd8cc8 100644
|
||||||
--- a/migration/qemu-file.h
|
--- a/migration/qemu-file.h
|
||||||
+++ b/migration/qemu-file.h
|
+++ b/migration/qemu-file.h
|
||||||
@@ -30,7 +30,9 @@
|
@@ -30,7 +30,9 @@
|
||||||
@@ -184,10 +193,10 @@ index 11c2120edd..edf3c5d147 100644
|
|||||||
|
|
||||||
/*
|
/*
|
||||||
diff --git a/migration/savevm-async.c b/migration/savevm-async.c
|
diff --git a/migration/savevm-async.c b/migration/savevm-async.c
|
||||||
index ee8ef316d0..1e79fce9ba 100644
|
index ae7ed68651..cdd5ea6288 100644
|
||||||
--- a/migration/savevm-async.c
|
--- a/migration/savevm-async.c
|
||||||
+++ b/migration/savevm-async.c
|
+++ b/migration/savevm-async.c
|
||||||
@@ -390,7 +390,7 @@ void qmp_savevm_start(const char *statefile, Error **errp)
|
@@ -386,7 +386,7 @@ void qmp_savevm_start(const char *statefile, Error **errp)
|
||||||
|
|
||||||
QIOChannel *ioc = QIO_CHANNEL(qio_channel_savevm_async_new(snap_state.target,
|
QIOChannel *ioc = QIO_CHANNEL(qio_channel_savevm_async_new(snap_state.target,
|
||||||
&snap_state.bs_pos));
|
&snap_state.bs_pos));
|
||||||
@@ -195,9 +204,9 @@ index ee8ef316d0..1e79fce9ba 100644
|
|||||||
+ snap_state.file = qemu_file_new_output_sized(ioc, 4 * 1024 * 1024);
|
+ snap_state.file = qemu_file_new_output_sized(ioc, 4 * 1024 * 1024);
|
||||||
|
|
||||||
if (!snap_state.file) {
|
if (!snap_state.file) {
|
||||||
error_setg(errp, "failed to open '%s'", statefile);
|
error_set(errp, ERROR_CLASS_GENERIC_ERROR, "failed to open '%s'", statefile);
|
||||||
@@ -534,7 +534,8 @@ int load_snapshot_from_blockdev(const char *filename, Error **errp)
|
@@ -514,7 +514,8 @@ int load_snapshot_from_blockdev(const char *filename, Error **errp)
|
||||||
bdrv_op_block_all(bs, blocker);
|
blk_op_block_all(be, blocker);
|
||||||
|
|
||||||
/* restore the VM state */
|
/* restore the VM state */
|
||||||
- f = qemu_file_new_input(QIO_CHANNEL(qio_channel_savevm_async_new(be, &bs_pos)));
|
- f = qemu_file_new_input(QIO_CHANNEL(qio_channel_savevm_async_new(be, &bs_pos)));
|
||||||
|
@@ -15,7 +15,7 @@ Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|||||||
create mode 100644 block/zeroinit.c
|
create mode 100644 block/zeroinit.c
|
||||||
|
|
||||||
diff --git a/block/meson.build b/block/meson.build
|
diff --git a/block/meson.build b/block/meson.build
|
||||||
index f1262ec2ba..6a60b5d6b9 100644
|
index e1f03fd773..b530e117b5 100644
|
||||||
--- a/block/meson.build
|
--- a/block/meson.build
|
||||||
+++ b/block/meson.build
|
+++ b/block/meson.build
|
||||||
@@ -39,6 +39,7 @@ block_ss.add(files(
|
@@ -39,6 +39,7 @@ block_ss.add(files(
|
||||||
@@ -23,12 +23,12 @@ index f1262ec2ba..6a60b5d6b9 100644
|
|||||||
'throttle-groups.c',
|
'throttle-groups.c',
|
||||||
'write-threshold.c',
|
'write-threshold.c',
|
||||||
+ 'zeroinit.c',
|
+ 'zeroinit.c',
|
||||||
), zstd, zlib)
|
), zstd, zlib, gnutls)
|
||||||
|
|
||||||
system_ss.add(when: 'CONFIG_TCG', if_true: files('blkreplay.c'))
|
system_ss.add(when: 'CONFIG_TCG', if_true: files('blkreplay.c'))
|
||||||
diff --git a/block/zeroinit.c b/block/zeroinit.c
|
diff --git a/block/zeroinit.c b/block/zeroinit.c
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..2b2b194ccf
|
index 0000000000..7998c9332d
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/block/zeroinit.c
|
+++ b/block/zeroinit.c
|
||||||
@@ -0,0 +1,207 @@
|
@@ -0,0 +1,207 @@
|
||||||
@@ -212,7 +212,7 @@ index 0000000000..2b2b194ccf
|
|||||||
+ .instance_size = sizeof(BDRVZeroinitState),
|
+ .instance_size = sizeof(BDRVZeroinitState),
|
||||||
+
|
+
|
||||||
+ .bdrv_parse_filename = zeroinit_parse_filename,
|
+ .bdrv_parse_filename = zeroinit_parse_filename,
|
||||||
+ .bdrv_open = zeroinit_open,
|
+ .bdrv_file_open = zeroinit_open,
|
||||||
+ .bdrv_close = zeroinit_close,
|
+ .bdrv_close = zeroinit_close,
|
||||||
+ .bdrv_co_getlength = zeroinit_co_getlength,
|
+ .bdrv_co_getlength = zeroinit_co_getlength,
|
||||||
+ .bdrv_child_perm = bdrv_default_perms,
|
+ .bdrv_child_perm = bdrv_default_perms,
|
||||||
|
@@ -14,10 +14,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
2 files changed, 11 insertions(+)
|
2 files changed, 11 insertions(+)
|
||||||
|
|
||||||
diff --git a/qemu-options.hx b/qemu-options.hx
|
diff --git a/qemu-options.hx b/qemu-options.hx
|
||||||
index c05f411599..0732077a0e 100644
|
index 511ab9415e..92e301d545 100644
|
||||||
--- a/qemu-options.hx
|
--- a/qemu-options.hx
|
||||||
+++ b/qemu-options.hx
|
+++ b/qemu-options.hx
|
||||||
@@ -1239,6 +1239,9 @@ legacy PC, they are not recommended for modern configurations.
|
@@ -1237,6 +1237,9 @@ legacy PC, they are not recommended for modern configurations.
|
||||||
|
|
||||||
ERST
|
ERST
|
||||||
|
|
||||||
@@ -28,10 +28,10 @@ index c05f411599..0732077a0e 100644
|
|||||||
"-fda/-fdb file use 'file' as floppy disk 0/1 image\n", QEMU_ARCH_ALL)
|
"-fda/-fdb file use 'file' as floppy disk 0/1 image\n", QEMU_ARCH_ALL)
|
||||||
DEF("fdb", HAS_ARG, QEMU_OPTION_fdb, "", QEMU_ARCH_ALL)
|
DEF("fdb", HAS_ARG, QEMU_OPTION_fdb, "", QEMU_ARCH_ALL)
|
||||||
diff --git a/system/vl.c b/system/vl.c
|
diff --git a/system/vl.c b/system/vl.c
|
||||||
index 39d451bb41..e7cae51f13 100644
|
index 2738ab7c91..20ebf2c920 100644
|
||||||
--- a/system/vl.c
|
--- a/system/vl.c
|
||||||
+++ b/system/vl.c
|
+++ b/system/vl.c
|
||||||
@@ -2762,6 +2762,7 @@ void qemu_init(int argc, char **argv)
|
@@ -2748,6 +2748,7 @@ void qemu_init(int argc, char **argv)
|
||||||
MachineClass *machine_class;
|
MachineClass *machine_class;
|
||||||
bool userconfig = true;
|
bool userconfig = true;
|
||||||
FILE *vmstate_dump_file = NULL;
|
FILE *vmstate_dump_file = NULL;
|
||||||
@@ -39,7 +39,7 @@ index 39d451bb41..e7cae51f13 100644
|
|||||||
|
|
||||||
qemu_add_opts(&qemu_drive_opts);
|
qemu_add_opts(&qemu_drive_opts);
|
||||||
qemu_add_drive_opts(&qemu_legacy_drive_opts);
|
qemu_add_drive_opts(&qemu_legacy_drive_opts);
|
||||||
@@ -3374,6 +3375,13 @@ void qemu_init(int argc, char **argv)
|
@@ -3371,6 +3372,13 @@ void qemu_init(int argc, char **argv)
|
||||||
machine_parse_property_opt(qemu_find_opts("smp-opts"),
|
machine_parse_property_opt(qemu_find_opts("smp-opts"),
|
||||||
"smp", optarg);
|
"smp", optarg);
|
||||||
break;
|
break;
|
||||||
|
@@ -11,7 +11,7 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 9 insertions(+)
|
1 file changed, 9 insertions(+)
|
||||||
|
|
||||||
diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
|
diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
|
||||||
index 62f3bbf203..89e0c7d995 100644
|
index d8fc1e2815..789694b8b3 100644
|
||||||
--- a/hw/intc/apic_common.c
|
--- a/hw/intc/apic_common.c
|
||||||
+++ b/hw/intc/apic_common.c
|
+++ b/hw/intc/apic_common.c
|
||||||
@@ -263,6 +263,15 @@ static void apic_reset_common(DeviceState *dev)
|
@@ -263,6 +263,15 @@ static void apic_reset_common(DeviceState *dev)
|
||||||
|
@@ -13,10 +13,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
2 files changed, 46 insertions(+), 20 deletions(-)
|
2 files changed, 46 insertions(+), 20 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/file-posix.c b/block/file-posix.c
|
diff --git a/block/file-posix.c b/block/file-posix.c
|
||||||
index e2ea071315..4c3dc56c8e 100644
|
index 43bc0bd520..60e98c87f1 100644
|
||||||
--- a/block/file-posix.c
|
--- a/block/file-posix.c
|
||||||
+++ b/block/file-posix.c
|
+++ b/block/file-posix.c
|
||||||
@@ -2884,6 +2884,7 @@ raw_co_create(BlockdevCreateOptions *options, Error **errp)
|
@@ -2876,6 +2876,7 @@ raw_co_create(BlockdevCreateOptions *options, Error **errp)
|
||||||
int fd;
|
int fd;
|
||||||
uint64_t perm, shared;
|
uint64_t perm, shared;
|
||||||
int result = 0;
|
int result = 0;
|
||||||
@@ -24,7 +24,7 @@ index e2ea071315..4c3dc56c8e 100644
|
|||||||
|
|
||||||
/* Validate options and set default values */
|
/* Validate options and set default values */
|
||||||
assert(options->driver == BLOCKDEV_DRIVER_FILE);
|
assert(options->driver == BLOCKDEV_DRIVER_FILE);
|
||||||
@@ -2924,19 +2925,22 @@ raw_co_create(BlockdevCreateOptions *options, Error **errp)
|
@@ -2916,19 +2917,22 @@ raw_co_create(BlockdevCreateOptions *options, Error **errp)
|
||||||
perm = BLK_PERM_WRITE | BLK_PERM_RESIZE;
|
perm = BLK_PERM_WRITE | BLK_PERM_RESIZE;
|
||||||
shared = BLK_PERM_ALL & ~BLK_PERM_RESIZE;
|
shared = BLK_PERM_ALL & ~BLK_PERM_RESIZE;
|
||||||
|
|
||||||
@@ -59,7 +59,7 @@ index e2ea071315..4c3dc56c8e 100644
|
|||||||
}
|
}
|
||||||
|
|
||||||
/* Clear the file by truncating it to 0 */
|
/* Clear the file by truncating it to 0 */
|
||||||
@@ -2990,13 +2994,15 @@ raw_co_create(BlockdevCreateOptions *options, Error **errp)
|
@@ -2982,13 +2986,15 @@ raw_co_create(BlockdevCreateOptions *options, Error **errp)
|
||||||
}
|
}
|
||||||
|
|
||||||
out_unlock:
|
out_unlock:
|
||||||
@@ -82,7 +82,7 @@ index e2ea071315..4c3dc56c8e 100644
|
|||||||
}
|
}
|
||||||
|
|
||||||
out_close:
|
out_close:
|
||||||
@@ -3020,6 +3026,7 @@ raw_co_create_opts(BlockDriver *drv, const char *filename,
|
@@ -3012,6 +3018,7 @@ raw_co_create_opts(BlockDriver *drv, const char *filename,
|
||||||
PreallocMode prealloc;
|
PreallocMode prealloc;
|
||||||
char *buf = NULL;
|
char *buf = NULL;
|
||||||
Error *local_err = NULL;
|
Error *local_err = NULL;
|
||||||
@@ -90,7 +90,7 @@ index e2ea071315..4c3dc56c8e 100644
|
|||||||
|
|
||||||
/* Skip file: protocol prefix */
|
/* Skip file: protocol prefix */
|
||||||
strstart(filename, "file:", &filename);
|
strstart(filename, "file:", &filename);
|
||||||
@@ -3042,6 +3049,18 @@ raw_co_create_opts(BlockDriver *drv, const char *filename,
|
@@ -3034,6 +3041,18 @@ raw_co_create_opts(BlockDriver *drv, const char *filename,
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -109,7 +109,7 @@ index e2ea071315..4c3dc56c8e 100644
|
|||||||
options = (BlockdevCreateOptions) {
|
options = (BlockdevCreateOptions) {
|
||||||
.driver = BLOCKDEV_DRIVER_FILE,
|
.driver = BLOCKDEV_DRIVER_FILE,
|
||||||
.u.file = {
|
.u.file = {
|
||||||
@@ -3053,6 +3072,8 @@ raw_co_create_opts(BlockDriver *drv, const char *filename,
|
@@ -3045,6 +3064,8 @@ raw_co_create_opts(BlockDriver *drv, const char *filename,
|
||||||
.nocow = nocow,
|
.nocow = nocow,
|
||||||
.has_extent_size_hint = has_extent_size_hint,
|
.has_extent_size_hint = has_extent_size_hint,
|
||||||
.extent_size_hint = extent_size_hint,
|
.extent_size_hint = extent_size_hint,
|
||||||
@@ -119,10 +119,10 @@ index e2ea071315..4c3dc56c8e 100644
|
|||||||
};
|
};
|
||||||
return raw_co_create(&options, errp);
|
return raw_co_create(&options, errp);
|
||||||
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
||||||
index 48ba32049f..321d1fd0e1 100644
|
index 905da8be72..3db587a6e4 100644
|
||||||
--- a/qapi/block-core.json
|
--- a/qapi/block-core.json
|
||||||
+++ b/qapi/block-core.json
|
+++ b/qapi/block-core.json
|
||||||
@@ -4974,6 +4974,10 @@
|
@@ -4956,6 +4956,10 @@
|
||||||
# @extent-size-hint: Extent size hint to add to the image file; 0 for
|
# @extent-size-hint: Extent size hint to add to the image file; 0 for
|
||||||
# not adding an extent size hint (default: 1 MB, since 5.1)
|
# not adding an extent size hint (default: 1 MB, since 5.1)
|
||||||
#
|
#
|
||||||
@@ -133,7 +133,7 @@ index 48ba32049f..321d1fd0e1 100644
|
|||||||
# Since: 2.12
|
# Since: 2.12
|
||||||
##
|
##
|
||||||
{ 'struct': 'BlockdevCreateOptionsFile',
|
{ 'struct': 'BlockdevCreateOptionsFile',
|
||||||
@@ -4981,7 +4985,8 @@
|
@@ -4963,7 +4967,8 @@
|
||||||
'size': 'size',
|
'size': 'size',
|
||||||
'*preallocation': 'PreallocMode',
|
'*preallocation': 'PreallocMode',
|
||||||
'*nocow': 'bool',
|
'*nocow': 'bool',
|
||||||
|
@@ -18,10 +18,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 1 insertion(+), 2 deletions(-)
|
1 file changed, 1 insertion(+), 2 deletions(-)
|
||||||
|
|
||||||
diff --git a/monitor/qmp.c b/monitor/qmp.c
|
diff --git a/monitor/qmp.c b/monitor/qmp.c
|
||||||
index eb181d5979..20fc0d20a6 100644
|
index 589c9524f8..2505dd658a 100644
|
||||||
--- a/monitor/qmp.c
|
--- a/monitor/qmp.c
|
||||||
+++ b/monitor/qmp.c
|
+++ b/monitor/qmp.c
|
||||||
@@ -534,8 +534,7 @@ void monitor_init_qmp(Chardev *chr, bool pretty, Error **errp)
|
@@ -536,8 +536,7 @@ void monitor_init_qmp(Chardev *chr, bool pretty, Error **errp)
|
||||||
qemu_chr_fe_set_echo(&mon->common.chr, true);
|
qemu_chr_fe_set_echo(&mon->common.chr, true);
|
||||||
|
|
||||||
/* Note: we run QMP monitor in I/O thread when @chr supports that */
|
/* Note: we run QMP monitor in I/O thread when @chr supports that */
|
||||||
|
@@ -26,10 +26,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 2 insertions(+), 1 deletion(-)
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
diff --git a/hw/core/machine.c b/hw/core/machine.c
|
diff --git a/hw/core/machine.c b/hw/core/machine.c
|
||||||
index f29fe95964..2c327fc36a 100644
|
index 4273de16a0..83f1fc0293 100644
|
||||||
--- a/hw/core/machine.c
|
--- a/hw/core/machine.c
|
||||||
+++ b/hw/core/machine.c
|
+++ b/hw/core/machine.c
|
||||||
@@ -180,7 +180,8 @@ GlobalProperty hw_compat_4_0[] = {
|
@@ -162,7 +162,8 @@ GlobalProperty hw_compat_4_0[] = {
|
||||||
{ "virtio-vga", "edid", "false" },
|
{ "virtio-vga", "edid", "false" },
|
||||||
{ "virtio-gpu-device", "edid", "false" },
|
{ "virtio-gpu-device", "edid", "false" },
|
||||||
{ "virtio-device", "use-started", "false" },
|
{ "virtio-device", "use-started", "false" },
|
||||||
|
@@ -16,15 +16,15 @@ Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|||||||
---
|
---
|
||||||
hw/core/machine-qmp-cmds.c | 5 +++++
|
hw/core/machine-qmp-cmds.c | 5 +++++
|
||||||
include/hw/boards.h | 2 ++
|
include/hw/boards.h | 2 ++
|
||||||
qapi/machine.json | 3 +++
|
qapi/machine.json | 4 +++-
|
||||||
system/vl.c | 24 ++++++++++++++++++++++++
|
system/vl.c | 25 +++++++++++++++++++++++++
|
||||||
4 files changed, 34 insertions(+)
|
4 files changed, 35 insertions(+), 1 deletion(-)
|
||||||
|
|
||||||
diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c
|
diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c
|
||||||
index 52a6d74820..362128842d 100644
|
index 314351cdff..628a3537c5 100644
|
||||||
--- a/hw/core/machine-qmp-cmds.c
|
--- a/hw/core/machine-qmp-cmds.c
|
||||||
+++ b/hw/core/machine-qmp-cmds.c
|
+++ b/hw/core/machine-qmp-cmds.c
|
||||||
@@ -94,6 +94,11 @@ MachineInfoList *qmp_query_machines(bool has_compat_props, bool compat_props,
|
@@ -94,6 +94,11 @@ MachineInfoList *qmp_query_machines(Error **errp)
|
||||||
if (strcmp(mc->name, MACHINE_GET_CLASS(current_machine)->name) == 0) {
|
if (strcmp(mc->name, MACHINE_GET_CLASS(current_machine)->name) == 0) {
|
||||||
info->has_is_current = true;
|
info->has_is_current = true;
|
||||||
info->is_current = true;
|
info->is_current = true;
|
||||||
@@ -37,64 +37,65 @@ index 52a6d74820..362128842d 100644
|
|||||||
|
|
||||||
if (mc->default_cpu_type) {
|
if (mc->default_cpu_type) {
|
||||||
diff --git a/include/hw/boards.h b/include/hw/boards.h
|
diff --git a/include/hw/boards.h b/include/hw/boards.h
|
||||||
index 36fbb9b59d..d1741ea121 100644
|
index 8b8f6d5c00..dd6d0a1447 100644
|
||||||
--- a/include/hw/boards.h
|
--- a/include/hw/boards.h
|
||||||
+++ b/include/hw/boards.h
|
+++ b/include/hw/boards.h
|
||||||
@@ -268,6 +268,8 @@ struct MachineClass {
|
@@ -246,6 +246,8 @@ struct MachineClass {
|
||||||
const char *desc;
|
const char *desc;
|
||||||
const char *deprecation_reason;
|
const char *deprecation_reason;
|
||||||
|
|
||||||
+ const char *pve_version;
|
+ const char *pve_version;
|
||||||
+
|
+
|
||||||
void (*init)(MachineState *state);
|
void (*init)(MachineState *state);
|
||||||
void (*reset)(MachineState *state, ResetType type);
|
void (*reset)(MachineState *state, ShutdownCause reason);
|
||||||
void (*wakeup)(MachineState *state);
|
void (*wakeup)(MachineState *state);
|
||||||
diff --git a/qapi/machine.json b/qapi/machine.json
|
diff --git a/qapi/machine.json b/qapi/machine.json
|
||||||
index 16366b774a..12cfd3f260 100644
|
index a024d5b05d..1d69bffaa0 100644
|
||||||
--- a/qapi/machine.json
|
--- a/qapi/machine.json
|
||||||
+++ b/qapi/machine.json
|
+++ b/qapi/machine.json
|
||||||
@@ -189,6 +189,8 @@
|
@@ -168,6 +168,8 @@
|
||||||
#
|
#
|
||||||
# @acpi: machine type supports ACPI (since 8.0)
|
# @acpi: machine type supports ACPI (since 8.0)
|
||||||
#
|
#
|
||||||
+# @pve-version: custom PVE version suffix specified as 'machine+pveN'
|
+# @pve-version: custom PVE version suffix specified as 'machine+pveN'
|
||||||
+#
|
+#
|
||||||
# @compat-props: The machine type's compatibility properties. Only
|
# Since: 1.2
|
||||||
# present when query-machines argument @compat-props is true.
|
##
|
||||||
# (since 9.1)
|
{ 'struct': 'MachineInfo',
|
||||||
@@ -205,6 +207,7 @@
|
@@ -175,7 +177,7 @@
|
||||||
|
'*is-default': 'bool', '*is-current': 'bool', 'cpu-max': 'int',
|
||||||
'hotpluggable-cpus': 'bool', 'numa-mem-supported': 'bool',
|
'hotpluggable-cpus': 'bool', 'numa-mem-supported': 'bool',
|
||||||
'deprecated': 'bool', '*default-cpu-type': 'str',
|
'deprecated': 'bool', '*default-cpu-type': 'str',
|
||||||
'*default-ram-id': 'str', 'acpi': 'bool',
|
- '*default-ram-id': 'str', 'acpi': 'bool' } }
|
||||||
+ '*pve-version': 'str',
|
+ '*default-ram-id': 'str', 'acpi': 'bool', '*pve-version': 'str' } }
|
||||||
'*compat-props': { 'type': ['CompatProperty'],
|
|
||||||
'features': ['unstable'] } } }
|
|
||||||
|
|
||||||
|
##
|
||||||
|
# @query-machines:
|
||||||
diff --git a/system/vl.c b/system/vl.c
|
diff --git a/system/vl.c b/system/vl.c
|
||||||
index e7cae51f13..3f4916ac5a 100644
|
index 20ebf2c920..4d39e32097 100644
|
||||||
--- a/system/vl.c
|
--- a/system/vl.c
|
||||||
+++ b/system/vl.c
|
+++ b/system/vl.c
|
||||||
@@ -1675,6 +1675,7 @@ static MachineClass *select_machine(QDict *qdict, Error **errp)
|
@@ -1659,6 +1659,7 @@ static const QEMUOption *lookup_opt(int argc, char **argv,
|
||||||
|
static MachineClass *select_machine(QDict *qdict, Error **errp)
|
||||||
{
|
{
|
||||||
ERRP_GUARD();
|
|
||||||
const char *machine_type = qdict_get_try_str(qdict, "type");
|
const char *machine_type = qdict_get_try_str(qdict, "type");
|
||||||
+ const char *pvever = qdict_get_try_str(qdict, "pvever");
|
+ const char *pvever = qdict_get_try_str(qdict, "pvever");
|
||||||
g_autoptr(GSList) machines = object_class_get_list(TYPE_MACHINE, false);
|
GSList *machines = object_class_get_list(TYPE_MACHINE, false);
|
||||||
MachineClass *machine_class = NULL;
|
MachineClass *machine_class;
|
||||||
|
Error *local_err = NULL;
|
||||||
|
@@ -1676,6 +1677,11 @@ static MachineClass *select_machine(QDict *qdict, Error **errp)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
@@ -1694,7 +1695,11 @@ static MachineClass *select_machine(QDict *qdict, Error **errp)
|
+ if (machine_class) {
|
||||||
if (!machine_class) {
|
|
||||||
error_append_hint(errp,
|
|
||||||
"Use -machine help to list supported machines\n");
|
|
||||||
+ } else {
|
|
||||||
+ machine_class->pve_version = g_strdup(pvever);
|
+ machine_class->pve_version = g_strdup(pvever);
|
||||||
+ qdict_del(qdict, "pvever");
|
+ qdict_del(qdict, "pvever");
|
||||||
}
|
+ }
|
||||||
+
|
+
|
||||||
return machine_class;
|
g_slist_free(machines);
|
||||||
}
|
if (local_err) {
|
||||||
|
error_append_hint(&local_err, "Use -machine help to list supported machines\n");
|
||||||
@@ -3316,12 +3321,31 @@ void qemu_init(int argc, char **argv)
|
@@ -3313,12 +3319,31 @@ void qemu_init(int argc, char **argv)
|
||||||
case QEMU_OPTION_machine:
|
case QEMU_OPTION_machine:
|
||||||
{
|
{
|
||||||
bool help;
|
bool help;
|
||||||
|
@@ -25,7 +25,7 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 4 insertions(+), 4 deletions(-)
|
1 file changed, 4 insertions(+), 4 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/backup.c b/block/backup.c
|
diff --git a/block/backup.c b/block/backup.c
|
||||||
index a1292c01ec..2e38b30d67 100644
|
index 3dd2e229d2..eba5b11493 100644
|
||||||
--- a/block/backup.c
|
--- a/block/backup.c
|
||||||
+++ b/block/backup.c
|
+++ b/block/backup.c
|
||||||
@@ -237,8 +237,8 @@ static void backup_init_bcs_bitmap(BackupBlockJob *job)
|
@@ -237,8 +237,8 @@ static void backup_init_bcs_bitmap(BackupBlockJob *job)
|
||||||
|
@@ -16,23 +16,23 @@ Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|||||||
---
|
---
|
||||||
block/meson.build | 2 +
|
block/meson.build | 2 +
|
||||||
meson.build | 5 +
|
meson.build | 5 +
|
||||||
vma-reader.c | 867 ++++++++++++++++++++++++++++++++++++++++++
|
vma-reader.c | 870 ++++++++++++++++++++++++++++++++++++++++++
|
||||||
vma-writer.c | 816 ++++++++++++++++++++++++++++++++++++++++
|
vma-writer.c | 817 ++++++++++++++++++++++++++++++++++++++++
|
||||||
vma.c | 941 ++++++++++++++++++++++++++++++++++++++++++++++
|
vma.c | 941 ++++++++++++++++++++++++++++++++++++++++++++++
|
||||||
vma.h | 150 ++++++++
|
vma.h | 150 ++++++++
|
||||||
6 files changed, 2781 insertions(+)
|
6 files changed, 2785 insertions(+)
|
||||||
create mode 100644 vma-reader.c
|
create mode 100644 vma-reader.c
|
||||||
create mode 100644 vma-writer.c
|
create mode 100644 vma-writer.c
|
||||||
create mode 100644 vma.c
|
create mode 100644 vma.c
|
||||||
create mode 100644 vma.h
|
create mode 100644 vma.h
|
||||||
|
|
||||||
diff --git a/block/meson.build b/block/meson.build
|
diff --git a/block/meson.build b/block/meson.build
|
||||||
index 6a60b5d6b9..652c8cbdb7 100644
|
index b530e117b5..b245daa98e 100644
|
||||||
--- a/block/meson.build
|
--- a/block/meson.build
|
||||||
+++ b/block/meson.build
|
+++ b/block/meson.build
|
||||||
@@ -42,6 +42,8 @@ block_ss.add(files(
|
@@ -42,6 +42,8 @@ block_ss.add(files(
|
||||||
'zeroinit.c',
|
'zeroinit.c',
|
||||||
), zstd, zlib)
|
), zstd, zlib, gnutls)
|
||||||
|
|
||||||
+block_ss.add(files('../vma-writer.c'), libuuid)
|
+block_ss.add(files('../vma-writer.c'), libuuid)
|
||||||
+
|
+
|
||||||
@@ -40,10 +40,10 @@ index 6a60b5d6b9..652c8cbdb7 100644
|
|||||||
system_ss.add(files('block-ram-registrar.c'))
|
system_ss.add(files('block-ram-registrar.c'))
|
||||||
|
|
||||||
diff --git a/meson.build b/meson.build
|
diff --git a/meson.build b/meson.build
|
||||||
index 147097c652..b9b673c271 100644
|
index 91a0aa64c6..620cc594b2 100644
|
||||||
--- a/meson.build
|
--- a/meson.build
|
||||||
+++ b/meson.build
|
+++ b/meson.build
|
||||||
@@ -2129,6 +2129,8 @@ endif
|
@@ -1922,6 +1922,8 @@ endif
|
||||||
|
|
||||||
has_gettid = cc.has_function('gettid')
|
has_gettid = cc.has_function('gettid')
|
||||||
|
|
||||||
@@ -52,22 +52,22 @@ index 147097c652..b9b673c271 100644
|
|||||||
# libselinux
|
# libselinux
|
||||||
selinux = dependency('libselinux',
|
selinux = dependency('libselinux',
|
||||||
required: get_option('selinux'),
|
required: get_option('selinux'),
|
||||||
@@ -4344,6 +4346,9 @@ if have_tools
|
@@ -4023,6 +4025,9 @@ if have_tools
|
||||||
dependencies: [blockdev, qemuutil, selinux],
|
dependencies: [blockdev, qemuutil, gnutls, selinux],
|
||||||
install: true)
|
install: true)
|
||||||
|
|
||||||
+ vma = executable('vma', files('vma.c', 'vma-reader.c') + genh,
|
+ vma = executable('vma', files('vma.c', 'vma-reader.c') + genh,
|
||||||
+ dependencies: [authz, block, crypto, io, qemuutil, qom], install: true)
|
+ dependencies: [authz, block, crypto, io, qom], install: true)
|
||||||
+
|
+
|
||||||
subdir('storage-daemon')
|
subdir('storage-daemon')
|
||||||
|
|
||||||
foreach exe: [ 'qemu-img', 'qemu-io', 'qemu-nbd', 'qemu-storage-daemon']
|
foreach exe: [ 'qemu-img', 'qemu-io', 'qemu-nbd', 'qemu-storage-daemon']
|
||||||
diff --git a/vma-reader.c b/vma-reader.c
|
diff --git a/vma-reader.c b/vma-reader.c
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..bb65ad313c
|
index 0000000000..d0b6721812
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/vma-reader.c
|
+++ b/vma-reader.c
|
||||||
@@ -0,0 +1,867 @@
|
@@ -0,0 +1,870 @@
|
||||||
+/*
|
+/*
|
||||||
+ * VMA: Virtual Machine Archive
|
+ * VMA: Virtual Machine Archive
|
||||||
+ *
|
+ *
|
||||||
@@ -382,6 +382,7 @@ index 0000000000..bb65ad313c
|
|||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
+
|
+
|
||||||
|
+ int count = 0;
|
||||||
+ for (i = 1; i < 256; i++) {
|
+ for (i = 1; i < 256; i++) {
|
||||||
+ VmaDeviceInfoHeader *dih = &h->dev_info[i];
|
+ VmaDeviceInfoHeader *dih = &h->dev_info[i];
|
||||||
+ uint32_t devname_ptr = GUINT32_FROM_BE(dih->devname_ptr);
|
+ uint32_t devname_ptr = GUINT32_FROM_BE(dih->devname_ptr);
|
||||||
@@ -389,6 +390,7 @@ index 0000000000..bb65ad313c
|
|||||||
+ const char *devname = get_header_str(vmar, devname_ptr);
|
+ const char *devname = get_header_str(vmar, devname_ptr);
|
||||||
+
|
+
|
||||||
+ if (size && devname) {
|
+ if (size && devname) {
|
||||||
|
+ count++;
|
||||||
+ vmar->devinfo[i].size = size;
|
+ vmar->devinfo[i].size = size;
|
||||||
+ vmar->devinfo[i].devname = devname;
|
+ vmar->devinfo[i].devname = devname;
|
||||||
+
|
+
|
||||||
@@ -883,7 +885,8 @@ index 0000000000..bb65ad313c
|
|||||||
+
|
+
|
||||||
+ int64_t cluster_num, end;
|
+ int64_t cluster_num, end;
|
||||||
+
|
+
|
||||||
+ end = DIV_ROUND_UP(vmar->devinfo[i].size, VMA_CLUSTER_SIZE);
|
+ end = (vmar->devinfo[i].size + VMA_CLUSTER_SIZE - 1) /
|
||||||
|
+ VMA_CLUSTER_SIZE;
|
||||||
+
|
+
|
||||||
+ for (cluster_num = 0; cluster_num < end; cluster_num++) {
|
+ for (cluster_num = 0; cluster_num < end; cluster_num++) {
|
||||||
+ if (!vma_reader_get_bitmap(rstate, cluster_num)) {
|
+ if (!vma_reader_get_bitmap(rstate, cluster_num)) {
|
||||||
@@ -937,10 +940,10 @@ index 0000000000..bb65ad313c
|
|||||||
+
|
+
|
||||||
diff --git a/vma-writer.c b/vma-writer.c
|
diff --git a/vma-writer.c b/vma-writer.c
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..3f489092df
|
index 0000000000..a466652a5d
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/vma-writer.c
|
+++ b/vma-writer.c
|
||||||
@@ -0,0 +1,816 @@
|
@@ -0,0 +1,817 @@
|
||||||
+/*
|
+/*
|
||||||
+ * VMA: Virtual Machine Archive
|
+ * VMA: Virtual Machine Archive
|
||||||
+ *
|
+ *
|
||||||
@@ -1134,7 +1137,8 @@ index 0000000000..3f489092df
|
|||||||
+ vmaw->stream_info[n].devname = g_strdup(devname);
|
+ vmaw->stream_info[n].devname = g_strdup(devname);
|
||||||
+ vmaw->stream_info[n].size = size;
|
+ vmaw->stream_info[n].size = size;
|
||||||
+
|
+
|
||||||
+ vmaw->stream_info[n].cluster_count = DIV_ROUND_UP(size, VMA_CLUSTER_SIZE);
|
+ vmaw->stream_info[n].cluster_count = (size + VMA_CLUSTER_SIZE - 1) /
|
||||||
|
+ VMA_CLUSTER_SIZE;
|
||||||
+
|
+
|
||||||
+ vmaw->stream_count = n;
|
+ vmaw->stream_count = n;
|
||||||
+
|
+
|
||||||
|
@@ -199,7 +199,7 @@ index 0000000000..e46abf1070
|
|||||||
+ return bs;
|
+ return bs;
|
||||||
+}
|
+}
|
||||||
diff --git a/block/backup.c b/block/backup.c
|
diff --git a/block/backup.c b/block/backup.c
|
||||||
index 2e38b30d67..fe69723ada 100644
|
index eba5b11493..1963e47ab9 100644
|
||||||
--- a/block/backup.c
|
--- a/block/backup.c
|
||||||
+++ b/block/backup.c
|
+++ b/block/backup.c
|
||||||
@@ -29,28 +29,6 @@
|
@@ -29,28 +29,6 @@
|
||||||
@@ -247,7 +247,7 @@ index 2e38b30d67..fe69723ada 100644
|
|||||||
if (perf->max_chunk && perf->max_chunk < cluster_size) {
|
if (perf->max_chunk && perf->max_chunk < cluster_size) {
|
||||||
error_setg(errp, "Required max-chunk (%" PRIi64 ") is less than backup "
|
error_setg(errp, "Required max-chunk (%" PRIi64 ") is less than backup "
|
||||||
diff --git a/block/meson.build b/block/meson.build
|
diff --git a/block/meson.build b/block/meson.build
|
||||||
index 652c8cbdb7..e1cf5a2e65 100644
|
index b245daa98e..e99914eaa4 100644
|
||||||
--- a/block/meson.build
|
--- a/block/meson.build
|
||||||
+++ b/block/meson.build
|
+++ b/block/meson.build
|
||||||
@@ -4,6 +4,7 @@ block_ss.add(files(
|
@@ -4,6 +4,7 @@ block_ss.add(files(
|
||||||
@@ -259,7 +259,7 @@ index 652c8cbdb7..e1cf5a2e65 100644
|
|||||||
'blklogwrites.c',
|
'blklogwrites.c',
|
||||||
'blkverify.c',
|
'blkverify.c',
|
||||||
diff --git a/include/block/block_int-common.h b/include/block/block_int-common.h
|
diff --git a/include/block/block_int-common.h b/include/block/block_int-common.h
|
||||||
index ebb4e56a50..e717a74e5f 100644
|
index 761276127e..b3e6697613 100644
|
||||||
--- a/include/block/block_int-common.h
|
--- a/include/block/block_int-common.h
|
||||||
+++ b/include/block/block_int-common.h
|
+++ b/include/block/block_int-common.h
|
||||||
@@ -26,6 +26,7 @@
|
@@ -26,6 +26,7 @@
|
||||||
|
@@ -94,21 +94,21 @@ Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|||||||
monitor/hmp-cmds.c | 72 +++
|
monitor/hmp-cmds.c | 72 +++
|
||||||
proxmox-backup-client.c | 146 +++++
|
proxmox-backup-client.c | 146 +++++
|
||||||
proxmox-backup-client.h | 60 ++
|
proxmox-backup-client.h | 60 ++
|
||||||
pve-backup.c | 1090 ++++++++++++++++++++++++++++++++
|
pve-backup.c | 1092 ++++++++++++++++++++++++++++++++
|
||||||
qapi/block-core.json | 233 +++++++
|
qapi/block-core.json | 233 +++++++
|
||||||
qapi/common.json | 14 +
|
qapi/common.json | 14 +
|
||||||
qapi/machine.json | 16 +-
|
qapi/machine.json | 16 +-
|
||||||
14 files changed, 1709 insertions(+), 14 deletions(-)
|
14 files changed, 1711 insertions(+), 14 deletions(-)
|
||||||
create mode 100644 proxmox-backup-client.c
|
create mode 100644 proxmox-backup-client.c
|
||||||
create mode 100644 proxmox-backup-client.h
|
create mode 100644 proxmox-backup-client.h
|
||||||
create mode 100644 pve-backup.c
|
create mode 100644 pve-backup.c
|
||||||
|
|
||||||
diff --git a/block/meson.build b/block/meson.build
|
diff --git a/block/meson.build b/block/meson.build
|
||||||
index e1cf5a2e65..2367e1ac1b 100644
|
index e99914eaa4..6bba803f94 100644
|
||||||
--- a/block/meson.build
|
--- a/block/meson.build
|
||||||
+++ b/block/meson.build
|
+++ b/block/meson.build
|
||||||
@@ -44,6 +44,11 @@ block_ss.add(files(
|
@@ -44,6 +44,11 @@ block_ss.add(files(
|
||||||
), zstd, zlib)
|
), zstd, zlib, gnutls)
|
||||||
|
|
||||||
block_ss.add(files('../vma-writer.c'), libuuid)
|
block_ss.add(files('../vma-writer.c'), libuuid)
|
||||||
+block_ss.add(files(
|
+block_ss.add(files(
|
||||||
@@ -167,7 +167,7 @@ index bdf2eb50b6..439a7a14c8 100644
|
|||||||
+ hmp_handle_error(mon, error);
|
+ hmp_handle_error(mon, error);
|
||||||
+}
|
+}
|
||||||
diff --git a/blockdev.c b/blockdev.c
|
diff --git a/blockdev.c b/blockdev.c
|
||||||
index 79d47b1920..3f67eb413d 100644
|
index ed8198f351..1054a69279 100644
|
||||||
--- a/blockdev.c
|
--- a/blockdev.c
|
||||||
+++ b/blockdev.c
|
+++ b/blockdev.c
|
||||||
@@ -37,6 +37,7 @@
|
@@ -37,6 +37,7 @@
|
||||||
@@ -179,10 +179,10 @@ index 79d47b1920..3f67eb413d 100644
|
|||||||
#include "monitor/monitor.h"
|
#include "monitor/monitor.h"
|
||||||
#include "qemu/error-report.h"
|
#include "qemu/error-report.h"
|
||||||
diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
|
diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
|
||||||
index d1a7b99add..af588145ff 100644
|
index d5ab880492..6c97248d1b 100644
|
||||||
--- a/hmp-commands-info.hx
|
--- a/hmp-commands-info.hx
|
||||||
+++ b/hmp-commands-info.hx
|
+++ b/hmp-commands-info.hx
|
||||||
@@ -458,6 +458,20 @@ SRST
|
@@ -471,6 +471,20 @@ SRST
|
||||||
Show the current VM UUID.
|
Show the current VM UUID.
|
||||||
ERST
|
ERST
|
||||||
|
|
||||||
@@ -204,7 +204,7 @@ index d1a7b99add..af588145ff 100644
|
|||||||
{
|
{
|
||||||
.name = "usernet",
|
.name = "usernet",
|
||||||
diff --git a/hmp-commands.hx b/hmp-commands.hx
|
diff --git a/hmp-commands.hx b/hmp-commands.hx
|
||||||
index 0c7c6f2c16..bf8315f226 100644
|
index 7506de251c..d5f9c28194 100644
|
||||||
--- a/hmp-commands.hx
|
--- a/hmp-commands.hx
|
||||||
+++ b/hmp-commands.hx
|
+++ b/hmp-commands.hx
|
||||||
@@ -101,6 +101,35 @@ ERST
|
@@ -101,6 +101,35 @@ ERST
|
||||||
@@ -244,7 +244,7 @@ index 0c7c6f2c16..bf8315f226 100644
|
|||||||
|
|
||||||
{
|
{
|
||||||
diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h
|
diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h
|
||||||
index 2596cc2426..9dda91d65a 100644
|
index 7a7def7530..cba7afe70c 100644
|
||||||
--- a/include/monitor/hmp.h
|
--- a/include/monitor/hmp.h
|
||||||
+++ b/include/monitor/hmp.h
|
+++ b/include/monitor/hmp.h
|
||||||
@@ -32,6 +32,7 @@ void hmp_info_savevm(Monitor *mon, const QDict *qdict);
|
@@ -32,6 +32,7 @@ void hmp_info_savevm(Monitor *mon, const QDict *qdict);
|
||||||
@@ -255,7 +255,7 @@ index 2596cc2426..9dda91d65a 100644
|
|||||||
void hmp_info_cpus(Monitor *mon, const QDict *qdict);
|
void hmp_info_cpus(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_info_vnc(Monitor *mon, const QDict *qdict);
|
void hmp_info_vnc(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_info_spice(Monitor *mon, const QDict *qdict);
|
void hmp_info_spice(Monitor *mon, const QDict *qdict);
|
||||||
@@ -82,6 +83,8 @@ void hmp_change_vnc(Monitor *mon, const char *device, const char *target,
|
@@ -84,6 +85,8 @@ void hmp_change_vnc(Monitor *mon, const char *device, const char *target,
|
||||||
void hmp_change_medium(Monitor *mon, const char *device, const char *target,
|
void hmp_change_medium(Monitor *mon, const char *device, const char *target,
|
||||||
const char *arg, const char *read_only, bool force,
|
const char *arg, const char *read_only, bool force,
|
||||||
Error **errp);
|
Error **errp);
|
||||||
@@ -265,10 +265,10 @@ index 2596cc2426..9dda91d65a 100644
|
|||||||
void hmp_device_add(Monitor *mon, const QDict *qdict);
|
void hmp_device_add(Monitor *mon, const QDict *qdict);
|
||||||
void hmp_device_del(Monitor *mon, const QDict *qdict);
|
void hmp_device_del(Monitor *mon, const QDict *qdict);
|
||||||
diff --git a/meson.build b/meson.build
|
diff --git a/meson.build b/meson.build
|
||||||
index b9b673c271..f6fb9b4fd8 100644
|
index 620cc594b2..d16b97cf3c 100644
|
||||||
--- a/meson.build
|
--- a/meson.build
|
||||||
+++ b/meson.build
|
+++ b/meson.build
|
||||||
@@ -2130,6 +2130,7 @@ endif
|
@@ -1923,6 +1923,7 @@ endif
|
||||||
has_gettid = cc.has_function('gettid')
|
has_gettid = cc.has_function('gettid')
|
||||||
|
|
||||||
libuuid = cc.find_library('uuid', required: true)
|
libuuid = cc.find_library('uuid', required: true)
|
||||||
@@ -277,18 +277,18 @@ index b9b673c271..f6fb9b4fd8 100644
|
|||||||
# libselinux
|
# libselinux
|
||||||
selinux = dependency('libselinux',
|
selinux = dependency('libselinux',
|
||||||
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
|
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
|
||||||
index 874084565f..bedeb81f8c 100644
|
index ef4634e5c1..6e25279f42 100644
|
||||||
--- a/monitor/hmp-cmds.c
|
--- a/monitor/hmp-cmds.c
|
||||||
+++ b/monitor/hmp-cmds.c
|
+++ b/monitor/hmp-cmds.c
|
||||||
@@ -22,6 +22,7 @@
|
@@ -21,6 +21,7 @@
|
||||||
#include "qemu/help_option.h"
|
#include "qemu/help_option.h"
|
||||||
#include "monitor/monitor-internal.h"
|
#include "monitor/monitor-internal.h"
|
||||||
#include "qapi/error.h"
|
#include "qapi/error.h"
|
||||||
+#include "qapi/qapi-commands-block-core.h"
|
+#include "qapi/qapi-commands-block-core.h"
|
||||||
#include "qapi/qapi-commands-control.h"
|
#include "qapi/qapi-commands-control.h"
|
||||||
#include "qapi/qapi-commands-machine.h"
|
|
||||||
#include "qapi/qapi-commands-migration.h"
|
#include "qapi/qapi-commands-migration.h"
|
||||||
@@ -119,6 +120,77 @@ void hmp_sync_profile(Monitor *mon, const QDict *qdict)
|
#include "qapi/qapi-commands-misc.h"
|
||||||
|
@@ -144,6 +145,77 @@ void hmp_sync_profile(Monitor *mon, const QDict *qdict)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -586,10 +586,10 @@ index 0000000000..8cbf645b2c
|
|||||||
+#endif /* PROXMOX_BACKUP_CLIENT_H */
|
+#endif /* PROXMOX_BACKUP_CLIENT_H */
|
||||||
diff --git a/pve-backup.c b/pve-backup.c
|
diff --git a/pve-backup.c b/pve-backup.c
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..fea0152de0
|
index 0000000000..c755bf302b
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/pve-backup.c
|
+++ b/pve-backup.c
|
||||||
@@ -0,0 +1,1090 @@
|
@@ -0,0 +1,1092 @@
|
||||||
+#include "proxmox-backup-client.h"
|
+#include "proxmox-backup-client.h"
|
||||||
+#include "vma.h"
|
+#include "vma.h"
|
||||||
+
|
+
|
||||||
@@ -1194,7 +1194,7 @@ index 0000000000..fea0152de0
|
|||||||
+ }
|
+ }
|
||||||
+ BlockDriverState *bs = blk_bs(blk);
|
+ BlockDriverState *bs = blk_bs(blk);
|
||||||
+ if (!bdrv_co_is_inserted(bs)) {
|
+ if (!bdrv_co_is_inserted(bs)) {
|
||||||
+ error_setg(errp, "Device '%s' has no medium", *d);
|
+ error_setg(errp, QERR_DEVICE_HAS_NO_MEDIUM, *d);
|
||||||
+ goto err;
|
+ goto err;
|
||||||
+ }
|
+ }
|
||||||
+ PVEBackupDevInfo *di = g_new0(PVEBackupDevInfo, 1);
|
+ PVEBackupDevInfo *di = g_new0(PVEBackupDevInfo, 1);
|
||||||
@@ -1440,7 +1440,9 @@ index 0000000000..fea0152de0
|
|||||||
+ } else if (format == BACKUP_FORMAT_VMA) {
|
+ } else if (format == BACKUP_FORMAT_VMA) {
|
||||||
+ vmaw = vma_writer_create(backup_file, uuid, &local_err);
|
+ vmaw = vma_writer_create(backup_file, uuid, &local_err);
|
||||||
+ if (!vmaw) {
|
+ if (!vmaw) {
|
||||||
+ error_propagate(errp, local_err);
|
+ if (local_err) {
|
||||||
|
+ error_propagate(errp, local_err);
|
||||||
|
+ }
|
||||||
+ goto err_mutex;
|
+ goto err_mutex;
|
||||||
+ }
|
+ }
|
||||||
+
|
+
|
||||||
@@ -1681,7 +1683,7 @@ index 0000000000..fea0152de0
|
|||||||
+ return ret;
|
+ return ret;
|
||||||
+}
|
+}
|
||||||
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
||||||
index 321d1fd0e1..68caf30084 100644
|
index 3db587a6e4..d05fffce1d 100644
|
||||||
--- a/qapi/block-core.json
|
--- a/qapi/block-core.json
|
||||||
+++ b/qapi/block-core.json
|
+++ b/qapi/block-core.json
|
||||||
@@ -851,6 +851,239 @@
|
@@ -851,6 +851,239 @@
|
||||||
@@ -1823,7 +1825,7 @@ index 321d1fd0e1..68caf30084 100644
|
|||||||
+#
|
+#
|
||||||
+# Cancel the current executing backup process.
|
+# Cancel the current executing backup process.
|
||||||
+#
|
+#
|
||||||
+# .. note:: This command succeeds even if there is no backup process running.
|
+# Notes: This command succeeds even if there is no backup process running.
|
||||||
+#
|
+#
|
||||||
+##
|
+##
|
||||||
+{ 'command': 'backup-cancel', 'coroutine': true }
|
+{ 'command': 'backup-cancel', 'coroutine': true }
|
||||||
@@ -1925,10 +1927,10 @@ index 321d1fd0e1..68caf30084 100644
|
|||||||
# @BlockDeviceTimedStats:
|
# @BlockDeviceTimedStats:
|
||||||
#
|
#
|
||||||
diff --git a/qapi/common.json b/qapi/common.json
|
diff --git a/qapi/common.json b/qapi/common.json
|
||||||
index 6ffc7a3789..9c6c671ece 100644
|
index 7558ce5430..6e3d800373 100644
|
||||||
--- a/qapi/common.json
|
--- a/qapi/common.json
|
||||||
+++ b/qapi/common.json
|
+++ b/qapi/common.json
|
||||||
@@ -212,3 +212,17 @@
|
@@ -200,3 +200,17 @@
|
||||||
##
|
##
|
||||||
{ 'struct': 'HumanReadableText',
|
{ 'struct': 'HumanReadableText',
|
||||||
'data': { 'human-readable-text': 'str' } }
|
'data': { 'human-readable-text': 'str' } }
|
||||||
@@ -1942,12 +1944,12 @@ index 6ffc7a3789..9c6c671ece 100644
|
|||||||
+#
|
+#
|
||||||
+# Since: 0.14.0
|
+# Since: 0.14.0
|
||||||
+#
|
+#
|
||||||
+# .. note:: If no UUID was specified for the guest, a null UUID is
|
+# Notes: If no UUID was specified for the guest, a null UUID is
|
||||||
+# returned.
|
+# returned.
|
||||||
+##
|
+##
|
||||||
+{ 'struct': 'UuidInfo', 'data': {'UUID': 'str'} }
|
+{ 'struct': 'UuidInfo', 'data': {'UUID': 'str'} }
|
||||||
diff --git a/qapi/machine.json b/qapi/machine.json
|
diff --git a/qapi/machine.json b/qapi/machine.json
|
||||||
index 12cfd3f260..a8abdb42a3 100644
|
index 1d69bffaa0..731d8d2f60 100644
|
||||||
--- a/qapi/machine.json
|
--- a/qapi/machine.json
|
||||||
+++ b/qapi/machine.json
|
+++ b/qapi/machine.json
|
||||||
@@ -4,6 +4,8 @@
|
@@ -4,6 +4,8 @@
|
||||||
@@ -1959,7 +1961,7 @@ index 12cfd3f260..a8abdb42a3 100644
|
|||||||
##
|
##
|
||||||
# = Machines
|
# = Machines
|
||||||
##
|
##
|
||||||
@@ -302,20 +304,6 @@
|
@@ -237,20 +239,6 @@
|
||||||
##
|
##
|
||||||
{ 'command': 'query-target', 'returns': 'TargetInfo' }
|
{ 'command': 'query-target', 'returns': 'TargetInfo' }
|
||||||
|
|
||||||
@@ -1972,8 +1974,8 @@ index 12cfd3f260..a8abdb42a3 100644
|
|||||||
-#
|
-#
|
||||||
-# Since: 0.14
|
-# Since: 0.14
|
||||||
-#
|
-#
|
||||||
-# .. note:: If no UUID was specified for the guest, the nil UUID (all
|
-# Notes: If no UUID was specified for the guest, a null UUID is
|
||||||
-# zeroes) is returned.
|
-# returned.
|
||||||
-##
|
-##
|
||||||
-{ 'struct': 'UuidInfo', 'data': {'UUID': 'str'} }
|
-{ 'struct': 'UuidInfo', 'data': {'UUID': 'str'} }
|
||||||
-
|
-
|
||||||
|
@@ -14,15 +14,15 @@ Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
|||||||
create mode 100644 pbs-restore.c
|
create mode 100644 pbs-restore.c
|
||||||
|
|
||||||
diff --git a/meson.build b/meson.build
|
diff --git a/meson.build b/meson.build
|
||||||
index f6fb9b4fd8..f666d0f028 100644
|
index d16b97cf3c..6de51c34cb 100644
|
||||||
--- a/meson.build
|
--- a/meson.build
|
||||||
+++ b/meson.build
|
+++ b/meson.build
|
||||||
@@ -4350,6 +4350,10 @@ if have_tools
|
@@ -4029,6 +4029,10 @@ if have_tools
|
||||||
vma = executable('vma', files('vma.c', 'vma-reader.c') + genh,
|
vma = executable('vma', files('vma.c', 'vma-reader.c') + genh,
|
||||||
dependencies: [authz, block, crypto, io, qemuutil, qom], install: true)
|
dependencies: [authz, block, crypto, io, qom], install: true)
|
||||||
|
|
||||||
+ pbs_restore = executable('pbs-restore', files('pbs-restore.c') + genh,
|
+ pbs_restore = executable('pbs-restore', files('pbs-restore.c') + genh,
|
||||||
+ dependencies: [authz, block, crypto, io, qemuutil, qom,
|
+ dependencies: [authz, block, crypto, io, qom,
|
||||||
+ libproxmox_backup_qemu], install: true)
|
+ libproxmox_backup_qemu], install: true)
|
||||||
+
|
+
|
||||||
subdir('storage-daemon')
|
subdir('storage-daemon')
|
||||||
|
@@ -15,15 +15,15 @@ Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
|||||||
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
---
|
---
|
||||||
block/meson.build | 2 +
|
block/meson.build | 2 +
|
||||||
block/pbs.c | 306 +++++++++++++++++++++++++++++++++++++++++++
|
block/pbs.c | 313 +++++++++++++++++++++++++++++++++++++++++++
|
||||||
meson.build | 2 +-
|
meson.build | 2 +-
|
||||||
qapi/block-core.json | 29 ++++
|
qapi/block-core.json | 29 ++++
|
||||||
qapi/pragma.json | 1 +
|
qapi/pragma.json | 1 +
|
||||||
5 files changed, 339 insertions(+), 1 deletion(-)
|
5 files changed, 346 insertions(+), 1 deletion(-)
|
||||||
create mode 100644 block/pbs.c
|
create mode 100644 block/pbs.c
|
||||||
|
|
||||||
diff --git a/block/meson.build b/block/meson.build
|
diff --git a/block/meson.build b/block/meson.build
|
||||||
index 2367e1ac1b..e178047ec9 100644
|
index 6bba803f94..1945e04eeb 100644
|
||||||
--- a/block/meson.build
|
--- a/block/meson.build
|
||||||
+++ b/block/meson.build
|
+++ b/block/meson.build
|
||||||
@@ -49,6 +49,8 @@ block_ss.add(files(
|
@@ -49,6 +49,8 @@ block_ss.add(files(
|
||||||
@@ -37,10 +37,10 @@ index 2367e1ac1b..e178047ec9 100644
|
|||||||
system_ss.add(files('block-ram-registrar.c'))
|
system_ss.add(files('block-ram-registrar.c'))
|
||||||
diff --git a/block/pbs.c b/block/pbs.c
|
diff --git a/block/pbs.c b/block/pbs.c
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..2d5e28ce8f
|
index 0000000000..aee66c2e93
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/block/pbs.c
|
+++ b/block/pbs.c
|
||||||
@@ -0,0 +1,306 @@
|
@@ -0,0 +1,313 @@
|
||||||
+/*
|
+/*
|
||||||
+ * Proxmox Backup Server read-only block driver
|
+ * Proxmox Backup Server read-only block driver
|
||||||
+ */
|
+ */
|
||||||
@@ -223,6 +223,12 @@ index 0000000000..2d5e28ce8f
|
|||||||
+ return 0;
|
+ return 0;
|
||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
|
+static int pbs_file_open(BlockDriverState *bs, QDict *options, int flags,
|
||||||
|
+ Error **errp)
|
||||||
|
+{
|
||||||
|
+ return pbs_open(bs, options, flags, errp);
|
||||||
|
+}
|
||||||
|
+
|
||||||
+static void pbs_close(BlockDriverState *bs) {
|
+static void pbs_close(BlockDriverState *bs) {
|
||||||
+ BDRVPBSState *s = bs->opaque;
|
+ BDRVPBSState *s = bs->opaque;
|
||||||
+ g_free(s->repository);
|
+ g_free(s->repository);
|
||||||
@@ -330,6 +336,7 @@ index 0000000000..2d5e28ce8f
|
|||||||
+
|
+
|
||||||
+ .bdrv_parse_filename = pbs_parse_filename,
|
+ .bdrv_parse_filename = pbs_parse_filename,
|
||||||
+
|
+
|
||||||
|
+ .bdrv_file_open = pbs_file_open,
|
||||||
+ .bdrv_open = pbs_open,
|
+ .bdrv_open = pbs_open,
|
||||||
+ .bdrv_close = pbs_close,
|
+ .bdrv_close = pbs_close,
|
||||||
+ .bdrv_co_getlength = pbs_co_getlength,
|
+ .bdrv_co_getlength = pbs_co_getlength,
|
||||||
@@ -348,23 +355,23 @@ index 0000000000..2d5e28ce8f
|
|||||||
+
|
+
|
||||||
+block_init(bdrv_pbs_init);
|
+block_init(bdrv_pbs_init);
|
||||||
diff --git a/meson.build b/meson.build
|
diff --git a/meson.build b/meson.build
|
||||||
index f666d0f028..4c85736ec3 100644
|
index 6de51c34cb..3bc039f60f 100644
|
||||||
--- a/meson.build
|
--- a/meson.build
|
||||||
+++ b/meson.build
|
+++ b/meson.build
|
||||||
@@ -4815,7 +4815,7 @@ summary_info += {'Query Processing Library support': qpl}
|
@@ -4477,7 +4477,7 @@ summary_info += {'bzip2 support': libbzip2}
|
||||||
summary_info += {'UADK Library support': uadk}
|
summary_info += {'lzfse support': liblzfse}
|
||||||
summary_info += {'qatzip support': qatzip}
|
summary_info += {'zstd support': zstd}
|
||||||
summary_info += {'NUMA host support': numa}
|
summary_info += {'NUMA host support': numa}
|
||||||
-summary_info += {'capstone': capstone}
|
-summary_info += {'capstone': capstone}
|
||||||
+summary_info += {'PBS bdrv support': config_host.has_key('CONFIG_PBS_BDRV')}
|
+summary_info += {'PBS bdrv support': config_host.has_key('CONFIG_PBS_BDRV')}
|
||||||
summary_info += {'libpmem support': libpmem}
|
summary_info += {'libpmem support': libpmem}
|
||||||
summary_info += {'libdaxctl support': libdaxctl}
|
summary_info += {'libdaxctl support': libdaxctl}
|
||||||
summary_info += {'libcbor support': libcbor}
|
summary_info += {'libudev': libudev}
|
||||||
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
||||||
index 68caf30084..d45e8975a7 100644
|
index d05fffce1d..e7cf3d94f3 100644
|
||||||
--- a/qapi/block-core.json
|
--- a/qapi/block-core.json
|
||||||
+++ b/qapi/block-core.json
|
+++ b/qapi/block-core.json
|
||||||
@@ -3466,6 +3466,7 @@
|
@@ -3457,6 +3457,7 @@
|
||||||
'parallels', 'preallocate', 'qcow', 'qcow2', 'qed', 'quorum',
|
'parallels', 'preallocate', 'qcow', 'qcow2', 'qed', 'quorum',
|
||||||
'raw', 'rbd',
|
'raw', 'rbd',
|
||||||
{ 'name': 'replication', 'if': 'CONFIG_REPLICATION' },
|
{ 'name': 'replication', 'if': 'CONFIG_REPLICATION' },
|
||||||
@@ -372,7 +379,7 @@ index 68caf30084..d45e8975a7 100644
|
|||||||
'ssh', 'throttle', 'vdi', 'vhdx',
|
'ssh', 'throttle', 'vdi', 'vhdx',
|
||||||
{ 'name': 'virtio-blk-vfio-pci', 'if': 'CONFIG_BLKIO' },
|
{ 'name': 'virtio-blk-vfio-pci', 'if': 'CONFIG_BLKIO' },
|
||||||
{ 'name': 'virtio-blk-vhost-user', 'if': 'CONFIG_BLKIO' },
|
{ 'name': 'virtio-blk-vhost-user', 'if': 'CONFIG_BLKIO' },
|
||||||
@@ -3552,6 +3553,33 @@
|
@@ -3543,6 +3544,33 @@
|
||||||
{ 'struct': 'BlockdevOptionsNull',
|
{ 'struct': 'BlockdevOptionsNull',
|
||||||
'data': { '*size': 'int', '*latency-ns': 'uint64', '*read-zeroes': 'bool' } }
|
'data': { '*size': 'int', '*latency-ns': 'uint64', '*read-zeroes': 'bool' } }
|
||||||
|
|
||||||
@@ -406,7 +413,7 @@ index 68caf30084..d45e8975a7 100644
|
|||||||
##
|
##
|
||||||
# @BlockdevOptionsNVMe:
|
# @BlockdevOptionsNVMe:
|
||||||
#
|
#
|
||||||
@@ -4993,6 +5021,7 @@
|
@@ -4977,6 +5005,7 @@
|
||||||
'nfs': 'BlockdevOptionsNfs',
|
'nfs': 'BlockdevOptionsNfs',
|
||||||
'null-aio': 'BlockdevOptionsNull',
|
'null-aio': 'BlockdevOptionsNull',
|
||||||
'null-co': 'BlockdevOptionsNull',
|
'null-co': 'BlockdevOptionsNull',
|
||||||
@@ -415,10 +422,10 @@ index 68caf30084..d45e8975a7 100644
|
|||||||
'nvme-io_uring': { 'type': 'BlockdevOptionsNvmeIoUring',
|
'nvme-io_uring': { 'type': 'BlockdevOptionsNvmeIoUring',
|
||||||
'if': 'CONFIG_BLKIO' },
|
'if': 'CONFIG_BLKIO' },
|
||||||
diff --git a/qapi/pragma.json b/qapi/pragma.json
|
diff --git a/qapi/pragma.json b/qapi/pragma.json
|
||||||
index 6aaa9cb975..e9c595c4ba 100644
|
index be8fa304c5..7ff46bd128 100644
|
||||||
--- a/qapi/pragma.json
|
--- a/qapi/pragma.json
|
||||||
+++ b/qapi/pragma.json
|
+++ b/qapi/pragma.json
|
||||||
@@ -91,6 +91,7 @@
|
@@ -100,6 +100,7 @@
|
||||||
'BlockInfo', # query-block
|
'BlockInfo', # query-block
|
||||||
'BlockdevAioOptions', # blockdev-add, -blockdev
|
'BlockdevAioOptions', # blockdev-add, -blockdev
|
||||||
'BlockdevDriver', # blockdev-add, query-blockstats, ...
|
'BlockdevDriver', # blockdev-add, query-blockstats, ...
|
||||||
|
@@ -14,10 +14,10 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
2 files changed, 7 insertions(+), 3 deletions(-)
|
2 files changed, 7 insertions(+), 3 deletions(-)
|
||||||
|
|
||||||
diff --git a/meson.build b/meson.build
|
diff --git a/meson.build b/meson.build
|
||||||
index 4c85736ec3..57f666d722 100644
|
index 3bc039f60f..067e8956a7 100644
|
||||||
--- a/meson.build
|
--- a/meson.build
|
||||||
+++ b/meson.build
|
+++ b/meson.build
|
||||||
@@ -2130,6 +2130,7 @@ endif
|
@@ -1923,6 +1923,7 @@ endif
|
||||||
has_gettid = cc.has_function('gettid')
|
has_gettid = cc.has_function('gettid')
|
||||||
|
|
||||||
libuuid = cc.find_library('uuid', required: true)
|
libuuid = cc.find_library('uuid', required: true)
|
||||||
@@ -25,7 +25,7 @@ index 4c85736ec3..57f666d722 100644
|
|||||||
libproxmox_backup_qemu = cc.find_library('proxmox_backup_qemu', required: true)
|
libproxmox_backup_qemu = cc.find_library('proxmox_backup_qemu', required: true)
|
||||||
|
|
||||||
# libselinux
|
# libselinux
|
||||||
@@ -3744,7 +3745,7 @@ if have_block
|
@@ -3530,7 +3531,7 @@ if have_block
|
||||||
if host_os == 'windows'
|
if host_os == 'windows'
|
||||||
system_ss.add(files('os-win32.c'))
|
system_ss.add(files('os-win32.c'))
|
||||||
else
|
else
|
||||||
@@ -35,7 +35,7 @@ index 4c85736ec3..57f666d722 100644
|
|||||||
endif
|
endif
|
||||||
|
|
||||||
diff --git a/os-posix.c b/os-posix.c
|
diff --git a/os-posix.c b/os-posix.c
|
||||||
index 43f9a43f3f..a47e46d1c2 100644
|
index a4284e2c07..197a2120fd 100644
|
||||||
--- a/os-posix.c
|
--- a/os-posix.c
|
||||||
+++ b/os-posix.c
|
+++ b/os-posix.c
|
||||||
@@ -29,6 +29,8 @@
|
@@ -29,6 +29,8 @@
|
||||||
@@ -47,7 +47,7 @@ index 43f9a43f3f..a47e46d1c2 100644
|
|||||||
|
|
||||||
#include "qemu/error-report.h"
|
#include "qemu/error-report.h"
|
||||||
#include "qemu/log.h"
|
#include "qemu/log.h"
|
||||||
@@ -306,9 +308,10 @@ void os_setup_post(void)
|
@@ -302,9 +304,10 @@ void os_setup_post(void)
|
||||||
|
|
||||||
dup2(fd, 0);
|
dup2(fd, 0);
|
||||||
dup2(fd, 1);
|
dup2(fd, 1);
|
||||||
|
@@ -26,52 +26,46 @@ Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|||||||
create mode 100644 migration/pbs-state.c
|
create mode 100644 migration/pbs-state.c
|
||||||
|
|
||||||
diff --git a/include/migration/misc.h b/include/migration/misc.h
|
diff --git a/include/migration/misc.h b/include/migration/misc.h
|
||||||
index 804eb23c06..c75b146ae6 100644
|
index c9e200f4eb..12c99ebc69 100644
|
||||||
--- a/include/migration/misc.h
|
--- a/include/migration/misc.h
|
||||||
+++ b/include/migration/misc.h
|
+++ b/include/migration/misc.h
|
||||||
@@ -106,4 +106,7 @@ bool migration_incoming_postcopy_advised(void);
|
@@ -117,4 +117,7 @@ bool migration_in_bg_snapshot(void);
|
||||||
/* True if background snapshot is active */
|
/* migration/block-dirty-bitmap.c */
|
||||||
bool migration_in_bg_snapshot(void);
|
void dirty_bitmap_mig_init(void);
|
||||||
|
|
||||||
+/* migration/pbs-state.c */
|
+/* migration/pbs-state.c */
|
||||||
+void pbs_state_mig_init(void);
|
+void pbs_state_mig_init(void);
|
||||||
+
|
+
|
||||||
#endif
|
#endif
|
||||||
diff --git a/migration/meson.build b/migration/meson.build
|
diff --git a/migration/meson.build b/migration/meson.build
|
||||||
index 075b013971..eca57cb2a3 100644
|
index 800f12a60d..35a4306183 100644
|
||||||
--- a/migration/meson.build
|
--- a/migration/meson.build
|
||||||
+++ b/migration/meson.build
|
+++ b/migration/meson.build
|
||||||
@@ -8,6 +8,7 @@ migration_files = files(
|
@@ -7,7 +7,9 @@ migration_files = files(
|
||||||
|
'vmstate.c',
|
||||||
'qemu-file.c',
|
'qemu-file.c',
|
||||||
'yank_functions.c',
|
'yank_functions.c',
|
||||||
|
+ 'pbs-state.c',
|
||||||
)
|
)
|
||||||
+system_ss.add(libproxmox_backup_qemu)
|
+system_ss.add(libproxmox_backup_qemu)
|
||||||
|
|
||||||
system_ss.add(files(
|
system_ss.add(files(
|
||||||
'block-dirty-bitmap.c',
|
'block-dirty-bitmap.c',
|
||||||
@@ -27,6 +28,7 @@ system_ss.add(files(
|
|
||||||
'multifd-zlib.c',
|
|
||||||
'multifd-zero-page.c',
|
|
||||||
'options.c',
|
|
||||||
+ 'pbs-state.c',
|
|
||||||
'postcopy-ram.c',
|
|
||||||
'savevm.c',
|
|
||||||
'savevm-async.c',
|
|
||||||
diff --git a/migration/migration.c b/migration/migration.c
|
diff --git a/migration/migration.c b/migration/migration.c
|
||||||
index 8c5bd0a75c..491d9aa017 100644
|
index 86bf76e925..b8d7e471a4 100644
|
||||||
--- a/migration/migration.c
|
--- a/migration/migration.c
|
||||||
+++ b/migration/migration.c
|
+++ b/migration/migration.c
|
||||||
@@ -266,6 +266,7 @@ void migration_object_init(void)
|
@@ -239,6 +239,7 @@ void migration_object_init(void)
|
||||||
|
blk_mig_init();
|
||||||
/* Initialize cpu throttle timers */
|
ram_mig_init();
|
||||||
cpu_throttle_init();
|
dirty_bitmap_mig_init();
|
||||||
+ pbs_state_mig_init();
|
+ pbs_state_mig_init();
|
||||||
}
|
}
|
||||||
|
|
||||||
typedef struct {
|
typedef struct {
|
||||||
diff --git a/migration/pbs-state.c b/migration/pbs-state.c
|
diff --git a/migration/pbs-state.c b/migration/pbs-state.c
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..a97187e4d7
|
index 0000000000..887e998b9e
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/migration/pbs-state.c
|
+++ b/migration/pbs-state.c
|
||||||
@@ -0,0 +1,104 @@
|
@@ -0,0 +1,104 @@
|
||||||
@@ -120,7 +114,7 @@ index 0000000000..a97187e4d7
|
|||||||
+}
|
+}
|
||||||
+
|
+
|
||||||
+/* serialize PBS state and send to target via f, called on source */
|
+/* serialize PBS state and send to target via f, called on source */
|
||||||
+static int pbs_state_save_setup(QEMUFile *f, void *opaque, Error **errp)
|
+static int pbs_state_save_setup(QEMUFile *f, void *opaque)
|
||||||
+{
|
+{
|
||||||
+ size_t buf_size;
|
+ size_t buf_size;
|
||||||
+ uint8_t *buf = proxmox_export_state(&buf_size);
|
+ uint8_t *buf = proxmox_export_state(&buf_size);
|
||||||
@@ -180,10 +174,10 @@ index 0000000000..a97187e4d7
|
|||||||
+ NULL);
|
+ NULL);
|
||||||
+}
|
+}
|
||||||
diff --git a/pve-backup.c b/pve-backup.c
|
diff --git a/pve-backup.c b/pve-backup.c
|
||||||
index fea0152de0..faa6a9b93c 100644
|
index c755bf302b..5ebb6a3947 100644
|
||||||
--- a/pve-backup.c
|
--- a/pve-backup.c
|
||||||
+++ b/pve-backup.c
|
+++ b/pve-backup.c
|
||||||
@@ -1083,6 +1083,7 @@ ProxmoxSupportStatus *qmp_query_proxmox_support(Error **errp)
|
@@ -1085,6 +1085,7 @@ ProxmoxSupportStatus *qmp_query_proxmox_support(Error **errp)
|
||||||
ret->pbs_library_version = g_strdup(proxmox_backup_qemu_version());
|
ret->pbs_library_version = g_strdup(proxmox_backup_qemu_version());
|
||||||
ret->pbs_dirty_bitmap = true;
|
ret->pbs_dirty_bitmap = true;
|
||||||
ret->pbs_dirty_bitmap_savevm = true;
|
ret->pbs_dirty_bitmap_savevm = true;
|
||||||
@@ -192,7 +186,7 @@ index fea0152de0..faa6a9b93c 100644
|
|||||||
ret->pbs_masterkey = true;
|
ret->pbs_masterkey = true;
|
||||||
ret->backup_max_workers = true;
|
ret->backup_max_workers = true;
|
||||||
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
||||||
index d45e8975a7..9795247c1f 100644
|
index e7cf3d94f3..282e2e8a8c 100644
|
||||||
--- a/qapi/block-core.json
|
--- a/qapi/block-core.json
|
||||||
+++ b/qapi/block-core.json
|
+++ b/qapi/block-core.json
|
||||||
@@ -1004,6 +1004,11 @@
|
@@ -1004,6 +1004,11 @@
|
||||||
|
@@ -15,22 +15,18 @@ transferred.
|
|||||||
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
|
||||||
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
---
|
---
|
||||||
migration/block-dirty-bitmap.c | 6 +++++-
|
migration/block-dirty-bitmap.c | 2 +-
|
||||||
1 file changed, 5 insertions(+), 1 deletion(-)
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||||
|
|
||||||
diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
|
diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
|
||||||
index a7d55048c2..44078ea670 100644
|
index 2708abf3d7..fb17c01308 100644
|
||||||
--- a/migration/block-dirty-bitmap.c
|
--- a/migration/block-dirty-bitmap.c
|
||||||
+++ b/migration/block-dirty-bitmap.c
|
+++ b/migration/block-dirty-bitmap.c
|
||||||
@@ -539,7 +539,11 @@ static int add_bitmaps_to_list(DBMSaveState *s, BlockDriverState *bs,
|
@@ -540,7 +540,7 @@ static int add_bitmaps_to_list(DBMSaveState *s, BlockDriverState *bs,
|
||||||
}
|
|
||||||
|
|
||||||
if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_DEFAULT, errp)) {
|
if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_DEFAULT, &local_err)) {
|
||||||
|
error_report_err(local_err);
|
||||||
- return -1;
|
- return -1;
|
||||||
+ if (errp != NULL) {
|
|
||||||
+ error_report_err(*errp);
|
|
||||||
+ *errp = NULL;
|
|
||||||
+ }
|
|
||||||
+ continue;
|
+ continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@@ -21,7 +21,7 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 30 insertions(+)
|
1 file changed, 30 insertions(+)
|
||||||
|
|
||||||
diff --git a/block/iscsi.c b/block/iscsi.c
|
diff --git a/block/iscsi.c b/block/iscsi.c
|
||||||
index 979bf90cb7..961714a4be 100644
|
index 2ff14b7472..46f275fbf7 100644
|
||||||
--- a/block/iscsi.c
|
--- a/block/iscsi.c
|
||||||
+++ b/block/iscsi.c
|
+++ b/block/iscsi.c
|
||||||
@@ -1392,12 +1392,42 @@ static char *get_initiator_name(QemuOpts *opts)
|
@@ -1392,12 +1392,42 @@ static char *get_initiator_name(QemuOpts *opts)
|
||||||
|
@@ -11,7 +11,7 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 1 insertion(+), 1 deletion(-)
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||||
|
|
||||||
diff --git a/block/stream.c b/block/stream.c
|
diff --git a/block/stream.c b/block/stream.c
|
||||||
index 9076203193..1d1c65f061 100644
|
index 7031eef12b..d2da83ae7c 100644
|
||||||
--- a/block/stream.c
|
--- a/block/stream.c
|
||||||
+++ b/block/stream.c
|
+++ b/block/stream.c
|
||||||
@@ -27,7 +27,7 @@ enum {
|
@@ -27,7 +27,7 @@ enum {
|
||||||
|
@@ -42,7 +42,7 @@ Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|||||||
|
|
||||||
diff --git a/block/alloc-track.c b/block/alloc-track.c
|
diff --git a/block/alloc-track.c b/block/alloc-track.c
|
||||||
new file mode 100644
|
new file mode 100644
|
||||||
index 0000000000..b4a9851144
|
index 0000000000..b9f8ea9137
|
||||||
--- /dev/null
|
--- /dev/null
|
||||||
+++ b/block/alloc-track.c
|
+++ b/block/alloc-track.c
|
||||||
@@ -0,0 +1,366 @@
|
@@ -0,0 +1,366 @@
|
||||||
@@ -386,7 +386,7 @@ index 0000000000..b4a9851144
|
|||||||
+ .format_name = "alloc-track",
|
+ .format_name = "alloc-track",
|
||||||
+ .instance_size = sizeof(BDRVAllocTrackState),
|
+ .instance_size = sizeof(BDRVAllocTrackState),
|
||||||
+
|
+
|
||||||
+ .bdrv_open = track_open,
|
+ .bdrv_file_open = track_open,
|
||||||
+ .bdrv_close = track_close,
|
+ .bdrv_close = track_close,
|
||||||
+ .bdrv_co_getlength = track_co_getlength,
|
+ .bdrv_co_getlength = track_co_getlength,
|
||||||
+ .bdrv_child_perm = track_child_perm,
|
+ .bdrv_child_perm = track_child_perm,
|
||||||
@@ -413,7 +413,7 @@ index 0000000000..b4a9851144
|
|||||||
+
|
+
|
||||||
+block_init(bdrv_alloc_track_init);
|
+block_init(bdrv_alloc_track_init);
|
||||||
diff --git a/block/meson.build b/block/meson.build
|
diff --git a/block/meson.build b/block/meson.build
|
||||||
index e178047ec9..7ef7250d31 100644
|
index 1945e04eeb..2873f3a25a 100644
|
||||||
--- a/block/meson.build
|
--- a/block/meson.build
|
||||||
+++ b/block/meson.build
|
+++ b/block/meson.build
|
||||||
@@ -2,6 +2,7 @@ block_ss.add(genh)
|
@@ -2,6 +2,7 @@ block_ss.add(genh)
|
||||||
@@ -425,7 +425,7 @@ index e178047ec9..7ef7250d31 100644
|
|||||||
'backup.c',
|
'backup.c',
|
||||||
'backup-dump.c',
|
'backup-dump.c',
|
||||||
diff --git a/block/stream.c b/block/stream.c
|
diff --git a/block/stream.c b/block/stream.c
|
||||||
index 1d1c65f061..d499c8883f 100644
|
index d2da83ae7c..f941cba14e 100644
|
||||||
--- a/block/stream.c
|
--- a/block/stream.c
|
||||||
+++ b/block/stream.c
|
+++ b/block/stream.c
|
||||||
@@ -120,6 +120,40 @@ static int stream_prepare(Job *job)
|
@@ -120,6 +120,40 @@ static int stream_prepare(Job *job)
|
||||||
|
@@ -13,7 +13,7 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 2 insertions(+), 40 deletions(-)
|
1 file changed, 2 insertions(+), 40 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/rbd.c b/block/rbd.c
|
diff --git a/block/rbd.c b/block/rbd.c
|
||||||
index 728bce3b1e..6c9a8e0add 100644
|
index 63f60d41be..367db42dce 100644
|
||||||
--- a/block/rbd.c
|
--- a/block/rbd.c
|
||||||
+++ b/block/rbd.c
|
+++ b/block/rbd.c
|
||||||
@@ -1515,7 +1515,6 @@ static int coroutine_fn qemu_rbd_co_block_status(BlockDriverState *bs,
|
@@ -1515,7 +1515,6 @@ static int coroutine_fn qemu_rbd_co_block_status(BlockDriverState *bs,
|
||||||
|
@@ -14,7 +14,7 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 5 insertions(+), 5 deletions(-)
|
1 file changed, 5 insertions(+), 5 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/rbd.c b/block/rbd.c
|
diff --git a/block/rbd.c b/block/rbd.c
|
||||||
index 6c9a8e0add..6f5fe90f3a 100644
|
index 367db42dce..347b121626 100644
|
||||||
--- a/block/rbd.c
|
--- a/block/rbd.c
|
||||||
+++ b/block/rbd.c
|
+++ b/block/rbd.c
|
||||||
@@ -1474,11 +1474,11 @@ static int qemu_rbd_diff_iterate_cb(uint64_t offs, size_t len,
|
@@ -1474,11 +1474,11 @@ static int qemu_rbd_diff_iterate_cb(uint64_t offs, size_t len,
|
||||||
|
@@ -24,7 +24,7 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|||||||
1 file changed, 112 deletions(-)
|
1 file changed, 112 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/rbd.c b/block/rbd.c
|
diff --git a/block/rbd.c b/block/rbd.c
|
||||||
index 6f5fe90f3a..24e820d056 100644
|
index 347b121626..e61b359b97 100644
|
||||||
--- a/block/rbd.c
|
--- a/block/rbd.c
|
||||||
+++ b/block/rbd.c
|
+++ b/block/rbd.c
|
||||||
@@ -108,12 +108,6 @@ typedef struct RBDTask {
|
@@ -108,12 +108,6 @@ typedef struct RBDTask {
|
||||||
@@ -152,7 +152,7 @@ index 6f5fe90f3a..24e820d056 100644
|
|||||||
static int64_t coroutine_fn qemu_rbd_co_getlength(BlockDriverState *bs)
|
static int64_t coroutine_fn qemu_rbd_co_getlength(BlockDriverState *bs)
|
||||||
{
|
{
|
||||||
BDRVRBDState *s = bs->opaque;
|
BDRVRBDState *s = bs->opaque;
|
||||||
@@ -1801,7 +1690,6 @@ static BlockDriver bdrv_rbd = {
|
@@ -1800,7 +1689,6 @@ static BlockDriver bdrv_rbd = {
|
||||||
#ifdef LIBRBD_SUPPORTS_WRITE_ZEROES
|
#ifdef LIBRBD_SUPPORTS_WRITE_ZEROES
|
||||||
.bdrv_co_pwrite_zeroes = qemu_rbd_co_pwrite_zeroes,
|
.bdrv_co_pwrite_zeroes = qemu_rbd_co_pwrite_zeroes,
|
||||||
#endif
|
#endif
|
||||||
|
@@ -17,7 +17,7 @@ Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|||||||
1 file changed, 5 insertions(+), 2 deletions(-)
|
1 file changed, 5 insertions(+), 2 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/alloc-track.c b/block/alloc-track.c
|
diff --git a/block/alloc-track.c b/block/alloc-track.c
|
||||||
index b4a9851144..fc7d58a5d0 100644
|
index b9f8ea9137..f3ed2935c4 100644
|
||||||
--- a/block/alloc-track.c
|
--- a/block/alloc-track.c
|
||||||
+++ b/block/alloc-track.c
|
+++ b/block/alloc-track.c
|
||||||
@@ -34,7 +34,6 @@ typedef struct {
|
@@ -34,7 +34,6 @@ typedef struct {
|
||||||
|
@@ -20,7 +20,7 @@ Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|||||||
1 file changed, 26 deletions(-)
|
1 file changed, 26 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/alloc-track.c b/block/alloc-track.c
|
diff --git a/block/alloc-track.c b/block/alloc-track.c
|
||||||
index fc7d58a5d0..b56425b7f0 100644
|
index f3ed2935c4..29138dcc49 100644
|
||||||
--- a/block/alloc-track.c
|
--- a/block/alloc-track.c
|
||||||
+++ b/block/alloc-track.c
|
+++ b/block/alloc-track.c
|
||||||
@@ -25,15 +25,9 @@
|
@@ -25,15 +25,9 @@
|
||||||
|
133
debian/patches/pve/0044-copy-before-write-allow-specifying-minimum-cluster-s.patch
vendored
Normal file
133
debian/patches/pve/0044-copy-before-write-allow-specifying-minimum-cluster-s.patch
vendored
Normal file
@@ -0,0 +1,133 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Thu, 11 Apr 2024 11:29:26 +0200
|
||||||
|
Subject: [PATCH] copy-before-write: allow specifying minimum cluster size
|
||||||
|
|
||||||
|
Useful to make discard-source work in the context of backup fleecing
|
||||||
|
when the fleecing image has a larger granularity than the backup
|
||||||
|
target.
|
||||||
|
|
||||||
|
Copy-before-write operations will use at least this granularity and in
|
||||||
|
particular, discard requests to the source node will too. If the
|
||||||
|
granularity is too small, they will just be aligned down in
|
||||||
|
cbw_co_pdiscard_snapshot() and thus effectively ignored.
|
||||||
|
|
||||||
|
The QAPI uses uint32 so the value will be non-negative, but still fit
|
||||||
|
into a uint64_t.
|
||||||
|
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
block/block-copy.c | 17 +++++++++++++----
|
||||||
|
block/copy-before-write.c | 3 ++-
|
||||||
|
include/block/block-copy.h | 1 +
|
||||||
|
qapi/block-core.json | 8 +++++++-
|
||||||
|
4 files changed, 23 insertions(+), 6 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/block-copy.c b/block/block-copy.c
|
||||||
|
index cc618e4561..12d662e9d4 100644
|
||||||
|
--- a/block/block-copy.c
|
||||||
|
+++ b/block/block-copy.c
|
||||||
|
@@ -310,6 +310,7 @@ void block_copy_set_copy_opts(BlockCopyState *s, bool use_copy_range,
|
||||||
|
}
|
||||||
|
|
||||||
|
static int64_t block_copy_calculate_cluster_size(BlockDriverState *target,
|
||||||
|
+ int64_t min_cluster_size,
|
||||||
|
Error **errp)
|
||||||
|
{
|
||||||
|
int ret;
|
||||||
|
@@ -335,7 +336,7 @@ static int64_t block_copy_calculate_cluster_size(BlockDriverState *target,
|
||||||
|
"used. If the actual block size of the target exceeds "
|
||||||
|
"this default, the backup may be unusable",
|
||||||
|
BLOCK_COPY_CLUSTER_SIZE_DEFAULT);
|
||||||
|
- return BLOCK_COPY_CLUSTER_SIZE_DEFAULT;
|
||||||
|
+ return MAX(min_cluster_size, BLOCK_COPY_CLUSTER_SIZE_DEFAULT);
|
||||||
|
} else if (ret < 0 && !target_does_cow) {
|
||||||
|
error_setg_errno(errp, -ret,
|
||||||
|
"Couldn't determine the cluster size of the target image, "
|
||||||
|
@@ -345,16 +346,18 @@ static int64_t block_copy_calculate_cluster_size(BlockDriverState *target,
|
||||||
|
return ret;
|
||||||
|
} else if (ret < 0 && target_does_cow) {
|
||||||
|
/* Not fatal; just trudge on ahead. */
|
||||||
|
- return BLOCK_COPY_CLUSTER_SIZE_DEFAULT;
|
||||||
|
+ return MAX(min_cluster_size, BLOCK_COPY_CLUSTER_SIZE_DEFAULT);
|
||||||
|
}
|
||||||
|
|
||||||
|
- return MAX(BLOCK_COPY_CLUSTER_SIZE_DEFAULT, bdi.cluster_size);
|
||||||
|
+ return MAX(min_cluster_size,
|
||||||
|
+ MAX(BLOCK_COPY_CLUSTER_SIZE_DEFAULT, bdi.cluster_size));
|
||||||
|
}
|
||||||
|
|
||||||
|
BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||||||
|
BlockDriverState *copy_bitmap_bs,
|
||||||
|
const BdrvDirtyBitmap *bitmap,
|
||||||
|
bool discard_source,
|
||||||
|
+ int64_t min_cluster_size,
|
||||||
|
Error **errp)
|
||||||
|
{
|
||||||
|
ERRP_GUARD();
|
||||||
|
@@ -365,7 +368,13 @@ BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||||||
|
|
||||||
|
GLOBAL_STATE_CODE();
|
||||||
|
|
||||||
|
- cluster_size = block_copy_calculate_cluster_size(target->bs, errp);
|
||||||
|
+ if (min_cluster_size && !is_power_of_2(min_cluster_size)) {
|
||||||
|
+ error_setg(errp, "min-cluster-size needs to be a power of 2");
|
||||||
|
+ return NULL;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ cluster_size = block_copy_calculate_cluster_size(target->bs,
|
||||||
|
+ min_cluster_size, errp);
|
||||||
|
if (cluster_size < 0) {
|
||||||
|
return NULL;
|
||||||
|
}
|
||||||
|
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
|
||||||
|
index 853e01a1eb..47b3cdd09f 100644
|
||||||
|
--- a/block/copy-before-write.c
|
||||||
|
+++ b/block/copy-before-write.c
|
||||||
|
@@ -477,7 +477,8 @@ static int cbw_open(BlockDriverState *bs, QDict *options, int flags,
|
||||||
|
|
||||||
|
s->discard_source = flags & BDRV_O_CBW_DISCARD_SOURCE;
|
||||||
|
s->bcs = block_copy_state_new(bs->file, s->target, bs, bitmap,
|
||||||
|
- flags & BDRV_O_CBW_DISCARD_SOURCE, errp);
|
||||||
|
+ flags & BDRV_O_CBW_DISCARD_SOURCE,
|
||||||
|
+ opts->min_cluster_size, errp);
|
||||||
|
if (!s->bcs) {
|
||||||
|
error_prepend(errp, "Cannot create block-copy-state: ");
|
||||||
|
return -EINVAL;
|
||||||
|
diff --git a/include/block/block-copy.h b/include/block/block-copy.h
|
||||||
|
index bdc703bacd..77857c6c68 100644
|
||||||
|
--- a/include/block/block-copy.h
|
||||||
|
+++ b/include/block/block-copy.h
|
||||||
|
@@ -28,6 +28,7 @@ BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||||||
|
BlockDriverState *copy_bitmap_bs,
|
||||||
|
const BdrvDirtyBitmap *bitmap,
|
||||||
|
bool discard_source,
|
||||||
|
+ int64_t min_cluster_size,
|
||||||
|
Error **errp);
|
||||||
|
|
||||||
|
/* Function should be called prior any actual copy request */
|
||||||
|
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
||||||
|
index 282e2e8a8c..9caf04cbe9 100644
|
||||||
|
--- a/qapi/block-core.json
|
||||||
|
+++ b/qapi/block-core.json
|
||||||
|
@@ -4926,12 +4926,18 @@
|
||||||
|
# @on-cbw-error parameter will decide how this failure is handled.
|
||||||
|
# Default 0. (Since 7.1)
|
||||||
|
#
|
||||||
|
+# @min-cluster-size: Minimum size of blocks used by copy-before-write
|
||||||
|
+# operations. Has to be a power of 2. No effect if smaller than
|
||||||
|
+# the maximum of the target's cluster size and 64 KiB. Default 0.
|
||||||
|
+# (Since 8.1)
|
||||||
|
+#
|
||||||
|
# Since: 6.2
|
||||||
|
##
|
||||||
|
{ 'struct': 'BlockdevOptionsCbw',
|
||||||
|
'base': 'BlockdevOptionsGenericFormat',
|
||||||
|
'data': { 'target': 'BlockdevRef', '*bitmap': 'BlockDirtyBitmap',
|
||||||
|
- '*on-cbw-error': 'OnCbwError', '*cbw-timeout': 'uint32' } }
|
||||||
|
+ '*on-cbw-error': 'OnCbwError', '*cbw-timeout': 'uint32',
|
||||||
|
+ '*min-cluster-size': 'uint32' } }
|
||||||
|
|
||||||
|
##
|
||||||
|
# @BlockdevOptions:
|
106
debian/patches/pve/0045-backup-add-minimum-cluster-size-to-performance-optio.patch
vendored
Normal file
106
debian/patches/pve/0045-backup-add-minimum-cluster-size-to-performance-optio.patch
vendored
Normal file
@@ -0,0 +1,106 @@
|
|||||||
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Date: Thu, 11 Apr 2024 11:29:27 +0200
|
||||||
|
Subject: [PATCH] backup: add minimum cluster size to performance options
|
||||||
|
|
||||||
|
Useful to make discard-source work in the context of backup fleecing
|
||||||
|
when the fleecing image has a larger granularity than the backup
|
||||||
|
target.
|
||||||
|
|
||||||
|
Backup/block-copy will use at least this granularity for copy operations
|
||||||
|
and in particular, discard requests to the backup source will too. If
|
||||||
|
the granularity is too small, they will just be aligned down in
|
||||||
|
cbw_co_pdiscard_snapshot() and thus effectively ignored.
|
||||||
|
|
||||||
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
||||||
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
||||||
|
---
|
||||||
|
block/backup.c | 2 +-
|
||||||
|
block/copy-before-write.c | 2 ++
|
||||||
|
block/copy-before-write.h | 1 +
|
||||||
|
blockdev.c | 3 +++
|
||||||
|
qapi/block-core.json | 9 +++++++--
|
||||||
|
5 files changed, 14 insertions(+), 3 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/block/backup.c b/block/backup.c
|
||||||
|
index 1963e47ab9..fe69723ada 100644
|
||||||
|
--- a/block/backup.c
|
||||||
|
+++ b/block/backup.c
|
||||||
|
@@ -434,7 +434,7 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
|
||||||
|
}
|
||||||
|
|
||||||
|
cbw = bdrv_cbw_append(bs, target, filter_node_name, discard_source,
|
||||||
|
- &bcs, errp);
|
||||||
|
+ perf->min_cluster_size, &bcs, errp);
|
||||||
|
if (!cbw) {
|
||||||
|
goto error;
|
||||||
|
}
|
||||||
|
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
|
||||||
|
index 47b3cdd09f..bba58326d7 100644
|
||||||
|
--- a/block/copy-before-write.c
|
||||||
|
+++ b/block/copy-before-write.c
|
||||||
|
@@ -546,6 +546,7 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
|
||||||
|
BlockDriverState *target,
|
||||||
|
const char *filter_node_name,
|
||||||
|
bool discard_source,
|
||||||
|
+ int64_t min_cluster_size,
|
||||||
|
BlockCopyState **bcs,
|
||||||
|
Error **errp)
|
||||||
|
{
|
||||||
|
@@ -564,6 +565,7 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
|
||||||
|
}
|
||||||
|
qdict_put_str(opts, "file", bdrv_get_node_name(source));
|
||||||
|
qdict_put_str(opts, "target", bdrv_get_node_name(target));
|
||||||
|
+ qdict_put_int(opts, "min-cluster-size", min_cluster_size);
|
||||||
|
|
||||||
|
top = bdrv_insert_node(source, opts, flags, errp);
|
||||||
|
if (!top) {
|
||||||
|
diff --git a/block/copy-before-write.h b/block/copy-before-write.h
|
||||||
|
index 01af0cd3c4..dc6cafe7fa 100644
|
||||||
|
--- a/block/copy-before-write.h
|
||||||
|
+++ b/block/copy-before-write.h
|
||||||
|
@@ -40,6 +40,7 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
|
||||||
|
BlockDriverState *target,
|
||||||
|
const char *filter_node_name,
|
||||||
|
bool discard_source,
|
||||||
|
+ int64_t min_cluster_size,
|
||||||
|
BlockCopyState **bcs,
|
||||||
|
Error **errp);
|
||||||
|
void bdrv_cbw_drop(BlockDriverState *bs);
|
||||||
|
diff --git a/blockdev.c b/blockdev.c
|
||||||
|
index 1054a69279..cbe224387b 100644
|
||||||
|
--- a/blockdev.c
|
||||||
|
+++ b/blockdev.c
|
||||||
|
@@ -2654,6 +2654,9 @@ static BlockJob *do_backup_common(BackupCommon *backup,
|
||||||
|
if (backup->x_perf->has_max_chunk) {
|
||||||
|
perf.max_chunk = backup->x_perf->max_chunk;
|
||||||
|
}
|
||||||
|
+ if (backup->x_perf->has_min_cluster_size) {
|
||||||
|
+ perf.min_cluster_size = backup->x_perf->min_cluster_size;
|
||||||
|
+ }
|
||||||
|
}
|
||||||
|
|
||||||
|
if ((backup->sync == MIRROR_SYNC_MODE_BITMAP) ||
|
||||||
|
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
||||||
|
index 9caf04cbe9..df934647ed 100644
|
||||||
|
--- a/qapi/block-core.json
|
||||||
|
+++ b/qapi/block-core.json
|
||||||
|
@@ -1790,11 +1790,16 @@
|
||||||
|
# it should not be less than job cluster size which is calculated
|
||||||
|
# as maximum of target image cluster size and 64k. Default 0.
|
||||||
|
#
|
||||||
|
+# @min-cluster-size: Minimum size of blocks used by copy-before-write
|
||||||
|
+# and background copy operations. Has to be a power of 2. No
|
||||||
|
+# effect if smaller than the maximum of the target's cluster size
|
||||||
|
+# and 64 KiB. Default 0. (Since 8.1)
|
||||||
|
+#
|
||||||
|
# Since: 6.0
|
||||||
|
##
|
||||||
|
{ 'struct': 'BackupPerf',
|
||||||
|
- 'data': { '*use-copy-range': 'bool',
|
||||||
|
- '*max-workers': 'int', '*max-chunk': 'int64' } }
|
||||||
|
+ 'data': { '*use-copy-range': 'bool', '*max-workers': 'int',
|
||||||
|
+ '*max-chunk': 'int64', '*min-cluster-size': 'uint32' } }
|
||||||
|
|
||||||
|
##
|
||||||
|
# @BackupCommon:
|
@@ -80,7 +80,7 @@ index 439a7a14c8..d0e7771dcc 100644
|
|||||||
|
|
||||||
hmp_handle_error(mon, error);
|
hmp_handle_error(mon, error);
|
||||||
diff --git a/pve-backup.c b/pve-backup.c
|
diff --git a/pve-backup.c b/pve-backup.c
|
||||||
index faa6a9b93c..4b0820c8a7 100644
|
index 5ebb6a3947..a747d12d3d 100644
|
||||||
--- a/pve-backup.c
|
--- a/pve-backup.c
|
||||||
+++ b/pve-backup.c
|
+++ b/pve-backup.c
|
||||||
@@ -7,9 +7,11 @@
|
@@ -7,9 +7,11 @@
|
||||||
@@ -252,7 +252,7 @@ index faa6a9b93c..4b0820c8a7 100644
|
|||||||
+ }
|
+ }
|
||||||
+ BlockDriverState *fleecing_bs = blk_bs(fleecing_blk);
|
+ BlockDriverState *fleecing_bs = blk_bs(fleecing_blk);
|
||||||
+ if (!bdrv_co_is_inserted(fleecing_bs)) {
|
+ if (!bdrv_co_is_inserted(fleecing_bs)) {
|
||||||
+ error_setg(errp, "Device '%s' has no medium", fleecing_devid);
|
+ error_setg(errp, QERR_DEVICE_HAS_NO_MEDIUM, fleecing_devid);
|
||||||
+ goto err;
|
+ goto err;
|
||||||
+ }
|
+ }
|
||||||
+ /*
|
+ /*
|
||||||
@@ -286,7 +286,7 @@ index faa6a9b93c..4b0820c8a7 100644
|
|||||||
bdrv_graph_co_rdunlock();
|
bdrv_graph_co_rdunlock();
|
||||||
if (local_err) {
|
if (local_err) {
|
||||||
error_propagate(errp, local_err);
|
error_propagate(errp, local_err);
|
||||||
@@ -1087,5 +1215,6 @@ ProxmoxSupportStatus *qmp_query_proxmox_support(Error **errp)
|
@@ -1089,5 +1217,6 @@ ProxmoxSupportStatus *qmp_query_proxmox_support(Error **errp)
|
||||||
ret->query_bitmap_info = true;
|
ret->query_bitmap_info = true;
|
||||||
ret->pbs_masterkey = true;
|
ret->pbs_masterkey = true;
|
||||||
ret->backup_max_workers = true;
|
ret->backup_max_workers = true;
|
||||||
@@ -294,7 +294,7 @@ index faa6a9b93c..4b0820c8a7 100644
|
|||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
diff --git a/qapi/block-core.json b/qapi/block-core.json
|
||||||
index 9795247c1f..c581f1f238 100644
|
index df934647ed..ff441d4258 100644
|
||||||
--- a/qapi/block-core.json
|
--- a/qapi/block-core.json
|
||||||
+++ b/qapi/block-core.json
|
+++ b/qapi/block-core.json
|
||||||
@@ -948,6 +948,10 @@
|
@@ -948,6 +948,10 @@
|
@@ -1,103 +0,0 @@
|
|||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
Date: Thu, 7 Nov 2024 17:51:14 +0100
|
|
||||||
Subject: [PATCH] PVE backup: fixup error handling for fleecing
|
|
||||||
|
|
||||||
The drained section needs to be terminated before breaking out of the
|
|
||||||
loop in the error scenarios. Otherwise, guest IO on the drive would
|
|
||||||
become stuck.
|
|
||||||
|
|
||||||
If the job is created successfully, then the job completion callback
|
|
||||||
will clean up the snapshot access block nodes. In case failure
|
|
||||||
happened before the job is created, there was no cleanup for the
|
|
||||||
snapshot access block nodes yet. Add it.
|
|
||||||
|
|
||||||
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
---
|
|
||||||
pve-backup.c | 38 +++++++++++++++++++++++++-------------
|
|
||||||
1 file changed, 25 insertions(+), 13 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/pve-backup.c b/pve-backup.c
|
|
||||||
index 81697d9bf9..320c660589 100644
|
|
||||||
--- a/pve-backup.c
|
|
||||||
+++ b/pve-backup.c
|
|
||||||
@@ -357,22 +357,23 @@ static void coroutine_fn pvebackup_co_complete_stream(void *opaque)
|
|
||||||
qemu_co_mutex_unlock(&backup_state.backup_mutex);
|
|
||||||
}
|
|
||||||
|
|
||||||
-static void pvebackup_complete_cb(void *opaque, int ret)
|
|
||||||
+static void cleanup_snapshot_access(PVEBackupDevInfo *di)
|
|
||||||
{
|
|
||||||
- PVEBackupDevInfo *di = opaque;
|
|
||||||
- di->completed_ret = ret;
|
|
||||||
-
|
|
||||||
- /*
|
|
||||||
- * Handle block-graph specific cleanup (for fleecing) outside of the coroutine, because the work
|
|
||||||
- * won't be done as a coroutine anyways:
|
|
||||||
- * - For snapshot_access, allows doing bdrv_unref() directly. Doing it via bdrv_co_unref() would
|
|
||||||
- * just spawn a BH calling bdrv_unref().
|
|
||||||
- * - For cbw, draining would need to spawn a BH.
|
|
||||||
- */
|
|
||||||
if (di->fleecing.snapshot_access) {
|
|
||||||
bdrv_unref(di->fleecing.snapshot_access);
|
|
||||||
di->fleecing.snapshot_access = NULL;
|
|
||||||
}
|
|
||||||
+ if (di->fleecing.cbw) {
|
|
||||||
+ bdrv_cbw_drop(di->fleecing.cbw);
|
|
||||||
+ di->fleecing.cbw = NULL;
|
|
||||||
+ }
|
|
||||||
+}
|
|
||||||
+
|
|
||||||
+static void pvebackup_complete_cb(void *opaque, int ret)
|
|
||||||
+{
|
|
||||||
+ PVEBackupDevInfo *di = opaque;
|
|
||||||
+ di->completed_ret = ret;
|
|
||||||
+
|
|
||||||
if (di->fleecing.cbw) {
|
|
||||||
/*
|
|
||||||
* With fleecing, failure for cbw does not fail the guest write, but only sets the snapshot
|
|
||||||
@@ -383,10 +384,17 @@ static void pvebackup_complete_cb(void *opaque, int ret)
|
|
||||||
if (di->completed_ret == -EACCES && snapshot_error) {
|
|
||||||
di->completed_ret = snapshot_error;
|
|
||||||
}
|
|
||||||
- bdrv_cbw_drop(di->fleecing.cbw);
|
|
||||||
- di->fleecing.cbw = NULL;
|
|
||||||
}
|
|
||||||
|
|
||||||
+ /*
|
|
||||||
+ * Handle block-graph specific cleanup (for fleecing) outside of the coroutine, because the work
|
|
||||||
+ * won't be done as a coroutine anyways:
|
|
||||||
+ * - For snapshot_access, allows doing bdrv_unref() directly. Doing it via bdrv_co_unref() would
|
|
||||||
+ * just spawn a BH calling bdrv_unref().
|
|
||||||
+ * - For cbw, draining would need to spawn a BH.
|
|
||||||
+ */
|
|
||||||
+ cleanup_snapshot_access(di);
|
|
||||||
+
|
|
||||||
/*
|
|
||||||
* Needs to happen outside of coroutine, because it takes the graph write lock.
|
|
||||||
*/
|
|
||||||
@@ -587,6 +595,7 @@ static void create_backup_jobs_bh(void *opaque) {
|
|
||||||
if (!di->fleecing.cbw) {
|
|
||||||
error_setg(errp, "appending cbw node for fleecing failed: %s",
|
|
||||||
local_err ? error_get_pretty(local_err) : "unknown error");
|
|
||||||
+ bdrv_drained_end(di->bs);
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
|
|
||||||
@@ -599,6 +608,8 @@ static void create_backup_jobs_bh(void *opaque) {
|
|
||||||
if (!di->fleecing.snapshot_access) {
|
|
||||||
error_setg(errp, "setting up snapshot access for fleecing failed: %s",
|
|
||||||
local_err ? error_get_pretty(local_err) : "unknown error");
|
|
||||||
+ cleanup_snapshot_access(di);
|
|
||||||
+ bdrv_drained_end(di->bs);
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
source_bs = di->fleecing.snapshot_access;
|
|
||||||
@@ -637,6 +648,7 @@ static void create_backup_jobs_bh(void *opaque) {
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!job || local_err) {
|
|
||||||
+ cleanup_snapshot_access(di);
|
|
||||||
error_setg(errp, "backup_job_create failed: %s",
|
|
||||||
local_err ? error_get_pretty(local_err) : "null");
|
|
||||||
break;
|
|
@@ -1,135 +0,0 @@
|
|||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
Date: Thu, 7 Nov 2024 17:51:15 +0100
|
|
||||||
Subject: [PATCH] PVE backup: factor out setting up snapshot access for
|
|
||||||
fleecing
|
|
||||||
|
|
||||||
Avoids some line bloat in the create_backup_jobs_bh() function and is
|
|
||||||
in preparation for setting up the snapshot access independently of
|
|
||||||
fleecing, in particular that will be useful for providing access to
|
|
||||||
the snapshot via NBD.
|
|
||||||
|
|
||||||
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
---
|
|
||||||
pve-backup.c | 95 ++++++++++++++++++++++++++++++++--------------------
|
|
||||||
1 file changed, 58 insertions(+), 37 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/pve-backup.c b/pve-backup.c
|
|
||||||
index 320c660589..d8d0c04b0f 100644
|
|
||||||
--- a/pve-backup.c
|
|
||||||
+++ b/pve-backup.c
|
|
||||||
@@ -525,6 +525,62 @@ static int coroutine_fn pvebackup_co_add_config(
|
|
||||||
goto out;
|
|
||||||
}
|
|
||||||
|
|
||||||
+/*
|
|
||||||
+ * Setup a snapshot-access block node for a device with associated fleecing image.
|
|
||||||
+ */
|
|
||||||
+static int setup_snapshot_access(PVEBackupDevInfo *di, Error **errp)
|
|
||||||
+{
|
|
||||||
+ Error *local_err = NULL;
|
|
||||||
+
|
|
||||||
+ if (!di->fleecing.bs) {
|
|
||||||
+ error_setg(errp, "no associated fleecing image");
|
|
||||||
+ return -1;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ QDict *cbw_opts = qdict_new();
|
|
||||||
+ qdict_put_str(cbw_opts, "driver", "copy-before-write");
|
|
||||||
+ qdict_put_str(cbw_opts, "file", bdrv_get_node_name(di->bs));
|
|
||||||
+ qdict_put_str(cbw_opts, "target", bdrv_get_node_name(di->fleecing.bs));
|
|
||||||
+
|
|
||||||
+ if (di->bitmap) {
|
|
||||||
+ /*
|
|
||||||
+ * Only guest writes to parts relevant for the backup need to be intercepted with
|
|
||||||
+ * old data being copied to the fleecing image.
|
|
||||||
+ */
|
|
||||||
+ qdict_put_str(cbw_opts, "bitmap.node", bdrv_get_node_name(di->bs));
|
|
||||||
+ qdict_put_str(cbw_opts, "bitmap.name", bdrv_dirty_bitmap_name(di->bitmap));
|
|
||||||
+ }
|
|
||||||
+ /*
|
|
||||||
+ * Fleecing storage is supposed to be fast and it's better to break backup than guest
|
|
||||||
+ * writes. Certain guest drivers like VirtIO-win have 60 seconds timeout by default, so
|
|
||||||
+ * abort a bit before that.
|
|
||||||
+ */
|
|
||||||
+ qdict_put_str(cbw_opts, "on-cbw-error", "break-snapshot");
|
|
||||||
+ qdict_put_int(cbw_opts, "cbw-timeout", 45);
|
|
||||||
+
|
|
||||||
+ di->fleecing.cbw = bdrv_insert_node(di->bs, cbw_opts, BDRV_O_RDWR, &local_err);
|
|
||||||
+
|
|
||||||
+ if (!di->fleecing.cbw) {
|
|
||||||
+ error_setg(errp, "appending cbw node for fleecing failed: %s",
|
|
||||||
+ local_err ? error_get_pretty(local_err) : "unknown error");
|
|
||||||
+ return -1;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ QDict *snapshot_access_opts = qdict_new();
|
|
||||||
+ qdict_put_str(snapshot_access_opts, "driver", "snapshot-access");
|
|
||||||
+ qdict_put_str(snapshot_access_opts, "file", bdrv_get_node_name(di->fleecing.cbw));
|
|
||||||
+
|
|
||||||
+ di->fleecing.snapshot_access =
|
|
||||||
+ bdrv_open(NULL, NULL, snapshot_access_opts, BDRV_O_RDWR | BDRV_O_UNMAP, &local_err);
|
|
||||||
+ if (!di->fleecing.snapshot_access) {
|
|
||||||
+ error_setg(errp, "setting up snapshot access for fleecing failed: %s",
|
|
||||||
+ local_err ? error_get_pretty(local_err) : "unknown error");
|
|
||||||
+ return -1;
|
|
||||||
+ }
|
|
||||||
+
|
|
||||||
+ return 0;
|
|
||||||
+}
|
|
||||||
+
|
|
||||||
/*
|
|
||||||
* backup_job_create can *not* be run from a coroutine, so this can't either.
|
|
||||||
* The caller is responsible that backup_mutex is held nonetheless.
|
|
||||||
@@ -569,49 +625,14 @@ static void create_backup_jobs_bh(void *opaque) {
|
|
||||||
const char *job_id = bdrv_get_device_name(di->bs);
|
|
||||||
bdrv_graph_co_rdunlock();
|
|
||||||
if (di->fleecing.bs) {
|
|
||||||
- QDict *cbw_opts = qdict_new();
|
|
||||||
- qdict_put_str(cbw_opts, "driver", "copy-before-write");
|
|
||||||
- qdict_put_str(cbw_opts, "file", bdrv_get_node_name(di->bs));
|
|
||||||
- qdict_put_str(cbw_opts, "target", bdrv_get_node_name(di->fleecing.bs));
|
|
||||||
-
|
|
||||||
- if (di->bitmap) {
|
|
||||||
- /*
|
|
||||||
- * Only guest writes to parts relevant for the backup need to be intercepted with
|
|
||||||
- * old data being copied to the fleecing image.
|
|
||||||
- */
|
|
||||||
- qdict_put_str(cbw_opts, "bitmap.node", bdrv_get_node_name(di->bs));
|
|
||||||
- qdict_put_str(cbw_opts, "bitmap.name", bdrv_dirty_bitmap_name(di->bitmap));
|
|
||||||
- }
|
|
||||||
- /*
|
|
||||||
- * Fleecing storage is supposed to be fast and it's better to break backup than guest
|
|
||||||
- * writes. Certain guest drivers like VirtIO-win have 60 seconds timeout by default, so
|
|
||||||
- * abort a bit before that.
|
|
||||||
- */
|
|
||||||
- qdict_put_str(cbw_opts, "on-cbw-error", "break-snapshot");
|
|
||||||
- qdict_put_int(cbw_opts, "cbw-timeout", 45);
|
|
||||||
-
|
|
||||||
- di->fleecing.cbw = bdrv_insert_node(di->bs, cbw_opts, BDRV_O_RDWR, &local_err);
|
|
||||||
-
|
|
||||||
- if (!di->fleecing.cbw) {
|
|
||||||
- error_setg(errp, "appending cbw node for fleecing failed: %s",
|
|
||||||
- local_err ? error_get_pretty(local_err) : "unknown error");
|
|
||||||
- bdrv_drained_end(di->bs);
|
|
||||||
- break;
|
|
||||||
- }
|
|
||||||
-
|
|
||||||
- QDict *snapshot_access_opts = qdict_new();
|
|
||||||
- qdict_put_str(snapshot_access_opts, "driver", "snapshot-access");
|
|
||||||
- qdict_put_str(snapshot_access_opts, "file", bdrv_get_node_name(di->fleecing.cbw));
|
|
||||||
-
|
|
||||||
- di->fleecing.snapshot_access =
|
|
||||||
- bdrv_open(NULL, NULL, snapshot_access_opts, BDRV_O_RDWR | BDRV_O_UNMAP, &local_err);
|
|
||||||
- if (!di->fleecing.snapshot_access) {
|
|
||||||
+ if (setup_snapshot_access(di, &local_err) < 0) {
|
|
||||||
error_setg(errp, "setting up snapshot access for fleecing failed: %s",
|
|
||||||
local_err ? error_get_pretty(local_err) : "unknown error");
|
|
||||||
cleanup_snapshot_access(di);
|
|
||||||
bdrv_drained_end(di->bs);
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
+
|
|
||||||
source_bs = di->fleecing.snapshot_access;
|
|
||||||
discard_source = true;
|
|
||||||
|
|
@@ -21,7 +21,7 @@ Tested-by: Friedrich Weber <f.weber@proxmox.com>
|
|||||||
3 files changed, 22 insertions(+), 6 deletions(-)
|
3 files changed, 22 insertions(+), 6 deletions(-)
|
||||||
|
|
||||||
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
|
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
|
||||||
index 81afeff1c7..fdf9cdc0cd 100644
|
index bba58326d7..50cc4c7aae 100644
|
||||||
--- a/block/copy-before-write.c
|
--- a/block/copy-before-write.c
|
||||||
+++ b/block/copy-before-write.c
|
+++ b/block/copy-before-write.c
|
||||||
@@ -27,6 +27,7 @@
|
@@ -27,6 +27,7 @@
|
||||||
@@ -32,7 +32,7 @@ index 81afeff1c7..fdf9cdc0cd 100644
|
|||||||
#include "qemu/cutils.h"
|
#include "qemu/cutils.h"
|
||||||
#include "qapi/error.h"
|
#include "qapi/error.h"
|
||||||
#include "block/block_int.h"
|
#include "block/block_int.h"
|
||||||
@@ -75,7 +76,8 @@ typedef struct BDRVCopyBeforeWriteState {
|
@@ -74,7 +75,8 @@ typedef struct BDRVCopyBeforeWriteState {
|
||||||
* @snapshot_error is normally zero. But on first copy-before-write failure
|
* @snapshot_error is normally zero. But on first copy-before-write failure
|
||||||
* when @on_cbw_error == ON_CBW_ERROR_BREAK_SNAPSHOT, @snapshot_error takes
|
* when @on_cbw_error == ON_CBW_ERROR_BREAK_SNAPSHOT, @snapshot_error takes
|
||||||
* value of this error (<0). After that all in-flight and further
|
* value of this error (<0). After that all in-flight and further
|
||||||
@@ -42,7 +42,7 @@ index 81afeff1c7..fdf9cdc0cd 100644
|
|||||||
*/
|
*/
|
||||||
int snapshot_error;
|
int snapshot_error;
|
||||||
} BDRVCopyBeforeWriteState;
|
} BDRVCopyBeforeWriteState;
|
||||||
@@ -115,7 +117,7 @@ static coroutine_fn int cbw_do_copy_before_write(BlockDriverState *bs,
|
@@ -114,7 +116,7 @@ static coroutine_fn int cbw_do_copy_before_write(BlockDriverState *bs,
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -51,7 +51,7 @@ index 81afeff1c7..fdf9cdc0cd 100644
|
|||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -139,9 +141,7 @@ static coroutine_fn int cbw_do_copy_before_write(BlockDriverState *bs,
|
@@ -138,9 +140,7 @@ static coroutine_fn int cbw_do_copy_before_write(BlockDriverState *bs,
|
||||||
WITH_QEMU_LOCK_GUARD(&s->lock) {
|
WITH_QEMU_LOCK_GUARD(&s->lock) {
|
||||||
if (ret < 0) {
|
if (ret < 0) {
|
||||||
assert(s->on_cbw_error == ON_CBW_ERROR_BREAK_SNAPSHOT);
|
assert(s->on_cbw_error == ON_CBW_ERROR_BREAK_SNAPSHOT);
|
||||||
@@ -62,7 +62,7 @@ index 81afeff1c7..fdf9cdc0cd 100644
|
|||||||
} else {
|
} else {
|
||||||
bdrv_set_dirty_bitmap(s->done_bitmap, off, end - off);
|
bdrv_set_dirty_bitmap(s->done_bitmap, off, end - off);
|
||||||
}
|
}
|
||||||
@@ -215,7 +215,7 @@ cbw_snapshot_read_lock(BlockDriverState *bs, int64_t offset, int64_t bytes,
|
@@ -214,7 +214,7 @@ cbw_snapshot_read_lock(BlockDriverState *bs, int64_t offset, int64_t bytes,
|
||||||
|
|
||||||
QEMU_LOCK_GUARD(&s->lock);
|
QEMU_LOCK_GUARD(&s->lock);
|
||||||
|
|
||||||
@@ -71,7 +71,7 @@ index 81afeff1c7..fdf9cdc0cd 100644
|
|||||||
g_free(req);
|
g_free(req);
|
||||||
return NULL;
|
return NULL;
|
||||||
}
|
}
|
||||||
@@ -595,6 +595,12 @@ void bdrv_cbw_drop(BlockDriverState *bs)
|
@@ -585,6 +585,12 @@ void bdrv_cbw_drop(BlockDriverState *bs)
|
||||||
bdrv_unref(bs);
|
bdrv_unref(bs);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -85,7 +85,7 @@ index 81afeff1c7..fdf9cdc0cd 100644
|
|||||||
{
|
{
|
||||||
bdrv_register(&bdrv_cbw_filter);
|
bdrv_register(&bdrv_cbw_filter);
|
||||||
diff --git a/block/copy-before-write.h b/block/copy-before-write.h
|
diff --git a/block/copy-before-write.h b/block/copy-before-write.h
|
||||||
index 2a5d4ba693..969da3620f 100644
|
index dc6cafe7fa..a27d2d7d9f 100644
|
||||||
--- a/block/copy-before-write.h
|
--- a/block/copy-before-write.h
|
||||||
+++ b/block/copy-before-write.h
|
+++ b/block/copy-before-write.h
|
||||||
@@ -44,5 +44,6 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
|
@@ -44,5 +44,6 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
|
||||||
@@ -96,7 +96,7 @@ index 2a5d4ba693..969da3620f 100644
|
|||||||
|
|
||||||
#endif /* COPY_BEFORE_WRITE_H */
|
#endif /* COPY_BEFORE_WRITE_H */
|
||||||
diff --git a/pve-backup.c b/pve-backup.c
|
diff --git a/pve-backup.c b/pve-backup.c
|
||||||
index 4b0820c8a7..81697d9bf9 100644
|
index a747d12d3d..4e730aa3da 100644
|
||||||
--- a/pve-backup.c
|
--- a/pve-backup.c
|
||||||
+++ b/pve-backup.c
|
+++ b/pve-backup.c
|
||||||
@@ -374,6 +374,15 @@ static void pvebackup_complete_cb(void *opaque, int ret)
|
@@ -374,6 +374,15 @@ static void pvebackup_complete_cb(void *opaque, int ret)
|
@@ -1,135 +0,0 @@
|
|||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
Date: Thu, 7 Nov 2024 17:51:16 +0100
|
|
||||||
Subject: [PATCH] PVE backup: save device name in device info structure
|
|
||||||
|
|
||||||
The device name needs to be queried while holding the graph read lock
|
|
||||||
and since it doesn't change during the whole operation, just get it
|
|
||||||
once during setup and avoid the need to query it again in different
|
|
||||||
places.
|
|
||||||
|
|
||||||
Also in preparation to use it more often in error messages and for the
|
|
||||||
upcoming external backup access API.
|
|
||||||
|
|
||||||
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
---
|
|
||||||
pve-backup.c | 29 +++++++++++++++--------------
|
|
||||||
1 file changed, 15 insertions(+), 14 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/pve-backup.c b/pve-backup.c
|
|
||||||
index d8d0c04b0f..e2110ce0db 100644
|
|
||||||
--- a/pve-backup.c
|
|
||||||
+++ b/pve-backup.c
|
|
||||||
@@ -94,6 +94,7 @@ typedef struct PVEBackupDevInfo {
|
|
||||||
size_t size;
|
|
||||||
uint64_t block_size;
|
|
||||||
uint8_t dev_id;
|
|
||||||
+ char* device_name;
|
|
||||||
int completed_ret; // INT_MAX if not completed
|
|
||||||
BdrvDirtyBitmap *bitmap;
|
|
||||||
BlockDriverState *target;
|
|
||||||
@@ -327,6 +328,8 @@ static void coroutine_fn pvebackup_co_complete_stream(void *opaque)
|
|
||||||
}
|
|
||||||
|
|
||||||
di->bs = NULL;
|
|
||||||
+ g_free(di->device_name);
|
|
||||||
+ di->device_name = NULL;
|
|
||||||
|
|
||||||
assert(di->target == NULL);
|
|
||||||
|
|
||||||
@@ -621,9 +624,6 @@ static void create_backup_jobs_bh(void *opaque) {
|
|
||||||
|
|
||||||
BlockDriverState *source_bs = di->bs;
|
|
||||||
bool discard_source = false;
|
|
||||||
- bdrv_graph_co_rdlock();
|
|
||||||
- const char *job_id = bdrv_get_device_name(di->bs);
|
|
||||||
- bdrv_graph_co_rdunlock();
|
|
||||||
if (di->fleecing.bs) {
|
|
||||||
if (setup_snapshot_access(di, &local_err) < 0) {
|
|
||||||
error_setg(errp, "setting up snapshot access for fleecing failed: %s",
|
|
||||||
@@ -654,7 +654,7 @@ static void create_backup_jobs_bh(void *opaque) {
|
|
||||||
}
|
|
||||||
|
|
||||||
BlockJob *job = backup_job_create(
|
|
||||||
- job_id, source_bs, di->target, backup_state.speed, sync_mode, di->bitmap,
|
|
||||||
+ di->device_name, source_bs, di->target, backup_state.speed, sync_mode, di->bitmap,
|
|
||||||
bitmap_mode, false, discard_source, NULL, &perf, BLOCKDEV_ON_ERROR_REPORT,
|
|
||||||
BLOCKDEV_ON_ERROR_REPORT, JOB_DEFAULT, pvebackup_complete_cb, di, backup_state.txn,
|
|
||||||
&local_err);
|
|
||||||
@@ -751,6 +751,7 @@ static GList coroutine_fn GRAPH_RDLOCK *get_device_info(
|
|
||||||
}
|
|
||||||
PVEBackupDevInfo *di = g_new0(PVEBackupDevInfo, 1);
|
|
||||||
di->bs = bs;
|
|
||||||
+ di->device_name = g_strdup(bdrv_get_device_name(bs));
|
|
||||||
|
|
||||||
if (fleecing && device_uses_fleecing(*d)) {
|
|
||||||
g_autofree gchar *fleecing_devid = g_strconcat(*d, "-fleecing", NULL);
|
|
||||||
@@ -789,6 +790,7 @@ static GList coroutine_fn GRAPH_RDLOCK *get_device_info(
|
|
||||||
|
|
||||||
PVEBackupDevInfo *di = g_new0(PVEBackupDevInfo, 1);
|
|
||||||
di->bs = bs;
|
|
||||||
+ di->device_name = g_strdup(bdrv_get_device_name(bs));
|
|
||||||
di_list = g_list_append(di_list, di);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -956,9 +958,6 @@ UuidInfo coroutine_fn *qmp_backup(
|
|
||||||
|
|
||||||
di->block_size = dump_cb_block_size;
|
|
||||||
|
|
||||||
- bdrv_graph_co_rdlock();
|
|
||||||
- const char *devname = bdrv_get_device_name(di->bs);
|
|
||||||
- bdrv_graph_co_rdunlock();
|
|
||||||
PBSBitmapAction action = PBS_BITMAP_ACTION_NOT_USED;
|
|
||||||
size_t dirty = di->size;
|
|
||||||
|
|
||||||
@@ -973,7 +972,8 @@ UuidInfo coroutine_fn *qmp_backup(
|
|
||||||
}
|
|
||||||
action = PBS_BITMAP_ACTION_NEW;
|
|
||||||
} else {
|
|
||||||
- expect_only_dirty = proxmox_backup_check_incremental(pbs, devname, di->size) != 0;
|
|
||||||
+ expect_only_dirty =
|
|
||||||
+ proxmox_backup_check_incremental(pbs, di->device_name, di->size) != 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (expect_only_dirty) {
|
|
||||||
@@ -997,7 +997,8 @@ UuidInfo coroutine_fn *qmp_backup(
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
- int dev_id = proxmox_backup_co_register_image(pbs, devname, di->size, expect_only_dirty, errp);
|
|
||||||
+ int dev_id = proxmox_backup_co_register_image(pbs, di->device_name, di->size,
|
|
||||||
+ expect_only_dirty, errp);
|
|
||||||
if (dev_id < 0) {
|
|
||||||
goto err_mutex;
|
|
||||||
}
|
|
||||||
@@ -1009,7 +1010,7 @@ UuidInfo coroutine_fn *qmp_backup(
|
|
||||||
di->dev_id = dev_id;
|
|
||||||
|
|
||||||
PBSBitmapInfo *info = g_malloc(sizeof(*info));
|
|
||||||
- info->drive = g_strdup(devname);
|
|
||||||
+ info->drive = g_strdup(di->device_name);
|
|
||||||
info->action = action;
|
|
||||||
info->size = di->size;
|
|
||||||
info->dirty = dirty;
|
|
||||||
@@ -1032,10 +1033,7 @@ UuidInfo coroutine_fn *qmp_backup(
|
|
||||||
goto err_mutex;
|
|
||||||
}
|
|
||||||
|
|
||||||
- bdrv_graph_co_rdlock();
|
|
||||||
- const char *devname = bdrv_get_device_name(di->bs);
|
|
||||||
- bdrv_graph_co_rdunlock();
|
|
||||||
- di->dev_id = vma_writer_register_stream(vmaw, devname, di->size);
|
|
||||||
+ di->dev_id = vma_writer_register_stream(vmaw, di->device_name, di->size);
|
|
||||||
if (di->dev_id <= 0) {
|
|
||||||
error_set(errp, ERROR_CLASS_GENERIC_ERROR,
|
|
||||||
"register_stream failed");
|
|
||||||
@@ -1146,6 +1144,9 @@ err:
|
|
||||||
bdrv_co_unref(di->target);
|
|
||||||
}
|
|
||||||
|
|
||||||
+ g_free(di->device_name);
|
|
||||||
+ di->device_name = NULL;
|
|
||||||
+
|
|
||||||
g_free(di);
|
|
||||||
}
|
|
||||||
g_list_free(di_list);
|
|
@@ -1,25 +0,0 @@
|
|||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
Date: Thu, 7 Nov 2024 17:51:17 +0100
|
|
||||||
Subject: [PATCH] PVE backup: include device name in error when setting up
|
|
||||||
snapshot access fails
|
|
||||||
|
|
||||||
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
---
|
|
||||||
pve-backup.c | 3 ++-
|
|
||||||
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
||||||
|
|
||||||
diff --git a/pve-backup.c b/pve-backup.c
|
|
||||||
index e2110ce0db..32352fb5ec 100644
|
|
||||||
--- a/pve-backup.c
|
|
||||||
+++ b/pve-backup.c
|
|
||||||
@@ -626,7 +626,8 @@ static void create_backup_jobs_bh(void *opaque) {
|
|
||||||
bool discard_source = false;
|
|
||||||
if (di->fleecing.bs) {
|
|
||||||
if (setup_snapshot_access(di, &local_err) < 0) {
|
|
||||||
- error_setg(errp, "setting up snapshot access for fleecing failed: %s",
|
|
||||||
+ error_setg(errp, "%s - setting up snapshot access for fleecing failed: %s",
|
|
||||||
+ di->device_name,
|
|
||||||
local_err ? error_get_pretty(local_err) : "unknown error");
|
|
||||||
cleanup_snapshot_access(di);
|
|
||||||
bdrv_drained_end(di->bs);
|
|
@@ -1,137 +0,0 @@
|
|||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
Date: Fri, 3 Jan 2025 14:03:12 +0100
|
|
||||||
Subject: [PATCH] adapt machine version deprecation for Proxmox VE
|
|
||||||
|
|
||||||
In commit a35f8577a0 ("include/hw: add macros for deprecation &
|
|
||||||
removal of versioned machines"), a new machine version deprecation and
|
|
||||||
removal policy was introduced. After only 3 years a machine version
|
|
||||||
will be deprecated while being removed after 6 years.
|
|
||||||
|
|
||||||
The deprecation is a bit early considering major PVE releases are
|
|
||||||
approximately every 2 years. This means that a deprecation warning can
|
|
||||||
already happen for a machine version that was introduced during the
|
|
||||||
previous major release. This would scare users for no good reason, so
|
|
||||||
avoid deprecating machine versions in PVE too early and define a
|
|
||||||
baseline of machine versions that will be supported throughout a
|
|
||||||
single major PVE release.
|
|
||||||
|
|
||||||
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
---
|
|
||||||
include/hw/boards.h | 78 +++++++++++++++++++++++++++++----------------
|
|
||||||
1 file changed, 51 insertions(+), 27 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/include/hw/boards.h b/include/hw/boards.h
|
|
||||||
index d1741ea121..3f9befda14 100644
|
|
||||||
--- a/include/hw/boards.h
|
|
||||||
+++ b/include/hw/boards.h
|
|
||||||
@@ -631,42 +631,66 @@ struct MachineState {
|
|
||||||
|
|
||||||
|
|
||||||
/*
|
|
||||||
- * How many years/major releases for each phase
|
|
||||||
- * of the life cycle. Assumes use of versioning
|
|
||||||
- * scheme where major is bumped each year
|
|
||||||
+ * Baseline of machine versions that are still considered supported throughout
|
|
||||||
+ * current major Proxmox VE release. Machine versions older than this are
|
|
||||||
+ * considered to be deprecated in Proxmox VE.
|
|
||||||
+ *
|
|
||||||
+ * Machine versions older than 6 years are removed just like in upstream QEMU.
|
|
||||||
+ * (policy takes effect with QEMU 10.1). Assumes yearly major QEMU release.
|
|
||||||
+ *
|
|
||||||
+ * QEMU release cylce N.0 in ~April, N.1 in ~August, N.2 in ~December
|
|
||||||
+ * Debian/PVE release cylce ~every two years in summer
|
|
||||||
+ *
|
|
||||||
+ * PVE - last QEMU - machine versions dropped - baseline
|
|
||||||
+ * 8 9.2 2.3 and older 2.4
|
|
||||||
+ * 9 11.2 5.2 and older 6.0
|
|
||||||
+ * 10 13.2 7.2 and older 8.0
|
|
||||||
+ */
|
|
||||||
+#define MACHINE_VER_BASELINE_PVE_MAJOR 2
|
|
||||||
+#define MACHINE_VER_BASELINE_PVE_MINOR 4
|
|
||||||
+#define MACHINE_VER_DELETION_MAJOR (QEMU_VERSION_MAJOR - 6)
|
|
||||||
+#define MACHINE_VER_DELETION_MINOR QEMU_VERSION_MINOR
|
|
||||||
+
|
|
||||||
+/*
|
|
||||||
+ * Proxmox VE needs to support the baseline throughout a major PVE release. So
|
|
||||||
+ * a QEMU release where the baseline is already deleted cannot be used.
|
|
||||||
+ * Removal policy after 6 years takes effect with QEMU 10.1.
|
|
||||||
*/
|
|
||||||
-#define MACHINE_VER_DELETION_MAJOR 6
|
|
||||||
-#define MACHINE_VER_DEPRECATION_MAJOR 3
|
|
||||||
+#if ((QEMU_VERSION_MAJOR > 10) || ((QEMU_VERSION_MAJOR == 10) && (QEMU_VERSION_MINOR >= 1)))
|
|
||||||
+#if ((MACHINE_VER_BASELINE_PVE_MAJOR < MACHINE_VER_DELETION_MAJOR) || \
|
|
||||||
+ ((MACHINE_VER_BASELINE_PVE_MAJOR == MACHINE_VER_DELETION_MAJOR) && \
|
|
||||||
+ (MACHINE_VER_BASELINE_PVE_MINOR < MACHINE_VER_DELETION_MINOR)))
|
|
||||||
+#error "Baseline machine version needed by Proxmox VE not supported anymore by this QEMU release"
|
|
||||||
+#endif
|
|
||||||
+#endif
|
|
||||||
|
|
||||||
/*
|
|
||||||
* Expands to a static string containing a deprecation
|
|
||||||
* message for a versioned machine type
|
|
||||||
*/
|
|
||||||
#define MACHINE_VER_DEPRECATION_MSG \
|
|
||||||
- "machines more than " stringify(MACHINE_VER_DEPRECATION_MAJOR) \
|
|
||||||
- " years old are subject to deletion after " \
|
|
||||||
- stringify(MACHINE_VER_DELETION_MAJOR) " years"
|
|
||||||
-
|
|
||||||
-#define _MACHINE_VER_IS_EXPIRED_IMPL(cutoff, major, minor) \
|
|
||||||
- (((QEMU_VERSION_MAJOR - major) > cutoff) || \
|
|
||||||
- (((QEMU_VERSION_MAJOR - major) == cutoff) && \
|
|
||||||
- (QEMU_VERSION_MINOR - minor) >= 0))
|
|
||||||
-
|
|
||||||
-#define _MACHINE_VER_IS_EXPIRED2(cutoff, major, minor) \
|
|
||||||
- _MACHINE_VER_IS_EXPIRED_IMPL(cutoff, major, minor)
|
|
||||||
-#define _MACHINE_VER_IS_EXPIRED3(cutoff, major, minor, micro) \
|
|
||||||
- _MACHINE_VER_IS_EXPIRED_IMPL(cutoff, major, minor)
|
|
||||||
-#define _MACHINE_VER_IS_EXPIRED4(cutoff, major, minor, _unused, tag) \
|
|
||||||
- _MACHINE_VER_IS_EXPIRED_IMPL(cutoff, major, minor)
|
|
||||||
-#define _MACHINE_VER_IS_EXPIRED5(cutoff, major, minor, micro, _unused, tag) \
|
|
||||||
- _MACHINE_VER_IS_EXPIRED_IMPL(cutoff, major, minor)
|
|
||||||
-
|
|
||||||
-#define _MACHINE_IS_EXPIRED(cutoff, ...) \
|
|
||||||
+ "old machine version is subject to deletion during current major Proxmox VE release"
|
|
||||||
+
|
|
||||||
+#define _MACHINE_VER_IS_EXPIRED_IMPL(baseline_major, baseline_minor, major, minor) \
|
|
||||||
+ ((major < baseline_major) || \
|
|
||||||
+ ((major == baseline_major) && \
|
|
||||||
+ (minor < baseline_minor)))
|
|
||||||
+
|
|
||||||
+#define _MACHINE_VER_IS_EXPIRED2(baseline_major, baseline_minor, major, minor) \
|
|
||||||
+ _MACHINE_VER_IS_EXPIRED_IMPL(baseline_major, baseline_minor, major, minor)
|
|
||||||
+#define _MACHINE_VER_IS_EXPIRED3(baseline_major, baseline_minor, major, minor, micro) \
|
|
||||||
+ _MACHINE_VER_IS_EXPIRED_IMPL(baseline_major, baseline_minor, major, minor)
|
|
||||||
+#define _MACHINE_VER_IS_EXPIRED4(baseline_major, baseline_minor, major, minor, _unused, tag) \
|
|
||||||
+ _MACHINE_VER_IS_EXPIRED_IMPL(baseline_major, baseline_minor, major, minor)
|
|
||||||
+#define _MACHINE_VER_IS_EXPIRED5(baseline_major, baseline_minor, major, minor, micro, _unused, tag) \
|
|
||||||
+ _MACHINE_VER_IS_EXPIRED_IMPL(baseline_major, baseline_minor, major, minor)
|
|
||||||
+
|
|
||||||
+#define _MACHINE_IS_EXPIRED(baseline_major, baseline_minor, ...) \
|
|
||||||
_MACHINE_VER_PICK(__VA_ARGS__, \
|
|
||||||
_MACHINE_VER_IS_EXPIRED5, \
|
|
||||||
_MACHINE_VER_IS_EXPIRED4, \
|
|
||||||
_MACHINE_VER_IS_EXPIRED3, \
|
|
||||||
- _MACHINE_VER_IS_EXPIRED2) (cutoff, __VA_ARGS__)
|
|
||||||
+ _MACHINE_VER_IS_EXPIRED2) (baseline_major, baseline_minor, __VA_ARGS__)
|
|
||||||
|
|
||||||
/*
|
|
||||||
* Evaluates true when a machine type with (major, minor)
|
|
||||||
@@ -675,7 +699,7 @@ struct MachineState {
|
|
||||||
* lifecycle rules
|
|
||||||
*/
|
|
||||||
#define MACHINE_VER_IS_DEPRECATED(...) \
|
|
||||||
- _MACHINE_IS_EXPIRED(MACHINE_VER_DEPRECATION_MAJOR, __VA_ARGS__)
|
|
||||||
+ _MACHINE_IS_EXPIRED(MACHINE_VER_BASELINE_PVE_MAJOR, MACHINE_VER_BASELINE_PVE_MINOR, __VA_ARGS__)
|
|
||||||
|
|
||||||
/*
|
|
||||||
* Evaluates true when a machine type with (major, minor)
|
|
||||||
@@ -684,7 +708,7 @@ struct MachineState {
|
|
||||||
* lifecycle rules
|
|
||||||
*/
|
|
||||||
#define MACHINE_VER_SHOULD_DELETE(...) \
|
|
||||||
- _MACHINE_IS_EXPIRED(MACHINE_VER_DELETION_MAJOR, __VA_ARGS__)
|
|
||||||
+ _MACHINE_IS_EXPIRED(MACHINE_VER_DELETION_MAJOR, MACHINE_VER_DELETION_MINOR, __VA_ARGS__)
|
|
||||||
|
|
||||||
/*
|
|
||||||
* Sets the deprecation reason for a versioned machine based
|
|
@@ -1,50 +0,0 @@
|
|||||||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
Date: Wed, 19 Mar 2025 17:31:05 +0100
|
|
||||||
Subject: [PATCH] Revert "hpet: avoid timer storms on periodic timers"
|
|
||||||
|
|
||||||
This reverts commit 7c912ffb59e8137091894d767433e65c3df8b0bf.
|
|
||||||
|
|
||||||
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|
||||||
---
|
|
||||||
hw/timer/hpet.c | 13 ++-----------
|
|
||||||
1 file changed, 2 insertions(+), 11 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
|
|
||||||
index 5399f1b2a3..8ccc421cbb 100644
|
|
||||||
--- a/hw/timer/hpet.c
|
|
||||||
+++ b/hw/timer/hpet.c
|
|
||||||
@@ -59,7 +59,6 @@ typedef struct HPETTimer { /* timers */
|
|
||||||
uint8_t wrap_flag; /* timer pop will indicate wrap for one-shot 32-bit
|
|
||||||
* mode. Next pop will be actual timer expiration.
|
|
||||||
*/
|
|
||||||
- uint64_t last; /* last value armed, to avoid timer storms */
|
|
||||||
} HPETTimer;
|
|
||||||
|
|
||||||
struct HPETState {
|
|
||||||
@@ -267,7 +266,6 @@ static int hpet_post_load(void *opaque, int version_id)
|
|
||||||
for (i = 0; i < s->num_timers; i++) {
|
|
||||||
HPETTimer *t = &s->timer[i];
|
|
||||||
t->cmp64 = hpet_calculate_cmp64(t, s->hpet_counter, t->cmp);
|
|
||||||
- t->last = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) - NANOSECONDS_PER_SECOND;
|
|
||||||
}
|
|
||||||
/* Recalculate the offset between the main counter and guest time */
|
|
||||||
if (!s->hpet_offset_saved) {
|
|
||||||
@@ -366,15 +364,8 @@ static const VMStateDescription vmstate_hpet = {
|
|
||||||
|
|
||||||
static void hpet_arm(HPETTimer *t, uint64_t tick)
|
|
||||||
{
|
|
||||||
- uint64_t ns = hpet_get_ns(t->state, tick);
|
|
||||||
-
|
|
||||||
- /* Clamp period to reasonable min value (1 us) */
|
|
||||||
- if (timer_is_periodic(t) && ns - t->last < 1000) {
|
|
||||||
- ns = t->last + 1000;
|
|
||||||
- }
|
|
||||||
-
|
|
||||||
- t->last = ns;
|
|
||||||
- timer_mod(t->qemu_timer, ns);
|
|
||||||
+ /* FIXME: Clamp period to reasonable min value? */
|
|
||||||
+ timer_mod(t->qemu_timer, hpet_get_ns(t->state, tick));
|
|
||||||
}
|
|
||||||
|
|
||||||
/*
|
|
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user