vitalif-js
/
ajv
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

docs: pull request template

master
Evgeny Poberezkin 2016-08-11 00:59:09 +01:00
parent 368606627e
commit dcdeefcaf9
3 changed files with 26 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.github/ISSUE_TEMPLATE.md vendored
View File

@ -62,3 +62,6 @@ It would help if you post a working code sample in Tonic notebook and include th
```
**What results did you expect?**
**Do you intend to resolve the issue?**

20
.github/PULL_REQUEST_TEMPLATE.md vendored Normal file
View File

@ -0,0 +1,20 @@
<!--
Thank you for submitting a pull request to Ajv.
Before continuing, please read the guidelines:
https://github.com/epoberezkin/ajv/blob/master/CONTRIBUTING.md#pull-requests
If the pull request contains code please make sure there is an issue that we agreed to resolve (if it is a documentation improvement there is no need for an issue).
If this pull request contains code and there isn't yet an agreed issue, please open a new issue first.
Please answer the questions below.
-->
**What issue does this pull request resolve?**
**What changes did you make?**
**Is there anything that requires more attention while reviewing?**

6
CONTRIBUTING.md
View File

@ -103,11 +103,11 @@ All validation functions are generated using doT templates in [dot](https://gith
To make accepting your changes faster please follow these steps:
1. Submit an [issue with the bug](https://github.com/epoberezkin/ajv/issues/new) or with the proposed change (unless the contribution is to fix the documentation typos and mistakes).
2. Please confirm with me the proposed api and implementation plan (unless the issue is a relative simple bug and fixing it doesn't change any api).
3. Write as little code as possible to achieve the desired result.
2. Please describe the proposed api and implementation plan (unless the issue is a relatively simple bug and fixing it doesn't change any api).
3. Once agreed, please write as little code as possible to achieve the desired result.
4. Please avoid unnecessary changes, refactoring or changing coding styles as part of your change (unless the change was proposed as refactoring).
5. Please follow the coding conventions even if they are not validated (and/or you use different conventions in your code).
6. Please run tests before committing your code.
6. Please run the tests before committing your code.
7. If tests fail in Travis after you make a PR please investigate and fix the issue.