vitalif-js
/
dynamic-virtual-scroll
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix "infinite update loop" when item count changes off-screen

master v1.0.13
Vitaliy Filippov 2019-10-10 16:56:10 +03:00
parent 43f9864c13
commit ba46a65559
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
VirtualScrollList.js
View File

@ -63,9 +63,10 @@ export class VirtualScrollList extends React.Component
render()
{
if (this.state.totalItems && this.props.totalItems != this.state.totalItems &&
this.state.scrollTimes <= 0)
this.state.scrollTimes <= 0 && this.viewport && this.viewport.offsetParent)
{
// Automatically preserve scroll position when item count changes
// Automatically preserve scroll position when item count changes...
// But only when the list is on-screen! We'll end up with an infinite update loop if it's off-screen.
this.state.scrollTo = this.getItemScrollPos();
this.state.scrollTimes = 2;
}
@ -132,7 +133,8 @@ export class VirtualScrollList extends React.Component
componentDidUpdate = () =>
{
let changed = this.driver();
if (!changed && this.state.scrollTimes > 0 && this.props.totalItems > 0)
if (!changed && this.state.scrollTimes > 0 && this.props.totalItems > 0 &&
this.viewport && this.viewport.offsetParent)
{
// FIXME: It would be better to find a way to put this logic back into virtual-scroll-driver
let pos = this.state.scrollTo;

2
package.json
View File

@ -1,6 +1,6 @@
{
"name": "dynamic-virtual-scroll",
"version": "1.0.12",
"version": "1.0.13",
"author": {
"name": "Vitaliy Filippov",
"email": "vitalif@yourcmc.ru",