Plugins can have falsy default options (#6348)

src/main/options.js

@@ -71,7 +71,8 @@ function normalize(options, opts) {
   const pluginDefaults = supportOptions
     .filter(
       optionInfo =>
-        optionInfo.pluginDefaults && optionInfo.pluginDefaults[plugin.name]
+        optionInfo.pluginDefaults &&
+        optionInfo.pluginDefaults[plugin.name] !== undefined
     )
     .reduce(
       (reduced, optionInfo) =>

src/main/support.js

@@ -65,7 +65,9 @@ function getSupportInfo(version, opts) {
     })
     .map(option => {
       const filteredPlugins = plugins.filter(
-        plugin => plugin.defaultOptions && plugin.defaultOptions[option.name]
+        plugin =>
+          plugin.defaultOptions &&
+          plugin.defaultOptions[option.name] !== undefined
       );
       const pluginDefaults = filteredPlugins.reduce((reduced, plugin) => {
         reduced[plugin.name] = plugin.defaultOptions[option.name];

tests_integration/__tests__/format.js

@@ -49,5 +49,7 @@ test("should work with foo plugin instance", () => {
     JSON.stringify(
       prettier.format(input, { parser: "foo-parser", plugins: [fooPlugin] })
     )
-  ).toMatchInlineSnapshot(`"\\"tabWidth:8\\""`);
+  ).toMatchInlineSnapshot(
+    `"\\"{\\\\\\"tabWidth\\\\\\":8,\\\\\\"bracketSpacing\\\\\\":false}\\""`
+  );
 });

tests_integration/__tests__/plugin-default-options.js

@@ -8,7 +8,10 @@ describe("plugin default options should work", () => {
     ["--stdin-filepath", "example.foo", "--plugin=./plugin"],
     { input: "hello-world" }
   ).test({
-    stdout: "tabWidth:8",
+    stdout: JSON.stringify({
+      tabWidth: 8,
+      bracketSpacing: false
+    }),
     stderr: "",
     status: 0,
     write: []
@@ -21,7 +24,10 @@ describe("overriding plugin default options should work", () => {
     ["--stdin-filepath", "example.foo", "--plugin=./plugin", "--tab-width=4"],
     { input: "hello-world" }
   ).test({
-    stdout: "tabWidth:4",
+    stdout: JSON.stringify({
+      tabWidth: 4,
+      bracketSpacing: false
+    }),
     stderr: "",
     status: 0,
     write: []

tests_integration/plugins/defaultOptions/plugin.js

@@ -9,7 +9,8 @@ module.exports = {
     }
   ],
   defaultOptions: {
-    tabWidth: 8
+    tabWidth: 8,
+    bracketSpacing: false
   },
   parsers: {
     "foo-parser": {
@@ -20,7 +21,10 @@ module.exports = {
   printers: {
     "foo-ast": {
       print: (path, options) =>
-        options.tabWidth ? `tabWidth:${options.tabWidth}` : path.getValue().text
+        JSON.stringify({
+          tabWidth: options.tabWidth,
+          bracketSpacing: options.bracketSpacing
+        })
     }
   }
 };