From c5bfdae5d807d40487c07a2c7974ad711dcd49a5 Mon Sep 17 00:00:00 2001 From: Christopher Chedeau Date: Sun, 12 Feb 2017 20:09:39 -0800 Subject: [PATCH] Fix dangling comments for arrays (#665) It was missing a softline. I copy and pasted the dangling handling for objects. Fixes #624 --- src/printer.js | 9 ++++++- .../comments/__snapshots__/jsfmt.spec.js.snap | 26 +++++++++++++++++++ tests/comments/dangling_array.js | 3 +++ 3 files changed, 37 insertions(+), 1 deletion(-) create mode 100644 tests/comments/dangling_array.js diff --git a/src/printer.js b/src/printer.js index e78ec971..9a46ef7e 100644 --- a/src/printer.js +++ b/src/printer.js @@ -712,7 +712,14 @@ function genericPrintNoParens(path, options, print) { case "ArrayPattern": if (n.elements.length === 0) { parts.push( - concat(["[", comments.printDanglingComments(path, options), "]"]) + group( + concat([ + "[", + comments.printDanglingComments(path, options), + softline, + "]" + ]) + ) ); } else { const lastElem = util.getLast(n.elements); diff --git a/tests/comments/__snapshots__/jsfmt.spec.js.snap b/tests/comments/__snapshots__/jsfmt.spec.js.snap index 063b75f2..b6c03623 100644 --- a/tests/comments/__snapshots__/jsfmt.spec.js.snap +++ b/tests/comments/__snapshots__/jsfmt.spec.js.snap @@ -74,6 +74,32 @@ declare class Foo extends Qux {/* dangling */} " `; +exports[`test dangling_array.js 1`] = ` +"expect(() => {}).toTriggerReadyStateChanges([ + // Nothing. +]); +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +expect(() => {}).toTriggerReadyStateChanges( + [ + // Nothing. + ] +); +" +`; + +exports[`test dangling_array.js 2`] = ` +"expect(() => {}).toTriggerReadyStateChanges([ + // Nothing. +]); +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +expect(() => {}).toTriggerReadyStateChanges( + [ + // Nothing. + ] +); +" +`; + exports[`test first-line.js 1`] = ` "a // comment b diff --git a/tests/comments/dangling_array.js b/tests/comments/dangling_array.js new file mode 100644 index 00000000..599897d5 --- /dev/null +++ b/tests/comments/dangling_array.js @@ -0,0 +1,3 @@ +expect(() => {}).toTriggerReadyStateChanges([ + // Nothing. +]);