prettier

Commit Graph

Author	SHA1	Message	Date
Christopher Chedeau	f68531a45d	Fix overflow for last argument expansion (#1224 ) In #847, I used a heuristic to find if the element was going to be expanded. But, it wasn't 100% accurate because we couldn't know in which conditionalGroup we would land. We added a way for the parent to tell that function if we should be in `expandLastArg`. By replacing the condition by this variable, it now fixes the issues! This is so good that adding the right abstraction fixes problems across the board :) Fixes #997	2017-04-12 20:24:50 -07:00
Royce Townsend	9eb389b9f4	Group first arg for inline functions (#947 ) * Group first arg for inline functions * Group first arg. Unless there are comments. * Group first arg. Allow second arg to be empty object/array. This implementation has a side effect of disallowing empty objects/arrays in the should group last arg heuristic.	2017-03-18 11:20:07 -07:00
Christopher Chedeau	211e18bed2	Inline last arg function arguments (#847 ) ```js SuperSuperSuperSuperSuperSuperSuperSuperSuperSuperSuperSuperLongCall((err, result) => { // comment }); ``` currently breaks into ```js SuperSuperSuperSuperSuperSuperSuperSuperSuperSuperSuperSuperLongCall(( err, result, ) => { // comment }); ``` which looks bad, instead this PR makes it break ```js SuperSuperSuperSuperSuperSuperSuperSuperSuperSuperSuperSuperLongCall( (err, result) => { // comment } ); ``` which look better	2017-03-02 22:29:53 -05:00

Author

SHA1

Message

Date

Christopher Chedeau

f68531a45d

Fix overflow for last argument expansion (#1224 )

In #847, I used a heuristic to find if the element was going to be expanded. But, it wasn't 100% accurate because we couldn't know in which conditionalGroup we would land. We added a way for the parent to tell that function if we should be in `expandLastArg`. By replacing the condition by this variable, it now fixes the issues!

This is so good that adding the right abstraction fixes problems across the board :)

Fixes #997

2017-04-12 20:24:50 -07:00

Royce Townsend

9eb389b9f4

Group first arg for inline functions (#947 )

* Group first arg for inline functions

* Group first arg. Unless there are comments.

* Group first arg. Allow second arg to be empty object/array.

This implementation has a side effect of disallowing empty objects/arrays in the should group last arg heuristic.

2017-03-18 11:20:07 -07:00

Christopher Chedeau

211e18bed2

Inline last arg function arguments (#847 )

```js
SuperSuperSuperSuperSuperSuperSuperSuperSuperSuperSuperSuperLongCall((err, result) => {
  // comment
});
```

currently breaks into

```js
SuperSuperSuperSuperSuperSuperSuperSuperSuperSuperSuperSuperLongCall((
  err,
  result,
) => {
  // comment
});
```

which looks bad, instead this PR makes it break

```js
SuperSuperSuperSuperSuperSuperSuperSuperSuperSuperSuperSuperLongCall(
  (err, result) => {
    // comment
  }
);
```

which look better

2017-03-02 22:29:53 -05:00

3 Commits (a398ec31b893afd3c1261e70c72f6590cd03f938)