diff --git a/favicon.php b/favicon.php index 75889ad..e939508 100644 --- a/favicon.php +++ b/favicon.php @@ -12,7 +12,7 @@ */ require_once('simplepie/simplepie.php'); -if(file_exists("./cache/" . $_GET[i] . ".spi")) +if(file_exists("./cache/" . $_GET['i'] . ".spi")) { SimplePie_Misc::display_cached_file($_GET['i'], './cache', 'spi'); } diff --git a/fof-db.php b/fof-db.php index 78eab00..d0887fe 100644 --- a/fof-db.php +++ b/fof-db.php @@ -41,7 +41,7 @@ function fof_safe_query(/* $query, [$args...]*/) { $args = func_get_args(); $query = array_shift($args); - if(is_array($args[0])) $args = $args[0]; + if(isset($args[0]) && is_array($args[0])) $args = $args[0]; $args = array_map('mysql_real_escape_string', $args); $query = vsprintf($query, $args); @@ -57,6 +57,7 @@ function fof_db_query($sql, $live=0) $result = mysql_query($sql, $fof_connection); + $num = 0; if(is_resource($result)) $num = mysql_num_rows($result); if($result) $affected = mysql_affected_rows($fof_connection); @@ -150,8 +151,11 @@ function fof_db_feed_update_metadata($feed_id, $url, $title, $link, $description function fof_db_get_latest_item_age($user_id) { global $FOF_SUBSCRIPTION_TABLE, $FOF_ITEM_TABLE; - - $result = fof_db_query("SELECT max( item_cached ) AS \"max_date\", $FOF_ITEM_TABLE.feed_id as \"id\" FROM $FOF_ITEM_TABLE GROUP BY $FOF_ITEM_TABLE.feed_id"); + $result = fof_safe_query( + "select max(i.item_cached) max_date, i.feed_id id". + " from $FOF_ITEM_TABLE i, $FOF_SUBSCRIPTION_TABLE s". + " where s.user_id=%d and s.feed_id=i.feed_id group by i.feed_id", $user_id + ); return $result; } @@ -324,7 +328,7 @@ function fof_db_get_items($user_id = 1, $feed = NULL, $what = "unread", $user_id = intval($user_id); $prefs = fof_prefs(); $offset = $prefs['tzoffset']; - if ($prefs['dst']) + if (!empty($prefs['dst'])) $offset += date('I'); if (!is_null($when) && $when != "") @@ -402,7 +406,7 @@ function fof_db_get_items($user_id = 1, $feed = NULL, $what = "unread", $order_by = "order by $pubdate desc $limit_clause "; - $query = "$select FROM $from $where $group $order_by"; + $query = "$select FROM $from $where $order_by"; $result = fof_safe_query($query, $args); if (mysql_num_rows($result) == 0) return array(); diff --git a/fof-main.php b/fof-main.php index bc8ff50..81401fe 100644 --- a/fof-main.php +++ b/fof-main.php @@ -31,9 +31,9 @@ $fof_tag_prefilters = array(); fof_db_connect(); -if(!$fof_installer) +if (empty($fof_installer)) { - if(!$fof_no_login) + if (empty($fof_no_login)) { require_user(); $fof_prefs_obj = FoF_Prefs::instance(); @@ -301,100 +301,76 @@ function fof_get_feeds($user_id, $order = 'feed_title', $direction = 'asc') $result = fof_db_get_subscriptions($user_id); - $i = 0; - - while($row = fof_db_get_row($result)) + while ($row = fof_db_get_row($result)) { - $id = $row['feed_id']; $age = $row['feed_cache_date']; - - $feeds[$i]['prefs'] = unserialize($row['subscription_prefs']); - $feeds[$i]['feed_id'] = $id; - $feeds[$i]['feed_url'] = $row['feed_url']; - $feeds[$i]['feed_title'] = $row['feed_title']; - $feeds[$i]['feed_link'] = $row['feed_link']; - $feeds[$i]['feed_description'] = $row['feed_description']; - $feeds[$i]['feed_image'] = $row['feed_image']; - $feeds[$i]['feed_age'] = $age; - list($agestr, $agestrabbr) = fof_nice_time_stamp($age); - - $feeds[$i]['agestr'] = $agestr; - $feeds[$i]['agestrabbr'] = $agestrabbr; - - $i++; + $feeds[$row['feed_id']] = array( + 'prefs' => unserialize($row['subscription_prefs']), + 'feed_id' => $row['feed_id'], + 'feed_url' => $row['feed_url'], + 'feed_title' => $row['feed_title'], + 'feed_link' => $row['feed_link'], + 'feed_description' => $row['feed_description'], + 'feed_image' => $row['feed_image'], + 'feed_age' => $age, + 'agestr' => $agestr, + 'agestrabbr' => $agestrabbr, + 'feed_items' => 0, + 'feed_read' => 0, + 'feed_unread' => 0, + 'feed_starred' => 0, + 'max_date' => NULL, + 'lateststr' => '', + 'lateststrabbr' => '', + ); } $tags = fof_db_get_tag_id_map(); - for($i=0; $i$item_content", $_GET['search'], "highlight"); $item_title = do_highlight("$item_title", $_GET['search'], "highlight"); diff --git a/items.php b/items.php index 366ab71..a13b650 100644 --- a/items.php +++ b/items.php @@ -15,42 +15,31 @@ include_once("fof-main.php"); include_once("fof-render.php"); -if (!isset($_GET['which'])) - $which = 0; -else - $which = $_GET['which']; +$which = !empty($_GET['which']) ? $_GET['which'] : 0; +$order = !empty($_GET['order']) ? $_GET['order'] : $fof_prefs_obj->get('order'); +$what = !empty($_GET['what']) ? $_GET['what'] : 'unread'; -$order = $_GET['order']; +$how = !empty($_GET['how']) ? $_GET['how'] : NULL; +$feed = !empty($_GET['feed']) ? $_GET['feed'] : NULL; +$when = !empty($_GET['when']) ? $_GET['when'] : NULL; +$howmany = !empty($_GET['howmany']) ? $_GET['howmany'] : $fof_prefs_obj->get('howmany'); +$search = !empty($_GET['search']) ? $_GET['search'] : NULL; -if(!isset($_GET['what'])) - $what = "unread"; -else - $what = $_GET['what']; - -if(!isset($_GET['order'])) - $order = $fof_prefs_obj->get("order"); - -$how = $_GET['how']; -$feed = $_GET['feed']; -$when = $_GET['when']; -$howmany = $_GET['howmany']; - -$title = fof_view_title($_GET['feed'], $what, $_GET['when'], $which, $_GET['howmany'], $_GET['search']); -$noedit = $_GET['noedit']; +$title = fof_view_title($feed, $what, $when, $which, $howmany, $search); ?> -

+