Assume bridge angle is stored in radians in infill generation. #1917

visilibity
Alessandro Ranellucci 2014-04-21 23:21:15 +02:00
parent f7e8a99078
commit bc101bd93e
3 changed files with 26 additions and 22 deletions

View File

@ -13,7 +13,7 @@ use Slic3r::Fill::OctagramSpiral;
use Slic3r::Fill::PlanePath; use Slic3r::Fill::PlanePath;
use Slic3r::Fill::Rectilinear; use Slic3r::Fill::Rectilinear;
use Slic3r::Flow ':roles'; use Slic3r::Flow ':roles';
use Slic3r::Geometry qw(X Y PI scale chained_path); use Slic3r::Geometry qw(X Y PI scale chained_path deg2rad);
use Slic3r::Geometry::Clipper qw(union union_ex diff diff_ex intersection_ex offset offset2); use Slic3r::Geometry::Clipper qw(union union_ex diff diff_ex intersection_ex offset offset2);
use Slic3r::Surface ':types'; use Slic3r::Surface ':types';
@ -62,7 +62,7 @@ sub make_fill {
# in case of bridge surfaces, the ones with defined angle will be attached to the ones # in case of bridge surfaces, the ones with defined angle will be attached to the ones
# without any angle (shouldn't this logic be moved to process_external_surfaces()?) # without any angle (shouldn't this logic be moved to process_external_surfaces()?)
{ {
my @surfaces_with_bridge_angle = grep defined $_->bridge_angle, @{$layerm->fill_surfaces}; my @surfaces_with_bridge_angle = grep { $_->bridge_angle >= 0 } @{$layerm->fill_surfaces};
# group surfaces by distinct properties # group surfaces by distinct properties
my @groups = @{$layerm->fill_surfaces->group}; my @groups = @{$layerm->fill_surfaces->group};
@ -111,13 +111,13 @@ sub make_fill {
} }
# give priority to bridges # give priority to bridges
@groups = sort { defined $a->[0]->bridge_angle ? -1 : 0 } @groups; @groups = sort { ($a->[0]->bridge_angle >= 0) ? -1 : 0 } @groups;
foreach my $group (@groups) { foreach my $group (@groups) {
my $union_p = union([ map $_->p, @$group ], 1); my $union_p = union([ map $_->p, @$group ], 1);
# subtract surfaces having a defined bridge_angle from any other # subtract surfaces having a defined bridge_angle from any other
if (@surfaces_with_bridge_angle && !defined $group->[0]->bridge_angle) { if (@surfaces_with_bridge_angle && $group->[0]->bridge_angle < 0) {
$union_p = diff( $union_p = diff(
$union_p, $union_p,
[ map $_->p, @surfaces_with_bridge_angle ], [ map $_->p, @surfaces_with_bridge_angle ],
@ -211,7 +211,7 @@ sub make_fill {
my $f = $self->filler($filler); my $f = $self->filler($filler);
$f->layer_id($layerm->id); $f->layer_id($layerm->id);
$f->angle($layerm->config->fill_angle); $f->angle(deg2rad($layerm->config->fill_angle));
my ($params, @polylines) = $f->fill_surface( my ($params, @polylines) = $f->fill_surface(
$surface, $surface,
density => $density/100, density => $density/100,

View File

@ -1,10 +1,10 @@
package Slic3r::Fill::Base; package Slic3r::Fill::Base;
use Moo; use Moo;
use Slic3r::Geometry qw(PI); use Slic3r::Geometry qw(PI rad2deg);
has 'layer_id' => (is => 'rw'); has 'layer_id' => (is => 'rw');
has 'angle' => (is => 'rw'); has 'angle' => (is => 'rw'); # in radians, ccw, 0 = East
has 'bounding_box' => (is => 'ro', required => 0); # Slic3r::Geometry::BoundingBox object has 'bounding_box' => (is => 'ro', required => 0); # Slic3r::Geometry::BoundingBox object
sub angles () { [0, PI/2] } sub angles () { [0, PI/2] }
@ -19,28 +19,29 @@ sub infill_direction {
} }
# set infill angle # set infill angle
my (@rotate, @shift); my (@rotate);
$rotate[0] = Slic3r::Geometry::deg2rad($self->angle); $rotate[0] = $self->angle;
$rotate[1] = $self->bounding_box $rotate[1] = $self->bounding_box
? $self->bounding_box->center ? $self->bounding_box->center
: $surface->expolygon->bounding_box->center; : $surface->expolygon->bounding_box->center;
@shift = @{$rotate[1]}; my $shift = $rotate[1]->clone;
if (defined $self->layer_id) { if (defined $self->layer_id) {
# alternate fill direction # alternate fill direction
my $layer_num = $self->layer_id / $surface->thickness_layers; my $layer_num = $self->layer_id / $surface->thickness_layers;
my $angle = $self->angles->[$layer_num % @{$self->angles}]; my $angle = $self->angles->[$layer_num % @{$self->angles}];
$rotate[0] = Slic3r::Geometry::deg2rad($self->angle) + $angle if $angle; $rotate[0] = $self->angle + $angle if $angle;
} }
# use bridge angle # use bridge angle
if ($surface->bridge_angle != -1) { if ($surface->bridge_angle >= 0) {
Slic3r::debugf "Filling bridge with angle %d\n", $surface->bridge_angle; Slic3r::debugf "Filling bridge with angle %d\n", rad2deg($surface->bridge_angle);
$rotate[0] = Slic3r::Geometry::deg2rad($surface->bridge_angle); $rotate[0] = $surface->bridge_angle;
} }
@shift = @{ +(Slic3r::Geometry::rotate_points(@rotate, \@shift))[0] }; $rotate[0] += PI/2;
return [\@rotate, \@shift]; $shift->rotate(@rotate);
return [\@rotate, $shift];
} }
# this method accepts any object that implements rotate() and translate() # this method accepts any object that implements rotate() and translate()
@ -49,18 +50,21 @@ sub rotate_points {
my ($expolygon, $rotate_vector) = @_; my ($expolygon, $rotate_vector) = @_;
# rotate points # rotate points
$expolygon->rotate(@{$rotate_vector->[0]}); my ($rotate, $shift) = @$rotate_vector;
$expolygon->translate(@{$rotate_vector->[1]}); $rotate = [ -$rotate->[0], $rotate->[1] ];
$expolygon->rotate(@$rotate);
$expolygon->translate(@$shift);
} }
sub rotate_points_back { sub rotate_points_back {
my $self = shift; my $self = shift;
my ($paths, $rotate_vector) = @_; my ($paths, $rotate_vector) = @_;
my @rotate = (-$rotate_vector->[0][0], $rotate_vector->[0][1]);
my $shift = [ map -$_, @{$rotate_vector->[1]} ]; my ($rotate, $shift) = @$rotate_vector;
$shift = [ map -$_, @$shift ];
$_->translate(@$shift) for @$paths; $_->translate(@$shift) for @$paths;
$_->rotate(@rotate) for @$paths; $_->rotate(@$rotate) for @$paths;
} }
sub adjust_solid_spacing { sub adjust_solid_spacing {

View File

@ -14,7 +14,7 @@ class Surface
SurfaceType surface_type; SurfaceType surface_type;
double thickness; // in mm double thickness; // in mm
unsigned short thickness_layers; // in layers unsigned short thickness_layers; // in layers
double bridge_angle; double bridge_angle; // in radians, ccw, 0 = East, only 0+ (negative means undefined)
unsigned short extra_perimeters; unsigned short extra_perimeters;
double area() const; double area() const;
bool is_solid() const; bool is_solid() const;