Delete attach_data.thedata field

Bugzilla/Field.pm

@@ -206,7 +206,6 @@ use constant DEFAULT_FIELDS => (map { my $i = 0; $_ = { (map { (DEFAULT_FIELD_CO
     [ 'work_time',             'Hours Worked',          0, 0, 0 ],
     [ 'percentage_complete',   'Percentage Complete',   0, 0, 0 ],
     [ 'content',               'Content',               0, 0, 0 ],
-    [ 'attach_data.thedata',   'Attachment data',       0, 0, 0 ],
     [ 'owner_idle_time', 'Time Since Assignee Touched', 0, 0, 0 ],
     [ 'see_also',              'See Also',              0, 1, 0, FIELD_TYPE_BUG_URLS ],
 ));
@@ -1189,6 +1188,7 @@ sub populate_field_definitions
     $dbh->do("DELETE FROM fielddefs WHERE name='requesters.login_name'");
     # This field was never tracked in bugs_activity, so it's safe to delete.
     $dbh->do("DELETE FROM fielddefs WHERE name='attachments.thedata'");
+    $dbh->do("DELETE FROM fielddefs WHERE name='attach_data.thedata'");
 
     # MODIFY old field definitions
 

Bugzilla/Language/en.pm

@@ -140,7 +140,6 @@ $Bugzilla::messages->{en} = {
         longdesc                  => 'Comment',
         commenter                 => 'Commenter',
         'longdescs.isprivate'     => 'Comment is private',
-        'attach_data.thedata'     => 'Attachment data',
         'attachments.description' => 'Attachment description',
         'attachments.filename'    => 'Attachment filename',
         'attachments.mimetype'    => 'Attachment mime type',
@@ -156,7 +155,6 @@ $Bugzilla::messages->{en} = {
         other_longdesc                  => 'Comment $1',
         other_commenter                 => 'Comment $1 author',
         'other_longdescs.isprivate'     => 'Comment $1 is private',
-        'other_attach_data.thedata'     => 'Attachment $1 data',
         'other_attachments.description' => 'Attachment $1 description',
         'other_attachments.filename'    => 'Attachment $1 filename',
         'other_attachments.mimetype'    => 'Attachment $1 mime type',

Bugzilla/Search/Quicksearch.pm

@@ -69,8 +69,6 @@ use constant MAPPINGS => {
     "attachment"     => "attachments.description",
     "attachmentdesc" => "attachments.description",
     "attachdesc"     => "attachments.description",
-    "attachmentdata" => "attach_data.thedata",
-    "attachdata"     => "attach_data.thedata",
     "attachmentmimetype" => "attachments.mimetype",
     "attachmimetype" => "attachments.mimetype"
 };

contrib/cmdline/query.conf

@@ -43,7 +43,6 @@ bug_file_loc            substring       "u","url"
 status_whiteboard       substring       "w","whiteboard"
 keywords                substring       "k","K","keywords"
 attachments.description substring       "attachdesc"
-attach_data.thedata     substring       "attachdata"
 attachments.mimetype    substring       "attachmime"
 dependson               substring       # bug 30823
 blocked                 substring       # bug 30823

qa/t/webservice_bug_fields.t

@@ -10,7 +10,6 @@ my ($xmlrpc, $jsonrpc, $config) = get_rpc_clients();
 use constant INVALID_FIELD_NAME => 'invalid_field';
 use constant INVALID_FIELD_ID => -1;
 use constant GLOBAL_GENERAL_FIELDS => qw(
-    attach_data.thedata
     attachments.description
     attachments.filename
     attachments.isobsolete

template/en/default/pages/quicksearchhack.html.tmpl

@@ -281,13 +281,6 @@
     <i>(&ldquo;attachments.description&rdquo;)</i>
   </td>
 </tr>
-<tr>
-  <td>&nbsp;</td>
-  <td>&nbsp;</td>
-  <td><tt>attachmentdata</tt></td>
-  <td><tt>attachdata</tt></td>
-  <td>Attachment Data <i>(&ldquo;attach_data.thedata&rdquo;)</i></td>
-</tr>
 <tr>
   <td>&nbsp;</td>
   <td>&nbsp;</td>