vitalif
/
bugzilla-4intranet
mirror of https://github.com/vitalif/bugzilla-4intranet
1
0
Fork 0
Code Issues Releases Wiki Activity

Allow object in set_product

beta
Vitaliy Filippov 2018-05-18 16:04:03 +03:00
parent 861ce067d9
commit 3e36282959
1 changed files with 24 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
Bugzilla/Bug.pm
View File

@ -2209,18 +2209,32 @@ sub _set_keywords
sub _set_product
{
my ($self, $name) = @_;
$name = trim($name);
# If we're updating the bug and they haven't changed the product, always allow it.
if ($self->product_obj && $self->product_obj->name eq $name)
my $product;
if (!ref $name)
{
return undef;
$name = trim($name);
# If we're updating the bug and they haven't changed the product, always allow it.
if ($self->product_obj && $self->product_obj->name eq $name)
{
return undef;
}
# Check that the product exists and that the user
# is allowed to enter bugs into this product.
Bugzilla->user->can_enter_product($name, THROW_ERROR);
# can_enter_product already does everything that check_product
# would do for us, so we don't need to use it.
$product = new Bugzilla::Product({ name => $name });
}
else
{
$product = $name;
# If we're updating the bug and they haven't changed the product, always allow it.
if ($self->product_id == $product->id)
{
return undef;
}
Bugzilla->user->can_enter_product($product, THROW_ERROR);
}
# Check that the product exists and that the user
# is allowed to enter bugs into this product.
Bugzilla->user->can_enter_product($name, THROW_ERROR);
# can_enter_product already does everything that check_product
# would do for us, so we don't need to use it.
my $product = new Bugzilla::Product({ name => $name });
if (($self->product_id || 0) != $product->id)
{
$self->{product_id} = $product->id;