From 40dc73f69269c46529db9debdf857747ff02d751 Mon Sep 17 00:00:00 2001 From: Vitaliy Filippov Date: Mon, 7 Dec 2015 12:49:47 +0300 Subject: [PATCH] Fix possible duplicate key error when adding a bookmark to saved searches --- userprefs.cgi | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/userprefs.cgi b/userprefs.cgi index dfa227a50..e6f656057 100755 --- a/userprefs.cgi +++ b/userprefs.cgi @@ -389,11 +389,16 @@ sub DoSavedSearches { trick_taint($name); trick_taint($url); - $dbh->do( - 'INSERT INTO namedqueries (userid, name, query) VALUES (?, ?, ?)', - undef, $user->id, $name, $url - ); - $dbh->commit; + $dbh->bz_start_transaction; + my $search = Bugzilla::Search::Saved->new({ name => $name }); + if (!$search) + { + $dbh->do( + 'INSERT INTO namedqueries (userid, name, query) VALUES (?, ?, ?)', + undef, $user->id, $name, $url + ); + } + $dbh->bz_commit_transaction; } if ($user->queryshare_groups_as_string) {