Bug 141986 - Fix fieldvaluecontrol.cgi crash for unauthorized users

git-svn-id: svn://svn.office.custis.ru/3rdparty/bugzilla.org/trunk@1877 6955db30-a419-402b-8a0d-67ecbb4d7f56

Bugzilla/Field/Choice.pm

@@ -263,7 +263,7 @@ sub get_all
         ->{$f->id};
     my $visible_ids = { map { $_->id => 1 } Bugzilla::Product->get_all };
     my $vis;
-    my $filtered;
+    my $filtered = [];
     for my $value (@$all)
     {
         $vis = !$h->{$value->id} || !%{$h->{$value->id}} ? 1 : 0;

Bugzilla/User.pm

@@ -805,6 +805,10 @@ sub get_selectable_classifications
         # Return classifications with at least one visible product
         # + all empty classifications
         my $products = $self->get_selectable_products;
+        if (!@$products)
+        {
+            return [];
+        }
         my $class_ids = Bugzilla->dbh->selectcol_arrayref(
             "SELECT DISTINCT c.id FROM classifications c".
             " LEFT JOIN products p ON p.classification_id=c.id".