Remove "attachment already obsolete" error, fix longdesclength argument check

Bugzilla/Attachment.pm

@@ -737,11 +737,6 @@ sub validate_obsolete
             ThrowCodeError('mismatched_bug_ids_on_obsolete', $vars);
         }
 
-        if ($attachment->isobsolete)
-        {
-            ThrowCodeError('attachment_already_obsolete', $vars);
-        }
-
         push(@obsolete_attachments, $attachment);
     }
     return @obsolete_attachments;

process_bug.cgi

@@ -221,7 +221,7 @@ if ($ARGS->{delta_ts})
 
         $vars->{title_tag} = "mid_air";
 
-        ThrowCodeError('undefined_field', { field => 'longdesclength' }) if !$ARGS->{longdesclength};
+        ThrowCodeError('undefined_field', { field => 'longdesclength' }) if !defined $ARGS->{longdesclength};
 
         $vars->{start_at} = $ARGS->{longdesclength};
         # Always sort midair collision comments oldest to newest,

template/en/default/global/code-error.html.tmpl

@@ -65,11 +65,6 @@
   of the <em>action</em> variable.
 [% END %]
 
-[% BLOCK error_attachment_already_obsolete %]
-  Attachment #[% attach_id FILTER html %] ([% description FILTER html %])
-  is already obsolete.
-[% END %]
-
 [% BLOCK error_attachment_local_storage_disabled %]
   [% title = "Local Storage Disabled" %]
   You cannot store attachments locally. This feature is disabled.