Error and confirm-delete styles

skins/contrib/Mozilla/global.css

@@ -935,6 +935,10 @@ table.tabs {
     padding: 1em 2em;
 }
 
+.admin_table tr {
+    background: white;
+}
+
 .admin_table tr.even_row {
     background: white;
 }

skins/standard/editusers.css

@@ -18,15 +18,14 @@ table.main {
 }
 table.main tr {
     vertical-align: top;
-    border-top: solid thin black;
 }
 table.main th {
-    text-align: right;
+    text-align: left;
     white-space: nowrap;
+    border-width: 0;
 }
-table.main th,
 table.main td {
-    padding: 0;
+    border-width: 0;
 }
 table.main ul {
     list-style-type: none;
@@ -53,12 +52,10 @@ table.groups td.checkbox {
 
 table#user_responsibilities th {
     text-align: center;
-    padding: 0 1em 1em;
 }
 
 table#user_responsibilities th.product {
     text-align: left;
-    padding: 1em 0 0;
 }
 
 table#user_responsibilities td.center {

skins/standard/global.css

@@ -365,14 +365,6 @@ input.requestee {
     font-size: x-large;
 }
 
-.throw_error {
-    background-color: #ff0000;
-    color: black;
-    font-size: 120%;
-    margin: 1em;
-    padding: 0.5em 1em;
-}
-
 dt {
     font-weight: bold;
 }
@@ -600,7 +592,7 @@ filter:mask();
 .numeric_invalid { background-color: #FFE0E0; }
 .buglist-navbar { float: left; margin: 4pt; font-size: 120%; padding: 2pt; }
 
-.user-error-div { margin: 20px; padding: 10px; font-size: 130%; font-family: sans-serif; border: 10px solid red; background: white; }
+.user-error-div { margin: 20px; padding: 10px; font-size: 130%; border: 10px solid red; background: white; }
 .user-error-div-first { background-color: #ffd0d0; padding: 10px; }
 
 .quicksearch { width: 300px; }

template/en/default/admin/classifications/del.html.tmpl

@@ -22,9 +22,9 @@
   title = "Delete classification"
 %]
 
-<table border=1 cellpadding=4 cellspacing=0>
-<tr bgcolor="#6666ff">
-  <th valign="top" align="left">Part</th>
+<table class="admin_table">
+<tr>
+  <th valign="top" align="left">Property</th>
   <th valign="top" align="left">Value</th>
 
 </tr><tr>

template/en/default/admin/components/confirm-delete.html.tmpl

@@ -33,9 +33,9 @@ from '[% product.name FILTER html %]' product
   title = title
 %]
 
-<table border="1" cellpadding="4" cellspacing="0">
-<tr bgcolor="#6666FF">
-  <th valign="top" align="left">Field</th>
+<table class="admin_table">
+<tr>
+  <th valign="top" align="left">Property</th>
   <th valign="top" align="left">Value</th>
 </tr>
 <tr>
@@ -114,8 +114,7 @@ from '[% product.name FILTER html %]' product
   </p>
   [% ELSE %]
 
-    <table border="0" cellpadding="20" width="70%" bgcolor="red"><tr><td>
-
+    <div class="user-error-div"><div class="user-error-div-first">
       There [% IF comp.bug_count > 1 %] 
         are [% comp.bug_count %] [%+ terms.bugs %] 
       [% ELSE %]
@@ -124,7 +123,7 @@ from '[% product.name FILTER html %]' product
       entered for this component!  When you delete this
       component, <b><blink>ALL</blink></b> stored [% terms.bugs %] and
       their history will be deleted too.
-      </td></tr></table>
+    </div></div>
 
   [% END %]
 

template/en/default/admin/confirm-action.html.tmpl

@@ -28,7 +28,7 @@
                                    style_urls = ['skins/standard/global.css'] %]
 
 [% IF abuser %]
-  <div class="throw_error">
+  <div class="user-error-div"><div class="user-error-div-first">
     <p>When you view an administrative form in [% terms.Bugzilla %], a token string
     is randomly generated and stored both in the database and in the form you loaded,
     to make sure that the requested changes are being made as a result of submitting
@@ -66,9 +66,9 @@
     </table>
 
     <p>Please report this problem to [%+ Param("maintainer") FILTER html %].</p>
-  </div>
+  </div></div>
 [% ELSE %]
-  <div class="throw_error">
+  <div class="user-error-div"><div class="user-error-div-first">
     It looks like you didn't come from the right page (you have no valid token for
     the <em>[% expected_action FILTER html %]</em> action while processing the
     '[% script_name FILTER html%]' script). The reason could be one of:<br>
@@ -82,7 +82,7 @@
     </ul>
     Are you sure you want to commit these changes anyway? This may result in
     unexpected and undesired results.
-  </div>
+  </div></div>
 
   <form name="check" id="check" method="post" action="[% script_name FILTER html %]">
     [% PROCESS "global/hidden-fields.html.tmpl"

template/en/default/admin/custom_fields/confirm-delete.html.tmpl

@@ -27,9 +27,9 @@
            doc_section = "custom-fields.html#delete-custom-fields"
 %]
 
-<table border="1" cellpadding="4" cellspacing="0">
-<tr bgcolor="#6666FF">
-  <th valign="top" align="left">Field</th>
+<table class="admin_table">
+<tr>
+  <th valign="top" align="left">Property</th>
   <th valign="top" align="left">Value</th>
 </tr>
 <tr>

template/en/default/admin/fieldvalues/confirm-delete.html.tmpl

@@ -28,20 +28,20 @@
   style_urls = ['skins/standard/admin.css']
 %]
 
-<table border="1" cellpadding="4" cellspacing="0">
-<tr bgcolor="#6666FF">
-  <th valign="top" align="left">Field</th>
+<table class="admin_table">
+<tr>
+  <th valign="top" align="left">Property</th>
   <th valign="top" align="left">Value</th>
 </tr>
-<tr>
+<tr class="even_row">
   <td valign="top">Field Name:</td>
   <td valign="top">[% field.description | html %]</td>
 </tr>
-<tr>
+<tr class="odd_row">
   <td valign="top">Field Value:</td>
   <td valign="top">[% value.name | html %]</td>
 </tr>
-<tr>
+<tr class="even_row">
   <td valign="top">[% terms.Bugs %]:</td>
   <td valign="top">
 [% IF value.bug_count %]

template/en/default/admin/milestones/confirm-delete.html.tmpl

@@ -33,9 +33,9 @@
   title = title
 %]
 
-<table border="1" cellpadding="4" cellspacing="0">
-<tr bgcolor="#6666FF">
-  <th valign="top" align="left">Field</th>
+<table class="admin_table">
+<tr>
+  <th valign="top" align="left">Property</th>
   <th valign="top" align="left">Value</th>
 </tr>
 <tr>
@@ -66,8 +66,7 @@
 
 [% IF milestone.bug_count %]
 
-  <table border="0" cellpadding="20" width="70%" bgcolor="red">
-  <tr><td>
+  <div class="user-error-div"><div class="user-error-div-first">
     You can't delete this milestone, because there
     [% IF milestone.bug_count > 1 %]
       are [% milestone.bug_count FILTER none %] [%+ terms.bugs %]
@@ -75,8 +74,7 @@
       is 1 [% terms.bug %]
     [% END %]
     targetted to it.
-  </td></tr>
-  </table>
+  </div></div>
 
 [% ELSE %]
 

template/en/default/admin/products/confirm-delete.html.tmpl

@@ -31,9 +31,9 @@
   style_urls = ['skins/standard/admin.css']
 %]
 
-<table border="1" cellpadding="4" cellspacing="0">
-  <tr bgcolor="#6666FF">
-    <th valign="top" align="left">Field</th>
+<table class="admin_table">
+  <tr>
+    <th valign="top" align="left">Property</th>
     <th valign="top" align="left">Value</th>
   </tr>
 
@@ -206,21 +206,17 @@
 
   [% ELSE %]
 
-    <table border="0" cellpadding="20" width="70%" bgcolor="red">
-      <tr>
-        <td>
-          There
-          [% IF product.bug_count > 1 %]
-            are [% product.bug_count FILTER html %] [%+ terms.bugs %]
-          [% ELSE %]
-            is 1 [% terms.bug %]
-          [% END %]
-          entered for this product!  When you delete this
-          product, <b><blink>ALL</blink></b> stored [% terms.bugs %] and
-          their history will be deleted, too.
-        </td>
-      </tr>
-    </table>
+    <div class="user-error-div"><div class="user-error-div-first">
+      There
+      [% IF product.bug_count > 1 %]
+        are [% product.bug_count FILTER html %] [%+ terms.bugs %]
+      [% ELSE %]
+        is 1 [% terms.bug %]
+      [% END %]
+      entered for this product!  When you delete this
+      product, <b><blink>ALL</blink></b> stored [% terms.bugs %] and
+      their history will be deleted, too.
+    </div></div>
 
   [% END %]
 

template/en/default/admin/users/confirm-delete.html.tmpl

@@ -55,7 +55,7 @@
   listselectionvalues = listselectionvalues
 %]
 
-<table class="main">
+<table class="admin_table main">
   <tr>
     <th>Login name:</th>
     <td>[% otheruser.login FILTER html %]</td>

template/en/default/admin/users/edit.html.tmpl

@@ -37,7 +37,7 @@
 %]
 
 <form method="post" action="editusers.cgi">
-<table class="main">
+<table class="admin_table main">
   [% PROCESS admin/users/userdata.html.tmpl
     editform  = 1
     editusers = editusers

template/en/default/admin/versions/confirm-delete.html.tmpl

@@ -33,9 +33,9 @@
   title = title
 %]
 
-<table border="1" cellpadding="4" cellspacing="0">
-<tr bgcolor="#6666FF">
-  <th valign="top" align="left">Field</th>
+<table class="admin_table">
+<tr>
+  <th valign="top" align="left">Property</th>
   <th valign="top" align="left">Value</th>
 </tr>
 <tr>
@@ -65,7 +65,7 @@
 <h2>Confirmation</h2>
 
 [% IF version.bug_count %]
-  <p>
+  <div class="user-error-div"><div class="user-error-div-first">
   Sorry, there
   [% IF version.bug_count > 1 %] 
     are [% version.bug_count FILTER none %] [%+ terms.bugs %] 
@@ -76,16 +76,16 @@
   outstanding for this version. You must move 
 
   [% IF version.bug_count > 1 %]
-     those [% terms.bugs %] 
+     those [% terms.bugs %]
   [% ELSE %]
      that [% terms.bug %]
   [% END %]
   to another version before you can delete this one.
-  </p>
+  </div></div>
 [% ELSE %]
 
   <p>Do you really want to delete this version?</p>
-  
+
   <form method="post" action="editversions.cgi">
     <input type="submit" id="delete" value="Yes, delete">
     <input type="hidden" name="action" value="delete">

template/en/default/admin/versions/edit.html.tmpl

@@ -25,23 +25,23 @@
   <table border="0" cellpadding="4" cellspacing="0">
     <tr>
       <th class="field_label"><label for="version">Version:</label></th>
-      <td><input id="version" size="64" maxlength="64" name="version" id="version" value="[%- version.name | html %]"></td>
+      <td><input id="version" size="64" maxlength="64" name="version" id="version" value="[%- version.name | html %]" /></td>
     </tr>
     [% IF version.id %]
     <tr>
       <th class="field_label"><label for="isactive">Enabled For [% terms.Bugs %]:</label></th>
-      <td><input id="isactive" name="isactive" type="checkbox" value="1" [% 'checked="checked"' IF version.isactive %]></td>
+      <td><input id="isactive" name="isactive" type="checkbox" value="1" [% 'checked="checked"' IF version.isactive %] /></td>
     </tr>
     [% INCLUDE "admin/fieldvalues/control-list-common.html.tmpl" this_field=version.field this_value=version %]
     [% END %]
   </table>
 
-  <input type="submit" value="[% version.id ? "Save Changes" : "Add" %]">
-  <input type="hidden" name="action" value="[% version.id ? "update" : "new" %]">
-  <input type="hidden" name="product" value="[% product.name | html %]">
-  <input type="hidden" name="token" value="[% token | html %]">
+  <p><input type="submit" value="[% version.id ? "Save Changes" : "Add" %]" /></p>
+  <input type="hidden" name="action" value="[% version.id ? "update" : "new" %]" />
+  <input type="hidden" name="product" value="[% product.name | html %]" />
+  <input type="hidden" name="token" value="[% token | html %]" />
   [% IF version.id %]
-  <input type="hidden" name="versionold" value="[% version.name | html %]">
+  <input type="hidden" name="versionold" value="[% version.name | html %]" />
   [% END %]
 </form>
 

template/en/default/attachment/confirm-delete.html.tmpl

@@ -27,9 +27,9 @@
   doc_section = "attachments.html"
 %]
 
-<table border="1" cellpadding="4" cellspacing="0">
-  <tr bgcolor="#6666FF">
-    <th valign="top" align="left">Field</th>
+<table class="admin_table">
+  <tr>
+    <th valign="top" align="left">Property</th>
     <th valign="top" align="left">Value</th>
   </tr>
   <tr>
@@ -62,13 +62,9 @@
 
 <h2>Confirmation</h2>
 
-<table border="0" cellpadding="20" width="70%" bgcolor="red">
-  <tr>
-    <td>
-      The content of this attachment will be deleted in an <b>irreversible</b> way.
-    </td>
-  </tr>
-</table>
+<div class="user-error-div"><div class="user-error-div-first">
+  The content of this attachment will be deleted in an <b>irreversible</b> way.
+</div></div>
 
 <p>Do you really want to delete this attachment?</p>
 

template/en/default/global/confirm-action.html.tmpl

@@ -26,7 +26,7 @@
 [% PROCESS global/header.html.tmpl title = "Suspicious Action"
                                    style_urls = ['skins/standard/global.css'] %]
 
-<div class="throw_error">
+<div class="user-error-div"><div class="user-error-div-first">
   [% IF reason == "expired_token" %]
     Your changes have been rejected because you exceeded the time limit
     of [% constants.MAX_TOKEN_AGE FILTER html %] days before submitting your
@@ -48,7 +48,7 @@
   <p>
     Are you sure you want to commit these changes?
   </p>
-</div>
+</div></div>
 
 <form name="check" id="check" method="post" action="[% script_name FILTER html %]">
   [% PROCESS "global/hidden-fields.html.tmpl"

template/en/default/reports/keywords.html.tmpl

@@ -33,8 +33,8 @@
 %]
 
 [% IF keywords.size > 0 %]
-<table border="1" cellpadding="4" cellspacing="0">
-  <tr bgcolor="#6666FF">
+<table class="admin_table">
+  <tr>
     <th align="left">Name</th>
     <th align="left">Description</th>
     <th align="left">Open [% terms.Bugs %]</th>
@@ -43,11 +43,10 @@
 [% END %]
 
 [% FOREACH keyword = keywords %]
-  <tr>
-    <th>
-      <a name="[% keyword.name FILTER html %]">
-        [% keyword.name FILTER html %]</a>
-    </th>
+  <tr class="[% loop.index % 2 ? 'odd_row' : 'even_row' %]">
+    <td>
+      <b><a name="[% keyword.name FILTER html %]">[% keyword.name FILTER html %]</a></b>
+    </td>
     <td>[% keyword.description FILTER html_light %]</td>
     <td align="center">
       [% IF keyword.bug_count > 0 %]