Fix selecting values from URL on the bug entry form

3col
Vitaliy Filippov 2015-08-26 14:00:54 +03:00
parent 85e85d6d42
commit 9c2b7db0e3
2 changed files with 11 additions and 2 deletions

View File

@ -136,11 +136,17 @@ function handleControlledField(controlled_id, is_initial_editform)
if (m.default_value || (df = m.default_field && document.getElementById(m.default_field)))
{
// Check if the value is different from previous default or from empty value
// We must check it before re-filling field options because some values can disappear
// We must check it before re-filling field options because some values may disappear
if (controlled.nodeName == 'SELECT')
{
var copt = getSelectedIds(controlled);
delete copt[0]; // skip empty value
if (copt.UNKNOWN)
{
// We are on the bug entry form and some default value is selected,
// but its ID is still unknown (because entry form does not prefill select options)
diff = true;
}
if (controlled._oldDefault)
{
for (var i in controlled._oldDefault)

View File

@ -302,7 +302,10 @@ function getSelectedIds(sel)
if (sel.options[i].selected)
{
id = sel.options[i].id;
opt[id ? id.substr(1, id.length-lm) : 0] = true;
if (!id && sel.options[i].value)
opt.UNKNOWN = true;
else
opt[id ? id.substr(1, id.length-lm) : 0] = true;
}
}
return opt;