vitalif
/
e2fsprogs
mirror of https://github.com/vitalif/e2fsprogs
1
0
Fork 0
Code Issues Releases Wiki Activity

libblkid: add error checking for rename() while saving the blkid cache 

Addresses-Coverity-Id: #1049141

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
maint-test
Theodore Ts'o 2014-01-10 22:09:45 -05:00
parent a8307ab8cc
commit 0d719bad86
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/blkid/save.c
View File

@ -136,7 +136,7 @@ int blkid_flush_cache(blkid_cache cache)
fclose(file);
if (opened != filename) {
if (ret < 0) {
unlink(opened);
(void) unlink(opened);
DBG(DEBUG_SAVE,
printf("unlinked temp cache %s\n", opened));
} else {
@ -149,7 +149,8 @@ int blkid_flush_cache(blkid_cache cache)
link(filename, backup);
free(backup);
}
rename(opened, filename);
if (rename(opened, filename) < 0)
(void) unlink(opened);
DBG(DEBUG_SAVE,
printf("moved temp cache %s\n", opened));
}