mirror of https://github.com/vitalif/e2fsprogs
quota: fix uninitiaized memory reference in mke2fs with quota enabled
Initialize the on-disk structure before we fill it in, to avoid the following valgrind warning: Conditional jump or move depends on uninitialised value(s) at 0x4323A8: qtree_entry_unused (quotaio_tree.c:40) by 0x431218: v2r1_mem2diskdqblk (quotaio_v2.c:85) by 0x432409: qtree_write_dquot (quotaio_tree.c:336) by 0x431136: v2_commit_dquot (quotaio_v2.c:264) by 0x42FB63: quota_write_inode (mkquota.c:126) by 0x408BE6: create_quota_inodes (mke2fs.c:2466) by 0x409A2D: main (mke2fs.c:2850) Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>maint-test
parent
5bb4d0cec4
commit
0dedd011ed
|
@ -329,6 +329,7 @@ void qtree_write_dquot(struct dquot *dquot)
|
||||||
(unsigned int)dquot->dq_id, strerror(errno));
|
(unsigned int)dquot->dq_id, strerror(errno));
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
memset(ddquot, 0, info->dqi_entry_size);
|
||||||
|
|
||||||
if (!dquot->dq_dqb.u.v2_mdqb.dqb_off)
|
if (!dquot->dq_dqb.u.v2_mdqb.dqb_off)
|
||||||
dq_insert_tree(dquot->dq_h, dquot);
|
dq_insert_tree(dquot->dq_h, dquot);
|
||||||
|
|
Loading…
Reference in New Issue