diff --git a/lib/ext2fs/dir_iterate.c b/lib/ext2fs/dir_iterate.c index 39d713bc..0087d588 100644 --- a/lib/ext2fs/dir_iterate.c +++ b/lib/ext2fs/dir_iterate.c @@ -80,7 +80,7 @@ static int ext2fs_validate_entry(ext2_filsys fs, char *buf, offset += rec_len; if ((rec_len < 8) || ((rec_len % 4) != 0) || - (((dirent->name_len & 0xFF)+8) > rec_len)) + ((((unsigned) dirent->name_len & 0xFF)+8) > rec_len)) return 0; } return (offset == final_offset); @@ -186,8 +186,8 @@ int ext2fs_process_dir_block(ext2_filsys fs, int ret = 0; int changed = 0; int do_abort = 0; - unsigned int rec_len; - int entry, size; + unsigned int rec_len, size; + int entry; struct ext2_dir_entry *dirent; if (blockcnt < 0) @@ -206,7 +206,7 @@ int ext2fs_process_dir_block(ext2_filsys fs, if (((offset + rec_len) > fs->blocksize) || (rec_len < 8) || ((rec_len % 4) != 0) || - (((dirent->name_len & 0xFF)+8) > rec_len)) { + ((((unsigned) dirent->name_len & 0xFF)+8) > rec_len)) { ctx->errcode = EXT2_ET_DIR_CORRUPTED; return BLOCK_ABORT; } diff --git a/lib/ext2fs/extent.c b/lib/ext2fs/extent.c index c3b7c586..7fcc2cf9 100644 --- a/lib/ext2fs/extent.c +++ b/lib/ext2fs/extent.c @@ -1354,7 +1354,6 @@ errcode_t ext2fs_extent_delete(ext2_extent_handle_t handle, int flags) char *cp; struct ext3_extent_header *eh; errcode_t retval = 0; - struct ext2fs_extent extent; EXT2_CHECK_MAGIC(handle, EXT2_ET_MAGIC_EXTENT_HANDLE); diff --git a/lib/ext2fs/gen_bitmap.c b/lib/ext2fs/gen_bitmap.c index 19caf230..1f7d2c4c 100644 --- a/lib/ext2fs/gen_bitmap.c +++ b/lib/ext2fs/gen_bitmap.c @@ -355,7 +355,7 @@ static int ext2fs_test_clear_generic_bitmap_range(ext2fs_generic_bitmap bitmap, unsigned int len) { size_t start_byte, len_byte = len >> 3; - int start_bit, len_bit = len % 8; + unsigned int start_bit, len_bit = len % 8; int first_bit = 0; int last_bit = 0; int mark_count = 0; @@ -425,8 +425,6 @@ static int ext2fs_test_clear_generic_bitmap_range(ext2fs_generic_bitmap bitmap, int ext2fs_test_block_bitmap_range(ext2fs_block_bitmap bitmap, blk_t block, int num) { - int i; - EXT2_CHECK_MAGIC(bitmap, EXT2_ET_MAGIC_BLOCK_BITMAP); if ((block < bitmap->start) || (block+num-1 > bitmap->real_end)) { ext2fs_warn_bitmap(EXT2_ET_BAD_BLOCK_TEST, @@ -440,8 +438,6 @@ int ext2fs_test_block_bitmap_range(ext2fs_block_bitmap bitmap, int ext2fs_test_inode_bitmap_range(ext2fs_inode_bitmap bitmap, ino_t inode, int num) { - int i; - EXT2_CHECK_MAGIC(bitmap, EXT2_ET_MAGIC_INODE_BITMAP); if ((inode < bitmap->start) || (inode+num-1 > bitmap->real_end)) { ext2fs_warn_bitmap(EXT2_ET_BAD_INODE_TEST,