vitalif
/
e2fsprogs
mirror of https://github.com/vitalif/e2fsprogs
1
0
Fork 0
Code Issues Releases Wiki Activity

e2fsck: mark sparse journal as invalid 

For a filesystem that fails with:

journal_bmap: journal block not found at offset 7334 on loop0
JBD: bad block at offset 7334

e2fsck won't actually fix this; it will mark the fs as clean,
so it will mount, but it does not fix that block, and when the
journal reaches this point again it will fail again.

The following simple change to process_journal_block() might be
a little drastic; it will clear & recreate the journal inode if
it's sparse - i.e. if it gets block 0.

I suppose we could be more complicated and try to replay the journal
up to the error, but I'm not sure it's worth it since we're fscking
it anyway.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
bitmap-optimize
Eric Sandeen 2010-04-12 17:36:33 -05:00 committed by Theodore Ts'o
parent a6217f5ae2
commit 5750e5f924
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
e2fsck/journal.c
View File

@ -214,7 +214,7 @@ static int process_journal_block(ext2_filsys fs,
p = (struct process_block_struct *) priv_data;
if (blk < fs->super->s_first_data_block ||
if (!blk || blk < fs->super->s_first_data_block ||
blk >= fs->super->s_blocks_count)
return BLOCK_ABORT;