vitalif
/
e2fsprogs
mirror of https://github.com/vitalif/e2fsprogs
1
0
Fork 0
Code Issues Releases Wiki Activity

libext2fs: Fix a corner case bug in ext2fs_unlink 

We cannot merge a removed directory entry to just arbitrary previous
directory entry. The previous entry must be in the same block.  So
really bad things can happen when are deleting the first directory
entry in a block where the last directory entry in the previous
directory block is not in use.  We fix this bug by checking to see if
the current entry is not the first one in the block before trying to
merge it to the previous entry.

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
bitmap-optimize
Theodore Ts'o 2007-12-01 07:08:45 -05:00
parent 8cdd6a6f34
commit 7e5a86a660
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/ext2fs/unlink.c
View File

@ -31,7 +31,7 @@ struct link_struct {
#pragma argsused
#endif
static int unlink_proc(struct ext2_dir_entry *dirent,
int offset EXT2FS_ATTR((unused)),
int offset,
int blocksize EXT2FS_ATTR((unused)),
char *buf EXT2FS_ATTR((unused)),
void *priv_data)
@ -56,7 +56,7 @@ static int unlink_proc(struct ext2_dir_entry *dirent,
return 0;
}
if (prev)
if (offset)
prev->rec_len += dirent->rec_len;
else
dirent->inode = 0;