From 713edbd08252a02e70638222ced86c838c320a57 Mon Sep 17 00:00:00 2001 From: Andreas Dilger Date: Wed, 10 Aug 2016 18:21:19 -0400 Subject: [PATCH] fsck: fix strange logic llvm warns about the confusingly written comparison: !strncmp(argv[i+1], "-", 1) == 0) { misc/fsck.c:1178 col 9: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] misc/fsck.c:1178 col 9: note: add parentheses after the '!' to evaluate the comparison first misc/fsck.c:1178 col 9: note: add parentheses around left hand side expression to silence this warning It makes sense to simplify this to a character comparison rather than using strncmp() to check only one character. Signed-off-by: Andreas Dilger Signed-off-by: Theodore Ts'o --- misc/fsck.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/misc/fsck.c b/misc/fsck.c index 826aaebb..67e158a5 100644 --- a/misc/fsck.c +++ b/misc/fsck.c @@ -1174,8 +1174,8 @@ static void PRS(int argc, char *argv[]) progress_fd = 0; else goto next_arg; - } else if ((i+1) < argc && - !strncmp(argv[i+1], "-", 1) == 0) { + } else if (argc > i + 1 && + argv[i + 1][0] != '-') { progress_fd = string_to_int(argv[i]); if (progress_fd < 0) progress_fd = 0;