vitalif
/
e2fsprogs
mirror of https://github.com/vitalif/e2fsprogs
1
0
Fork 0
Code Issues Releases Wiki Activity

blkid: suppress Coverity warning 

The getopt() function will never let optarg be NULL (at least without
using the GNU double-colon extension, which we don't use because it's
not portable), so don't bother checking for that case.  It's harmless,
but it triggers a Coverity warning elsewhere, since it thinks optarg
could in fact be NULL.

Addresses-Coverity-Id: #1049156

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
maint-test
Theodore Ts'o 2014-01-30 18:02:37 -05:00
parent 9b36ce0e19
commit e5397d7ae9
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
misc/blkid.c
View File

@ -293,10 +293,7 @@ int main(int argc, char **argv)
while ((c = getopt (argc, argv, "c:f:ghlLo:s:t:w:v")) != EOF)
switch (c) {
case 'c':
if (optarg && !*optarg)
read = NULL;
else
read = optarg;
read = optarg;
if (!write)
write = read;
break;
@ -349,10 +346,7 @@ int main(int argc, char **argv)
version = 1;
break;
case 'w':
if (optarg && !*optarg)
write = NULL;
else
write = optarg;
write = optarg;
break;
case 'h':
err = 0;