45e338f533
remove useless if-before-free tests
...
In case you're wondering about whether this change is safe from a
portability standpoint, fear not. This has been beaten to death
in other forums. Here are a few threads:
http://thread.gmane.org/gmane.comp.version-control.git/74187
http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/12712
http://thread.gmane.org/gmane.emacs.devel/98144
http://thread.gmane.org/gmane.comp.lib.glibc.alpha/13092
There has been debate about whether it's a good idea from a
performance standpoint, too, but imho you'll have a hard time
finding an instance where this sort of change induces a
measurable performance penalty. If you do, please let me know.
Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2009-03-08 20:37:12 -04:00
efc6f628e1
Remove trailing whitespace for the entire source tree
...
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-27 23:07:54 -04:00
f1d6a0797b
[COVERITY] Fix (error case) file handle leak in util/subst program
...
Need to close old_f before returning since it had been successfully opened
before.
Coverity ID: 19: Resource Leak
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
2007-03-21 17:19:55 -04:00
98224fbc1d
Avoid infinite substitution loop in subst caused by autoconf pre-v2.60
...
Autoconf versions before 2.60 don't have datarootdir defined, and so this
resulted in a @datarootdir@ --> @datarootdir@ infinite expansion.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2006-11-12 17:43:50 -05:00
3f5ef9642b
Create the generated files read-only to remind developers not to edit them.
...
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2006-08-05 14:41:00 -04:00
f932ed925c
Add missing #include <time.h>, fixing a compiler warning.
2004-04-12 20:16:04 +02:00
dd60705665
Refine the build process to avoid re-running subst all the time on
...
some generated files, by having subst update the modtime on these
files even when the generated file hasn't changed. We do this with
generated files that do not have any downstream dependencies.
2004-04-03 13:53:46 -05:00
544349270e
Fix gcc -Wall nitpicks
2003-12-07 01:28:50 -05:00
913c4e9f14
ChangeLog, subst.c:
...
subst.c (replace_string): Fix replace_string so that it correctly
handles replacing a substitution variable with a zero-length string.
2001-04-17 05:05:37 +00:00
691d3353c2
ChangeLog, subst.c:
...
subst.c: For platforms that don't define optarg.h, manually define
optarg and optind.
2000-04-03 16:16:46 +00:00
cdceb0496f
ChangeLog, subst.c:
...
subst.c (substitute_line): Removed some unused variables.
1999-10-26 16:28:59 +00:00
7822c1d410
ChangeLog, subst.c:
...
subst.c (get_subst_symbol): Add [0-9] to the list of valid characters
for a substitution symbol.
1998-12-19 08:08:43 +00:00
e7549ca628
ChangeLog, subst.c, subst.conf.in:
...
* subst.c: Add the ability to substitute apparent shell/make variables
such as ${prefix}, since this is needed to make the shell scripts work
correctly.
subst.conf.in: Add ${prefix} to the list of substitutions which subst
should make.
1998-08-01 04:35:39 +00:00
45d2161466
ChangeLog, subst.c:
...
subst.c: Rename "new" to "new_f" to avoid C++ reserved word clash.
subst.c: Explicitly cast all assignments from void * to be compatible
with C++.
1998-01-19 14:40:24 +00:00
44339bdff8
Many files:
...
Use new substitution technology which doesn't depend on shell scripts.
(Faster, and better for MS-DOS port!)
1997-10-15 02:47:20 +00:00
Jim Meyering