e2fsprogs/debugfs
Eric Whitney a25fffae5c debugfs: restore and tweak original error messaging
In response to reviewer comments, commit fe56188b07 included changes
that modified some of the code used to output error messages when
checking user-supplied block numbers.  These changes converted calls
to parse_ulonglong() to calls to strtoblk().  Because strtoblk() calls
parse_ulonglong(), and both output error messages, two redundant and
relatively generic messages were output on each error.

Fix this by removing the error message output from strtoblk(), and
extending it to accept an optional error message argument that it
supplies in lieu of a default to parse_ulonglong().  Also, revert to
the more descriptive original error messages with mods per reviewer
comments, and fix an error message in do_replace_node().

Signed-off-by: Eric Whitney <enwlinux@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2013-12-30 16:56:19 -05:00
..
Makefile.in e2fsprogs: add (optional) sparse checking to the build 2013-10-11 23:12:40 -04:00
debug_cmds.ct debugfs: add symlink command 2013-01-16 14:09:20 -05:00
debugfs.8.in debugfs: document the lsdel command in the man page 2013-12-28 22:15:59 -05:00
debugfs.c debugfs: restore and tweak original error messaging 2013-12-30 16:56:19 -05:00
debugfs.h debugfs: restore and tweak original error messaging 2013-12-30 16:56:19 -05:00
dump.c debugfs: don't leak fd when calling dump_file 2013-12-12 12:51:01 -05:00
extent_cmds.ct debugfs: add the ability to manipulate the extent tree directly 2012-12-24 10:49:41 -05:00
extent_inode.c debugfs: restore and tweak original error messaging 2013-12-30 16:56:19 -05:00
filefrag.c debugfs: update usage message for open and filefrag 2013-12-08 21:06:40 -05:00
htree.c Fix gcc -Wall nits 2013-01-01 13:28:27 -05:00
icheck.c debugfs: restore and tweak original error messaging 2013-12-30 16:56:19 -05:00
jfs_user.h Move linux/jbd.h to ext2fs/kernel-jbd.h, to avoid using the 2001-12-23 19:33:51 -05:00
logdump.c Clean up sparse warnings 2013-12-16 18:56:36 -05:00
ls.c debugfs: initialize inode to 0 in list_dir_proc() if no inode nr 2011-09-25 01:55:28 -04:00
lsdel.c debugfs: clean up debugfs man page and help text 2013-12-15 22:13:15 -05:00
ncheck.c debugfs: fix spelling typo in ncheck 2012-01-23 11:33:33 -05:00
ro_debug_cmds.ct debugfs: add the ability to manipulate the extent tree directly 2012-12-24 10:49:41 -05:00
set_fields.c debugfs, e2fsck: fix s_desc_size handling 2013-12-24 22:50:19 -05:00
unused.c Shorten compile commands run by the build system 2011-09-18 17:34:37 -04:00
util.c debugfs: restore and tweak original error messaging 2013-12-30 16:56:19 -05:00
zap.c debugfs: clean up debugfs man page and help text 2013-12-15 22:13:15 -05:00