mirror of https://github.com/vitalif/e2fsprogs
38d5adf339
It turns out that there are some serious problems with the on-disk format of journal checksum v2. The foremost is that the function to calculate descriptor tag size returns sizes that are too big. This causes alignment issues on some architectures and is compounded by the fact that some parts of jbd2 use the structure size (incorrectly) to determine the presence of a 64bit journal instead of checking the feature flags. These errors regrettably lead to the journal corruption reported by Mr. Reardon. Therefore, introduce journal checksum v3, which enlarges the descriptor block tag format to allow for full 32-bit checksums of journal blocks, fix the journal tag function to return the correct sizes, and fix the jbd2 recovery code to use feature flags to determine 64bitness. Add a few function helpers so we don't have to open-code quite so many pieces. Switching to a 16-byte block size was found to increase journal size overhead by a maximum of 0.1%, to convert a 32-bit journal with no checksumming to a 32-bit journal with checksum v3 enabled. Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Reported-by: TR Reardon <thomas_reardon@hotmail.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu> |
||
|---|---|---|
| .. | ||
| Makefile.in | ||
| debug_cmds.ct | ||
| debugfs.8.in | ||
| debugfs.c | ||
| debugfs.h | ||
| dump.c | ||
| extent_cmds.ct | ||
| extent_inode.c | ||
| filefrag.c | ||
| htree.c | ||
| icheck.c | ||
| jfs_user.h | ||
| logdump.c | ||
| ls.c | ||
| lsdel.c | ||
| ncheck.c | ||
| quota.c | ||
| ro_debug_cmds.ct | ||
| set_fields.c | ||
| unused.c | ||
| util.c | ||
| xattrs.c | ||
| zap.c | ||