mirror of https://github.com/vitalif/e2fsprogs
![]() The current m68k code was buggy for multiple reasons; first the bfset, et. al commands interpret the bit number as a signed number, not an unsigned number. Secondly, there were missing memory clobbers. Since there is no real benefit in using explicit asm's at this point (gcc is smart enough to optimize the generic C code to use the set/clear/test bit m68k instruction) fix this bug by removing the m68k specific asm versions of these functions. Tested on m68k-linux with e2fsprogs-1.42.6 and gcc-4.6.3 as before. All tests pass and the debug output looks sane. I compared the e2fsck binaries from the previous build with this one. They had identical .text sizes, and almost the same number of bit field instructions (obviously compiler-generated), so this change should have no serious performance implications. Signed-off-by: Mikael Pettersson <mikpe@it.uu.se> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Cc: Andreas Schwab <schwab@linux-m68k.org> |
||
---|---|---|
.. | ||
blkid | ||
e2p | ||
et | ||
ext2fs | ||
quota | ||
ss | ||
uuid | ||
Makefile.bsd-lib | ||
Makefile.checker | ||
Makefile.darwin-lib | ||
Makefile.elf-lib | ||
Makefile.library | ||
Makefile.profile | ||
Makefile.solaris-lib | ||
config.h.in | ||
dirpaths.h.in | ||
fpopen.c |