From 036cb96fd1e94b8cfc696d9d3c84c55330117ddd Mon Sep 17 00:00:00 2001 From: "Sahdev P. Zala" Date: Mon, 30 Sep 2019 13:26:51 -0400 Subject: [PATCH] *: create project governance Create project governance. --- CHANGELOG-3.5.md | 3 +++ GOVERNANCE.md | 18 +++++------------- MAINTAINERS | 6 +----- 3 files changed, 9 insertions(+), 18 deletions(-) diff --git a/CHANGELOG-3.5.md b/CHANGELOG-3.5.md index e9f815e12..656679a7e 100644 --- a/CHANGELOG-3.5.md +++ b/CHANGELOG-3.5.md @@ -102,6 +102,9 @@ Note that any `etcd_debugging_*` metrics are experimental and subject to change. - Require [*Go 1.13+*](https://github.com/etcd-io/etcd/pull/11110). - Compile with [*Go 1.13*](https://golang.org/doc/devel/release.html#go1.13) +### Project Governance + +- The etcd team has added, a well defined and openly discussed, project [governance](https://github.com/etcd-io/etcd/pull/11175).
diff --git a/GOVERNANCE.md b/GOVERNANCE.md index b7d10081f..a0a6a290e 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -42,7 +42,7 @@ below. Contributors who are interested in becoming a maintainer, if performing these responsibilities, should discuss their interest with the existing maintainers. New maintainers must be nominated by an existing maintainer and must be elected by a -supermajority of maintainers. Likewise, maintainers can be removed by a supermajority +supermajority of maintainers. Likewise, maintainers can be removed by a supermajority of the maintainers and moved to emeritus status. Life priorities, interests, and passions can change. If a maintainer needs to step @@ -51,22 +51,14 @@ to pick up the related work. At the very least, ensure the related work can be c Afterward, create a pull request to remove yourself from the [MAINTAINERS](./MAINTAINERS) file. -## Approvers - -[Approvers](./MAINTAINERS) are contributors with merge rights. They are active reviewers -and have created significant numbers of PRs in the various code areas to add new features, -fix bugs and improve code. New approvers must be nominated by an existing maintainer -and must be elected by a supermajority of maintainers. Likewise, approvers can be removed -by a supermajority of the maintainers or can resign by notifying the maintainers. - ## Reviewers [Reviewers](./MAINTAINERS) are contributors who have demonstrated greater skill in reviewing the code contribution from other contributors. Their LGTM counts towards -merging a code change into the project. New reviewers must be nominated by an existing -maintainer and must be elected by a supermajority of maintainers. Likewise, reviewers -can be removed by a supermajority of the maintainers or can resign by notifying the -maintainers. +merging a code change into the project. A reviewer is generally on the ladder towards +maintainership. New reviewers must be nominated by an existing maintainer and must be +elected by a supermajority of maintainers. Likewise, reviewers can be removed by a +supermajority of the maintainers or can resign by notifying the maintainers. ## Decision making process diff --git a/MAINTAINERS b/MAINTAINERS index fd85ff1e2..b42a28e53 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1,4 +1,4 @@ -# The official list of maintainers, approvers, and reviewers for the project maintenance. +# The official list of maintainers and reviewers for the project maintenance. # # Refer to the GOVERNANCE.md for description of the roles. # @@ -21,9 +21,5 @@ Xiang Li (@xiang90) pkg:* Ben Darnell (@bdarnell) pkg:go.etcd.io/etcd/raft Tobias Grieger (@tbg) pkg:go.etcd.io/etcd/raft -# APPROVERS -Anthony Romano (@heyitsanthony) pkg:* -Fanmin Shi (@fanminshi) pkg:* - # REVIEWERS Wenjia Zhang (@wenjiaswe) pkg:*