From 091b84f154d9c7ebbeffc47b96e356b0a2254a1e Mon Sep 17 00:00:00 2001 From: Gyuho Lee Date: Fri, 17 Jan 2020 12:04:10 -0800 Subject: [PATCH] clientv3/integration: fix "TestLeaseKeepAliveNotFound" with "default" select, the failure case will never be selected Signed-off-by: Gyuho Lee --- clientv3/integration/lease_test.go | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/clientv3/integration/lease_test.go b/clientv3/integration/lease_test.go index 84f18d529..439e683f4 100644 --- a/clientv3/integration/lease_test.go +++ b/clientv3/integration/lease_test.go @@ -268,16 +268,10 @@ func TestLeaseKeepAliveNotFound(t *testing.T) { <-lchs[0].ch if _, ok := <-lchs[0].ch; !ok { - t.Fatalf("closed keepalive on wrong lease") + t.Fatal("closed keepalive on wrong lease") } - - timec := time.After(5 * time.Second) - for range lchs[1].ch { - select { - case <-timec: - t.Fatalf("revoke did not close keep alive") - default: - } + if _, ok := <-lchs[1].ch; ok { + t.Fatal("expected closed keepalive") } }