From 195744aea64bfa2d5f9e28e536522e9a58c036bb Mon Sep 17 00:00:00 2001 From: Gyu-Ho Lee Date: Wed, 9 Aug 2017 15:58:48 -0700 Subject: [PATCH] pkg/flags: warns on shadowed environment variable flags Signed-off-by: Gyu-Ho Lee --- pkg/flags/flag.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/flags/flag.go b/pkg/flags/flag.go index d30bf3f9b..89c2202d2 100644 --- a/pkg/flags/flag.go +++ b/pkg/flags/flag.go @@ -80,9 +80,7 @@ func SetFlagsFromEnv(prefix string, fs *flag.FlagSet) error { fs.VisitAll(func(f *flag.Flag) { err = setFlagFromEnv(fs, prefix, f.Name, usedEnvKey, alreadySet, true) }) - verifyEnv(prefix, usedEnvKey, alreadySet) - return err } @@ -100,6 +98,7 @@ func SetPflagsFromEnv(prefix string, fs *pflag.FlagSet) error { err = serr } }) + verifyEnv(prefix, usedEnvKey, alreadySet) return err } @@ -118,7 +117,8 @@ func verifyEnv(prefix string, usedEnvKey, alreadySet map[string]bool) { continue } if alreadySet[kv[0]] { - plog.Infof("recognized environment variable %s, but unused: shadowed by corresponding flag ", kv[0]) + // TODO: exit with error in v3.4 + plog.Warningf("recognized environment variable %s, but unused: shadowed by corresponding flag", kv[0]) continue } if strings.HasPrefix(env, prefix+"_") {