From 0914b8b707903d36593e2f427e93a51fb299fe40 Mon Sep 17 00:00:00 2001
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
Date: Thu, 9 Feb 2017 08:01:28 -0500
Subject: [PATCH] test: Fix gosimple errors

Getting gosimple suggestion while running test script, so this PR is for fixing gosimple S1019 check.
raft/node_test.go:456:40: should use make([]raftpb.Entry, 1) instead (S1019)
raft/node_test.go:457:49: should use make([]raftpb.Entry, 1) instead (S1019)
raft/node_test.go:458:43: should use make([]raftpb.Message, 1) instead (S1019)

Refer https://github.com/dominikh/go-tools/blob/master/cmd/gosimple/README.md#checks for more information.
---
 etcdserver/util.go                                    | 2 +-
 integration/v3_election_test.go                       | 2 +-
 mvcc/kvstore.go                                       | 2 +-
 raft/node_test.go                                     | 6 +++---
 tools/functional-tester/etcd-runner/command/global.go | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/etcdserver/util.go b/etcdserver/util.go
index 66084ae12..e3896ffc2 100644
--- a/etcdserver/util.go
+++ b/etcdserver/util.go
@@ -87,7 +87,7 @@ type notifier struct {
 
 func newNotifier() *notifier {
 	return &notifier{
-		c: make(chan struct{}, 0),
+		c: make(chan struct{}),
 	}
 }
 
diff --git a/integration/v3_election_test.go b/integration/v3_election_test.go
index 0eb5eae93..d74e2966c 100644
--- a/integration/v3_election_test.go
+++ b/integration/v3_election_test.go
@@ -112,7 +112,7 @@ func TestElectionFailover(t *testing.T) {
 	cctx, cancel := context.WithCancel(context.TODO())
 	defer cancel()
 
-	ss := make([]*concurrency.Session, 3, 3)
+	ss := make([]*concurrency.Session, 3)
 
 	for i := 0; i < 3; i++ {
 		var err error
diff --git a/mvcc/kvstore.go b/mvcc/kvstore.go
index 28a18a065..f9f78c155 100644
--- a/mvcc/kvstore.go
+++ b/mvcc/kvstore.go
@@ -101,7 +101,7 @@ func NewStore(b backend.Backend, le lease.Lessor, ig ConsistentIndexGetter) *sto
 		currentRev:     revision{main: 1},
 		compactMainRev: -1,
 
-		bytesBuf8: make([]byte, 8, 8),
+		bytesBuf8: make([]byte, 8),
 		fifoSched: schedule.NewFIFOScheduler(),
 
 		stopc: make(chan struct{}),
diff --git a/raft/node_test.go b/raft/node_test.go
index 41720c498..94414d9e1 100644
--- a/raft/node_test.go
+++ b/raft/node_test.go
@@ -453,9 +453,9 @@ func TestReadyContainUpdates(t *testing.T) {
 		{Ready{}, false},
 		{Ready{SoftState: &SoftState{Lead: 1}}, true},
 		{Ready{HardState: raftpb.HardState{Vote: 1}}, true},
-		{Ready{Entries: make([]raftpb.Entry, 1, 1)}, true},
-		{Ready{CommittedEntries: make([]raftpb.Entry, 1, 1)}, true},
-		{Ready{Messages: make([]raftpb.Message, 1, 1)}, true},
+		{Ready{Entries: make([]raftpb.Entry, 1)}, true},
+		{Ready{CommittedEntries: make([]raftpb.Entry, 1)}, true},
+		{Ready{Messages: make([]raftpb.Message, 1)}, true},
 		{Ready{Snapshot: raftpb.Snapshot{Metadata: raftpb.SnapshotMetadata{Index: 1}}}, true},
 	}
 
diff --git a/tools/functional-tester/etcd-runner/command/global.go b/tools/functional-tester/etcd-runner/command/global.go
index 80b941f7e..38d6de38c 100644
--- a/tools/functional-tester/etcd-runner/command/global.go
+++ b/tools/functional-tester/etcd-runner/command/global.go
@@ -66,7 +66,7 @@ func doRounds(rcs []roundClient, rounds int) {
 	var wg sync.WaitGroup
 
 	wg.Add(len(rcs))
-	finished := make(chan struct{}, 0)
+	finished := make(chan struct{})
 	for i := range rcs {
 		go func(rc *roundClient) {
 			defer wg.Done()