From 23ce3a1acc416a1b1b64731f0b9a2ec03b42db79 Mon Sep 17 00:00:00 2001 From: Gyuho Lee Date: Wed, 11 Apr 2018 19:35:17 -0700 Subject: [PATCH] functional: rename to "listCases" Signed-off-by: Gyuho Lee --- functional/tester/cluster.go | 8 ++++---- functional/tester/cluster_run.go | 4 ++-- functional/tester/cluster_test.go | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/functional/tester/cluster.go b/functional/tester/cluster.go index 5cd863d14..b18084d48 100644 --- a/functional/tester/cluster.go +++ b/functional/tester/cluster.go @@ -263,12 +263,12 @@ func (clus *Cluster) updateCases() { } } -func (clus *Cluster) failureStrings() (fs []string) { - fs = make([]string, len(clus.cases)) +func (clus *Cluster) listCases() (css []string) { + css = make([]string, len(clus.cases)) for i := range clus.cases { - fs[i] = clus.cases[i].Desc() + css[i] = clus.cases[i].Desc() } - return fs + return css } // UpdateDelayLatencyMs updates delay latency with random value diff --git a/functional/tester/cluster_run.go b/functional/tester/cluster_run.go index 6ef47fd90..6dd002106 100644 --- a/functional/tester/cluster_run.go +++ b/functional/tester/cluster_run.go @@ -126,7 +126,7 @@ func (clus *Cluster) doRound() error { zap.Int("round", clus.rd), zap.Int("case", clus.cs), zap.Int("case-total", len(clus.cases)), - zap.Strings("failures", clus.failureStrings()), + zap.Strings("cases", clus.listCases()), ) for i, fa := range clus.cases { clus.cs = i @@ -260,7 +260,7 @@ func (clus *Cluster) doRound() error { clus.lg.Info( "round ALL PASS", zap.Int("round", clus.rd), - zap.Strings("failures", clus.failureStrings()), + zap.Strings("cases", clus.listCases()), zap.Int("case-total", len(clus.cases)), zap.Duration("took", time.Since(roundNow)), ) diff --git a/functional/tester/cluster_test.go b/functional/tester/cluster_test.go index e3ab8a135..dccc36307 100644 --- a/functional/tester/cluster_test.go +++ b/functional/tester/cluster_test.go @@ -260,16 +260,16 @@ func Test_read(t *testing.T) { cfg.lg = logger cfg.updateCases() - fs1 := cfg.failureStrings() + fs1 := cfg.listCases() cfg.shuffleCases() - fs2 := cfg.failureStrings() + fs2 := cfg.listCases() if reflect.DeepEqual(fs1, fs2) { t.Fatalf("expected shuffled failure cases, got %q", fs2) } cfg.shuffleCases() - fs3 := cfg.failureStrings() + fs3 := cfg.listCases() if reflect.DeepEqual(fs2, fs3) { t.Fatalf("expected reshuffled failure cases from %q, got %q", fs2, fs3) }