From 8aa7a3dc091a70279974c7ec4e019e7010b530f2 Mon Sep 17 00:00:00 2001 From: Ted Yu Date: Thu, 16 Jan 2020 17:34:45 -0800 Subject: [PATCH] mvcc: log error if tmpdb is not removed (#11523) Co-authored-by: yutedz <54038175+yutedz@users.noreply.github.com> --- mvcc/backend/backend.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/mvcc/backend/backend.go b/mvcc/backend/backend.go index c1a7ed75f..73a84020f 100644 --- a/mvcc/backend/backend.go +++ b/mvcc/backend/backend.go @@ -391,7 +391,13 @@ func (b *backend) defrag() error { err = defragdb(b.db, tmpdb, defragLimit) if err != nil { tmpdb.Close() - os.RemoveAll(tmpdb.Path()) + if rmErr := os.RemoveAll(tmpdb.Path()); rmErr != nil { + if b.lg != nil { + b.lg.Error("failed to remove dirs under tmpdb", zap.Error(rmErr)) + } else { + plog.Errorf("failed to remove dirs under tmpdb (%s)", rmErr) + } + } return err }