vitalif
/
etcd
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #7853 from gyuho/revert 

Documentation/upgrades: revert KeepAlive interface change
release-3.2
Gyu-Ho Lee 2017-05-03 11:04:15 -07:00 committed by GitHub
parent 24e85b2454 bb42ba5f4e
commit c2d6a92b01
1 changed files with 0 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
Documentation/upgrades/upgrade_3_2.md
View File

@ -30,32 +30,6 @@ resp.TTL == -1
err == nil
```
Previously, `clientv3.Lease.KeepAlive` interface does not return error (see [#7488](https://github.com/coreos/etcd/issues/7488) and [#7732](https://github.com/coreos/etcd/pull/7732)).
Before
```go
// clientv3
type Lease interface {
KeepAlive(ctx context.Context, id LeaseID) (<-chan *LeaseKeepAliveResponse, error)
KeepAliveOnce(ctx context.Context, id LeaseID) (*LeaseKeepAliveResponse, error)
}
```
After
```go
// clientv3
type Lease interface {
KeepAlive(ctx context.Context, id LeaseID) LeaseKeepAliveChan
KeepAliveOnce(ctx context.Context, id LeaseID) LeaseKeepAliveResponse
}
// check error
for ka := range <-LeaseKeepAliveChan { ka.Err }
LeaseKeepAliveResponse.Err
```
### Server upgrade checklists
#### Upgrade requirements