From 6205a9a6cb23fcb60b759aab553f2f53822f8f60 Mon Sep 17 00:00:00 2001 From: sharat Date: Thu, 11 Aug 2016 22:09:25 +0530 Subject: [PATCH] etcdserver: stats/server - refactored removed code duplicacy and improved readability #6160 --- etcdserver/stats/server.go | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/etcdserver/stats/server.go b/etcdserver/stats/server.go index 10849813c..cd450e2d1 100644 --- a/etcdserver/stats/server.go +++ b/etcdserver/stats/server.go @@ -123,17 +123,11 @@ func (ss *ServerStats) SendAppendReq(reqSize int) { ss.Lock() defer ss.Unlock() - now := time.Now() - - if ss.State != raft.StateLeader { - ss.State = raft.StateLeader - ss.LeaderInfo.Name = ss.ID - ss.LeaderInfo.StartTime = now - } + ss.becomeLeader() ss.sendRateQueue.Insert( &RequestStats{ - SendingTime: now, + SendingTime: time.Now(), Size: reqSize, }, ) @@ -144,7 +138,10 @@ func (ss *ServerStats) SendAppendReq(reqSize int) { func (ss *ServerStats) BecomeLeader() { ss.Lock() defer ss.Unlock() + ss.becomeLeader() +} +func (ss *ServerStats) becomeLeader() { if ss.State != raft.StateLeader { ss.State = raft.StateLeader ss.LeaderInfo.Name = ss.ID