etcdserver/etcdhttp: remove closenotify watch

release-2.0
Blake Mizerany 2014-08-27 15:21:45 -07:00 committed by Yicheng Qin
parent 7638acdf37
commit cd3f047ccd
1 changed files with 0 additions and 19 deletions

View File

@ -35,21 +35,6 @@ func (h Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
return
}
// avoid spawing goroutines for requests that are short lived.
if canBlock(rr) {
// cancel the request and release resources associated with it if the
// client closes their connection before we get a response.
if nf, ok := w.(http.CloseNotifier); ok {
go func() {
select {
case <-nf.CloseNotify():
cancel()
case <-ctx.Done():
}
}()
}
}
resp, err := h.Server.Do(ctx, rr)
if err != nil {
// TODO(bmizerany): switch on store errors and etcdserver.ErrUnknownMethod
@ -96,7 +81,3 @@ func encodeResponse(ctx context.Context, w http.ResponseWriter, resp etcdserver.
}
return nil
}
func canBlock(r etcdserver.Request) bool {
return r.Method != "GET" || (r.Method == "GET" && r.Wait)
}