diff --git a/tools/etcd-dump-logs/expectedoutput/decoder_correctoutputformat.output b/tools/etcd-dump-logs/expectedoutput/decoder_correctoutputformat.output index edfbedb90..158139d6b 100644 --- a/tools/etcd-dump-logs/expectedoutput/decoder_correctoutputformat.output +++ b/tools/etcd-dump-logs/expectedoutput/decoder_correctoutputformat.output @@ -1,6 +1,6 @@ Snapshot: empty -Start dupmping log entries from snapshot. +Start dumping log entries from snapshot. WAL metadata: nodeID=0 clusterID=0 term=0 commitIndex=0 vote=0 WAL entries: @@ -26,7 +26,7 @@ term index type data decoder_status decoded_data 12 18 norm ID:13 auth_enable:<> ERROR jhjdcbcejj 13 19 norm ID:14 auth_disable:<> ERROR jhjeiacfjj 14 20 norm ID:15 authenticate: OK jhjfabcfaijajffdgifefafdfeabjhgjfagcgcggffgbfdaajegdfffbfefe - 15 21 norm ID:16 auth_user_add: OK jhajebddjejajefefafdfecaabjegjfagcgcca + 15 21 norm ID:16 auth_user_add: > OK jhajebddajjajefefafdfecaabjegjfagcgccaaajj 16 22 norm ID:17 auth_user_delete: OK jhaaeaddjgjajefefafdfeca 17 23 norm ID:18 auth_user_get: OK jhabfbddjgjajefefafdfeca 18 24 norm ID:19 auth_user_change_password: OK jhacfaddjejajefefafdfecaabjegjfagcgccb @@ -41,4 +41,4 @@ term index type data decoder_status decoded_data 27 33 norm ID:28 auth_role_revoke_permission: OK jhacabdbafjajegbfffcfeccabjcfbfegiaajhgbfafefgfefefefd 27 34 norm ??? ERROR cf -Entry types () count is : 34 \ No newline at end of file +Entry types (Normal,ConfigChange) count is : 34 diff --git a/tools/etcd-dump-logs/expectedoutput/decoder_wrongoutputformat.output b/tools/etcd-dump-logs/expectedoutput/decoder_wrongoutputformat.output index c76b3692b..bcb0c742d 100644 --- a/tools/etcd-dump-logs/expectedoutput/decoder_wrongoutputformat.output +++ b/tools/etcd-dump-logs/expectedoutput/decoder_wrongoutputformat.output @@ -1,6 +1,6 @@ Snapshot: empty -Start dupmping log entries from snapshot. +Start dumping log entries from snapshot. WAL metadata: nodeID=0 clusterID=0 term=0 commitIndex=0 vote=0 WAL entries: @@ -26,7 +26,7 @@ term index type data decoder_status decoded_data 12 18 norm ID:13 auth_enable:<> decoder output format is not right, print output anyway jhjdcbcejj 13 19 norm ID:14 auth_disable:<> decoder output format is not right, print output anyway jhjeiacfjj 14 20 norm ID:15 authenticate: decoder output format is not right, print output anyway jhjfabcfaijajffdgifefafdfeabjhgjfagcgcggffgbfdaajegdfffbfefe - 15 21 norm ID:16 auth_user_add: decoder output format is not right, print output anyway jhajebddjejajefefafdfecaabjegjfagcgcca + 15 21 norm ID:16 auth_user_add: > decoder output format is not right, print output anyway jhajebddajjajefefafdfecaabjegjfagcgccaaajj 16 22 norm ID:17 auth_user_delete: decoder output format is not right, print output anyway jhaaeaddjgjajefefafdfeca 17 23 norm ID:18 auth_user_get: decoder output format is not right, print output anyway jhabfbddjgjajefefafdfeca 18 24 norm ID:19 auth_user_change_password: decoder output format is not right, print output anyway jhacfaddjejajefefafdfecaabjegjfagcgccb @@ -41,4 +41,4 @@ term index type data decoder_status decoded_data 27 33 norm ID:28 auth_role_revoke_permission: decoder output format is not right, print output anyway jhacabdbafjajegbfffcfeccabjcfbfegiaajhgbfafefgfefefefd 27 34 norm ??? decoder output format is not right, print output anyway cf -Entry types () count is : 34 \ No newline at end of file +Entry types (Normal,ConfigChange) count is : 34 diff --git a/tools/etcd-dump-logs/expectedoutput/listAll.output b/tools/etcd-dump-logs/expectedoutput/listAll.output index 2b998c574..fbf57a08f 100644 --- a/tools/etcd-dump-logs/expectedoutput/listAll.output +++ b/tools/etcd-dump-logs/expectedoutput/listAll.output @@ -1,6 +1,6 @@ Snapshot: empty -Start dupmping log entries from snapshot. +Start dumping log entries from snapshot. WAL metadata: nodeID=0 clusterID=0 term=0 commitIndex=0 vote=0 WAL entries: @@ -26,7 +26,7 @@ term index type data 12 18 norm ID:13 auth_enable:<> 13 19 norm ID:14 auth_disable:<> 14 20 norm ID:15 authenticate: - 15 21 norm ID:16 auth_user_add: + 15 21 norm ID:16 auth_user_add: > 16 22 norm ID:17 auth_user_delete: 17 23 norm ID:18 auth_user_get: 18 24 norm ID:19 auth_user_change_password: @@ -41,4 +41,4 @@ term index type data 27 33 norm ID:28 auth_role_revoke_permission: 27 34 norm ??? -Entry types () count is : 34 \ No newline at end of file +Entry types (Normal,ConfigChange) count is : 34 diff --git a/tools/etcd-dump-logs/expectedoutput/listConfigChange.output b/tools/etcd-dump-logs/expectedoutput/listConfigChange.output index c682b5372..1b2dc9ec9 100644 --- a/tools/etcd-dump-logs/expectedoutput/listConfigChange.output +++ b/tools/etcd-dump-logs/expectedoutput/listConfigChange.output @@ -1,6 +1,6 @@ Snapshot: empty -Start dupmping log entries from snapshot. +Start dumping log entries from snapshot. WAL metadata: nodeID=0 clusterID=0 term=0 commitIndex=0 vote=0 WAL entries: @@ -11,4 +11,4 @@ term index type data 2 3 conf method=ConfChangeUpdateNode id=2 2 4 conf method=ConfChangeAddLearnerNode id=3 -Entry types (ConfigChange) count is : 4 \ No newline at end of file +Entry types (ConfigChange) count is : 4 diff --git a/tools/etcd-dump-logs/expectedoutput/listConfigChangeIRRCompaction.output b/tools/etcd-dump-logs/expectedoutput/listConfigChangeIRRCompaction.output index 663f2559f..c262c2e8a 100644 --- a/tools/etcd-dump-logs/expectedoutput/listConfigChangeIRRCompaction.output +++ b/tools/etcd-dump-logs/expectedoutput/listConfigChangeIRRCompaction.output @@ -1,6 +1,6 @@ Snapshot: empty -Start dupmping log entries from snapshot. +Start dumping log entries from snapshot. WAL metadata: nodeID=0 clusterID=0 term=0 commitIndex=0 vote=0 WAL entries: @@ -12,4 +12,4 @@ term index type data 2 4 conf method=ConfChangeAddLearnerNode id=3 8 14 norm ID:9 compaction: -Entry types (ConfigChange,IRRCompaction) count is : 5 \ No newline at end of file +Entry types (ConfigChange,IRRCompaction) count is : 5 diff --git a/tools/etcd-dump-logs/expectedoutput/listIRRCompaction.output b/tools/etcd-dump-logs/expectedoutput/listIRRCompaction.output index ebd826bec..493545884 100644 --- a/tools/etcd-dump-logs/expectedoutput/listIRRCompaction.output +++ b/tools/etcd-dump-logs/expectedoutput/listIRRCompaction.output @@ -1,6 +1,6 @@ Snapshot: empty -Start dupmping log entries from snapshot. +Start dumping log entries from snapshot. WAL metadata: nodeID=0 clusterID=0 term=0 commitIndex=0 vote=0 WAL entries: @@ -8,4 +8,4 @@ lastIndex=34 term index type data 8 14 norm ID:9 compaction: -Entry types (IRRCompaction) count is : 1 \ No newline at end of file +Entry types (IRRCompaction) count is : 1 diff --git a/tools/etcd-dump-logs/expectedoutput/listIRRDeleteRange.output b/tools/etcd-dump-logs/expectedoutput/listIRRDeleteRange.output index b3dec283d..85e71d396 100644 --- a/tools/etcd-dump-logs/expectedoutput/listIRRDeleteRange.output +++ b/tools/etcd-dump-logs/expectedoutput/listIRRDeleteRange.output @@ -1,6 +1,6 @@ Snapshot: empty -Start dupmping log entries from snapshot. +Start dumping log entries from snapshot. WAL metadata: nodeID=0 clusterID=0 term=0 commitIndex=0 vote=0 WAL entries: @@ -8,4 +8,4 @@ lastIndex=34 term index type data 6 12 norm ID:7 delete_range: -Entry types (IRRDeleteRange) count is : 1 \ No newline at end of file +Entry types (IRRDeleteRange) count is : 1 diff --git a/tools/etcd-dump-logs/expectedoutput/listIRRLeaseGrant.output b/tools/etcd-dump-logs/expectedoutput/listIRRLeaseGrant.output index fdc042a0b..5cba3a497 100644 --- a/tools/etcd-dump-logs/expectedoutput/listIRRLeaseGrant.output +++ b/tools/etcd-dump-logs/expectedoutput/listIRRLeaseGrant.output @@ -1,6 +1,6 @@ Snapshot: empty -Start dupmping log entries from snapshot. +Start dumping log entries from snapshot. WAL metadata: nodeID=0 clusterID=0 term=0 commitIndex=0 vote=0 WAL entries: @@ -8,4 +8,4 @@ lastIndex=34 term index type data 9 15 norm ID:10 lease_grant: -Entry types (IRRLeaseGrant) count is : 1 \ No newline at end of file +Entry types (IRRLeaseGrant) count is : 1 diff --git a/tools/etcd-dump-logs/expectedoutput/listIRRLeaseRevoke.output b/tools/etcd-dump-logs/expectedoutput/listIRRLeaseRevoke.output index 0820848d3..d67d05d02 100644 --- a/tools/etcd-dump-logs/expectedoutput/listIRRLeaseRevoke.output +++ b/tools/etcd-dump-logs/expectedoutput/listIRRLeaseRevoke.output @@ -1,6 +1,6 @@ Snapshot: empty -Start dupmping log entries from snapshot. +Start dumping log entries from snapshot. WAL metadata: nodeID=0 clusterID=0 term=0 commitIndex=0 vote=0 WAL entries: @@ -8,4 +8,4 @@ lastIndex=34 term index type data 10 16 norm ID:11 lease_revoke: -Entry types (IRRLeaseRevoke) count is : 1 \ No newline at end of file +Entry types (IRRLeaseRevoke) count is : 1 diff --git a/tools/etcd-dump-logs/expectedoutput/listIRRPut.output b/tools/etcd-dump-logs/expectedoutput/listIRRPut.output index bbda48f23..397ae60c7 100644 --- a/tools/etcd-dump-logs/expectedoutput/listIRRPut.output +++ b/tools/etcd-dump-logs/expectedoutput/listIRRPut.output @@ -1,6 +1,6 @@ Snapshot: empty -Start dupmping log entries from snapshot. +Start dumping log entries from snapshot. WAL metadata: nodeID=0 clusterID=0 term=0 commitIndex=0 vote=0 WAL entries: @@ -8,4 +8,4 @@ lastIndex=34 term index type data 5 11 norm ID:6 put: -Entry types (IRRPut) count is : 1 \ No newline at end of file +Entry types (IRRPut) count is : 1 diff --git a/tools/etcd-dump-logs/expectedoutput/listIRRRange.output b/tools/etcd-dump-logs/expectedoutput/listIRRRange.output index 2a90ab744..422e03749 100644 --- a/tools/etcd-dump-logs/expectedoutput/listIRRRange.output +++ b/tools/etcd-dump-logs/expectedoutput/listIRRRange.output @@ -1,6 +1,6 @@ Snapshot: empty -Start dupmping log entries from snapshot. +Start dumping log entries from snapshot. WAL metadata: nodeID=0 clusterID=0 term=0 commitIndex=0 vote=0 WAL entries: @@ -8,4 +8,4 @@ lastIndex=34 term index type data 4 10 norm ID:5 range: -Entry types (IRRRange) count is : 1 \ No newline at end of file +Entry types (IRRRange) count is : 1 diff --git a/tools/etcd-dump-logs/expectedoutput/listIRRTxn.output b/tools/etcd-dump-logs/expectedoutput/listIRRTxn.output index 3ad761027..92a7d0a26 100644 --- a/tools/etcd-dump-logs/expectedoutput/listIRRTxn.output +++ b/tools/etcd-dump-logs/expectedoutput/listIRRTxn.output @@ -1,6 +1,6 @@ Snapshot: empty -Start dupmping log entries from snapshot. +Start dumping log entries from snapshot. WAL metadata: nodeID=0 clusterID=0 term=0 commitIndex=0 vote=0 WAL entries: @@ -8,4 +8,4 @@ lastIndex=34 term index type data 7 13 norm ID:8 txn: > failure: > > -Entry types (IRRTxn) count is : 1 \ No newline at end of file +Entry types (IRRTxn) count is : 1 diff --git a/tools/etcd-dump-logs/expectedoutput/listInternalRaftRequest.output b/tools/etcd-dump-logs/expectedoutput/listInternalRaftRequest.output index 73728c508..da1ccb9a6 100644 --- a/tools/etcd-dump-logs/expectedoutput/listInternalRaftRequest.output +++ b/tools/etcd-dump-logs/expectedoutput/listInternalRaftRequest.output @@ -1,6 +1,6 @@ Snapshot: empty -Start dupmping log entries from snapshot. +Start dumping log entries from snapshot. WAL metadata: nodeID=0 clusterID=0 term=0 commitIndex=0 vote=0 WAL entries: @@ -17,7 +17,7 @@ term index type data 12 18 norm ID:13 auth_enable:<> 13 19 norm ID:14 auth_disable:<> 14 20 norm ID:15 authenticate: - 15 21 norm ID:16 auth_user_add: + 15 21 norm ID:16 auth_user_add: > 16 22 norm ID:17 auth_user_delete: 17 23 norm ID:18 auth_user_get: 18 24 norm ID:19 auth_user_change_password: @@ -31,4 +31,4 @@ term index type data 26 32 norm ID:27 auth_role_grant_permission: > 27 33 norm ID:28 auth_role_revoke_permission: -Entry types (InternalRaftRequest) count is : 24 \ No newline at end of file +Entry types (InternalRaftRequest) count is : 24 diff --git a/tools/etcd-dump-logs/expectedoutput/listNormal.output b/tools/etcd-dump-logs/expectedoutput/listNormal.output index 1afb89994..60759bca5 100644 --- a/tools/etcd-dump-logs/expectedoutput/listNormal.output +++ b/tools/etcd-dump-logs/expectedoutput/listNormal.output @@ -1,6 +1,6 @@ Snapshot: empty -Start dupmping log entries from snapshot. +Start dumping log entries from snapshot. WAL metadata: nodeID=0 clusterID=0 term=0 commitIndex=0 vote=0 WAL entries: @@ -22,7 +22,7 @@ term index type data 12 18 norm ID:13 auth_enable:<> 13 19 norm ID:14 auth_disable:<> 14 20 norm ID:15 authenticate: - 15 21 norm ID:16 auth_user_add: + 15 21 norm ID:16 auth_user_add: > 16 22 norm ID:17 auth_user_delete: 17 23 norm ID:18 auth_user_get: 18 24 norm ID:19 auth_user_change_password: @@ -37,4 +37,4 @@ term index type data 27 33 norm ID:28 auth_role_revoke_permission: 27 34 norm ??? -Entry types (Normal) count is : 30 \ No newline at end of file +Entry types (Normal) count is : 30 diff --git a/tools/etcd-dump-logs/expectedoutput/listRequest.output b/tools/etcd-dump-logs/expectedoutput/listRequest.output index c64dc4d67..938519ff5 100644 --- a/tools/etcd-dump-logs/expectedoutput/listRequest.output +++ b/tools/etcd-dump-logs/expectedoutput/listRequest.output @@ -1,6 +1,6 @@ Snapshot: empty -Start dupmping log entries from snapshot. +Start dumping log entries from snapshot. WAL metadata: nodeID=0 clusterID=0 term=0 commitIndex=0 vote=0 WAL entries: @@ -12,4 +12,4 @@ term index type data 3 8 norm method=DELETE path="/path3" 3 9 norm method=RANDOM path="/path4/superlong/path/path/path/path/path/path/path/path/path/pa"..."path/path/path/path/path/path/path/path/path/path/path/path/path" val="{\"hey\":\"ho\",\"hi\":[\"yo\"]}" -Entry types (Request) count is : 5 \ No newline at end of file +Entry types (Request) count is : 5 diff --git a/tools/etcd-dump-logs/main.go b/tools/etcd-dump-logs/main.go index b0dfd47c5..8161c8909 100644 --- a/tools/etcd-dump-logs/main.go +++ b/tools/etcd-dump-logs/main.go @@ -38,16 +38,21 @@ import ( "go.uber.org/zap" ) +const ( + defaultEntryTypes string = "Normal,ConfigChange" +) + func main() { snapfile := flag.String("start-snap", "", "The base name of snapshot file to start dumping") index := flag.Uint64("start-index", 0, "The index to start dumping") - entrytype := flag.String("entry-type", "", `If set, filters output by entry type. Must be one or more than one of: - ConfigChange, Normal, Request, InternalRaftRequest, - IRRRange, IRRPut, IRRDeleteRange, IRRTxn, - IRRCompaction, IRRLeaseGrant, IRRLeaseRevoke, IRRLeaseCheckpoint`) + // Default entry types are Normal and ConfigChange + entrytype := flag.String("entry-type", defaultEntryTypes, `If set, filters output by entry type. Must be one or more than one of: +ConfigChange, Normal, Request, InternalRaftRequest, +IRRRange, IRRPut, IRRDeleteRange, IRRTxn, +IRRCompaction, IRRLeaseGrant, IRRLeaseRevoke, IRRLeaseCheckpoint`) streamdecoder := flag.String("stream-decoder", "", `The name of an executable decoding tool, the executable must process - hex encoded lines of binary input (from etcd-dump-logs) - and output a hex encoded line of binary for each input line`) +hex encoded lines of binary input (from etcd-dump-logs) +and output a hex encoded line of binary for each input line`) flag.Parse() @@ -279,12 +284,6 @@ func evaluateEntrytypeFlag(entrytype string) []EntryFilter { "IRRLeaseCheckpoint": {passIRRLeaseCheckpoint}, } filters := make([]EntryFilter, 0) - if len(entrytypelist) == 0 { - filters = append(filters, passInternalRaftRequest) - filters = append(filters, passRequest) - filters = append(filters, passUnknownNormal) - filters = append(filters, passConfChange) - } for _, et := range entrytypelist { if f, ok := validRequest[et]; ok { filters = append(filters, f...) @@ -373,7 +372,7 @@ func listEntriesType(entrytype string, streamdecoder string, ents []raftpb.Entry } } - fmt.Printf("\nEntry types (%s) count is : %d", entrytype, cnt) + fmt.Printf("\nEntry types (%s) count is : %d\n", entrytype, cnt) } func parseDecoderOutput(decoderoutput string) (string, string) {