diff --git a/clientv3/concurrency/key.go b/clientv3/concurrency/key.go index f2c6a3329..43290a219 100644 --- a/clientv3/concurrency/key.go +++ b/clientv3/concurrency/key.go @@ -45,16 +45,6 @@ func NewUniqueKV(ctx context.Context, kv v3.KV, pfx, val string, opts ...v3.OpOp } } -func waitUpdate(ctx context.Context, client *v3.Client, key string, opts ...v3.OpOption) error { - cctx, cancel := context.WithCancel(ctx) - defer cancel() - wresp, ok := <-client.Watch(cctx, key, opts...) - if !ok { - return ctx.Err() - } - return wresp.Err() -} - func waitDelete(ctx context.Context, client *v3.Client, key string, rev int64) error { cctx, cancel := context.WithCancel(ctx) defer cancel() diff --git a/contrib/systemd/etcd2-backup-coreos/etcd2-restore.go b/contrib/systemd/etcd2-backup-coreos/etcd2-restore.go index 892d6f050..1c01841a7 100644 --- a/contrib/systemd/etcd2-backup-coreos/etcd2-restore.go +++ b/contrib/systemd/etcd2-backup-coreos/etcd2-restore.go @@ -81,9 +81,11 @@ func restoreEtcd() error { return runCommands(10, 2*time.Second) } -var clusterHealthRegex = regexp.MustCompile(".*cluster is healthy.*") -var lineSplit = regexp.MustCompile("\n+") -var colonSplit = regexp.MustCompile("\\:") +var ( + clusterHealthRegex = regexp.MustCompile(".*cluster is healthy.*") + lineSplit = regexp.MustCompile("\n+") + colonSplit = regexp.MustCompile(`\:`) +) func runCommands(maxRetry int, interval time.Duration) error { var retryCnt int diff --git a/etcdctl/ctlv2/command/cluster_health.go b/etcdctl/ctlv2/command/cluster_health.go index 954bb0f08..a03dd5050 100644 --- a/etcdctl/ctlv2/command/cluster_health.go +++ b/etcdctl/ctlv2/command/cluster_health.go @@ -104,7 +104,7 @@ func handleClusterHealth(c *cli.Context) { } checked = true - if result.Health == "true" || nresult.Health == true { + if result.Health == "true" || nresult.Health { health = true fmt.Printf("member %s is healthy: got healthy result from %s\n", m.ID, url) } else { diff --git a/etcdctl/ctlv2/command/util.go b/etcdctl/ctlv2/command/util.go index 34e2373f8..8164e5be7 100644 --- a/etcdctl/ctlv2/command/util.go +++ b/etcdctl/ctlv2/command/util.go @@ -42,18 +42,6 @@ var ( defaultDialTimeout = 30 * time.Second ) -// trimsplit slices s into all substrings separated by sep and returns a -// slice of the substrings between the separator with all leading and trailing -// white space removed, as defined by Unicode. -func trimsplit(s, sep string) []string { - raw := strings.Split(s, ",") - trimmed := make([]string, 0) - for _, r := range raw { - trimmed = append(trimmed, strings.TrimSpace(r)) - } - return trimmed -} - func argOrStdin(args []string, stdin io.Reader, i int) (string, error) { if i < len(args) { return args[i], nil diff --git a/etcdctl/ctlv3/command/member_command.go b/etcdctl/ctlv3/command/member_command.go index 8a2b97712..0edc1a768 100644 --- a/etcdctl/ctlv3/command/member_command.go +++ b/etcdctl/ctlv3/command/member_command.go @@ -22,10 +22,7 @@ import ( "github.com/spf13/cobra" ) -var ( - memberID uint64 - memberPeerURLs string -) +var memberPeerURLs string // NewMemberCommand returns the cobra command for "member". func NewMemberCommand() *cobra.Command { diff --git a/etcdserver/auth/auth_test.go b/etcdserver/auth/auth_test.go index 3014f573d..a28a98948 100644 --- a/etcdserver/auth/auth_test.go +++ b/etcdserver/auth/auth_test.go @@ -416,7 +416,7 @@ func TestCreateAndUpdateUser(t *testing.T) { s := store{server: d, timeout: testTimeout, ensuredOnce: true, PasswordStore: fastPasswordStore{}} out, created, err := s.CreateOrUpdateUser(user) - if created == false { + if !created { t.Error("Should have created user, instead updated?") } if err != nil { @@ -427,7 +427,7 @@ func TestCreateAndUpdateUser(t *testing.T) { t.Error("UpdateUser doesn't match given update. Got", out, "expected", expected) } out, created, err = s.CreateOrUpdateUser(update) - if created == true { + if created { t.Error("Should have updated user, instead created?") } if err != nil { @@ -572,6 +572,7 @@ func TestEnableAuth(t *testing.T) { t.Error("Unexpected error", err) } } + func TestDisableAuth(t *testing.T) { trueval := "true" falseval := "false" diff --git a/etcdserver/membership/cluster.go b/etcdserver/membership/cluster.go index 52fd821c4..eb970566f 100644 --- a/etcdserver/membership/cluster.go +++ b/etcdserver/membership/cluster.go @@ -144,9 +144,7 @@ func (c *RaftCluster) PeerURLs() []string { defer c.Unlock() urls := make([]string, 0) for _, p := range c.members { - for _, addr := range p.PeerURLs { - urls = append(urls, addr) - } + urls = append(urls, p.PeerURLs...) } sort.Strings(urls) return urls @@ -159,9 +157,7 @@ func (c *RaftCluster) ClientURLs() []string { defer c.Unlock() urls := make([]string, 0) for _, p := range c.members { - for _, url := range p.ClientURLs { - urls = append(urls, url) - } + urls = append(urls, p.ClientURLs...) } sort.Strings(urls) return urls diff --git a/etcdserver/stats/queue.go b/etcdserver/stats/queue.go index aa8d36e54..838a30f3b 100644 --- a/etcdserver/stats/queue.go +++ b/etcdserver/stats/queue.go @@ -85,7 +85,7 @@ func (q *statsQueue) Rate() (float64, float64) { return 0, 0 } - if time.Now().Sub(back.SendingTime) > time.Second { + if time.Since(back.SendingTime) > time.Second { q.Clear() return 0, 0 } diff --git a/etcdserver/stats/server.go b/etcdserver/stats/server.go index 84065985d..8e2e7701d 100644 --- a/etcdserver/stats/server.go +++ b/etcdserver/stats/server.go @@ -57,7 +57,7 @@ func (ss *ServerStats) JSON() []byte { ss.Lock() stats := *ss ss.Unlock() - stats.LeaderInfo.Uptime = time.Now().Sub(stats.LeaderInfo.StartTime).String() + stats.LeaderInfo.Uptime = time.Since(stats.LeaderInfo.StartTime).String() stats.SendingPkgRate, stats.SendingBandwidthRate = stats.SendRates() stats.RecvingPkgRate, stats.RecvingBandwidthRate = stats.RecvRates() b, err := json.Marshal(stats) diff --git a/pkg/testutil/leak.go b/pkg/testutil/leak.go index 79b8b2db4..0f2ee559f 100644 --- a/pkg/testutil/leak.go +++ b/pkg/testutil/leak.go @@ -48,7 +48,7 @@ func CheckLeakedGoroutine() bool { } stackCount := make(map[string]int) - re := regexp.MustCompile("\\(0[0-9a-fx, ]*\\)") + re := regexp.MustCompile(`\(0[0-9a-fx, ]*\)`) for _, g := range gs { // strip out pointer arguments in first function of stack dump normalized := string(re.ReplaceAll([]byte(g), []byte("(...)"))) diff --git a/storage/kvstore.go b/storage/kvstore.go index e9fceb7da..fc4beec7b 100644 --- a/storage/kvstore.go +++ b/storage/kvstore.go @@ -289,7 +289,7 @@ func (s *store) Compact(rev int64) (<-chan struct{}, error) { s.fifoSched.Schedule(j) - indexCompactionPauseDurations.Observe(float64(time.Now().Sub(start) / time.Millisecond)) + indexCompactionPauseDurations.Observe(float64(time.Since(start) / time.Millisecond)) return ch, nil } diff --git a/storage/kvstore_compaction.go b/storage/kvstore_compaction.go index a7b9cc8ad..4f3c083db 100644 --- a/storage/kvstore_compaction.go +++ b/storage/kvstore_compaction.go @@ -21,7 +21,7 @@ import ( func (s *store) scheduleCompaction(compactMainRev int64, keep map[revision]struct{}) bool { totalStart := time.Now() - defer dbCompactionTotalDurations.Observe(float64(time.Now().Sub(totalStart) / time.Millisecond)) + defer dbCompactionTotalDurations.Observe(float64(time.Since(totalStart) / time.Millisecond)) end := make([]byte, 8) binary.BigEndian.PutUint64(end, uint64(compactMainRev+1)) @@ -54,7 +54,7 @@ func (s *store) scheduleCompaction(compactMainRev int64, keep map[revision]struc // update last revToBytes(revision{main: rev.main, sub: rev.sub + 1}, last) tx.Unlock() - dbCompactionPauseDurations.Observe(float64(time.Now().Sub(start) / time.Millisecond)) + dbCompactionPauseDurations.Observe(float64(time.Since(start) / time.Millisecond)) select { case <-time.After(100 * time.Millisecond): diff --git a/store/event_history.go b/store/event_history.go index 5bd967ead..a96437c98 100644 --- a/store/event_history.go +++ b/store/event_history.go @@ -117,10 +117,7 @@ func (eh *EventHistory) clone() *EventHistory { Back: eh.Queue.Back, } - for i, e := range eh.Queue.Events { - clonedQueue.Events[i] = e - } - + copy(clonedQueue.Events, eh.Queue.Events) return &EventHistory{ StartIndex: eh.StartIndex, Queue: clonedQueue, diff --git a/store/store.go b/store/store.go index 3a4ec0df4..00ca3e810 100644 --- a/store/store.go +++ b/store/store.go @@ -345,7 +345,7 @@ func (s *store) Delete(nodePath string, dir, recursive bool) (*Event, error) { } // recursive implies dir - if recursive == true { + if recursive { dir = true }