Commit Graph

19863 Commits (master)

Author SHA1 Message Date
Marek Siarkowicz 2d9aeec91f
Merge pull request #15645 from serathius/tests-cleanup-alternative-binaries
tests/framework: Cleanup alternative binaries in e2e tests
2023-04-06 07:33:17 +02:00
Marek Siarkowicz 99df35e69b
Merge pull request #15644 from serathius/robustness-etcdctl-provided
tests/robustness: Ensure that etcdctl binary is provided
2023-04-06 07:32:01 +02:00
Marek Siarkowicz 540d012e5e tests/robustness: Ensure that etcdctl binary is provided
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-05 23:04:20 +02:00
Marek Siarkowicz 1e41d95ab2 tests/robustness: Document analysing watch issue
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-05 22:40:47 +02:00
Marek Siarkowicz 651873cf7b tests/framework: Cleanup alternative binaries in e2e tests
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-05 15:32:31 +02:00
Marek Siarkowicz f6bb874298
Merge pull request #15237 from scpmw/guarantee_progress_notify_order
etcdserver: Send requested progress notifications through watchStream (fix #15220)
2023-04-05 13:49:41 +02:00
Peter Wortmann 74feb229c7 etcdserver: Guarantee order of requested progress notifications
Progress notifications requested using ProgressRequest were sent
directly using the ctrlStream, which means that they could race
against watch responses in the watchStream.

This would especially happen when the stream was not synced - e.g. if
you requested a progress notification on a freshly created unsynced
watcher, the notification would typically arrive indicating a revision
for which not all watch responses had been sent.

This changes the behaviour so that v3rpc always goes through the watch
stream, using a new RequestProgressAll function that closely matches
the behaviour of the v3rpc code - i.e.

1. Generate a message with WatchId -1, indicating the revision for
   *all* watchers in the stream

2. Guarantee that a response is (eventually) sent

The latter might require us to defer the response until all watchers
are synced, which is likely as it should be. Note that we do *not*
guarantee that the number of progress notifications matches the number
of requests, only that eventually at least one gets sent.

Signed-off-by: Peter Wortmann <peter.wortmann@skao.int>
2023-04-05 11:54:10 +01:00
Peter Wortmann 42a2643df9 tests/robustness: Reproduce issue #15220
This issue is somewhat easily reproduced simply by bombarding the
server with requests for progress notifications, which eventually
leads to one being delivered ahead of the payload message. This is
then caught by the watch response validation code previously added by
Marek Siarkowicz.

Signed-off-by: Peter Wortmann <peter.wortmann@skao.int>
2023-04-05 11:23:02 +01:00
Peter Wortmann af25936fb7 tests/integration: Demonstrate manual progress notification race
This will fail basically every time, as the progress notification
request catches the watcher in an asynchronised state.

Signed-off-by: Peter Wortmann <peter.wortmann@skao.int>
2023-04-05 11:19:07 +01:00
Marek Siarkowicz b504ac1840
Merge pull request #15593 from serathius/community-membership
Move to community membership model closer to kubernetes one
2023-04-05 12:11:31 +02:00
Marek Siarkowicz 9b58269298
Merge pull request #15642 from serathius/robustness-detect-trigger-timeout
tests/robustness: Detect trigger timeout and exit
2023-04-05 10:48:18 +02:00
Benjamin Wang 29a8b56cf2
Merge pull request #15641 from mitake/changelog-15294
changelog: add items to cover 15294
2023-04-05 08:26:08 +08:00
Marek Siarkowicz 5bae6b1e44 tests/robustness: Detect trigger timeout and exit
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-04 15:23:58 +02:00
Hitoshi Mitake aaf8919a19 changelog: add items to cover 15294
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
2023-04-04 21:56:46 +09:00
Lanre Adelowo 386aedef51
[WIP]server/auth:fix panic on identical JWT token generation and auth
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2023-04-04 18:01:55 +05:30
Marek Siarkowicz f9d124974b
Merge pull request #15604 from jmhbnz/robustness-ensure-healthy-clus
tests: Ensure healthy cluster before and after robustness failpoint
2023-04-04 14:22:52 +02:00
James Blair 1227754284 Cancel watch if cluster not healthy before or after injecting failpoints.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-04-04 13:58:17 +02:00
Marek Siarkowicz 05e2910f15
Merge pull request #15633 from serathius/robustness-enforce-timeout
tests: Enfoce timeout on failpoints
2023-04-04 13:27:03 +02:00
Marek Siarkowicz 6582e349db tests: Enfoce timeout on failpoints
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-04 12:25:07 +02:00
Marek Siarkowicz 523f235c82
Merge pull request #15603 from serathius/robustness-finish-with-success
tests: Ensure that operation history finishes with successful request
2023-04-04 12:03:36 +02:00
Benjamin Wang 32acc662c9
Merge pull request #15638 from ahrtr/dependency_20230404
Bump some dependencies
2023-04-04 17:11:26 +08:00
Marek Siarkowicz 6a5d326519 tests: Ensure that operation history finishes with successful request
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-04 09:40:17 +02:00
Marek Siarkowicz 5e0119eadc
Merge pull request #15636 from lavacat/main-test-watch-delay
tests: increase maxWatchDelay to prevent flaky TestWatchDelay*
2023-04-04 09:38:03 +02:00
Marek Siarkowicz 138fae6246
Merge pull request #15632 from serathius/fix-comparing-etcd-version
tests: Fix comparing etcd version
2023-04-04 09:34:55 +02:00
Marek Siarkowicz 8b6bf90c0d
Merge pull request #15580 from chaochn47/fix_flaking_auth_member_remove_test
fix flaking auth member remove test
2023-04-04 09:34:16 +02:00
Marek Siarkowicz 4fab20aa75
Merge pull request #15618 from serathius/robustness-fix-periodic-etcd-version
tests: Fix building incorrect etcd version and make switch strict
2023-04-04 09:30:20 +02:00
Benjamin Wang 072c5cb5da dependency: bump google.golang.org/protobuf from 1.28.1 to 1.30.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-04 15:28:09 +08:00
Benjamin Wang 56284d5dfe dependency: bump github.com/golang/protobuf from 1.5.2 to 1.5.3
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-04 15:21:22 +08:00
Benjamin Wang 0c66fc9f29 dependency: bump go.uber.org/multierr from 1.9.0 to 1.11.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-04 15:15:32 +08:00
Bogdan Kanivets 757910958e tests: increase maxWatchDelay to prevent flaky TestWatchDelay*
value is selected empirically after spot checking some logs of flaky workflows

fixes: https://github.com/etcd-io/etcd/issues/15634
Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
2023-04-03 21:49:36 -07:00
Chao Chen caed563e08 fix flaking auth member remove test
Signed-off-by: Chao Chen <chaochn@amazon.com>
2023-04-03 17:41:08 -07:00
Marek Siarkowicz 69afcd1960 tests: Fix comparing etcd version
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-03 21:13:36 +02:00
Marek Siarkowicz b4c1fb14e3 Move to community membership model closer to kubernetes one
Based on https://github.com/kubernetes/community/blob/master/community-membership.md

Changes:
* Extracted contributor membership to separate file
* Provide more detailed requirements for each role. Base maintainers on
  kubernetes subproject owners.
* Introduction of member role

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-03 16:42:01 +02:00
Marek Siarkowicz 6f4e5f316e
Merge pull request #15592 from serathius/cleanup-endpoints
tests: Cleanup endpoints
2023-04-03 16:00:44 +02:00
Marek Siarkowicz 9c72ecb1f9 tests: Fix building incorrect etcd version and make switch strict
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-03 15:06:10 +02:00
Marek Siarkowicz 204892a0f8
Merge pull request #15616 from ahrtr/fix_typo_20230403
test: fix typo in robustness test
2023-04-03 14:22:17 +02:00
Benjamin Wang e57dcd5ceb test: fix typo in robustness test
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-03 18:46:32 +08:00
Marek Siarkowicz 0cbd56e8b6 tests: Cleanup endpoints
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-03 12:18:54 +02:00
Marek Siarkowicz 7c7f636aea
Merge pull request #15615 from serathius/robustness-snapshot-older-version
tests/robustness: Support running snapshot tests on older versions
2023-04-03 12:13:01 +02:00
Marek Siarkowicz 029315f57e tests/robustness: Support running snapshot tests on older versions
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-03 10:43:06 +02:00
Hitoshi Mitake 4da39e4b1e
Merge pull request #15294 from mitake/range-check
server/auth: disallow creating empty permission ranges
2023-04-03 09:03:50 +09:00
Marek Siarkowicz a1bd154cb4
Merge pull request #15610 from serathius/robustness-fix-blackhole
Robustness fix blackhole
2023-04-02 19:34:09 +02:00
Benjamin Wang 5d53c83d61
Merge pull request #15614 from zhangguanzhang/changelog-3.5
CHANGELOG: add item into 3.5
2023-04-02 18:58:53 +08:00
zhangguanzhang 2d9d6bdbca CHANGELOG: add item into 3.5
Signed-off-by: zhangguanzhang <zhangguanzhang@qq.com>
2023-04-02 18:05:56 +08:00
Marek Siarkowicz 03214c0239 Revert "tests/robustness: Disable testing network blackhole until #15595 is fixed"
This reverts commit 013e25fab9.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-01 16:32:20 +02:00
Marek Siarkowicz 71ba0873e3 tests/robustness: Encrypt peer traffic to prevent proxy manipulating packets
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-01 16:31:53 +02:00
Benjamin Wang 5f99ffdba1
Merge pull request #15607 from etcd-io/dependabot/github_actions/ossf/scorecard-action-2.1.3
build(deps): bump ossf/scorecard-action from 2.1.2 to 2.1.3
2023-04-01 16:50:08 +08:00
dependabot[bot] 38b7406eb7
build(deps): bump ossf/scorecard-action from 2.1.2 to 2.1.3
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.2 to 2.1.3.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](e38b1902ae...80e868c13c)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-01 07:02:49 +00:00
Marek Siarkowicz d0cd94a520
Merge pull request #15561 from serathius/makefile-entrypoint
Use makefile as entrypoint in CI
2023-04-01 09:02:09 +02:00
Marek Siarkowicz 6a995d2d63
Merge pull request #15602 from tangwz/fix_raftexample_link
contrib/raftexample: fix raftexample README's raft library link.
2023-03-31 16:00:30 +02:00