Anthony Romano
6464574952
netutil: don't resolve unix socket URLs when comparing URLs
...
Was causing VerifyBootstrap() to hang on unix peers.
2017-08-17 19:58:24 -07:00
Gyu-Ho Lee
195744aea6
pkg/flags: warns on shadowed environment variable flags
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-08-09 15:58:48 -07:00
Anthony Romano
e9a7f3551b
Merge pull request #8281 from heyitsanthony/san-rdns
...
transport: use reverse lookup to match wildcard DNS SAN
2017-07-22 08:02:57 -07:00
Anthony Romano
b1aa962233
transport: use reverse lookup to match wildcard DNS SAN
...
Fixes #8268
2017-07-21 16:43:25 -07:00
Anthony Romano
426ad25924
transport: include InsecureSkipVerify in TLSInfo
...
Some functions take a TLSInfo to generate a tls.Config and there was no
way to force the InsecureSkipVerify flag.
2017-07-21 11:00:22 -07:00
Anthony Romano
bb42d2b40e
testutil: whitelist os.(*file).close
...
Leak detector is catching goroutines trying to close files which appear
runtime related:
1 instances of:
syscall.Syscall(...)
/usr/local/golang/1.8.3/go/src/syscall/asm_linux_386.s:20 +0x5
syscall.Close(...)
/usr/local/golang/1.8.3/go/src/syscall/zsyscall_linux_386.go:296 +0x3d
os.(*file).close(...)
/usr/local/golang/1.8.3/go/src/os/file_unix.go:140 +0x62
It's unlikely a user goroutine will leak on file close; whitelist it.
2017-07-19 13:28:15 -07:00
Anthony Romano
026e05518e
testutil: whitelist WaitGroup.Done
...
Calling a WaitGroup.Done() in a defer will sometimes trigger the leak
detector since the WaitGroup.Wait() will unblock before the defer
block completes. If the leak detector runs before the Done() is
rescheduled, it will spuriously report the finishing Done() as a leak.
This happens enough in CI to be irritating; whitelist it and ignore.
2017-07-12 14:04:24 -07:00
Anthony Romano
ab95eb0795
transport: accept connection if matched IP SAN but no DNS match
...
The IP SAN check would always do a DNS SAN check if DNS is given
and the connection's IP is verified. Instead, don't check DNS
entries if there's a matching iP.
Fixes #8206
2017-07-06 16:11:53 -07:00
Anthony Romano
5c7efaa288
adt: Union for interval trees
2017-06-21 14:33:15 -07:00
Anthony Romano
322976bedc
transport: CRL checking
2017-06-19 15:23:41 -07:00
Anthony Romano
a36d62a30c
Merge pull request #8049 from heyitsanthony/flock-base-test
...
fileutil: test some fallback functionality
2017-06-07 16:12:38 -07:00
Anthony Romano
c3fcf0f339
fileutil: test some fallback functionality
...
syscall.Flock fallback and preallocExtendTrunc
2017-06-07 11:22:40 -07:00
Anthony Romano
87a3c87e45
fileutil: return immediately if preallocating 0 bytes
...
fallocate will return EINVAL, causing zeroing to the end of a
0 byte file to fail.
Fixes #8045
2017-06-07 09:57:14 -07:00
Anthony Romano
88a3bb74b3
test, osutil: disable setting SIG_DFL on linux if built with cov tag
...
Was causing etcd to terminate before finishing writing its
coverage profile.
2017-06-05 21:09:35 -07:00
Gyu-Ho Lee
d690634bd6
*: remove unused, fix typos
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-05-18 12:11:18 -07:00
Anthony Romano
a6a1eb8378
Merge pull request #7949 from heyitsanthony/godocs
...
*: fill out missing package godocs
2017-05-18 10:23:26 -07:00
Anthony Romano
33c375dc44
*: fill out blank package godocs
...
Mostly one-liner short descriptions, but also includes some typo fixes
and some examples.
2017-05-18 09:41:13 -07:00
Anthony Romano
c09f0ca9d4
report: add NewWeightedReport
...
Reports with weighted results.
2017-05-17 16:07:20 -07:00
Gyu-Ho Lee
fba225cee5
pkg/osutil: fix missing 'syscall' import
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-05-15 14:11:54 -07:00
Anthony Romano
74fd7709ad
Merge pull request #7904 from heyitsanthony/osutil-exit
...
osutil: force SIG_DFL before resending terminating signal
2017-05-15 12:14:37 -07:00
Anthony Romano
6ce9aed8c5
Merge pull request #7881 from heyitsanthony/testctl-logging
...
e2e: more debugging output for lock and elect tests
2017-05-12 12:01:08 -07:00
Anthony Romano
7a1739a3e8
osutil: force SIG_DFL before resending terminating signal
...
The go runtime won't always reinstall the default signal handler on the
SIGTERM path, so it's possible the signal won't terminate the process.
Instead, force SIG_DFL for the signal.
2017-05-12 11:56:27 -07:00
Anthony Romano
90893735cf
Merge pull request #7917 from heyitsanthony/refactor-backend-paths
...
snap, etcdserver: tighten up snapshot path handling
2017-05-12 09:33:37 -07:00
Anthony Romano
71d7c85b6b
expect: reload DEBUG_EXPECT for each process
...
Lets e2e test cases selectively turn on expect debugging to get
full application output written to stdout.
2017-05-11 16:09:31 -07:00
Anthony Romano
f6cd4d4f5b
snap, etcdserver: tighten up snapshot path handling
...
Computing the snapshot file path is error prone; snapshot recovery was
constructing file paths missing a path separator so the snapshot
would never be loaded. Instead, refactor the backend path handling
to use helper functions where possible.
2017-05-11 13:46:59 -07:00
Gyu-Ho Lee
3505c254e1
pkg/srv: fix error checks from resolveTCPAddr
...
So that 'terr' can be returned later.
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-05-11 10:53:03 -07:00
Anthony Romano
07ad18178d
pkg/srv: package for SRV utilities
...
Trying to decouple the v2 client from SRV code. Can't move
into discovery/ since that creates a circular dependency. So,
give up and move all the SRV code into a new package.
2017-05-05 09:27:59 -07:00
Gyu-Ho Lee
747993de08
Merge pull request #7829 from gyuho/certs
...
pkg/transport: reload TLS certificates for every client requests
2017-04-27 14:36:53 -07:00
Xiang Li
d818ef2c76
pkg/wait: add comment and make List private
2017-04-27 13:25:02 -07:00
Tony Grosinger
4e21f87e3d
pkg/transport: reload TLS certificates for every client requests
...
This changes the baseConfig used when creating tls Configs to utilize
the GetCertificate and GetClientCertificate functions to always reload
the certificates from disk whenever they are needed.
Always reloading the certificates allows changing the certificates via
an external process without interrupting etcd.
Fixes #7576
Cherry-picked by Gyu-Ho Lee <gyuhox@gmail.com>
Original commit can be found at https://github.com/coreos/etcd/pull/7784
2017-04-27 11:22:03 -07:00
Anthony Romano
6f06e1cb47
testutil: add assert functions
2017-04-22 20:29:58 -07:00
Anthony Romano
91039bef7c
Merge pull request #7799 from heyitsanthony/ctxize-resolve
...
netutil: use "context" and ctx-ize TCP addr resolution
2017-04-21 16:30:32 -07:00
Anthony Romano
14d6ed9e5f
*: clear redundant return statement warnings (S1027)
2017-04-21 14:01:00 -07:00
Anthony Romano
85e87e8f6b
netutil: use "context" and ctx-ize TCP addr resolution
2017-04-21 10:01:53 -07:00
Anthony Romano
8fa4b8da6e
Merge pull request #7767 from heyitsanthony/transport-resolve-dnsnames
...
transport: resolve DNSNames when SAN checking
2017-04-18 17:28:01 -07:00
Anthony Romano
05582ad5b2
transport: resolve DNSNames when SAN checking
...
The current transport client TLS checking will pass an IP address into
VerifyHostnames if there is DNSNames SAN. However, the go runtime will
not resolve the DNS names to match the client IP. Intead, resolve the
names when checking.
2017-04-18 13:21:26 -07:00
Gyu-Ho Lee
5161b74799
pkg/debugutil: add 'mutex' profiler (Go 1.8+)
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-04-18 10:56:06 -07:00
Gyu-Ho Lee
8aaa1ed911
*: use '*tls.Config.Clone' in Go 1.8
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-04-17 20:08:27 -07:00
Anthony Romano
1153e1e7d9
Merge pull request #7687 from heyitsanthony/deny-tls-ipsan
...
transport: deny incoming peer certs with wrong IP SAN
2017-04-13 15:03:25 -07:00
Gyu-Ho Lee
8ce579aac9
pkg/transport: add 'IsClosedConnError'
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-04-13 11:55:18 -07:00
Anthony Romano
33a0496b5e
report: add test for Report interface
2017-04-12 16:41:32 -07:00
Anthony Romano
70a9929b5d
transport: use actual certs for listener tests
2017-04-12 13:41:33 -07:00
Anthony Romano
cad1215b18
*: deny incoming peer certs with wrong IP SAN
2017-04-12 13:41:33 -07:00
Anthony Romano
88d4e7ebeb
netutil: fix unused err staticcheck failure
...
Clears SA4006
2017-04-07 10:52:54 -07:00
Anthony Romano
d42c1f5131
Merge pull request #7646 from andelf/fix-unix-socket-url
...
*: fix a bug in handling unix socket urls
2017-04-05 09:24:38 -07:00
Gyu-Ho Lee
43f795a485
Merge pull request #7659 from gyuho/aaa
...
pkg/transport: remove port in Certificate.IPAddresses
2017-04-05 04:29:44 -07:00
andelf
4f27981c46
*: fix a bug in handling unix socket urls
...
Now use url.Host + url.Path as unix socket path
Fixes #7644
2017-04-05 14:33:13 +08:00
Hitoshi Mitake
c4a45c5713
auth, adt: introduce a new type BytesAffineComparable
...
It will be useful for avoiding a cost of casting from string to
[]byte. The permission checker is the first user of the type.
2017-04-05 13:17:24 +09:00
Gyu-Ho Lee
8a7a548a6d
pkg/transport: remove port in Certificate.IPAddresses
...
etcd passes 'url.URL.Host' to 'SelfCert' which contains
client, peer port. 'net.ParseIP("127.0.0.1:2379")' returns
'nil', and the client on this self-cert will see errors
of '127.0.0.1 because it doesn't contain any IP SANs'
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-04-04 09:44:59 -07:00
Xiang Li
972d8c55ab
Merge pull request #7653 from xiang90/pprof
...
*: add pprof flag to grpc proxy
2017-04-04 09:22:50 -07:00
Xiang
fd5984af56
*: add pprof flag to grpc proxy
2017-04-03 22:07:17 -07:00
Anthony Romano
f67bdc2eed
*: support checking that an interval tree's keys cover an entire interval
2017-04-03 15:38:07 -07:00
Peng Gao
d204b6c3b7
idgen: correct comments for id generator
...
Comments for id generator format is out of
date, correct it.
Fixes #7636
Signed-off-by: Peng Gao <peng.gao.dut@gmail.com>
2017-04-02 20:56:10 +08:00
Anthony Romano
997e83f8ea
testutil: check for grpc resources in AfterTest
...
gRPC leaks only show up at the final leak check, making it difficult to
determine which test is causing the leak.
2017-03-24 16:09:38 -07:00
Anthony Romano
25e3ce1feb
adt: Visit() interval trees in sorted order and terminate early
...
For all intervals [x, y), Visit will visit intervals in ascending order
sorted by x. Also fixes a bug where Visit would not terminate the search
when requested by the visitor function.
2017-03-23 00:02:29 -07:00
Gyu-Ho Lee
27550b229a
Merge pull request #7545 from gyuho/go1.7-go1.8
...
*: use 'io.Seek*' for go1.7+
2017-03-20 16:31:21 -07:00
Gyu-Ho Lee
aca2abd8fe
*: use 'io.Seek*' for go1.7+
...
For https://github.com/coreos/etcd/issues/6174 .
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-03-20 15:15:24 -07:00
Anthony Romano
ae7b4ee8ed
*: fix gosimple warning for fmt.Sprintf("%s")
2017-03-20 13:26:39 -07:00
Anthony Romano
2f1542c06d
*: use filepath.Join for files
2017-03-16 07:46:06 -07:00
Anthony Romano
eb6a47f87e
testutil: add CheckAfterTest for calling AfterTest without a testing.T
2017-03-10 12:18:24 -08:00
Gyu-Ho Lee
beb58c434c
*: fix minor typos
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-03-08 16:21:52 -08:00
Gyu-Ho Lee
3d75395875
*: remove never-unused vars, minor lint fix
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-03-06 14:59:12 -08:00
Anthony Romano
f97a077257
netutil: use ipv4 host by default
...
Was non-deterministic.
2017-02-21 20:11:35 -08:00
David Cheney
9b84127739
pkg/transport: remove dependency on pkg/fileutils
...
4a0f922
changed SelfCert to use a helper from pkg/fileutils which
introduced a transitive dependency on coreos/pkg/capnslog. This means
anyone who imports pkg/transport to use TLS with the clientv3 library
has the default stdlib logger hijacked by capnslog.
This PR reverts 4a0f922
. There are no tests because 4a0f922
contained no
test and was not attached to a PR.
Fixes #7350
2017-02-20 12:32:04 +11:00
fanmin shi
07129a6370
*: add and expose StopSignal field in ExpectProcess
...
add and expose StopSignal to ExpectProcess allows user
to define what signal to send on ExpectProcess.close()
coverage testing code sets StopSignal to SIGTERM allowing
the test binary to shutdown gracefully so that it can generate
a coverage report.
2017-02-17 14:47:06 -08:00
fanmin shi
1d521556ae
e2e: modify e2e to run code coverage
2017-02-15 09:51:50 -08:00
Gyu-Ho Lee
950a9da9d9
pkg/report: add min/max latency per second
...
For https://github.com/coreos/dbtester/issues/221 .
2017-02-04 12:46:54 -08:00
Gyu-Ho Lee
01a1dae7ae
pkg/netutil: name GetDefaultInterfaces consistent
2017-02-03 00:37:31 -08:00
sharat
9def4cb9fe
*: Use http.Request.WithContext instead of Cancel
2017-02-02 22:50:07 +05:30
felixoid
0f53ad0b84
netutil: add dualstack to linux_route
...
in v3.1.0 netutil couldn't get default interface for ipv6only hosts
Fixes #7219
2017-01-31 22:19:47 +03:00
Anthony Romano
5aab92414f
Merge pull request #7199 from heyitsanthony/netutil-test-arch
...
pkg/netutil: use native byte ordering
2017-01-23 09:41:20 -08:00
Anthony Romano
1ada4f939f
pkg/netutil: use native byte ordering for route information
...
Fixes #7199
2017-01-20 10:44:05 -08:00
Anthony Romano
e446c2c2c7
pkg/cpuutil: add cpuutil
...
A package for unsafe cpu-ish things.
2017-01-20 01:47:56 -08:00
Vimal Kumar
e4b8c874d2
pkg/flags: fixed prefix checking of the env variables
2017-01-20 13:13:40 +05:30
Gyu-Ho Lee
307e14028c
Merge pull request #7175 from gyuho/report
...
pkg/report: add nil checking for getTimeSeries
2017-01-17 13:22:20 -08:00
Gyu-Ho Lee
69606bb95f
pkg/report: add nil checking for getTimeSeries
2017-01-17 12:51:47 -08:00
Laurie Clark-Michalek
eba41cd7b3
pkg/transport: Obey the usual laws of ssl when using a private PKI
2017-01-15 21:27:53 +00:00
Gyu-Ho Lee
74bad576ed
pkg/report: add 'Stats' to expose report raw data
2017-01-13 10:26:00 -08:00
Anthony Romano
da8fd18d8e
transport: warn on user-provided CA
...
ServerName is ignored for a user-provided CA for backwards compatibility. This
breaks PKI, so warn it is deprecated.
2017-01-12 09:10:05 -08:00
Gyu-Ho Lee
e44d3abc77
pkg/report: support 99.9-percentile, change column name
2017-01-10 18:22:47 -08:00
Anthony Romano
f99c76cb47
Merge pull request #7113 from heyitsanthony/testutil-bufsize
...
testutil: increase size of buffer for stack dump
2017-01-06 18:16:42 -08:00
Anthony Romano
6ab8dcb679
testutil: increase size of buffer for stack dump
...
Too many goroutines to fit all stack traces in 8kb.
2017-01-06 17:14:42 -08:00
Anthony Romano
cf382dbe60
expect: EXPECT_DEBUG environment variable
...
Dump process output to stdout when EXPECT_DEBUG != "".
2017-01-06 11:09:06 -08:00
fanmin shi
74e7614759
testutil: whitelist thread created by go cover
2016-12-29 17:19:27 -08:00
Anthony Romano
13b05aeff8
netutil: ctx-ize URLStringsEqual
...
Handles the case where the DNS entry will only be set up after etcd
starts.
2016-12-14 15:46:30 -08:00
Xiang Li
2f96a68a20
etcdserver: do not send v2 sync if ttl keys do not exist
2016-12-07 14:48:15 -08:00
fanmin shi
e7f4010cca
lease: Use monotonic time in lease
...
lease uses monotimer to calculate its expiration. In this way, changing system time won't affect in lease expiration.
FIX #6700
2016-11-29 12:31:00 -08:00
Gyu-Ho Lee
097cdbd0e4
pkg/netutil: get default interface for tc commands
...
Fix https://github.com/coreos/etcd/issues/6841 .
2016-11-17 22:49:17 -08:00
Xiang Li
9f0ee53e86
etcd-runner: move string generation to pkg/stringutil
2016-10-31 12:20:02 -07:00
Gyu-Ho Lee
a00ed609c3
pkg/flags: export 'FlagToEnv' for e2e tests
2016-10-14 11:15:28 -07:00
Xiang Li
e2bd6f2213
Merge pull request #6601 from nekto0n/interval_tree_fast_stab
...
adt: fast path Stab in empty interval tree
2016-10-07 09:13:23 -07:00
Anthony Romano
3d28faa3eb
pkg/report, tools/benchmark: refactor report out of tools/benchmark
...
Only tracks time series when requested. Can configure output precision.
2016-10-06 16:18:47 -07:00
Nikita Vetoshkin
eae70c9379
adt: fast path Stab in empty interval tree
2016-10-06 22:41:33 +05:00
Xiang Li
a781f4ebda
Merge pull request #6551 from xiang90/fix_log_repo
...
pkg: use etcd as logging repo
2016-09-29 02:46:57 -05:00
Xiang Li
9473e9c30e
pkg: use etcd as logging repo
2016-09-29 15:29:38 +08:00
Gyu-Ho Lee
d0c29cc610
pkg/ioutil: configure pageOffset in NewPageWriter
2016-09-28 09:45:54 -07:00
Gyu-Ho Lee
629d9e7dab
Revert "pkg/transport: update tls.Config copy method"
2016-09-19 15:07:12 +09:00
Gyu-Ho Lee
8c9a88c7d4
pkg/transport: update tls.Config copy method
...
For Go 1.7
2016-09-18 22:50:45 +09:00
Xiang Li
7a48ca4cea
embed: fix go 1.7 http issue
...
go 1.7 introduces HTTP2 compability issue. Now we
need to explicitly enable HTTP2 when TLS is set.
2016-09-18 18:38:55 +08:00
Anthony Romano
c449da6ff9
fileutil: windows OpenDir
...
Windows needs to open a directory with write access to fsync but the go
runtime won't open directories that way.
2016-09-08 00:09:16 -07:00