Commit Graph

16313 Commits (37fe4b9afac63b8269184168bd01787cad866844)

Author SHA1 Message Date
Gyuho Lee 89a3a24d5a etcdserver: compute max request bytes humanized string once
No need to compute the request size limit everytime in runtime

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-05-09 23:11:45 -07:00
Gyuho Lee b95f135e10
Merge pull request #11861 from tedyu/node-run-found
raft: break out of nested loop when raft id is found
2020-05-09 23:05:26 -07:00
Gyuho Lee 485e1409ac
Merge pull request #11860 from tedyu/range-tx-lock
mvcc: Obtain tx Lock once in readTx#UnsafeRange
2020-05-09 22:23:02 -07:00
Ted Yu 43794efb1f raft: break out of nested loop when raft id is found
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-05-09 17:56:44 -07:00
Ted Yu 2dbbe6ce85 mvcc: Obtain txLock once in readTx#UnsafeRange
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-05-09 16:28:47 -07:00
Gyuho Lee c9377195d5
Merge pull request #11857 from tangcong/update-3.4-3.3-changelog-for-11817
CHANGELOG: update 3.4/3.3 changelog for 11817
2020-05-07 19:59:59 -07:00
tangcong e495c9220d CHANGELOG: update 3.4/3.3 changelog for 11817 2020-05-08 10:18:46 +08:00
Gyuho Lee d472f67c77
Merge pull request #11817 from tangcong/fix-mvcc-deadlock-bug
mvcc: fix a deadlock bug in mvcc
2020-05-07 16:03:45 -07:00
Gyuho Lee 6d067997e9
Merge pull request #11850 from jackkleeman/cancel-watch
clientv3: cancel watches proactively on client context cancellation
2020-05-07 11:06:49 -07:00
Jack Kleeman 87aa5a9e60 clientv3: cancel watches proactively on client context cancellation
Currently, watch cancel requests are only sent to the server after a
message comes through on a watch where the client has cancelled. This
means that cancelled watches that don't receive any new messages are
never cancelled; they persist for the lifetime of the client stream.
This has negative connotations for locking applications where a watch
may observe a key which might never change again after cancellation,
leading to many accumulating watches on the server.

By cancelling proactively, in most cases we simply move the cancel
request to happen earlier, and additionally we solve the case where the
cancel request would never be sent.

Fixes #9416
Heavy inspiration drawn from the solutions proposed there.
2020-05-07 16:50:26 +01:00
Hitoshi Mitake feb56298dd
etcdserver: don't let InternalAuthenticateRequest have password (#11818) 2020-05-06 16:46:41 -07:00
Hitoshi Mitake 035e1db0a2
Merge pull request #11830 from mitake/insecure-default
Documentation: note on the policy of insecure by default
2020-05-06 23:54:22 +09:00
Hitoshi Mitake 356f647866 Documentation: note on the policy of insecure by default 2020-05-05 22:44:24 +09:00
Xiang Li d9d850c885
rafthttp: add snapshot limit const (#11846) 2020-05-04 23:26:22 -07:00
Zhihong Yu 17ed0c6638
clientv3: Check the error return from Write in v3Manager#Status (#11837)
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-05-04 17:43:08 -07:00
Zhihong Yu df1d2ca78e
clientv3: v3Manager#saveDB should always close db file (#11838)
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-05-04 15:46:36 -07:00
Xiang Li 16810cd211 etcdmain: best effort detection of self pointing in tcp proxy 2020-05-04 15:42:01 -07:00
Sahdev Zala 4a64198a9f
Merge pull request #11844 from spzala/securityrelprocess
doc: remove Product Security Committee individual emails
2020-05-04 13:37:55 -04:00
Sahdev P. Zala 658fd15b61 doc: remove Product Security Committee individual emails
emails here can be an unnecessary maintainance. The provided
GitHub IDs have the latest emails and also the process has
security@etcd.io mentioned in this doc as a contact email.
2020-05-04 12:40:34 -04:00
Hitoshi Mitake 71170dd1d8
Merge pull request #11841 from mitake/warn-insecure-skip-tls-verify
etcdctl, etcdmain: warn about --insecure-skip-tls-verify options
2020-05-03 23:32:25 +09:00
Hitoshi Mitake c92691dc47 etcdctl, etcdmain: warn about --insecure-skip-tls-verify options 2020-05-03 17:17:30 +09:00
Sahdev Zala dfb0a40509
Merge pull request #11832 from krukkrz/issue_template_broken_link
.github/ISSUE_TEMPLATE: fix of a broken link
2020-04-30 11:08:33 -04:00
Krzysztof Kruk fc64b56058 .github/ISSUE_TEMPLATE: fix of a broken link
to make redirection possible. Changed undercore to dash.
2020-04-30 13:59:17 +02:00
Brandon Philips 1044a8b07c
Merge pull request #11768 from brancz/uid
Use UID instead of ID in Grafana dashboard
2020-04-29 05:35:06 -07:00
Gyuho Lee fb77f9b1d5
Merge pull request #11814 from tedyu/dir-closer
wal: close the directory when Fsync() encounters error
2020-04-28 23:27:08 -07:00
Gyuho Lee 3b79ed8506
Merge pull request #11821 from tedyu/wal-close-all
closeAll should attempt to close all ReadCloser's
2020-04-28 20:54:13 -07:00
Ted Yu 62755f484e wal: closeAll should attempt to close all ReadCloser's
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-04-28 20:33:40 -07:00
Brandon Philips d8bbf7f58d
Merge pull request #11816 from gaurav1086/fix_race_condition_kv_test
mvcc: fix race in TestKVTxnBlockWriteOperations
2020-04-28 16:11:26 -07:00
Brandon Philips b28a6272b7
Merge pull request #11823 from philips/v3-mod-attempt2
go.mod: name packages with go.etcd.io/etcd/v3
2020-04-28 15:24:29 -07:00
Brandon Philips eddca8dce2
Merge pull request #11819 from gaurav1086/fix_race_cond_client_test
clientv3: fix DialTimeout race condition
2020-04-28 15:12:50 -07:00
Brandon Philips d88d765ba4 Documentation, CHANGELOG: use new go.etcd.io/etcd/v3 pkg
Use the new package path in the docs and announce it in the CHANGELOG
2020-04-28 22:02:19 +00:00
Gaurav Singh 86a97533bb clientv3: fix DialTimeout race condition 2020-04-28 10:56:28 -04:00
Gaurav Singh e5ddc91228 mvcc: fix race in TestKVTxnBlockWriteOperations 2020-04-28 10:53:25 -04:00
Brandon Philips c9cdefaeac *: run gofmt and make fmt make test pass
gofmt tests were failing, fix.
2020-04-28 00:57:52 +00:00
Brandon Philips 03248a9045 bill-of-materials: updates for /etcd/v3 packaging
bill-of-materials:
- update to new package names

test/updatebom.sh scripts:
- Update to the right package names
- Don't add bom tool to go.mod
2020-04-28 00:57:52 +00:00
Brandon Philips dd21e710e1 testutil: leak: fix path for go routine filter
add go.etcd.io/etcd/v3 to existing filters
2020-04-28 00:57:52 +00:00
Brandon Philips c066230bad go.sum: cleanup after all the changes 2020-04-28 00:57:52 +00:00
Brandon Philips 2ea4d88299 *: use go.etcd.io/etcd/v3 where needed
Found potential locations via

```
git grep 'go.etcd.io/etcd$'
```
2020-04-28 00:57:52 +00:00
Brandon Philips 7a5fefedcd *: fix imports missed by gomove 2020-04-28 00:57:52 +00:00
Brandon Philips 96cce208c2 go.mod: use go.etcd.io/etcd/v3 versioning
This change makes the etcd package compatible with the existing Go
ecosystem for module versioning.

Used this tool to update package imports:
  https://github.com/KSubedi/gomove
2020-04-28 00:57:35 +00:00
tangcong a7423f2b7b CHANGELOG: update for 11817 2020-04-27 06:42:10 +08:00
tangcong 8fa7783875 mvcc: fix deadlock bug 2020-04-27 06:42:06 +08:00
Ted Yu 99eb5cdfdb wal: close the directory when Fsync() encounters error
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-04-25 11:08:39 -07:00
Sahdev Zala 262c939805
Merge pull request #11810 from tedyu/dir-after-rename
Use known dir-path in log message
2020-04-25 12:54:23 -04:00
Ted Yu 9d0ecc3ba3 wal: Use known dir-path in log message
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-04-25 09:14:30 -07:00
Gyuho Lee 69b70e8c43
Merge pull request #11807 from spzala/walread
wal: fix panic when decoder not set
2020-04-23 14:55:11 -07:00
Sahdev P. Zala 0d5c692eb6 wal: fix panic when decoder not set
Handle the related panic and clarify doc.
2020-04-23 15:53:05 -04:00
Brandon Philips 7a69d72a68
Merge pull request #11806 from philips/brandon-leaving-red-hat
MAINTAINERS: update @philips email
2020-04-23 11:02:27 -07:00
Brandon Philips e2e8fe63df
MAINTAINERS: update @philips email
Brandon is no longer at Red Hat. Use a different email.
2020-04-23 10:47:02 -07:00
Sahdev Zala f4b650b51d
Merge pull request #11793 from gyuho/fix
wal: check out of range slice in "ReadAll", entry limits in "decodeRecord"
2020-04-23 11:24:42 -04:00