df891e3c2f
Merge pull request #14451 from serathius/clean
...
Just some cleanup of expect
2022-09-14 09:20:20 +02:00
157ee32da4
test: Clean incorrectly used StopSignal field from expect
...
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2022-09-13 15:22:45 +02:00
5a315ef88f
add a verification on the pagebytes which must be > 0
...
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-09-13 16:35:31 +08:00
1038c2f45c
tests: Extract expect configuration into struct
...
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2022-09-13 09:20:35 +02:00
f36a8782f0
Merge pull request #14345 from nic-chen/tests/watch
...
tests: Migrate watch test to common framework
2022-08-25 13:35:34 +02:00
82bf79d4ce
Merge pull request #14376 from biosvs/fix-expect-package
...
Fixed infinite loop in ExpectProcess.ExpectFunc
2022-08-25 05:29:30 +08:00
71c5360f98
Fixed infinite loop in ExpectProcess.ExpectFunc
...
Signed-off-by: Vitalii Levitskii <vitalii@uber.com>
2022-08-24 16:46:24 +03:00
f6ed36372b
tests: Migrate watch test to common framework
...
Signed-off-by: nic-chen <chenjunxu6@gmail.com>
2022-08-22 21:55:57 +08:00
192d635da9
Merge pull request #14292 from tjungblu/debug_e2e
...
Add test name to e2e cluster members
2022-08-20 19:30:44 -04:00
b2726c4da3
Merge pull request #12469 from trawler/client_listen_unix_socket
...
pkg/types: Support Unix sockets in NewURLS
2022-08-09 06:40:31 +08:00
51933a7c8b
Add test name to e2e cluster members
...
This should aid in debugging test flakes, especially in tests where the process is restarted very often and thus changes its pid.
Now it's a lot easier to grep for different members, also when different tests fail at the same time.
The test TestDowngradeUpgradeClusterOf3 as mentioned in #13167 is a good example for that.
Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
2022-08-01 15:57:16 +02:00
eb59368440
Reduce ExpectFunc polling interval.
...
Fixes issue 14275, flakes close to timeout like TestKVDelete.
Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
2022-07-28 14:38:44 +02:00
8b6c8b4c96
add unit test for pkg/flags/Uint32FromFlag in uint32_test.go
...
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-07-07 04:52:28 +08:00
1a6fe4dbc6
update the comment for MaxConcurrentStreams to clearly state it's the max value for each client.
...
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-07-07 04:51:20 +08:00
d8347ec683
add & refine the uint32Value data type
...
The golang buildin package `flag` doesn't support `uint32` data
type, so we need to support it via the `flag.Var`.
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-07-06 03:43:46 +08:00
6220174687
support custom `grpc.MaxConcurrentStreams`
...
There is no update on the original PR (see below) for more then 2
weeks. So Benjamin(@ahrtr) continues to work on the PR. The first
step is to rebase the PR, because there are lots of conflicts with
the main branch.
The change to go.mod and go.sum reverted, because they are not needed.
The e2e test cases are also reverted, because they are not correct.
```
https://github.com/etcd-io/etcd/pull/14081
```
Signed-off-by: nic-chen <chenjunxu6@gmail.com>
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-07-06 03:43:46 +08:00
e2bff7cfe1
pkg/expect: send SIGTERM to target expect process instead of SIGKILL
...
Signed-off-by: Eval EXEC <execvy@gmail.com>
2022-06-26 16:39:30 +08:00
e7a84b69c8
Update zap to 1.21.
...
Signed-off-by: Piotr Tabor <ptab@google.com>
2022-06-17 10:05:25 +02:00
17c1dcd614
Update grpc to 1.47 and go-cmp to 0.5.8.
...
Signed-off-by: Piotr Tabor <ptab@google.com>
2022-06-17 08:57:22 +02:00
d83925e357
schedule: Provide logs when the fifo job panic happens
...
To make the fifo scheduler better debuggability.
Signed-off-by: SimFG <1142838399@qq.com>
2022-06-15 20:58:17 +08:00
d58f971895
tests: Use zaptest.NewLogger in places we missed
2022-05-06 12:23:20 +02:00
00ca558167
Fixed goroutine leak on NewServer
2022-04-22 08:57:19 +02:00
0dae4b3b1e
rollback the opentelemetry bumpping to recover the pipeline failures
2022-04-14 16:13:28 +08:00
eab1e0c5d5
go.mod: upgrade opentelemetry deps
...
Downstream users of etcd experience build issues when using dependencies
which require more recent (incompatible) versions of opentelemetry. This
commit upgrades the dependencies so that downstream users stop
experiencing these issues.
2022-04-13 07:14:10 -07:00
804fddf921
tests: Use zaptest.NewLogger in tests
2022-04-04 13:03:15 +02:00
63346bfead
server: Use default logging configuration instead of zap production one
...
This fixes problem where logs json changes format of timestamp.
2022-04-01 10:23:42 +02:00
e5bf23037a
tests: Keeps log in expect to allow their analysis
2022-03-31 21:02:36 +02:00
afecd3139c
fix the api dependency in pkg, and update cobra to 1.4.0
...
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
2022-03-25 17:18:56 +08:00
a045e4bbfc
expect_test: Look up binaries from the path
...
Not all systems include binaries in the same location. On my (NixOS, so
albeit a little weird) system these binaries exist in very different
locations.
This test switches to looking up the paths from the users PATH or skips
the test if they do not exist to improve the `make test` experience on
such systems.
2022-03-17 12:55:08 +00:00
b7824b794b
fix some typos
...
Signed-off-by: cuishuang <imcusg@gmail.com>
fix some typos
Signed-off-by: cuishuang <imcusg@gmail.com>
2022-03-07 20:28:53 +08:00
fb55910500
version: bump up to 3.6.0-alpha.0
2022-02-28 13:20:27 +01:00
77bf0a5a9e
update cobra version to 1.2.1
...
Signed-off-by: yankay <kay.yan@daocloud.io>
2021-12-29 17:35:25 +08:00
0213b8baed
fixing goroutine leaks in testServer
2021-12-15 02:43:49 -05:00
71493bde3e
*: Upgrade to use go.opentelemetry.io/otel@v1.2.0
...
Upgrading from v1.0.1.
Upgrading related dependencies
------------------------------
The following dependencies also had to be upgraded:
- go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.26.1
From v0.25.0. This gets rid of a transitive dependency on go.opentelemetry.io/otel@v1.0.1.
- google.golang.org/genproto@v0.0.0-20211118181313-81c1377c94b1
2021-11-24 16:03:33 +00:00
2a151c8982
*: move from io/ioutil to io and os packages
...
The io/ioutil package has been deprecated as of Go 1.16, see
https://golang.org/doc/go1.16#ioutil . This commit replaces the existing
io/ioutil functions with their new definitions in io and os packages.
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2021-10-28 00:05:28 +08:00
e6e279a14d
*: Bump go to go v1.17.2
2021-10-27 13:44:54 +02:00
49a8aa7f49
run fix.sh
...
To fix dependencies.
Signed-off-by: Vladimir Ermakov <vooon341@gmail.com>
2021-10-13 14:08:27 +03:00
33623c3f03
Merge pull request #13224 from sakateka/issue-7798-netutil-fix
...
netutil: add url comparison without resolver to URLStringsEqual
2021-10-07 18:19:42 +02:00
75747f24bc
Add unix socket test to TestNewURLsValue
2021-10-07 11:59:32 +02:00
d93b7c8cb1
pkg/types: Support Unix sockets in NewURLS
...
Resolves #12450
This commits adds support to unix/unixs socket URLs, which currently
fail with the message "URL address does not have the form "host:port".
It also replaces the work started in #11747 .
2021-10-07 11:59:32 +02:00
90932324b1
client: Add grpc authority header integration tests
2021-09-29 12:42:16 +02:00
b272b98b79
netutil: make a `raw` URL comparison part of the urlsEqual function
2021-09-26 13:58:21 +07:00
9d81dde082
server: Extract notifier struct
2021-09-10 10:16:48 +02:00
eac75c28ae
Apply suggestions from code review
...
Co-authored-by: Lili Cosic <cosiclili@gmail.com>
2021-08-01 00:20:50 +07:00
b922a28622
netutil: add url comparison without resolver to URLStringsEqual
...
If one of the nodes in the cluster has lost a dns record,
restarting the second node will break it.
This PR makes an attempt to add a comparison without using a resolver,
which allows to protect cluster from dns errors and does not break
the current logic of comparing urls in the URLStringsEqual function.
You can read more in the issue #7798
Fixes #7798
2021-07-19 01:31:21 +07:00
86f68b9374
*: Add missing file licenses and Fix static analysis prevent skipping them in future
2021-06-29 12:52:02 +02:00
df696a7e76
go.mod: Bump etcd to 3.5.0
2021-06-22 12:25:39 +02:00
404efd70f7
Upgrade of prometheous deps.
...
For now we need to depend on unstable: prometheus/client_golang
2021-06-03 16:07:01 +02:00
edcfe575cf
Update dependencies:
...
- github.com/coreos/go-systemd/v22 v22.3.2
- github.com/google/btree v1.0.1
- github.com/json-iterator/go v1.1.11
- github.com/mattn/go-runewidth v0.0.13
- github.com/prometheus/client_golang v1.10.0
- github.com/prometheus/common v0.26.0
- github.com/sirupsen/logrus v1.8.1
2021-06-03 13:03:01 +02:00
b240625d21
Update bbolt to v1.3.6.
...
`./scripts/update_dep.sh go.etcd.io/bbolt v1.3.6`
2021-06-03 12:39:53 +02:00
90cea7d4e7
Update zap to v1.17.0.
2021-06-03 12:37:43 +02:00
838be9c751
Omit the blank line
2021-05-21 21:25:49 +08:00
2d2a95c3fb
Fix the format issue
2021-05-21 21:23:38 +08:00
1b700e5ed8
Fix the goroutine leak in StubServer
...
---
(If this PR fixes a github issue, please add `Fixes #<xyz>`)
Fixes #13023
(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>`
to link to the master issue)
Master Issue: #13023
*Motivation*
Currently, StubServer can stop itself (by Stop()) before it start its
grpc server (created by Start()). This race condition may lead to a
goroutine leak mentioned by #13023 .
*Modifications*
This PR add a channel to force the Stop() started after Start()
*Verify this change*
Please pick either of following options.
- This change is already covered by existing tests, such as *(please describe tests)*.
Test/TestEtcdGrpcResolver
2021-05-21 20:54:06 +08:00
d8550deb7f
Fix pkg/proxy tests such that they don't leek goroutines and do close transports.
2021-05-14 22:45:59 +02:00
8981afb6f5
Fix unit tests logging config.
2021-05-14 22:45:57 +02:00
00c6090110
Refactor common code from etcdctl (v2,v3) to pkg/corbautl.
...
Preparation for etcdutl split.
2021-05-14 14:16:53 +02:00
1a718a958e
Add initial Tracing with OpenTelemetry
2021-05-10 10:44:40 +02:00
2ad893b110
Integrate verification into e2e tests.
2021-04-29 11:51:24 +02:00
3423a949c0
Update go for 3.5: 1.15 -> 1.16.(3).
...
https://github.com/etcd-io/etcd/issues/12732
2021-04-19 16:50:54 +02:00
17b982382e
Fix TestSnapshotV3RestoreMultiMemberAdd flakes (leaks)
...
- most important: unix's socket transport should not keep idle
connections. For top-level Transport we close them using:
f3c518025e/server/etcdserver/api/rafthttp/transport.go (L226)
2021-04-16 20:17:28 +02:00
eafbc8c57e
Update zap logging dependency.
...
In particular bring up zapgrpc V2 code:
89e382035dhttps://pkg.go.dev/google.golang.org/grpc/grpclog#LoggerV2
2021-04-14 12:15:48 +02:00
3bb7acc8cf
Migrate dependencies pkg/foo -> client/pkg/foo
2021-04-07 00:38:47 +02:00
0b81fdf418
Move pkg/* used by client to client/pkg.
2021-04-05 23:47:27 +02:00
d0962f10ae
Adopt grpc_testing to grpc-1.36.
2021-03-24 23:31:03 +01:00
a60676686b
Update dep: grpc: 1.32.0 -> 1.36.0.
2021-03-24 22:27:55 +01:00
45fb7b41d6
Update dep: github.com/golang/protobuf v1.3.5 -> v1.5.1
...
Thanks to https://go-review.googlesource.com/c/protobuf/+/300869/ its
feasible now.
2021-03-24 22:27:12 +01:00
18321a0c85
Merge pull request #12786 from ptabor/20210318-debug-env
...
client: Bring back ETCD_CLIENT_DEBUG variable interpretation.
2021-03-18 21:55:51 +01:00
e2b5835e64
Fix go-tip: (1.17) fmt error:
...
```
gofmt' started at Thu Mar 18 18:06:00 UTC 2021
transport/sockopt_unix.go
diff -u transport/sockopt_unix.go.orig transport/sockopt_unix.go
--- transport/sockopt_unix.go.orig 2021-03-18 18:06:01.667483834 +0000
+++ transport/sockopt_unix.go 2021-03-18 18:06:01.667483834 +0000
@@ -1,3 +1,4 @@
+//go:build !windows
// +build !windows
package transport
transport/sockopt_windows.go
diff -u transport/sockopt_windows.go.orig transport/sockopt_windows.go
--- transport/sockopt_windows.go.orig 2021-03-18 18:06:01.667483834 +0000
+++ transport/sockopt_windows.go 2021-03-18 18:06:01.667483834 +0000
@@ -1,3 +1,4 @@
+//go:build windows
// +build windows
```
2021-03-18 19:44:28 +01:00
9312d1b077
clientv3: Bring back ETCD_CLIENT_DEBUG variable interpretation.
...
env ETCD_CLIENT_DEBUG supports log levels (debug, info, warn, error, dpanic, panic, fatal).
Only when set, overrides application-wide grpc logging settings.
2021-03-18 18:43:07 +01:00
dac6e37ea1
*: over 20 staticcheck fixes
2021-03-18 15:06:17 +01:00
de67806175
mend
2021-03-14 13:35:47 +01:00
67491a00ea
e2e/expect: In case of sut process failure, print last 40lines of logs.
2021-03-13 23:41:29 +01:00
2c2456bf3d
*: partial staticcheck fix
2021-03-10 14:13:38 +00:00
b6c2e87a74
Testing: Integration tests does not check whether t==nil
2021-03-09 18:19:52 +01:00
5ddabfdb24
tests: Make tests operate in /tmp director instead of src.
...
Thanks to this, unix sockets should be not longer
created by integration tests in the the source code directory,
so potentially trigger IDE reloads and unnecessery load (and mess).
2021-03-09 18:19:52 +01:00
fb1d48e98e
Integration tests: Use BeforeTest(t) instead of defer AfterTest().
...
Thanks to this change, a single method BeforeTest(t) can handle
before-test logic as well as registration of cleanup code
(t.Cleanup(func)).
2021-03-09 18:19:51 +01:00
efb584cc9b
leak.go: Make the per-test AfterTest strictly wait for none of the unwanted rountines.
2021-03-09 18:19:51 +01:00
94a371acd7
Merge pull request #12750 from ptabor/20210306-mlock
...
--experimental-memory-mlock support
2021-03-09 09:13:40 -08:00
6fd85af641
Merge pull request #12702 from hexfusion/add-so
...
*: add support for socket options
2021-03-09 09:02:24 -08:00
5b49fb41c8
fixup: add ListenerOptions
...
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
2021-03-08 11:27:03 -05:00
a46a358577
--experimental-memory-mlock support
...
The flag protects etcd memory from being swapped out to disk.
This can happen in memory constrained systems where mmaped bbolt
area is natural condidate for swapping out.
This flag should provide better tail latency on the cost of higher RSS
ram usage. If the experiment is successful, the logic should get moved
into bbolt layer, where we can protect specific bbolt instances
(e.g. avoid protecting both during defragmentation).
2021-03-07 12:32:57 +01:00
792b7f57d3
Merge pull request #12747 from wilsonwang371/master
...
pkg/wait: change list from single element to an array.
2021-03-07 11:53:30 +01:00
66cef61444
Detect leaked go-routines bases on pre-normalization syntax.
2021-03-04 22:28:44 +01:00
432fde88a9
pkg/wait: change list from single element to an array.
...
We found wait lock contention when a large amount of write operations. Converting wait from single element to an array helps to improve the performance.
Fixes #12731
Signed-off-by: Wilson Wang <wilsonny371@gmail.com>
2021-03-04 12:16:41 -08:00
61fef348f8
Merge pull request #12742 from wilsonwang371/master
...
debugutil: Remove extra space in trace handler route
2021-03-04 08:55:44 +01:00
7fc447fb5c
debugutil: Remove extra space in trace handler route
...
debugutil: Remove extra space in trace handler route. To use trace, user needed to escape the extra space and the extra space needs to be removed.
2021-03-03 16:01:04 -08:00
102c198444
Merge pull request #12705 from astromechza/bm_etcd_peer_server_cert
...
etcdmain: added peer-client-{client,key}-file parameters for supporting separate client and server certs when communicating between peers
2021-03-02 09:03:35 +01:00
5e10d12996
tests: Fixes a few recently spotted test-flakes
...
```
Unexpected goroutines running after all test(s).
1 instances of:
syscall.Syscall(...)
/usr/local/go/src/syscall/asm_linux_386.s:19 +0x5
syscall.Close(...)
/usr/local/go/src/syscall/zsyscall_linux_386.go:285 +0x3d
internal/poll.(*FD).destroy(...)
/usr/local/go/src/internal/poll/fd_unix.go:77 +0x30
internal/poll.(*FD).decref(...)
/usr/local/go/src/internal/poll/fd_mutex.go:213 +0x38
internal/poll.(*FD).Close(...)
/usr/local/go/src/internal/poll/fd_unix.go:99 +0x43
net.(*netFD).Close(...)
/usr/local/go/src/net/fd_posix.go:37 +0x49
FAIL go.etcd.io/etcd/tests/v3/integration/client 0.039s
```
```
--- FAIL: TestServer_TCP_Secure_DelayTx (0.20s)
server_test.go:110: took 128.026085ms with no latency
server_test.go:125: took 62.980988ms with latency 50ms��5ms
server_test.go:133: expected took1 128.026085ms < took2 62.980988ms (with latency)
```
https://github.com/etcd-io/etcd/issues/12372
2021-03-01 18:07:38 +01:00
3d44f5bf80
*: added client-{client,key}-file parameters for supporting separate client and server certs when communicating between peers
...
In some environments, the CA is not able to sign certificates with both
'client auth' and 'server auth' extended usage parameters and so an operator
needs to be able to set a seperate client certificate to use when making
requests which is different to the certificate used for accepting requests.
This applies to both proxy and etcd member mode and is available as both a CLI
flag and config file field for peer TLS.
Signed-off-by: Ben Meier <ben.meier@oracle.com>
2021-02-28 14:37:56 +00:00
cb040801f9
Merge pull request #12730 from ptabor/20200208-client-no-logger
...
clientv3: Cleaning up dead logger code
2021-02-26 10:44:42 -08:00
a7f340216d
Reformat code according to 'gotip' rules.
...
In practices adds annotations in the new syntax:
```
+//go:build !linux
// +build !linux
```
Fixes failing gotip PASSES='fmt' check:
https://travis-ci.com/github/etcd-io/etcd/jobs/486453806
2021-02-26 10:14:46 +01:00
54b87505a3
Remove dead legacy logger code.
2021-02-26 09:13:09 +01:00
252dcc9bdb
Fix typo in DialJournal
2021-02-24 22:23:27 +05:30
1a9c81abda
Update grpc dependency to 1.32.
...
Simplify grpc testing infrastructure to align with upstream changes.
2021-02-23 11:31:50 +01:00
49078c683b
*: add support for socket options
...
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
2021-02-19 13:31:23 -05:00
60e44286fa
Fix pkg/tlsutil (test) to not fail on 386.
...
In fact this commit rewrites the functionality to use upstream list of
ciphers instead of checking whether the lists are in sync using ast
analysis.
2021-02-08 23:03:43 +01:00
dae29bb719
Merge pull request #12667 from lemonlinger/implement-endpoint-manager-and-resolver
...
Implement Update method for EndpointManager
2021-02-04 17:25:51 +01:00
571ed502d4
endpoints: implement Update method for EndpointManager.
...
- Add integration test for endpoints and resolver.
2021-02-04 23:30:22 +08:00
603d975599
Fix cluster peer HTTP SRV discovery
...
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
2021-02-03 03:08:13 -08:00
Marek Siarkowicz