ed5a01a48d
etcdserver: recover cluster version from backend
2019-12-05 16:25:13 -08:00
b14c7cd448
concurrency: make lock more reliable
2019-12-02 10:54:30 -08:00
5dc98c50d7
clientv3: fix retry/streamer error message
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-10-30 21:29:44 -07:00
6aae90325c
Merge pull request #11211 from jpbetz/ipv6-endpoints
...
Replace endpoint.ParseHostPort with net.SplitHostPort to fix IPv6 client endpoints
2019-10-08 15:15:16 -07:00
594354b886
Replace endpoint.ParseHostPort with net.SplitHostPort to fix IPv6 client endpoints
2019-10-08 14:53:49 -07:00
340f0ac797
Merge pull request #11179 from YoyinZyc/trace
...
Add tracing to range request in etcd server.
2019-10-08 13:23:53 -07:00
401df4bb8e
etcdserver: add put request steps.
...
mvcc: add put request steps; add trace to KV.Write() as input parameter.
2019-10-01 14:08:06 -07:00
97388ce454
clientv3: Set authority used in cert checks to host of endpoint
2019-09-25 15:14:23 -07:00
e24564224a
clientv3: remove the redundant CancelFunc invocation
2019-09-18 23:06:49 +08:00
e53298afb1
clientv3/concurrency: remove the unneeded slash
...
Since NewMutex will append a slash to pfx, there is no need to append a
slash beforehand.
2019-09-18 16:37:31 +08:00
6287052bd0
integration: fix bug in for loop, make it break properly
2019-09-17 11:27:31 +08:00
04ddfa8b8d
clientv3/concurrency: Added Mutex.TryLock()
...
TryLock locks the mutex if not already locked by another session.
If lock is held by another session, return immediately after attempting necessary cleanup
Added integration test
Fixes #10493
2019-09-09 20:16:07 -07:00
dd2b88d0ed
Merge pull request #11066 from vimalk78/clientv3-fixes
...
clientv3: add nil checks in Client.Close()
2019-08-23 23:22:42 -07:00
2680c2afe7
integration: fix TestKVPutError
...
Give backend quota enough overhead.
2019-08-21 19:56:38 -07:00
7f47de8414
clientv3: add nil checks in Close()
...
Added nil checks in Close() for Watcher and Lease fields
Added test case
2019-08-21 23:04:42 +01:00
b5aa46486b
clientv3/integration: fix "mvcc.NewStore" call
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-08-15 11:48:53 -07:00
9b51febaf5
*: Add experimental-compaction-batch-limit flag
2019-08-15 11:47:23 -07:00
97fd40c587
clientv3: use Endpoints(), fix context creation
...
If overwritten, the previous context should be canceled first.
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-08-12 21:39:50 -07:00
181419256d
integration: fix a data race about `err`
...
don't share `err` between goroutines
2019-08-06 14:58:15 -07:00
9b385737f5
clientv3: deprecate "grpc.ErrClientConnClosing"
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-08-05 13:27:16 -07:00
4b0af5b4ac
clientv3: document "WithBlock" dial option
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-08-04 23:52:17 -07:00
ba42e65b59
clientv3/integration: give more time for balancer resolution
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-07-26 09:19:22 -07:00
8c7c6ec0c1
clientv3/balancer: refactor
...
refactor + remove unused
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-07-26 09:19:19 -07:00
3dc00ab615
clientv3: move auth token credential to "credentials" package
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-07-26 09:17:44 -07:00
db61ee106c
clientv3/credentials: set dial target "Authority" with target address
...
Overwrite authority when it's IP.
When user dials with "grpc.WithDialer", "grpc.DialContext" "cc.parsedTarget"
update only happens once. This is problematic, because when TLS is enabled,
retries happen through "grpc.WithDialer" with static "cc.parsedTarget" from
the initial dial call.
If the server authenticates by IP addresses, we want to set a new endpoint as
a new authority. Otherwise
"transport: authentication handshake failed: x509: certificate is valid for 127.0.0.1, 192.168.121.180, not 192.168.223.156"
when the new dial target is "192.168.121.180" whose certificate host name is also "192.168.121.180"
but client tries to authenticate with previously set "cc.parsedTarget" field "192.168.223.156"
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-07-26 09:17:40 -07:00
db7231accc
clientv3: use new "credentials" package
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-07-26 08:56:33 -07:00
324c876742
clientv3/credential: implement grpc/credentials.Bundle
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-07-26 08:56:05 -07:00
12ab2ee3c4
clientv3: do not use pointer to TransportCredentials interface
...
Interface in Go is already reference
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-07-26 08:52:31 -07:00
1cef112a79
etcdserver: do not allow creating empty role
...
Like user, we should not allow creating empty role.
Related #10905
2019-07-24 17:41:24 -04:00
b9c051e7a7
raftpb: clean up naming in ConfChange
2019-07-23 10:40:03 +02:00
8194aa3f03
Fixed a missing block bug
...
Description: w.mu is locked at line 385 and unlocked at line 396. Among 5 return statements in this function, 4 are below line 396 but there is 1 return at line 387.
Fix: Add w.mu.Unlock() before that return at line 387.
2019-06-28 11:27:13 -07:00
1caaa9ed4a
test: test update for Go 1.12.5 and related changes
...
Update to Go 1.12.5 testing. Remove deprecated unused and gosimple
pacakges, and mask staticcheck 1006. Also, fix unconvert errors related
to unnecessary type conversions and following staticcheck errors:
- remove redundant return statements
- use for range instead of for select
- use time.Since instead of time.Now().Sub
- omit comparison to bool constant
- replace T.Fatal and T.Fatalf in tests with T.Error and T.Fatalf respectively because the goroutine calls T.Fatal must be called in the same goroutine as the test
- fix error strings that should not be capitalized
- use sort.Strings(...) instead of sort.Sort(sort.StringSlice(...))
- use he status code of Canceled instead of grpc.ErrClientConnClosing which is deprecated
- use use status.Errorf instead of grpc.Errorf which is deprecated
Related #10528 #10438
2019-06-05 17:02:05 -04:00
ea0f919cdc
Merge pull request #10775 from jingyih/integration_member_promote_failed_cases
...
clientv3/integration: add member promote failure test cases
2019-06-02 20:39:00 -07:00
ec17872c98
integration: add member promote failure test cases
...
Add TestMemberPromoteMemberNotLearner and
TestMemberPromoteMemberNotExist.
2019-05-31 10:52:54 -07:00
5a67dd788d
*: support creating a user without password
...
This commit adds a feature for creating a user without password. The
purpose of the feature is reducing attack surface by configuring bad
passwords (CN based auth will be allowed for the user).
The feature can be used with `--no-password` of `etcdctl user add`
command.
Fix https://github.com/coreos/etcd/issues/9590
2019-05-30 21:59:30 +09:00
23a89b0f09
Merge pull request #10755 from wrfly/patch-3
...
fix #10754
2019-05-28 20:50:52 -07:00
3754767dbc
clientv3: return getToken error when retryAuth
2019-05-29 10:15:22 +08:00
6bf609b96d
integration: update TestMemberPromote test
...
Update TestMemberPromote to include both learner not-ready and learner
ready test cases.
Removed unit test TestPromoteMember, it requires underlying raft node to
be started and running. The member promote is covered by the integration
test.
2019-05-28 18:50:13 -07:00
f8ad8ae4ad
etcdserver: use etcdserver ErrLearnerNotReady
...
If learner is not ready to be promoted, use etcdserver.ErrLearnerNotReady
instead of using membership.ErrLearnerNotReady.
2019-05-28 18:50:13 -07:00
dfe296ac3c
etcdserver: add mayPromote check
2019-05-28 18:47:03 -07:00
7a4d233bab
clientv3/integration: better way to deflake test
...
Use ReadyNotify instead of time.Sleep to wait for server ready.
2019-05-28 18:47:03 -07:00
aa4cda2f5c
etcdserver: allow 1 learner in cluster
...
Hard-coded the maximum number of learners to 1.
2019-05-28 18:47:03 -07:00
d0c1b3fa38
etcdserver: learner return Unavailable for unsupported RPC
...
Make learner return code.Unavailable when the request is not supported
by learner. Client balancer will retry a different endpoint.
2019-05-28 18:47:03 -07:00
34bd797e67
*: revert module import paths
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-05-28 15:39:35 -07:00
11d3f74c33
Merge pull request #10744 from philips/drop-readthedocs
...
*: move to etcd.io for docs
2019-05-27 03:02:01 -07:00
2eaed14def
clientv3: fix typo in test filename
2019-05-27 13:53:58 +06:00
c5e5240004
*: move to etcd.io for docs
...
Remove all readthedocs references for https://etcd.io to ensure the SEO
goes to the right place.
2019-05-20 14:32:08 -07:00
23f1d02391
*: address comments
2019-05-15 15:58:46 -07:00
90d28c0de7
clientv3/integration: deflake TestKVForLearner
...
Adding delay in the test for the newly started learner member to catch
up applying config change entries in raft log.
2019-05-15 13:58:28 -07:00
b23c8f3e8f
clientv3/integration: fix cluster tests
...
Fixes TestMemberAddForLearner and TestMemberPromoteForLearner.
2019-05-15 13:58:26 -07:00
a039f2efb8
clientv3, etcdctl: MemberPromote for learner
2019-05-15 13:48:52 -07:00
7f9479acc1
clientv3: add member promote
2019-05-15 13:27:42 -07:00
57a11eb1e1
integration: add TestKVForLearner
...
Adding TestKVForLearner. Also adding test utility functions for clientv3
integration tests.
2019-05-15 13:27:38 -07:00
2b76200f70
*: add MemberAddAsLearner to clientv3 Cluster API
...
Made changes to Clientv3 Cluster API:
- Added MemberAddAsLearner.
- Reverted changes to MemberAdd - removed input parameter isLearner.
2019-05-14 16:56:44 -07:00
fc14608cb7
clientv3: support MemberAdd for learner
...
Added IsLearner flag to clientv3 MemberAdd API.
2019-05-14 13:10:22 -07:00
a0d3c4d641
*: fix compilation after API change
...
Fixed compilation erros after API change for learner.
2019-05-14 13:10:22 -07:00
42a7ea6d33
etcd: Replace ghodss/yaml with sigs.k8s.io/yaml
...
To remove the dependency on ghodss/yaml. Replaced this dependency with sigs.k8s.io/yaml.
This wil help to remove the ghodss/yaml dependency from main kubernetes repository.
xref: https://github.com/kubernetes/kubernetes/issues/77024
2019-05-02 12:34:36 +05:30
e899023f3f
Merge pull request #10640 from shrajfr12/gomodulecompat
...
Fix module path to have the major version to comply with go modules specification.
2019-05-01 22:46:03 -07:00
fc6936863a
Merge pull request #10582 from johncming/empty_update
...
clientv3/naming: ignore empty update.
2019-04-30 14:21:56 -07:00
1bd02b2053
Merge pull request #10595 from johncming/locking
...
clientv3: modify lock type.
2019-04-30 14:19:02 -07:00
9150bf52d6
go modules: Fix module path version to include version number
2019-04-26 15:29:50 -07:00
c7c6894527
Merge pull request #10551 from johncming/lbname
...
clientv3/balancer: change balancer name to builder name.
2019-04-10 16:16:51 -07:00
cc08c1bd2e
clientv3/integration/leasing_test.go: Fix t.Fatalf error message
...
Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>
2019-04-10 13:19:50 -04:00
9b5c468dc6
clientv3: modify lock type.
2019-03-29 21:02:13 +08:00
cb39c97b22
clientv3/naming: ignore empty update.
2019-03-25 10:53:24 +08:00
41f7142ff9
doc: fix document example error
2019-03-21 08:21:03 -04:00
09d0844379
Merge pull request #10548 from jingyih/add_TestMemberAddWithExistingURLs
...
clientv3/integration: Add TestMemberAddWithExistingURLs
2019-03-19 15:23:15 -07:00
9bd86a647f
clientv3: Add TestMemberAddWithExistingURLs
...
TestMemberAddWithExistingURLs ensures adding a new member with URLs
already being used in the cluster will not succeed.
2019-03-18 12:48:44 -07:00
ddff08ffad
clientv3/balancer: change balancer name to builder name.
2019-03-18 11:05:22 +08:00
662fd55084
clientv3: clean up unused code.
2019-03-18 10:34:41 +08:00
e1ca3b4434
Merge pull request #10531 from JoeWrightss/patch-3
...
Fix some variable spelling errors
2019-03-12 12:09:09 -07:00
939b4f8599
clientv3/balancer/grpc1.7-health.go: Fix variable spelling error
...
Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>
2019-03-10 01:11:02 +08:00
4dc9d8b058
Merge pull request #10503 from spzala/v3argorder10431
...
clientV3: fix behavior of WithPrefix and WithFromKey functions
2019-03-08 11:59:17 -08:00
e80d1745be
Merge pull request #10420 from spzala/watch10340
...
clientV3watch: do not return ctx canceled when Close watch
2019-03-08 11:57:44 -08:00
b25edb62cc
clientV3watch: Watch Close should close successfully
...
Closing of watch by client will cancel the watch grpc stream and
can produce a context canceled error. However, since client
simply wanted to close the watcher the error can create confusion
that something went wrong instead of a successful close. Ensure
that Close do not return error.
Fixed #10340
2019-02-28 20:43:20 -05:00
8782bbae65
clientV3: fix behavior of WithPrefix and WithFromKey functions
...
The use of WithPrefix() and WithFromKey() together is not supported. The
client doesn't respect this behavior currently.
Fixes #10431
2019-02-27 09:23:01 -05:00
17de9bd526
Merge pull request #10501 from datuanmac/replacing_http_by_https
...
doc: Replacing 'HTTP' by 'HTTPS' for securing links
2019-02-27 14:08:24 +08:00
32389b1876
doc: Replacing 'HTTP' by 'HTTPS' for securing links
...
Currently, when we access the URL https://www.grpc.io , it is redirected to https://www.grpc.io automatically.
So this commit aims to replace **HTTP** to **HTTPs** for security.
2019-02-27 10:15:22 +07:00
4f46b65748
clientv3: use default info level log configuration
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-02-21 10:57:38 -08:00
94b782e7c9
clientv3/integration: add timeout case.
2019-02-18 09:38:49 +08:00
6af8ce6c60
clientv3: clarify retry interceptor logging
...
Log only when it errors + some clarification
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-02-15 08:48:37 -08:00
3546c4868c
Merge pull request #10445 from spzala/fromkey9833
...
clientv3: fix WithFromKey
2019-02-07 14:50:13 -08:00
313ab0ba47
clientv3: fix WithFromKey
...
The WithFromKey func should not return error similar to etcdctl usage
of it when an empty key is provided.
Fixed #9833
2019-02-02 19:21:49 -05:00
a033686acf
clientv3/integration: return err if err == rpctypes.ErrAuthNotEnable
2019-02-02 14:06:54 +08:00
61218004c0
clientv3: remove "JitterUp" imports
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-01-03 11:00:45 -08:00
510ae3d2a2
clientv3/concurrency: fix govet errors
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2018-12-05 18:28:13 -08:00
7d7266d3c9
concurrency: set keyPrefix when calling ResumeElection()
...
This change allows users to use Observe() after resuming an election as
Observe() requires a valid keyPrefix to function properly.
2018-12-05 14:50:56 -06:00
0cfc01b873
clientv3: Fix spelling in comment
2018-11-12 22:33:48 +01:00
aa4313a55a
*: fix github links
2018-11-10 11:14:18 +09:00
6a43db1eff
clientv3: Fix concurrent clientv3 client creation in 3.4 by using proper UUIDs
2018-10-22 14:08:58 -07:00
49450aaa60
clientv3: Clarify lessor KeepAlive docs
2018-10-11 15:11:28 -07:00
64e8b2e905
clientv3: concurrency.Mutex.Lock() - preserve invariant
...
Convenient invariant:
- if werr == nil then lock is supposed to be locked at the moment.
While we could not be confident in stronger invariant ('is exactly locked'),
it were inconvenient that previous code could return `werr == nil` after
Mutex.Unlock.
It could happen when ctx is canceled/timeouted exactly after waitDeletes
successfully returned werr == nil and before `<-ctx.Done()` checked.
While such situation is very rare, it is still possible.
fixes #10111
2018-10-05 14:17:32 +03:00
87beb8336f
clientv3: add test for snapshot status
...
Add unit test to check if we can correctly identify a corrupted snapshot
backup file.
2018-10-03 18:17:19 -07:00
7d57ee3427
clientv3: fix goword checking in config.go
2018-10-02 23:02:10 -07:00
f6f375109e
clientv3: let etcd client use all available keepalive ClientParams
...
We should allow etcd client use all of the available keepalive
client parameters as documented in this link,
https://godoc.org/google.golang.org/grpc/keepalive#ClientParameters
Currently in the etcd, by default PermitWithoutStream is set to
false, and user has no way to override it.
On the server side, we explicitely setting EnforcementPolicy
PermitWithoutStream to false and don't provide option to override it
to user but on the client side we should allow this option as
provided by the grpc.
2018-10-02 15:51:27 -04:00
fb674833c2
Merge pull request #10094 from nolouch/drop-read
...
server: drop read request if the leader is changed
2018-09-23 19:32:44 -07:00
422f867f6b
clientv3: add integrity check in snapshot status
...
Add snapshot file integrity check in snapshot status. If the file is
corrupted, return with error message.
2018-09-20 12:59:27 -07:00
6ea54195a6
client/integration: try to fix tests
2018-09-18 01:44:57 +08:00
c15fb607f6
server: broadcast leader changed
2018-09-17 14:15:04 +08:00
fd5ef74b80
clientv3/integration: try to fix tests
2018-09-14 17:57:56 +08:00
Jingyi Hu