62f8ec25c0
clientv3: use grpc reconnection logic
2016-06-08 01:04:59 -07:00
1e4d3603db
clientv3,ctlv3: following changes for proto change
2016-06-07 13:32:36 -07:00
83ce1051ff
auth: make naming consistent
2016-06-07 10:54:50 -07:00
94f22e8a07
*: rename RPCs and structs related to revoking
...
This commit renames RPCs and structs related to revoking.
1. UserRevoke -> UserRevokeRole
2. RoleRevoke -> RoleRevokePermission
2016-06-05 16:57:23 +09:00
429b2eee58
Merge pull request #5548 from mitake/auth-v3-revoke-delete
...
revoke user, revoke role, and delete role in auth v3
2016-06-03 21:44:37 -07:00
c7a1423d45
*: support deleting a role in auth v3
...
This commit implements RoleDelete() RPC for supporting deleting a role
in auth v3. It also adds a new subcommand "role delete" to etcdctl.
2016-06-04 13:42:45 +09:00
0cb1343109
*: support revoking a key from a role in auth v3
...
This commit implements RoleRevoke() RPC for supporting revoking a key
from a role in auth v3. It also adds a new subcommand "role revoke" to
etcdctl.
2016-06-04 13:42:45 +09:00
957b07c408
*: support revoking a role from a user in auth v3
...
This commit implements UserRevoke() RPC for supporting revoking a role
from a user in auth v3. It also adds a new subcommand "user revoke" to
etcdctl.
2016-06-04 13:39:26 +09:00
0cb4dd4331
clientv3/integration: test lease closed connection
...
Tests if lease operations return ErrConnClosed when
the client is closed.
2016-06-03 16:41:32 -07:00
7dfe7db243
clientv3: panic if ActiveConnection tries to return non-nil connection
2016-06-03 10:25:20 -07:00
267d1cb16f
clientv3: fix watch to reconnect on failure
...
It was spinning before.
2016-06-03 10:25:20 -07:00
5f5a203e27
clientv3: don't hold client lock while dialing
...
Causes async reconnect to block while the client is dialing.
This was also causing problems with the Close error message, so
now Close() will return the last dial error (if any) instead of
clearing it out with a cancel().
Fixes #5416
2016-06-03 10:25:20 -07:00
10ee69b44c
*: support getting role in auth v3
...
This commit implements RoleGet() RPC of etcdserver and adds a new
subcommand "role get" to etcdctl v3. It will list up permissions that
are granted to a given role.
$ ETCDCTL_API=3 bin/etcdctl role get r1
Role r1
KV Read:
b
d
KV Write:
a
c
d
2016-06-03 13:03:54 +09:00
84a487f723
Revert "etcdserverpb: make RangeResponse.More an int64"
...
This reverts commit 84e1ab8765
2016-06-02 13:43:40 -07:00
5609fdb9a8
*: support getting user in etcdctl v3
...
This commit adds a new subcommand "user get" to etcdctl v3. It will
list up roles that are granted to a given user.
Example:
$ ETCDCTL_API=3 bin/etcdctl user get u1
User: u1
Roles: r1 r2 r3
This commit also modifies the layout of InternalRaftRequest for
frequent update of auth related members.
2016-06-02 12:10:19 +09:00
b95c5b7da9
Merge pull request #5526 from heyitsanthony/more-to-int64
...
etcdserverpb: make RangeResponse.More an int64
2016-06-01 20:03:15 -07:00
84e1ab8765
etcdserverpb: make RangeResponse.More an int64
2016-06-01 17:10:23 -07:00
fb64c8ccfe
Merge pull request #5521 from heyitsanthony/clientv3-hide-retrydial
...
clientv3: hide retry dial api
2016-06-01 13:00:02 -07:00
22744566f4
clientv3: hide retry dial api
2016-06-01 11:36:16 -07:00
75dc10574a
clientv3: watch resp with error when client close
2016-06-01 10:39:48 -07:00
9ed3b446ca
Merge pull request #5509 from heyitsanthony/clientv3-fix-concurrent-close
...
clientv3: fix deadlock on Get with concurrent Close
2016-06-01 07:37:28 -07:00
a83051d0fc
clientv3: don't panic on Get if NewKV is created with a closed client
2016-06-01 05:53:21 -07:00
1d88130522
clientv3: fix deadlock on Get with concurrent Close
2016-06-01 05:53:21 -07:00
51551abef5
concurrency, benchmark: read-committed STM isolation policy
2016-05-31 14:35:27 -07:00
7b5657cf1a
clientv3: check if KV.Client is closed
...
For https://github.com/coreos/etcd/issues/5495 .
2016-05-31 12:00:19 -07:00
d116c116fe
clientv3: getRemote comment about release
2016-05-31 12:00:19 -07:00
9a0fe2620e
clientv3: fix panic message in OpPut
2016-05-28 11:55:28 -07:00
9dc0782f45
clientv3: handle URL scheme when given in endpoint
...
Fixes #5427
2016-05-25 18:01:36 -06:00
374b3ee40b
clientv3: fix typo
2016-05-20 17:18:52 -04:00
edca3cbe44
clientv3: Fix typos
...
Found randomly when going through docs. HTH
2016-05-20 14:06:29 -04:00
fa1e40c120
clientv3/concurrency: preallocate slice in stm
2016-05-19 14:42:19 -07:00
f9306fb817
clientv3: preallocate watch streams slice
...
To avoid slice growth when appending
2016-05-19 12:55:55 -07:00
e4a2dcad9e
clientv3/integration: ignore closing transport in TestKVPutStoppedServerAndClose
...
The grpc "transport is closing" error is rasied when the host is unreachable;
there's no good way to avoid it for a Put.
Fixes #5343
2016-05-18 14:49:39 -07:00
782a8802c0
clientv3: avoid reusing closed connection in KV
2016-05-18 14:46:17 -07:00
86c85b88ad
Merge pull request #5377 from purpleidea/bug/typos
...
clientv3: fix typos
2016-05-17 12:51:13 -07:00
42f3b4964f
clientv3: fix typos
2016-05-17 15:39:56 -04:00
6259318521
*: attach auth token as a gRPC credential
...
This commit adds a functionality of attaching an auth token to gRPC
connection as a per RPC credential.
For doing this, this commit lets clientv3.Client.Dial() create a
dedicated gRPC connection for doing authentication. With the dedicated
connection, the client calls Authenticate() RPC and obtain its
token. The token is attached to the main gRPC connection with
grpc.WithPerRPCCredentials().
This commit also adds a new option --username to etcdctl (v3). With
this option, etcdctl attaches its auth token to the main gRPC
connection (currently it is not used at all).
2016-05-17 13:26:12 +09:00
e8101ddf09
clientv3: throttle reconnection rate
...
Client was reconnecting after establishing connections because the lease
and watch APIs were thrashing. Instead, wait a little before accepting
new reconnect requests.
2016-05-16 11:14:45 -07:00
ec2ac72585
proxy: initial grpc kv service proxy
2016-05-13 23:00:29 -07:00
c7c0e1eb7a
integration: remove parallel testing
...
We cannot do testing in parallel since leak testing will detect the goroutines
in other tests running in parallel.
2016-05-13 12:01:25 -07:00
120020fa9c
clientv3/concurrency: use session id for election keys to avoid deadlock
2016-05-13 10:07:35 -07:00
393725fe5f
clientv3/concurrency: ctx-ize Leader(), Resign(), and Unlock()
2016-05-13 10:07:35 -07:00
fd9e07a529
clientv3: update LICENSE header
2016-05-12 20:50:58 -07:00
68eaf4083a
clientv3: WithRequireLeader
2016-05-12 19:25:42 -07:00
527aa1a499
clientv3: fix Close after failed Put
...
Was crashing on a nil connection. Reworked the shutdown path a little so
there's only one connection close site.
2016-05-12 16:16:27 -07:00
0d43a2b7e7
Merge pull request #5295 from ajityagaty/auth_disable
...
auth: Adding support for "auth disable" command.
2016-05-07 23:09:37 -07:00
adc981c53d
auth: Adding support for "auth disable" command.
...
Added support for the auth disable command in the server, added the
etcdctl command and a respective testcase.
2016-05-07 19:21:49 -07:00
712090fc09
clientv3: keep watcher client active if reconnect has network error
...
Otherwise watchers created after a long disconnect period will always
close immediately.
2016-05-05 19:30:11 -07:00
22c3a439bc
clientv3: do not stop lease client on lost receive stream
...
Fixes #5242
2016-05-05 19:30:11 -07:00
cdc8f99658
clientv3: rework reconnection logic
...
Avoids go routine flood for tight loops with a dead connection.
Now uses request ctx when reconnecting for immediate retry.
2016-05-05 19:30:11 -07:00
8b52fd0d2d
clientv3: gracefully handle watcher resume on compacted revision
...
Fixes #5239
2016-05-03 09:30:53 -07:00
0c5bcd5d80
clientv3: fix README, add error handling example
2016-04-29 13:34:16 -07:00
b3ebe66c97
clientv3/integration: tests with new errors
2016-04-29 12:00:26 -07:00
6049c95dc9
clientv3: auth with rpctypes.Error
2016-04-29 12:00:26 -07:00
c26eb3f241
clientv3: better serialization for kv and txn connection retry
...
If the grpc connection is restored between an rpc network failure
and trying to reestablish the connection, the connection retry would
end up resetting good connections if many operations were
in-flight at the time of network failure.
2016-04-29 09:26:32 -07:00
f148f4b2b9
clientv3/integration: tests error types (rpctypes)
2016-04-28 15:42:27 -07:00
2e3d79a7bf
clientv3: convert errors to rpctypes on returning
...
For https://github.com/coreos/etcd/issues/5211 .
2016-04-28 15:39:37 -07:00
08f6c0775a
Merge pull request #5199 from heyitsanthony/safe-lock-retry
...
clientv3/concurrency: use session lease id for mutex keys
2016-04-27 11:10:46 -07:00
ecb0e2bd38
Merge pull request #5203 from heyitsanthony/fix-lease-leak
...
clientv3: check stream context in lease keep alive send loop
2016-04-26 20:42:31 -07:00
30a9229f38
clientv3: check stream context in lease keep alive send loop
...
If no leases are being kept alive, a connection reset would leak
the send routine since it would only test the stream when sending
keep alives.
Fixes #5200
2016-04-26 20:10:09 -07:00
22797c7185
clientv3/concurrency: use session lease id for mutex keys
...
With randomized keys, if the connection goes down, but the session remains,
the client would need complicated recovery logic to avoid deadlock.
Instead, bind the session's lease id to the lock entry; if a session tries
to reacquire the lock it will reassume its old place in the wait list.
2016-04-26 17:37:26 -07:00
af1a0b60e2
etcdserver: respond with ttl=0 for revoked lease keep alive
...
Fixes #5172
2016-04-26 13:53:20 -07:00
b7ac758969
*: rename storage package to mvcc
2016-04-25 15:25:51 -07:00
9ec176a9b0
Merge pull request #5176 from xiang90/lease_client
...
clientv3: keepaliveonce should have a per call ctx
2016-04-25 11:45:58 -07:00
cbd79c666e
clientv3: keepaliveonce should have a per call ctx
...
KeepAliveOnce should have a per call ctx. Now we have a per
API ctx, but we might do rpc calls mutiple times in a for loop.
To avoid unnecessary routine leak, use per call ctx.
2016-04-25 10:46:47 -07:00
844208d7dd
clientv3: retry on switchRemoteAndStream
...
If switchRemoteAndStream fails, the whole lease API fails since
the internal routine exits. We should only fail the whole API when
there is a fatal error. For example, we should fail if we fail to
connection to all the endpoints user provided.
If we connect to an endpoint, but fail to create a stream, we should
retry instead of returning error to fail the entire API.
2016-04-23 21:55:34 -07:00
131e3806bb
*: support authenticate in v3 auth
...
This commit implements Authenticate() API of the auth package. It does
authentication based on its authUsers bucket and generate a token for
succeeding RPCs.
2016-04-21 12:32:19 +09:00
da5bd04a1a
clientv3: Remove superflous LeaseID casts in integration tests.
...
The integration tests under clientv3 have superflous LeaseID casts
that are not needed as the ID field of the lease responses are of
type LeaseID now.
2016-04-15 17:48:20 -07:00
9bfa0172f5
test, clientv3: run examples as integration tests
2016-04-15 11:51:30 -07:00
c1455a4f10
Merge pull request #5090 from ajityagaty/lease_id
...
clientv3: Use LeaseID in all the client APIs.
2016-04-15 10:48:29 -07:00
ae27b991b1
*: add more examples to clientv3, pkg/adt
2016-04-14 23:46:50 -07:00
06a4086bf9
clientv3: Use LeaseID in all the client APIs.
...
In order to use LeaseID type instead of int64 we have to convert
the protobuf lease responses into client lease reponses.
2016-04-14 23:09:46 -07:00
57448622d9
Merge pull request #5085 from heyitsanthony/hide-yaml
...
clientv3: make YamlConfig struct private
2016-04-14 14:10:20 -07:00
04ef861c3d
clientv3: make YamlConfig struct private
2016-04-14 12:26:01 -07:00
81e344bef9
clientv3: fix example code format, more examples
2016-04-14 12:13:07 -07:00
2c6176b5f2
*: remove MemberLeader API in client side (fix examples)
2016-04-13 16:23:57 -07:00
ae9b251d99
etcdctl: move endpoint-heath and status into endpoint command
2016-04-12 16:30:26 -07:00
be822b05d2
Merge pull request #5012 from heyitsanthony/snap-api
...
*: snapshot RPC
2016-04-11 13:00:18 -07:00
174a996c37
Merge pull request #5032 from mitake/auth-user-grant
...
*: support granting a role to a user in v3 auth
2016-04-11 11:10:10 -07:00
d5766eab3e
clientv3: add Snapshot to Maintenance
2016-04-11 09:51:17 -07:00
7ba2646d37
*: support granting a role to a user in v3 auth
2016-04-11 15:53:30 +09:00
9108af9046
*: clean up from go vet, misspell
2016-04-10 23:16:56 -07:00
1f4f3667a4
Merge pull request #5021 from gyuho/vendor_doc
...
*: client vendoring README
2016-04-10 22:15:36 -07:00
02033b4c47
*: support granting key permission to role in v3 auth
2016-04-11 12:23:19 +09:00
e3fd246414
clientv3: fix KeepAliveOnce return error message
2016-04-11 08:13:36 +08:00
78554c6de6
*: client vendoring README
2016-04-08 19:48:17 -07:00
953a08d841
*: clean up from gosimple
2016-04-08 11:55:03 -07:00
fb85da92e8
*: fix based on gosimple and unused
2016-04-07 23:16:37 -07:00
a9f1d5dfa6
clientv3/integration: use clientv3 event types
...
Fix https://github.com/coreos/etcd/issues/5001 .
2016-04-07 19:29:32 -07:00
dc17eaace7
*: rename Lease Create to Grant
...
Creating a lease through the client API interface union looked like
"c.Create(...)"-- the method name wasn't very descriptive.
2016-04-07 12:28:14 -07:00
aa11dafaf8
clientv3: expose event type in user API
...
- add another layer of abstraction in clientv3 for user, not expose internal storagepb ones
- provide commonly used routines IsCreate(), IsModify() on event
2016-04-07 09:47:04 -07:00
e72591b4a2
clientv3/integration: fix watch range test typo
2016-04-06 21:12:07 -07:00
c3bca3739f
Merge pull request #4926 from mitake/auth-role-add
...
*: support adding role in auth v3
2016-04-04 18:44:16 -07:00
2b17a3919c
*: support adding role in auth v3
2016-04-05 09:28:17 +09:00
88306c9fa7
etcdserver, clientv3: let progressReportIntervalMilliseconds be private
...
progressReportIntervalMilliseconds (old
ProgressReportIntervalMilliseconds) is accessed by multiple goroutines
and it is reported as race.
For avoiding this report, this commit wraps the variable with
functions. They access the variable with atomic operations so the race
won't be reported.
2016-04-05 09:12:17 +09:00
19136afc2b
Merge pull request #4798 from mqliang/memberStatus
...
etcdctlv3: initial implementaton of 'etcdctl member status' command
2016-04-03 08:48:23 -07:00
f3ca17ea03
etcdctlv3: implement the client side functionality
2016-04-03 13:46:34 +08:00
b0cc0e443c
*: clean up if, bool comparison
2016-04-02 12:55:11 -07:00
802de5f9f8
clientv3: support read conf from file
2016-04-01 09:36:11 -07:00
73166b41e9
*: support changing password in v3 auth
...
This commit adds a functionality for updating password of existing
users.
2016-03-31 15:28:15 +09:00
d8888ded12
*: support deleting user in v3 auth
...
This commit adds a functionality of user deletion. It can be invoked
with the new user delete command.
Example usage:
$ ETCDCTL_API=3 etcdctl user delete usr1
2016-03-31 13:18:51 +09:00
7ce5c2b9ff
Merge pull request #4902 from heyitsanthony/alarm-ctl
...
etcdctl: alarm command
2016-03-30 13:55:29 -07:00
c91b2d098d
clientv3: AlarmList and AlarmDisarm
2016-03-30 13:33:52 -07:00
b8d3b15206
*: document client package vendoring guide
2016-03-30 09:34:41 -07:00
b0956d5dbf
Merge pull request #4891 from mitake/auth-prefix
...
*: add Auth prefix to auth related requests and responses
2016-03-29 17:24:12 -07:00
9d49d35090
client: doc that client is thread-safe
2016-03-29 09:28:53 -07:00
d533c14881
Merge pull request #4876 from heyitsanthony/integration-races
...
*: fix races from clientv3/integration tests
2016-03-29 09:10:53 -07:00
161bc5e19c
clientv3: fix race when setting grpc Logger
...
grpc only permits SetLogger on init()
2016-03-28 23:30:03 -07:00
987568c65c
*: add Auth prefix to auth related requests and responses
2016-03-29 14:32:19 +09:00
096abb3f37
clientv3/integration: get quorum before watching in TestKVCompact
...
Fixes #4889
2016-03-28 22:18:10 -07:00
4bdfc0a46d
clientv3: fix race on writing watch channel over return channel
...
Found in TestElectionFailover
2016-03-28 16:08:18 -07:00
91dc6b29a6
clientv3/integration: fix race when setting progress report interval
2016-03-28 16:08:18 -07:00
2c83362e63
clientv3: fix race in KV reconnection logic
2016-03-28 16:08:18 -07:00
e129223dbe
clientv3: fix race in watcher resume
2016-03-28 16:08:18 -07:00
fa98d8d337
Merge pull request #4845 from mitake/auth-user
...
*: support adding user in v3 auth
2016-03-27 07:51:10 -07:00
8874545a1e
*: support adding user in v3 auth
...
This commit adds a new subcommand "user add" to etcdctlv3. With the
command users can create a user for the authentication.
Example of usage:
$ etcdctlv3 user add user1
Password of user1:
Type password of user1 again for confirmation:
2016-03-27 18:11:42 +09:00
29fccb3221
clientv3: configurable grpc logger
2016-03-26 22:38:53 -07:00
489779d905
clientv3: rename comparison from CreatedRevision to CreateRevision
...
To match protobuf naming
2016-03-23 09:50:46 -07:00
88e738fcb6
Merge pull request #4844 from ajityagaty/polish_naming_conventions
...
clientv3: Renaming SortByCreatedRev to maintain consistency.
2016-03-23 09:27:34 -07:00
2bb417bfff
clientv3: Renaming SortByCreatedRev to maintain consistency.
...
Renamed SortByCreatedRev to SortByCreateRevision to be consistent
with the naming used for SortByModRevision.
2016-03-22 17:56:24 -07:00
bd832e5b0a
*: migrate Godeps to vendor/
2016-03-22 17:10:28 -07:00
606889a002
clientv3: Fix inconsistent naming convention in v3 client.
...
In order to have a consistent naming for variable/function names
pertaining to ModifiedRevision, all occurrences have been renamed
to ModRevision.
2016-03-22 14:58:11 -07:00
d3809abe42
*: gRPC + HTTP on the same port
...
We use cmux to do this since we want to do http+https on the same
port in the near future too.
2016-03-21 14:29:25 -07:00
053bc83fe4
Merge pull request #4810 from gyuho/client_serialized_read
...
clientv3: set Serializable from Op
2016-03-19 14:35:55 -07:00
dae7e009b0
*: godoc clean up
2016-03-19 14:19:23 -07:00
4e4f0ab619
clientv3/concurrency: fix godoc
2016-03-18 16:34:58 -07:00
f38a611b55
clientv3: set Serializable from Op
...
Fix https://github.com/coreos/etcd/issues/4809 .
2016-03-18 15:56:48 -07:00
a001651bc1
clientv3: remove dependency on lease package
2016-03-17 11:52:34 -07:00
44753594ec
v3rpc: move errors to v3rpc/rpctypes
...
Fixes #4771
2016-03-17 11:52:34 -07:00
bc37a32062
clientv3/concurrency: software transactional memory
...
Repeatable read and serialized read STM implementations.
2016-03-16 11:23:06 -07:00
22065fe334
clientv3: fix mirror and add integration test
2016-03-13 18:27:45 -07:00
7c377fa703
*: add client.defrag and defrag cmd for etcdctl
2016-03-10 09:30:41 -08:00
3886129f52
clientv3/integration: fix TestTxnWriteFail
...
It might take client request more than dialtimeout to fail when
we kill the connection when the client is sending request.
2016-03-09 14:03:51 -08:00
e026b79c87
clientv3/integration: do not remove client member in TestMemberRemove
...
Fixes #4716
2016-03-08 11:55:26 -08:00
78132c9b5b
clientv3: use tls.Config in clientv3.Config
...
Fixes #4648
2016-03-07 16:08:40 -08:00
4eeea5ccda
clientv3/integration: remove invalid future revision test
...
Future revisions are now supported, so test is outdated.
2016-03-07 15:52:34 -08:00
d21d2e6624
clientv3: don't deadlock on Close with broken connection
...
Fixes #4679
2016-03-07 13:46:54 -08:00
d84811aecf
*: fix watch full key range
2016-03-05 14:45:43 -08:00
e708bc14d7
Merge pull request #4689 from hongchaodeng/master
...
watch.go: docs on WatchResponse.Canceled
2016-03-04 16:09:16 -08:00
5e017e94f9
watch.go: docs on WatchResponse.Canceled
2016-03-04 15:51:00 -08:00
450b586011
clientv3: add IsProgressNotify with example
...
This makes the test endpoints same as we have in
goreman proc file, and adds 'IsProgressNotify' method
and the 'WatchProgressNotify' code example to godoc.
2016-03-04 12:16:43 -08:00
4097a72c0b
Merge pull request #4678 from gyuho/watch_notify_clientv3
...
clientv3: add WithProgressNotify
2016-03-04 10:08:25 -08:00
27316196d8
clientv3: add WithProgressNotify
...
Client side for https://github.com/coreos/etcd/issues/4628 .
2016-03-04 09:47:13 -08:00
360aafec76
clientv3: include a context in Client
...
Useful for clean up tasks
2016-03-04 09:20:44 -08:00
1e16758029
clientv3: add Err() to WatchResponse
...
Checking for number of events as a failure condition was a kludge.
2016-03-03 15:21:04 -08:00
3cda514edb
Merge pull request #4676 from heyitsanthony/clientv3-fix-cancel-retry
...
clientv3: do not reconnect if request context is canceled
2016-03-03 14:24:50 -08:00
16c35167df
clientv3: do not reconnect on request context cancellation
2016-03-03 13:43:16 -08:00
6d3f172c6e
clientv3/concurrency: don't poll in mutex lock on early prior key delete
...
Lock would get the prior key on retry using WithRev(myRev - 1) instead of
using the latest revision; the Watch() would return immediately and Lock
devolves into polling.
2016-03-03 10:04:57 -08:00
3327858a54
clientv3/concurrency: move election recipe into clientv3
2016-03-03 00:22:19 -08:00
379d04ea53
clientv3: a new interface Auth for auth related RPCs
2016-03-02 15:17:59 +09:00
Anthony Romano