7cc2f8a411
raft: break out of nested loop when id is found ( #11870 )
...
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-05-12 16:59:22 -07:00
6fb3b9e591
chore(Dockerfile-release): Update base image to use new debian-base:v2.1.0 ( #11885 )
...
Updates the base image for all arch releases to the new location (us.gcr.io/k8s-artifacts-prod/build-image) as well as to the latest version (v2.1.0). This should fix a number of vulnerabilities that are in the 1.0.0 base image release.
2020-05-12 16:58:38 -07:00
ec13797407
mvcc: avoid negative watcher count metrics ( #11882 )
...
The watch count metrics are not robust to duplicate cancellations. These
cause the count to be decremented twice, leading eventually to negative
counts. We are seeing this in production. The duplicate cancellations
themselves are not themselves a big problem (except performance), but
they are caused by the new proactive cancellation logic (#11850 ) which
cancels proactively even immediately before initiating a Close, thus
nearly guaranteeing a Close-cancel race, as discussed in
watchable_store.go. We can avoid this in most cases by not sending a
cancellation when we are going to Close.
2020-05-12 16:50:53 -07:00
ab494956bf
Merge pull request #11862 from gyuho/const
...
etcdserver: compute max request bytes humanized string once
2020-05-11 19:36:37 -07:00
5f07d46f70
Merge pull request #11863 from gyuho/gofmt
...
*: run "gofmt -s" on genproto complete
2020-05-11 18:08:22 -07:00
2ecf268367
Merge pull request #11864 from gyuho/go1.14
...
*: use Go 1.14 for CI
2020-05-11 18:08:07 -07:00
11569821db
CHANGELOG-3.5: update
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-05-11 18:07:39 -07:00
60ce7bc2fa
functional/scripts: update default Go version
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-05-11 18:05:03 -07:00
c667c14d8d
fix memberList inconsistent output ( #11812 )
...
* etcdctl/ctlv3: support to print memberlist in hex format json
* e2e: add memberListWithHexTest
* CHANGELOG: update for #11812
2020-05-11 00:11:40 -07:00
0a0c27a4df
functional: add "-mod=mod" flags
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-05-10 18:36:38 -07:00
b79abb6f76
travis: set "-mod=mod"
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-05-10 18:36:38 -07:00
6874b9a76b
test: add "mod" to build tests
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-05-10 18:36:38 -07:00
b34c0c55a5
pkg/tlsutil: add "TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256" to support cipher suite
...
pkg/tlsutil: support TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-05-10 18:36:28 -07:00
e94201c9fd
test: set mod flags for bom test
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-05-10 13:37:18 -07:00
027c26a0fd
test: test '-mod=mod'
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-05-10 12:39:11 -07:00
b6ea32ee0f
test: ignore vendor directory in govet test
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-05-10 12:35:15 -07:00
628bd294e1
*: use Go 1.14 for CI
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-05-09 23:34:20 -07:00
d93c36bbb9
*: run "gofmt -s" on genproto complete
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-05-09 23:14:32 -07:00
89a3a24d5a
etcdserver: compute max request bytes humanized string once
...
No need to compute the request size limit everytime in runtime
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-05-09 23:11:45 -07:00
b95f135e10
Merge pull request #11861 from tedyu/node-run-found
...
raft: break out of nested loop when raft id is found
2020-05-09 23:05:26 -07:00
485e1409ac
Merge pull request #11860 from tedyu/range-tx-lock
...
mvcc: Obtain tx Lock once in readTx#UnsafeRange
2020-05-09 22:23:02 -07:00
43794efb1f
raft: break out of nested loop when raft id is found
...
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-05-09 17:56:44 -07:00
2dbbe6ce85
mvcc: Obtain txLock once in readTx#UnsafeRange
...
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-05-09 16:28:47 -07:00
c9377195d5
Merge pull request #11857 from tangcong/update-3.4-3.3-changelog-for-11817
...
CHANGELOG: update 3.4/3.3 changelog for 11817
2020-05-07 19:59:59 -07:00
e495c9220d
CHANGELOG: update 3.4/3.3 changelog for 11817
2020-05-08 10:18:46 +08:00
d472f67c77
Merge pull request #11817 from tangcong/fix-mvcc-deadlock-bug
...
mvcc: fix a deadlock bug in mvcc
2020-05-07 16:03:45 -07:00
6d067997e9
Merge pull request #11850 from jackkleeman/cancel-watch
...
clientv3: cancel watches proactively on client context cancellation
2020-05-07 11:06:49 -07:00
87aa5a9e60
clientv3: cancel watches proactively on client context cancellation
...
Currently, watch cancel requests are only sent to the server after a
message comes through on a watch where the client has cancelled. This
means that cancelled watches that don't receive any new messages are
never cancelled; they persist for the lifetime of the client stream.
This has negative connotations for locking applications where a watch
may observe a key which might never change again after cancellation,
leading to many accumulating watches on the server.
By cancelling proactively, in most cases we simply move the cancel
request to happen earlier, and additionally we solve the case where the
cancel request would never be sent.
Fixes #9416
Heavy inspiration drawn from the solutions proposed there.
2020-05-07 16:50:26 +01:00
feb56298dd
etcdserver: don't let InternalAuthenticateRequest have password ( #11818 )
2020-05-06 16:46:41 -07:00
035e1db0a2
Merge pull request #11830 from mitake/insecure-default
...
Documentation: note on the policy of insecure by default
2020-05-06 23:54:22 +09:00
356f647866
Documentation: note on the policy of insecure by default
2020-05-05 22:44:24 +09:00
d9d850c885
rafthttp: add snapshot limit const ( #11846 )
2020-05-04 23:26:22 -07:00
17ed0c6638
clientv3: Check the error return from Write in v3Manager#Status ( #11837 )
...
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-05-04 17:43:08 -07:00
df1d2ca78e
clientv3: v3Manager#saveDB should always close db file ( #11838 )
...
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-05-04 15:46:36 -07:00
16810cd211
etcdmain: best effort detection of self pointing in tcp proxy
2020-05-04 15:42:01 -07:00
4a64198a9f
Merge pull request #11844 from spzala/securityrelprocess
...
doc: remove Product Security Committee individual emails
2020-05-04 13:37:55 -04:00
658fd15b61
doc: remove Product Security Committee individual emails
...
emails here can be an unnecessary maintainance. The provided
GitHub IDs have the latest emails and also the process has
security@etcd.io mentioned in this doc as a contact email.
2020-05-04 12:40:34 -04:00
71170dd1d8
Merge pull request #11841 from mitake/warn-insecure-skip-tls-verify
...
etcdctl, etcdmain: warn about --insecure-skip-tls-verify options
2020-05-03 23:32:25 +09:00
c92691dc47
etcdctl, etcdmain: warn about --insecure-skip-tls-verify options
2020-05-03 17:17:30 +09:00
dfb0a40509
Merge pull request #11832 from krukkrz/issue_template_broken_link
...
.github/ISSUE_TEMPLATE: fix of a broken link
2020-04-30 11:08:33 -04:00
fc64b56058
.github/ISSUE_TEMPLATE: fix of a broken link
...
to make redirection possible. Changed undercore to dash.
2020-04-30 13:59:17 +02:00
1044a8b07c
Merge pull request #11768 from brancz/uid
...
Use UID instead of ID in Grafana dashboard
2020-04-29 05:35:06 -07:00
fb77f9b1d5
Merge pull request #11814 from tedyu/dir-closer
...
wal: close the directory when Fsync() encounters error
2020-04-28 23:27:08 -07:00
3b79ed8506
Merge pull request #11821 from tedyu/wal-close-all
...
closeAll should attempt to close all ReadCloser's
2020-04-28 20:54:13 -07:00
62755f484e
wal: closeAll should attempt to close all ReadCloser's
...
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2020-04-28 20:33:40 -07:00
d8bbf7f58d
Merge pull request #11816 from gaurav1086/fix_race_condition_kv_test
...
mvcc: fix race in TestKVTxnBlockWriteOperations
2020-04-28 16:11:26 -07:00
b28a6272b7
Merge pull request #11823 from philips/v3-mod-attempt2
...
go.mod: name packages with go.etcd.io/etcd/v3
2020-04-28 15:24:29 -07:00
eddca8dce2
Merge pull request #11819 from gaurav1086/fix_race_cond_client_test
...
clientv3: fix DialTimeout race condition
2020-04-28 15:12:50 -07:00
d88d765ba4
Documentation, CHANGELOG: use new go.etcd.io/etcd/v3 pkg
...
Use the new package path in the docs and announce it in the CHANGELOG
2020-04-28 22:02:19 +00:00
86a97533bb
clientv3: fix DialTimeout race condition
2020-04-28 10:56:28 -04:00
Zhihong Yu