c4fb5bdd23
embed: rename "v3alphaMutator" to "v3Mutator"
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-02-27 14:31:32 -08:00
bb95d190c1
*: revert "internal/auth" change
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-02-26 17:11:40 -08:00
6bbe107225
*: revert "internal/compactor" package change
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-02-26 17:11:40 -08:00
83d1c3d5ec
embed: fix revision-based compaction with default value
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-02-20 17:21:07 -08:00
4aa0320439
embed: document/validate compaction mode
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-02-20 17:18:48 -08:00
488ee99ae8
*: replace grpc-gateway endpoint with stable /v3
2018-02-11 19:07:36 -05:00
6acd3b4643
embed: define "embed.CompactorMode*"
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-01-29 15:42:30 -08:00
6c91766490
*: move "auth" to "internal/auth"
2018-01-29 14:57:35 +09:00
b26b8588b2
Merge pull request #8786 from harryge00/check-empty-hostname
...
embed: return error when advertise-client-urls are with empty hosts
2018-01-26 10:43:45 -08:00
6912a8e59e
embed: return error when advertise-client-urls or initial-advertise-peer-urls are with empty hosts
2018-01-26 11:10:09 +08:00
b664b9176c
pkg/srv, embed, etcdmain: Support multiple clusters in the same DNS discovery region.
2018-01-24 20:15:48 +00:00
a535c01050
embed: enable extensive metrics if specified
2018-01-06 20:40:30 +01:00
9e11ef3ad5
etcdserver,embed: discard gRPC info logs when debug is off
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-01-02 09:29:07 -08:00
39d0e9c3ca
embed: only discard infos when debug flag is off
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2017-12-21 14:28:13 -08:00
0133d77f0a
etcdmain: display default --enable-v2, --strict-reconfig-check value ("true")
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2017-12-14 11:25:20 -08:00
9744e1ee87
embed: stop *grpc.Server on *serveCtx serve error
...
If serve errors before *grpc.Server is sent to serversC,
it should be closed manually.
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2017-12-08 18:50:37 -08:00
bbd2147248
Merge pull request #8988 from gyuho/error-return
...
embed/config: remove v3.2 TODO
2017-12-08 06:41:12 -08:00
af5a5b3998
embed/config: remove v3.2 TODO
...
Already returning error.
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2017-12-07 20:37:12 -08:00
552b58dcfb
embed: only gracefully shutdown insecure grpc.Server
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2017-12-07 20:36:31 -08:00
e39915feec
embed: Avoid panic when shutting down gRPC Server
...
Avoid panic when stopping gRPC Server if TLS configuration is present.
Provided solution (attempts to) implement suggestion from gRPC team: https://github.com/grpc/grpc-go/issues/1384#issuecomment-317124531 .
Fixes #8916
2017-12-07 20:36:31 -08:00
ae589018cb
embed: provide more details on TLS handshake failure
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-12-01 09:40:23 -08:00
cffa130253
embed: error on zero heartbeat-interval, election-timeout
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-11-28 09:53:32 -08:00
0e4e8ed3d1
embed: corrupt-check on restart member
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-11-22 21:20:19 -08:00
3db5ad8d57
embed,etcdmain: add "--experimental-initial-corrupt-check"
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-11-22 15:27:14 -08:00
75ababa61f
embed: split peer/client/metrics serve methods
...
Priliminary commit to start client server later.
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-11-20 15:23:15 -08:00
cbe8c7eda7
Merge pull request #8880 from gyuho/v3beta-endpoint
...
*: replace grpc-gateway endpoint with /v3beta
2017-11-16 09:42:19 -08:00
fe7b094f63
Revert "embed: fix HTTPs + DNS SRV discovery"
...
This reverts commit f79d5aaca4
2017-11-15 13:00:21 -08:00
c706c6e238
embed: mutate /v3alpha requests with /v3beta for backward compatibilities
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-11-15 02:14:04 -08:00
5fd419ff50
embed: replace v3alpha serve path with v3beta
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-11-15 01:55:49 -08:00
75110dd839
*: fix naked returns
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-11-10 18:46:15 -08:00
cdc71ae38e
embed: NewConfig sets LogOutput to "default"
...
Otherwise, embedded etcd will panic in SetupLogging
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-11-02 14:41:32 -07:00
6127f785a4
embed: disable grpc server logging by default
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-11-02 13:19:49 -07:00
4b1e09f2b4
embed: move SetupLogging, LogOutput from etcdmain
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-11-02 13:19:44 -07:00
b766a26059
Merge pull request #8257 from yudai/websocket_streams
...
embed: support websocket for bi-directional streams
2017-10-06 21:33:55 -07:00
37eabd770e
embed: support websocket for bi-directional streams
2017-10-05 16:08:18 -07:00
f79d5aaca4
embed: fix HTTPs + DNS SRV discovery
2017-10-05 15:21:45 -07:00
bcef78c665
Merge pull request #8563 from fanminshi/make_auto_compaction_granular
...
*: support auto-compaction with finer granularity
2017-09-29 11:18:51 -07:00
0e1993f131
etcdmain: check for empty AutoCompactionRetention
2017-09-28 17:31:09 -07:00
733de98cfb
*: modify etcd flags to support finner compaction retention
2017-09-28 17:22:44 -07:00
157c8eccf0
embed: define keepalive server options
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-09-28 11:19:29 -07:00
f65aee0759
*: replace 'golang.org/x/net/context' with 'context'
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-09-07 13:39:42 -07:00
5d669290e3
embed: support experimental v2v3 proxy option
2017-08-31 11:47:41 -07:00
35c5dcefc2
*: cockroachdb/cmux -> soheilhy/cmux
...
Has fixes not in fork. Includes SetReadTimeout.
2017-08-22 09:59:59 -07:00
1f734e0299
embed: support experimental-corrupt-check-time flag
2017-08-22 09:59:59 -07:00
153ba92830
embed: serve basic v3 grpc over peer port
2017-08-22 09:59:59 -07:00
f4183c68cc
embed: associate peer serve() listener with corresponding peer
...
Fixes #8383
2017-08-17 10:25:00 -07:00
e24de6c9ac
embed: add 'enable-pprof' tag for config file
...
Fix https://github.com/coreos/etcd/issues/8402 .
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-08-15 11:22:10 -07:00
fe344ef302
embed: warns about empty hosts in advertise urls
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-08-10 12:31:58 -07:00
74c8050adc
*: use etcdhttp.Handle* for health, prometheus handlers
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-07-26 06:23:55 -07:00
d5a0d4d696
etcdmain, embed: --auto-peer-tls and --auto-tls for v2 proxy
...
Fixes #7930
2017-07-21 11:00:22 -07:00
334554f655
embed: wait up to request timeout for pending RPCs when closing
...
Both grpc.Server.Stop and grpc.Server.GracefulStop close the listeners
first, to stop accepting the new connections. GracefulStop blocks until
all clients close their open transports(connections). Unary RPCs
only take a few seconds to finish. Stream RPCs, like watch, might never
close the connections from client side, thus making gRPC server wait
forever.
This patch still calls GracefulStop, but waits up to 10s before manually
closing the open transports.
Address https://github.com/coreos/etcd/issues/8224 .
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-07-14 15:31:40 -07:00
9bb5ede659
embed: configure 'ListenMetricsUrls'
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-07-14 11:14:05 -07:00
e29db923bc
*: move v2http handlers without /v2 prefix to etcdhttp
...
Lets --enable-v2=false configurations provide /metrics, /health, etc.
Fixes #8167
2017-07-07 18:35:57 -07:00
63350f5ac1
embed: connect json gateway with user-provided listen address
...
net.Listener says its address is [::] when given 0.0.0.0, breaking
hosts that have ipv6 disabled.
Fixes #8151
Fixes #7961
2017-07-06 14:24:29 -07:00
0fe8fdcb29
Merge pull request #8123 from yudai/revision_compactor
...
Compactor: Add Revisional compactor
2017-06-22 16:34:28 -07:00
a3f8f47422
*: add Revision compactor
2017-06-21 15:41:07 -07:00
87d16af2e2
embed: use transport TLS listener for client listener for CRLs
2017-06-19 15:23:41 -07:00
dcf52bbfac
etcdserver, embed, integration: don't use pointer for ServerConfig
...
ServerConfig is owned by etdcserver and unshared, so don't pass or store by
pointer. Also removes duplicated field 'snapCount'.
2017-06-15 13:02:13 -07:00
2f84f3d8d8
Merge pull request #7968 from fanminshi/make_maxRequestBytes_configurable
...
etcd: make max request bytes configurable
2017-05-25 15:54:24 -07:00
212a1efd47
Merge pull request #7965 from heyitsanthony/shared-grpc-conn
...
embed: share grpc connection for grpc json services
2017-05-25 14:35:33 -07:00
9e7740011b
etcdserver: add --max-request-bytes flag
2017-05-25 11:01:38 -07:00
ae7ddfb483
etcdserver: add --max-txn-ops flag
...
--max-txn-ops allows users to define the maximum transaction operations
for each txn request. it defaults at 128.
Fixes #7826
2017-05-24 10:32:32 -07:00
db7ab961bf
embed: share grpc connection for grpc json services
2017-05-22 12:59:13 -07:00
aac2292ab5
Merge pull request #7882 from heyitsanthony/srv-priority
...
gateway: DNS SRV priority
2017-05-08 14:17:04 -07:00
7d21d6c894
embed: gracefully close peer handlers on shutdown
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-05-06 07:47:23 -07:00
07ad18178d
pkg/srv: package for SRV utilities
...
Trying to decouple the v2 client from SRV code. Can't move
into discovery/ since that creates a circular dependency. So,
give up and move all the SRV code into a new package.
2017-05-05 09:27:59 -07:00
b0e9d24fb6
embed: fix blocking Close before gRPC server start
...
If 'StartEtcd' returns before starting gRPC server
(e.g. mismatch snapshot, misconfiguration),
receiving from grpcServerC blocks forever. This patch
just closes the channel to not block on grpcServerC,
and proceeds to next stop operations in Close.
This was masking the issues in https://github.com/coreos/etcd/issues/7834
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-05-01 16:41:13 -07:00
393e4335b7
*: put gateway stubs into their own packages
...
Fixes #7773
2017-04-19 13:09:06 -07:00
ba299bcaaf
embed: signal 'grpcServerC' before cmux serve
...
CMux.Serve blocks, so grpcServerC was never closed.
Fix https://github.com/coreos/etcdlabs/issues/216 .
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-04-18 17:49:50 -07:00
f10a70401b
embed: use '*url.URL.Hostname(),Port()' for Go 1.8
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-04-18 12:08:59 -07:00
8aaa1ed911
*: use '*tls.Config.Clone' in Go 1.8
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-04-17 20:08:27 -07:00
c407e097e2
embed: gracefully shut down gRPC server
...
Fix https://github.com/coreos/etcd/issues/7322 .
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-04-17 14:12:40 -07:00
1153e1e7d9
Merge pull request #7687 from heyitsanthony/deny-tls-ipsan
...
transport: deny incoming peer certs with wrong IP SAN
2017-04-13 15:03:25 -07:00
537c7100b0
embed: remove ReadTimeout TODO
...
ref. https://github.com/golang/go/issues/9524#issuecomment-271937649
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-04-13 10:55:45 -07:00
780a7d359c
discovery: remove dead token argument from SRVGetCluster
...
Can add the argument back when it's actually used something.
2017-04-12 16:49:44 -07:00
cad1215b18
*: deny incoming peer certs with wrong IP SAN
2017-04-12 13:41:33 -07:00
93594006df
embed: register grpc-gateway endpoints for v3lock and v3election
2017-04-10 15:21:07 -07:00
78422eaa17
embed: add Election service
2017-04-07 16:36:38 -07:00
d42c1f5131
Merge pull request #7646 from andelf/fix-unix-socket-url
...
*: fix a bug in handling unix socket urls
2017-04-05 09:24:38 -07:00
4f27981c46
*: fix a bug in handling unix socket urls
...
Now use url.Host + url.Path as unix socket path
Fixes #7644
2017-04-05 14:33:13 +08:00
fd5984af56
*: add pprof flag to grpc proxy
2017-04-03 22:07:17 -07:00
d0d4b1378b
embed: Delay setting initial cluster for YAML
...
NewConfig() sets an initial cluster (potentially using a default name)
but we should clear it in the event another discovery option has been
specified.
PR #7517 attempted to address this however it only worked if the name
was left as "default".
(Completely) Fixes #7516
2017-03-31 10:01:42 +11:00
f292a4c953
embed: don't return error when closing on embed etcd
...
FIXES #7019
2017-03-17 13:41:05 -07:00
5015480e0c
Merge pull request #7517 from jsok/7516-discovery-flags
...
embed: Delay setting initial cluster
2017-03-16 09:17:42 -07:00
2f1542c06d
*: use filepath.Join for files
2017-03-16 07:46:06 -07:00
1a91ed0e99
embed: Clear default initial cluster
...
NewConfig() should sets initial cluster from name but we should clear it
in the event that another discovery option has been specified.
Fixes #7516
2017-03-16 13:59:06 +11:00
ad1a790116
embed: serve lock api
2017-03-13 15:23:26 -07:00
f8a290e7ca
*: support jwt token in v3 auth API
...
This commit adds jwt token support in v3 auth API.
Remaining major ToDos:
- Currently token type isn't hidden from etcdserver. In the near
future the information should be completely invisible from
etcdserver package.
- Configurable expiration of token. Currently tokens can be valid
until keys are changed.
How to use:
1. generate keys for signing and verfying jwt tokens:
$ openssl genrsa -out app.rsa 1024
$ openssl rsa -in app.rsa -pubout > app.rsa.pub
2. add command line options to etcd like below:
--auth-token-type jwt \
--auth-jwt-pub-key app.rsa.pub --auth-jwt-priv-key app.rsa \
--auth-jwt-sign-method RS512
3. launch etcd cluster
Below is a performance comparison of serializable read w/ and w/o jwt
token. Every (3) etcd node is executed on a single machine. Signing
method is RS512 and key length is 1024 bit. As the results show, jwt
based token introduces a performance overhead but it would be
acceptable for a case that requires authentication.
w/o jwt token auth (no auth):
Summary:
Total: 1.6172 secs.
Slowest: 0.0125 secs.
Fastest: 0.0001 secs.
Average: 0.0002 secs.
Stddev: 0.0004 secs.
Requests/sec: 6183.5877
Response time histogram:
0.000 [1] |
0.001 [9982] |∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎
0.003 [1] |
0.004 [1] |
0.005 [0] |
0.006 [0] |
0.008 [6] |
0.009 [0] |
0.010 [1] |
0.011 [5] |
0.013 [3] |
Latency distribution:
10% in 0.0001 secs.
25% in 0.0001 secs.
50% in 0.0001 secs.
75% in 0.0001 secs.
90% in 0.0002 secs.
95% in 0.0002 secs.
99% in 0.0003 secs.
w/ jwt token auth:
Summary:
Total: 2.5364 secs.
Slowest: 0.0182 secs.
Fastest: 0.0002 secs.
Average: 0.0003 secs.
Stddev: 0.0005 secs.
Requests/sec: 3942.5185
Response time histogram:
0.000 [1] |
0.002 [9975] |∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎∎
0.004 [0] |
0.006 [1] |
0.007 [11] |
0.009 [2] |
0.011 [4] |
0.013 [5] |
0.015 [0] |
0.016 [0] |
0.018 [1] |
Latency distribution:
10% in 0.0002 secs.
25% in 0.0002 secs.
50% in 0.0002 secs.
75% in 0.0002 secs.
90% in 0.0003 secs.
95% in 0.0003 secs.
99% in 0.0004 secs.
2017-03-06 19:46:03 -08:00
b7ee8f4967
embed: use machine default host only for default value, 0.0.0.0
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-03-03 14:25:34 -08:00
c4f1e64de7
embed: enable debug endpoint if Debug is set and add net.trace events
...
/debug/ was only being enabled for Pprof.
2017-02-27 11:34:58 -08:00
0f53ad0b84
netutil: add dualstack to linux_route
...
in v3.1.0 netutil couldn't get default interface for ipv6only hosts
Fixes #7219
2017-01-31 22:19:47 +03:00
5a67b0aba6
embed: reject binding listeners to domain names
...
Fixes #6336
2017-01-26 12:37:34 -08:00
861cb5cfa2
embed: add example for ServiceRegister.
2017-01-23 10:47:01 +08:00
4374d944d4
embed: support user defined grpc services.
...
Fixes #7200
2017-01-22 18:21:19 +08:00
f80914fba2
embed/etcd.go: make v2 endpoint optional. fixes #7100
2017-01-20 11:49:52 +05:30
e63059ec31
Merge pull request #7030 from crandles/grpc-histograms
...
etcdmain: add '--metrics' option
2016-12-28 12:03:53 -08:00
36b2d3f5eb
etcdmain: add --metrics flag for exposing histogram metrics
...
this adds a new flag, --metrics, that can be used to enable extensive (histogram) metrics.
Fixes #7024
2016-12-28 13:04:52 -05:00
e58287f026
embed: only override default advertised client URL if the client listen URL is 0.0.0.0
2016-12-16 18:31:04 -08:00
cc931a2319
embed: deep copy user handlers
...
Shallow copy of user handlers leads to a nil map assignment when
enabling pprof. Since the map is being modified, it should probably
be deep copied into the server context, which fixes the crash.
2016-12-14 10:17:32 -08:00
2c06def8ca
etcdserver, embed, v2http: move pprof setup to embed
...
Seems like a better place for prof setup since it's not specific to v2.
2016-12-09 12:37:35 -08:00
745cd730a7
embed: Make immutable defaults constant
...
This changes the two immutable defaults into constants which allows
packages embedding etcd to import them as const! If they are variables,
then you'll fail with "const initializer foo is not a constant".
2016-11-11 07:34:45 -05:00
b8017004ba
embed: add 'Config' method
2016-09-29 07:10:59 -07:00
c7212b438d
embed: warn on domain name in listener
2016-09-13 09:17:40 -07:00
fa2e9c2449
Revert "Merge pull request #6365 from heyitsanthony/fix-dns-bind"
...
This reverts commit af5ab7b351da6a0f0594
2016-09-12 19:45:35 -07:00
2752169d6a
embed: reject binding listeners to domain names
...
Fixes #6336
2016-09-06 15:33:28 -07:00
9e9bbb829e
Merge pull request #6289 from purpleidea/feat/move-readynotify
...
embed: Move the ReadyNotify() call to a more sane place
2016-08-29 20:06:17 -07:00
9aee3f01cd
embed: Move the ReadyNotify() call to a better place
...
When using the embed functionality, you can't call the Server.Stop()
function until StartEtcd returns, which can block until there is a call
to Server.Stop() in error situations. Since we have a catch-22, the
ReadyNotify() can be called manually by the user if they wish to wait
for the server startup, or in parallel with a timeout if they wish to
cancel it after some time.
Chzz pointed out that this is also more consistent with the
etcdserver.Start() behaviour too.
purpleidea pointed out that this is actually more correct too, because
we can now register the stop interrupt handler before we block on
startup.
2016-08-29 22:45:41 -04:00
e8594b60b1
embed: use default route IP for default advertise URL
...
Fixes #2858
2016-08-15 11:12:26 -07:00
6de993b468
embed: load config defaults before loading config from file
2016-08-10 09:44:50 -07:00
9063ce5e3f
etcdserver, embed: stricter reconfig checking
...
Make --strict-reconfig-check a default and check if cluster is healthy when
adding a member.
2016-08-05 16:59:25 -07:00
d1809830bb
embed: use ServerName on TLS DNS discovery without CA file
2016-08-03 22:28:03 -07:00
e2088b8073
Merge pull request #6063 from siddontang/siddontang/embed-handler
...
embed: support registering client handlers
2016-07-27 22:57:27 -07:00
86de0797e1
embed: support registering user handlers
2016-07-28 13:39:06 +08:00
42fc36b4d6
embed: add listen urls to default config
...
Was only setting the advertise urls.
2016-07-25 11:06:03 -07:00
fee9e2b183
embed: Fixed serve() err return
2016-07-21 18:06:08 +02:00
be001c44e8
embed: set 'ClientCertAuthEnabled'
2016-07-20 16:23:24 -07:00
e177f391f2
embed: support unix peers
2016-07-18 16:41:41 -07:00
4835322aa1
Merge pull request #5954 from heyitsanthony/fix-embed-cfg-validate
...
embed: fix nil dereference on error to set up initial cluster
2016-07-15 15:41:40 -07:00
34602b87ec
embed: fix nil dereference on error to set up initial cluster
2016-07-15 14:43:00 -07:00
b2b98399fb
embed: change import path to 'grpc-ecosystem'
2016-07-15 12:10:38 -07:00
8368e6a992
embed: only get initial cluster setting if the member is not init
2016-07-13 16:03:27 -07:00
f4f33ea767
etcdmain, embed: export Config and StartEtcd into embed/
...
Lets programs embed etcd.
Fixes #5430
2016-07-13 10:40:03 -07:00
Gyuho Lee