Anthony Romano
f465e3ea8a
grpcproxy: support nested txns
2017-06-21 14:33:15 -07:00
Xiang Li
a65e3c69a6
Merge pull request #8122 from yudai/fast_fail_proxy
...
grpcproxy: Disable fast fail on lease grant call to cluster
2017-06-19 15:04:25 -07:00
Iwasaki Yudai
df2cc4bc8c
grpcproxy: Disable fast fail on lease grant call to cluster
...
Problem Observed
----------------
When there is no etcd process behind the proxy,
clients repeat resending lease grant requests without delay.
This behavior can cause abnormal resource consumption on CPU/RAM and
network.
Problem Detail
--------------
`LeaseGrant()` uses a bare protobuf client to forward requests.
However, it doesn't use `grpc.FailFast(false)`, which means the method returns
an `Unavailable` error immediately when no etcd process is available.
In clientv3, `Unavailable` errors are not considered the "Halt" error,
and library retries the request without delay.
Both clients and the proxy consume much CPU cycles to process retry requests.
Resolution
----------
Add `grpc.FailFast(false))` to `LeaseGrant()` of the `leaseProxy`.
This makes the proxy not to return immediately when no etcd process is
available. Clients will simply timeout requests instead.
2017-06-16 15:09:05 -07:00
Anthony Romano
aeb2dc03aa
grpcproxy: invalidate cache on comparison range
2017-06-16 12:13:27 -07:00
Gyu-Ho Lee
5e059fd8dc
*: use metadata Incoming/OutgoingContext
...
Fix https://github.com/coreos/etcd/issues/7888 .
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-06-15 16:41:23 -07:00
Nikola Kovacs
66687da3ba
*: grammar fixes, it's -> its
2017-06-15 18:23:16 +02:00
Anthony Romano
5bb0a091fc
adapter: auth server to client adapter
2017-06-09 09:36:16 -07:00
Anthony Romano
33c375dc44
*: fill out blank package godocs
...
Mostly one-liner short descriptions, but also includes some typo fixes
and some examples.
2017-05-18 09:41:13 -07:00
Anthony Romano
5bd9b9614f
tcpproxy: display endpoints, not pointers, in ready to proxy string
...
The switch to *net.SRV for endpoints caused the ready string to emit
pointers instead of endpoint strings.
Fixes #7942
2017-05-17 10:51:35 -07:00
Anthony Romano
713e006bc6
adpater: adapters for lock and election services
2017-05-10 12:51:05 -07:00
Anthony Romano
fd01db9e60
grpcproxy, etcdmain: add lock and election services to proxy
2017-05-10 12:19:09 -07:00
Anthony Romano
c232814003
etcdmain, tcpproxy: srv-priority policy
...
Adds DNS SRV weighting and priorities to gateway.
Partially addresses #4378
2017-05-08 11:35:18 -07:00
Anthony Romano
6dd8fb6f24
Revert "Merge pull request #7732 from heyitsanthony/lease-err-ka"
...
This reverts commit fbbc4a4979
, reversing
changes made to f254e38385
.
Fixes #7851
2017-05-02 09:36:16 -07:00
Anthony Romano
b5384ac1c0
grpcproxy: use new lease interface
2017-04-24 23:49:44 -07:00
Gyu-Ho Lee
7adf4d7c94
grpcproxy/adapter: add Cluster API support
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-04-04 08:13:30 -07:00
Gyu-Ho Lee
5c642ae314
grpcproxy/adapter: add maintenance API support
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-03-28 09:09:06 -07:00
Gyu-Ho Lee
caa73c176f
proxy/grpcproxy: add chanStream helper
...
Prelimiary work for maintenance API in adapter
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-03-27 11:24:02 -07:00
Anthony Romano
b2a465e354
grpcproxy/cache: only check compaction revision for historical revisions
...
Since the current revision is 0, it'll always be less than the compaction
revision. If the proxy sees a compaction, it would always reject the
current revision requests since it's less than the compaction revision.
Instead, check if the revision is historical before trying to reject on
compaction revision.
Fixes #7599
2017-03-24 13:20:46 -07:00
Anthony Romano
b025cdd097
adapter, integration: split out grpc adapters from grpcproxy package
...
Break cyclic dependency:
clientv3/naming <-> integration <-> v3client <-> grpcproxy <-> clientv3/naming
2017-03-13 15:23:26 -07:00
Gyu-Ho Lee
f862b47e92
grpcproxy: configure register to Cluster API
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-03-09 02:40:13 -08:00
Anthony Romano
28e9ba365a
grpcproxy: return closing error when stream is canceled from conn close
...
Fixes #6630
2017-03-01 16:46:13 -08:00
Gyu-Ho Lee
72a531e8b2
grpcproxy: add 'register' address
...
For https://github.com/coreos/etcd/issues/6902 .
2017-02-22 16:47:48 -08:00
Anthony Romano
25403970f5
Merge pull request #7361 from heyitsanthony/fix-gateway-goroutine
...
tcpproxy: don't use range variable in reactivate goroutine
2017-02-21 13:26:53 -08:00
Anthony Romano
8b097f279d
tcpproxy: don't use range variable in reactivate goroutine
...
Ends up trying to reactivate only the last endpoint.
2017-02-21 12:39:49 -08:00
Anthony Romano
29a6fd65ad
grpcproxy: only return ctx error in chan stream if recvc is empty
...
Since select{} won't prioritize, ctx.Done() can sometimes override
a pending message on recvc. Loop if recvc has messages instead.
Fixes #7340
2017-02-21 10:53:58 -08:00
fanmin shi
ba52bd07ba
grpcproxy: add lease coalescing support
2017-02-16 11:50:50 -08:00
fanmin shi
05b82f2022
grpcproxy: refactor chan stream out of watch_client_adapter
2017-02-16 11:41:21 -08:00
Anthony Romano
80de75431e
grpcproxy: support forcing leader as available
...
Leadership timeout can sometimes take too long, such as in test cases.
However, it is possible to infer a leader is available based on RPCs
that must go through consensus. Therefore, have a way to update the
leadership status off the watch path.
2017-02-15 16:49:41 -08:00
Anthony Romano
36f5b713bf
grpcproxy: don't wait for ctx.Done() to close kv donec
...
Causes a goroutine leak in ActiveConnection.Close() tests. Channel is
vestigial since removing ccache; revisit if kv ever needs goroutines.
2017-02-15 00:16:25 -08:00
Anthony Romano
49a0a63fc3
grpcproxy: split out leadership detection code
...
Move out of watch code since will be shared with lease code. Also assumes
leader does not exist unless watch can be successfully created.
2017-02-15 00:16:25 -08:00
Anthony Romano
853f68071b
grpcproxy: respect CompactRevision in watcher
...
CompactRevision wasn't sent over watch stream, causing TestKVCompact to hang.
2017-02-13 15:43:41 -08:00
Anthony Romano
c22ba766d5
grpcproxy: support CountOnly
...
TestKVRange from client integration tests was failing.
2017-02-10 16:06:24 -08:00
Anthony Romano
1fe2a9b124
Revert "Merge pull request #7139 from heyitsanthony/proxy-rlock"
...
This reverts commit 304606ab0b
, reversing
changes made to 7dfe503f1c
.
2017-02-10 14:37:48 -08:00
Anthony Romano
d159353d51
Merge pull request #7268 from heyitsanthony/proxy-test-clientv3
...
test: add proxy tests for clientv3 integration tests
2017-02-02 20:31:05 -08:00
Anthony Romano
e42fa18ccf
grpcproxy: don't use WithRequireLeader for watch event stream
...
Ohterwise leader loss will reject all stream creation.
2017-02-02 09:32:25 -08:00
sharat
9def4cb9fe
*: Use http.Request.WithContext instead of Cancel
2017-02-02 22:50:07 +05:30
sharat
2fce80e4c0
grpcproxy: handle 'IgnoreLease' field in PutRequest
2017-01-25 03:14:31 +05:30
Anthony Romano
8c0282ab24
grpcproxy, etcdmain, integration: add close channel to kv proxy
...
ccache launches goroutines that need to be explicitly stopped.
Fixes #7158
2017-01-18 11:51:16 -08:00
Gyu-Ho Lee
0f8060bede
grpcproxy: handle 'IgnoreValue' field in PutRequest
2017-01-13 15:13:18 -08:00
Anthony Romano
9fa6c95054
grpcproxy: use ccache for key cache
...
groupcache needs a write lock and has no way to expire keys; ccache can
do this, though.
Also removes the key count metric, since there's no way to efficiently
calculate it using ccache.
2017-01-13 10:00:57 -08:00
Anthony Romano
e179225f28
grpcproxy: tear down watch when client context is done
...
If client closes but all watch streams are not canceled, the outstanding
watch will wait until it is canceled, causing watch server to potentially
wait forever to close.
Fixes #7102
2017-01-04 16:23:27 -08:00
Anthony Romano
9b5eb1ae5a
grpcproxy, etcdmain, integration: return done channel with WatchServer
...
Makes it possible to synchronously close the watch server.
Fixes #7078
2016-12-30 12:09:48 -08:00
Gyu-Ho Lee
7e74b3f846
grpcproxy: remove unused field 'wbs *watchBroadcasts'
2016-12-12 10:07:14 -08:00
Gyu-Ho Lee
a98de7efa7
grpcproxy: fix minor typo
2016-12-07 17:08:46 -08:00
Anthony Romano
91ff6f30b5
grpcproxy: fix deadlock in watchbroadcast
...
Calling empty() in watchbroadcast methods was trying to
lock the rwmutex when it was already held.
Fixes #6937
2016-12-05 15:06:44 -08:00
Anthony Romano
62398954e4
grpcproxy: lock store when getting size
...
Fixes data race in proxy integration tests.
2016-12-05 13:29:57 -08:00
Xiang Li
0cb680800e
grpcproxy: add cache related metrics
2016-12-02 15:29:42 -08:00
Xiang Li
1f954dc9f4
Merge pull request #6926 from xiang90/metrics
...
grpcproxy: add richer metrics for watch
2016-12-02 14:13:43 -08:00
Xiang Li
a686c994cd
grpcproxy: add richer metrics for watch
2016-12-02 11:13:30 -08:00
Anthony Romano
60908c64a6
grpcproxy: fix race between coalesce and bcast on nextrev
...
coalesce was locking the target coalesce broadcast object but not the source
broadcast object resulting in a data race on the source's nextrev.
2016-11-30 16:50:29 -08:00