From 00b92df61c231bb4ce282188850d2efc45c0e34d Mon Sep 17 00:00:00 2001 From: Aaron Jacobs Date: Tue, 4 Aug 2015 02:19:21 +0000 Subject: [PATCH] Don't forget to close the opened files. --- samples/errorfs/error_fs_test.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/samples/errorfs/error_fs_test.go b/samples/errorfs/error_fs_test.go index 063a44c..9061388 100644 --- a/samples/errorfs/error_fs_test.go +++ b/samples/errorfs/error_fs_test.go @@ -66,7 +66,8 @@ func (t *ErrorFSTest) SetUp(ti *TestInfo) { func (t *ErrorFSTest) OpenFile() { t.fs.SetError(reflect.TypeOf(&fuseops.OpenFileOp{}), syscall.EOWNERDEAD) - _, err := os.Open(path.Join(t.Dir, "foo")) + f, err := os.Open(path.Join(t.Dir, "foo")) + defer f.Close() ExpectThat(err, Error(MatchesRegexp("open.*: .*owner died"))) } @@ -75,6 +76,7 @@ func (t *ErrorFSTest) ReadFile() { // Open f, err := os.Open(path.Join(t.Dir, "foo")) + defer f.Close() AssertEq(nil, err) // Read @@ -85,7 +87,8 @@ func (t *ErrorFSTest) ReadFile() { func (t *ErrorFSTest) OpenDir() { t.fs.SetError(reflect.TypeOf(&fuseops.OpenDirOp{}), syscall.EOWNERDEAD) - _, err := os.Open(t.Dir) + f, err := os.Open(t.Dir) + defer f.Close() ExpectThat(err, Error(MatchesRegexp("open.*: .*owner died"))) } @@ -94,6 +97,7 @@ func (t *ErrorFSTest) ReadDir() { // Open f, err := os.Open(t.Dir) + defer f.Close() AssertEq(nil, err) // Read