Updated PosixTest.WriteStartsPastEndOfFile_AppendMode for Linux.

geesefs-0-30-9
Aaron Jacobs 2015-03-18 16:16:24 +11:00
parent e011f89d97
commit 76226f19f5
1 changed files with 21 additions and 2 deletions

View File

@ -22,6 +22,7 @@ import (
"io/ioutil"
"os"
"path"
"runtime"
"testing"
. "github.com/jacobsa/oglematchers"
@ -183,9 +184,22 @@ func (t *PosixTest) WriteStartsPastEndOfFile_AppendMode() {
AssertEq(3, n)
// Read the full contents of the file.
//
// Linux's support for pwrite is buggy; the pwrite(2) man page says this:
//
// POSIX requires that opening a file with the O_APPEND flag should have
// no affect on the location at which pwrite() writes data. However, on
// Linux, if a file is opened with O_APPEND, pwrite() appends data to
// the end of the file, regardless of the value of offset.
//
contents, err := ioutil.ReadFile(f.Name())
AssertEq(nil, err)
ExpectEq("111\x00\x00\x00222", string(contents))
if runtime.GOOS == "linux" {
ExpectEq("111222", string(contents))
} else {
ExpectEq("111\x00\x00\x00222", string(contents))
}
}
func (t *PosixTest) WriteAtDoesntChangeOffset_NotAppendMode() {
@ -300,7 +314,12 @@ func (t *PosixTest) AppendMode() {
// So we allow either the POSIX result or the Linux result.
n, err = f.ReadAt(buf, 0)
AssertEq(io.EOF, err)
ExpectThat(string(buf[:n]), AnyOf("Hello, world!", "Jello, world!H"))
if runtime.GOOS == "linux" {
ExpectEq("Jello, world!H", string(buf[:n]))
} else {
ExpectEq("Hello, world!", string(buf[:n]))
}
}
func (t *PosixTest) ReadsPastEndOfFile() {